[v2] staging: rtl8723bs: remove unnecessary comparison to true

[PATCH v2] staging: rtl8723bs: remove unnecessary comparison to true

Posted by Ashwin Gundarapu 1 month, 1 week ago

Remove explicit comparison to true in check_fwstate() call and
add spacing around the bitwise OR operator to improve code style.

---

v2: Resent with corrected whitespace via Thunderbird plain text mode.

Signed-off-by: Ashwin Gundarapu <linuxuser509@zohomail.in>
---
  drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c 
b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
index c70541f95a73..c100a0d70fe2 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
@@ -151,7 +151,8 @@ u8 rtw_set_802_11_ssid(struct adapter *padapter, 
struct ndis_802_11_ssid *ssid)
      else if (check_fwstate(pmlmepriv, _FW_UNDER_LINKING) == true)
          goto release_mlme_lock;

-    if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) == 
true) {
+    if (check_fwstate(pmlmepriv,
+        _FW_LINKED | WIFI_ADHOC_MASTER_STATE)) {
          if ((pmlmepriv->assoc_ssid.ssid_length == ssid->ssid_length) &&
              (!memcmp(&pmlmepriv->assoc_ssid.ssid, ssid->ssid, 
ssid->ssid_length))) {
              if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) == false) {

base-commit: 26fd6bff2c050196005312d1d306889220952a99
-- 
2.43.0

Re: [PATCH v2] staging: rtl8723bs: remove unnecessary comparison to true

Posted by Greg KH 1 month, 1 week ago

On Tue, May 05, 2026 at 04:13:54PM +0530, Ashwin Gundarapu wrote:
> Remove explicit comparison to true in check_fwstate() call and
> add spacing around the bitwise OR operator to improve code style.
> 
> ---
> 
> v2: Resent with corrected whitespace via Thunderbird plain text mode.

This goes below the --- line below.  There should not be a --- line in
the middle of the changelog.

> 
> Signed-off-by: Ashwin Gundarapu <linuxuser509@zohomail.in>
> ---
>  drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
> b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
> index c70541f95a73..c100a0d70fe2 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
> @@ -151,7 +151,8 @@ u8 rtw_set_802_11_ssid(struct adapter *padapter, struct
> ndis_802_11_ssid *ssid)
>      else if (check_fwstate(pmlmepriv, _FW_UNDER_LINKING) == true)
>          goto release_mlme_lock;
> 
> -    if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) ==
> true) {
> +    if (check_fwstate(pmlmepriv,
> +        _FW_LINKED | WIFI_ADHOC_MASTER_STATE)) {

again, your patch is corrupted, and you ignored my previous review
comments.

Please relax, take a few days, fix up your email client and test it out
by sending a patch to yourself, and then send a new version.  There is
no rush here.

thanks,

greg k-h