[v5] staging: rtl8723bs: remove unnecessary comparison to true

[PATCH v5] staging: rtl8723bs: remove unnecessary comparison to true

Posted by Ashwin Gundarapu 1 month, 1 week ago

Remove explicit comparison to true in check_fwstate() call and
add spacing around the bitwise OR operator to improve code style.

Signed-off-by: Ashwin Gundarapu <linuxuser509@zohomail.in>
---
v5: Removed git header from email body. Fixed indentation on
the second line of the function call. Added full version history.

v4: Moved changelog below the --- separator. Ran checkpatch.pl
- no errors or warnings. Fixed whitespace per Greg KH's review.

v3: Fixed double --- line and corrected whitespace formatting.

v2: Resent with corrected whitespace via Thunderbird plain text mode.

 drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
index c70541f95a73..c100a0d70fe2 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
@@ -151,7 +151,8 @@ u8 rtw_set_802_11_ssid(struct adapter *padapter, struct ndis_802_11_ssid *ssid)
	else if (check_fwstate(pmlmepriv, _FW_UNDER_LINKING) == true)
		goto release_mlme_lock;
 
-	if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) == true) {
+	if (check_fwstate(pmlmepriv,
+		_FW_LINKED | WIFI_ADHOC_MASTER_STATE)) {
		if ((pmlmepriv->assoc_ssid.ssid_length == ssid->ssid_length) &&
		    (!memcmp(&pmlmepriv->assoc_ssid.ssid, ssid->ssid, ssid->ssid_length))) {
			if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) == false) {

base-commit: 26fd6bff2c050196005312d1d306889220952a99
-- 
2.43.0

Re: [PATCH v5] staging: rtl8723bs: remove unnecessary comparison to true

Posted by Luka Gejak 1 month ago

On Thu May 7, 2026 at 7:21 AM CEST, Ashwin Gundarapu wrote:
> Remove explicit comparison to true in check_fwstate() call and
> add spacing around the bitwise OR operator to improve code style.
>
> Signed-off-by: Ashwin Gundarapu <linuxuser509@zohomail.in>
> ---
> v5: Removed git header from email body. Fixed indentation on
> the second line of the function call. Added full version history.
>
> v4: Moved changelog below the --- separator. Ran checkpatch.pl
> - no errors or warnings. Fixed whitespace per Greg KH's review.
>
> v3: Fixed double --- line and corrected whitespace formatting.
>
> v2: Resent with corrected whitespace via Thunderbird plain text mode.
>
>  drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
> index c70541f95a73..c100a0d70fe2 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
> @@ -151,7 +151,8 @@ u8 rtw_set_802_11_ssid(struct adapter *padapter, struct ndis_802_11_ssid *ssid)
> 	else if (check_fwstate(pmlmepriv, _FW_UNDER_LINKING) == true)
> 		goto release_mlme_lock;
>  
> -	if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) == true) {
> +	if (check_fwstate(pmlmepriv,
> +		_FW_LINKED | WIFI_ADHOC_MASTER_STATE)) {

Please align it as you see in the following block:
	if (check_fwstate(pmlmepriv,
	    _FW_LINKED | WIFI_ADHOC_MASTER_STATE)) {
Best regards,
Luka Gejak
> 		if ((pmlmepriv->assoc_ssid.ssid_length == ssid->ssid_length) &&
> 		    (!memcmp(&pmlmepriv->assoc_ssid.ssid, ssid->ssid, ssid->ssid_length))) {
> 			if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) == false) {
>
> base-commit: 26fd6bff2c050196005312d1d306889220952a99

Re: [PATCH v5] staging: rtl8723bs: remove unnecessary comparison to true

Posted by Luka Gejak 1 month ago

On Thu May 7, 2026 at 7:21 AM CEST, Ashwin Gundarapu wrote:
> Remove explicit comparison to true in check_fwstate() call and
> add spacing around the bitwise OR operator to improve code style.
>
> Signed-off-by: Ashwin Gundarapu <linuxuser509@zohomail.in>
> ---
> v5: Removed git header from email body. Fixed indentation on
> the second line of the function call. Added full version history.
>
> v4: Moved changelog below the --- separator. Ran checkpatch.pl
> - no errors or warnings. Fixed whitespace per Greg KH's review.
>
> v3: Fixed double --- line and corrected whitespace formatting.
>
> v2: Resent with corrected whitespace via Thunderbird plain text mode.
>
>  drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
> index c70541f95a73..c100a0d70fe2 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
> @@ -151,7 +151,8 @@ u8 rtw_set_802_11_ssid(struct adapter *padapter, struct ndis_802_11_ssid *ssid)
> 	else if (check_fwstate(pmlmepriv, _FW_UNDER_LINKING) == true)
> 		goto release_mlme_lock;
>  
> -	if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) == true) {
> +	if (check_fwstate(pmlmepriv,
> +		_FW_LINKED | WIFI_ADHOC_MASTER_STATE)) {

This indentation is still not correct and it doesn't apply to 
staging-next either.
Best regards,
Luka Gejak

> 		if ((pmlmepriv->assoc_ssid.ssid_length == ssid->ssid_length) &&
> 		    (!memcmp(&pmlmepriv->assoc_ssid.ssid, ssid->ssid, ssid->ssid_length))) {
> 			if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) == false) {
>
> base-commit: 26fd6bff2c050196005312d1d306889220952a99