remoteproc: qcom: Fix devm_ioremap_resource_wc() checking

[PATCH 0/4] remoteproc: qcom: Fix devm_ioremap_resource_wc() checking

Dan Carpenter posted 4 patches 2 days, 7 hours ago

Download series mbox

drivers/remoteproc/qcom_q6v5_adsp.c | 5 +++--
drivers/remoteproc/qcom_q6v5_pas.c  | 8 ++++----
drivers/remoteproc/qcom_q6v5_wcss.c | 4 ++--
drivers/remoteproc/qcom_wcnss.c     | 4 ++--
4 files changed, 11 insertions(+), 10 deletions(-)

Expand all Fold all

[PATCH 0/4] remoteproc: qcom: Fix devm_ioremap_resource_wc() checking

Posted by Dan Carpenter 2 days, 7 hours ago

The devm_ioremap_resource_wc() function returns error pointers and not
NULL.  I don't know, if you'll want to fold these patches all together
or not.  Or into the original patch, perhaps?

Dan Carpenter (4):
  remoteproc: qcom: Fix a NULL vs IS_ERR() check in
    adsp_alloc_memory_region()
  remoteproc: qcom: pas: Fix a couple NULL vs IS_ERR() bugs
  remoteproc: qcom: Fix NULL vs IS_ERR() bug in
    q6v5_alloc_memory_region()
  remoteproc: qcom_wcnss: Fix NULL vs IS_ERR() bug in
    wcnss_alloc_memory_region()

 drivers/remoteproc/qcom_q6v5_adsp.c | 5 +++--
 drivers/remoteproc/qcom_q6v5_pas.c  | 8 ++++----
 drivers/remoteproc/qcom_q6v5_wcss.c | 4 ++--
 drivers/remoteproc/qcom_wcnss.c     | 4 ++--
 4 files changed, 11 insertions(+), 10 deletions(-)

-- 
2.51.0

Re: [PATCH 0/4] remoteproc: qcom: Fix devm_ioremap_resource_wc() checking

Posted by Konrad Dybcio 10 hours ago

On 11/29/25 3:50 PM, Dan Carpenter wrote:
> The devm_ioremap_resource_wc() function returns error pointers and not
> NULL.  I don't know, if you'll want to fold these patches all together
> or not.  Or into the original patch, perhaps?

Thanks for catching this!

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad