From nobody Mon Dec 1 22:36:28 2025 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81039274FD3 for ; Sat, 29 Nov 2025 14:50:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764427860; cv=none; b=FNgzsLZnUHMP/LR3zkxhGuH2elOUyCYqHbt5LTkDUp5ENZdBX18+tWD5bgBU7KCsWfaKfFflXIwMd35I8ex9Y70r9pii0qzNddNEvijoaWNOsX2qCw15T1SqQNHvgYK9V5M7ONOH52rbxNiL5rX7QBwiY9YMbD2OEMiVusVKYKo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764427860; c=relaxed/simple; bh=kJAVYd2/PPlXFLOf6bOfuTDn5AtW65rQSCFJWrlTfDE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=s02lvMrq+o5dvmIMaiSSidR0AjRSBoQ6w+RblH6CR9uOyXvQ/XT5KXbeJU41+MLBlvnQ0JmjseOrZfGb28709Xa/at8qSt9IOOl8jRPQONzz3teba9MfyXuA3Dr6uriDl9kiLDX+XLOdjTyaXdJV2GvcPjlKVmoXr+EHAiUzMms= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=W/Qx3XDM; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="W/Qx3XDM" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-42b3c5defb2so1914065f8f.2 for ; Sat, 29 Nov 2025 06:50:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764427857; x=1765032657; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=5roHuQegQf4KvGy0xBz6y0ubzRCDlqFmvzi3L2AWogw=; b=W/Qx3XDMWS1ds9QdnTvdp2EazQKt2QvWbGq+Oz5cZIPAnny/0obCp/TMzLTcx7G/Dl 1/DyEOg8aKg1/+cwX7yUJg90U7s0QCM3ggawgrJyeRqT8snKDOHGJadgjo/RcC8L6Mj0 4RuJyXgRVSei3CyAYLngQzTfQHJeBCZinYKHoSU9M5WF2XO+/Sco7oZ+aWRxh/d392Ug MUmmJnfY+A+vVz/CflTebjGmsYZZgB29EOgtChAB2fNYQqjVfWAvOSPfts78IFu6cBIE tcDtgrxVxBjc8D1ELRBZBg1eY5TbTKA7JbxXPAmgdo/BJ4DZ1y/LisyCd5KVMZWm06o8 mmfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764427857; x=1765032657; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5roHuQegQf4KvGy0xBz6y0ubzRCDlqFmvzi3L2AWogw=; b=fQJvW65dm9SesiiKpF74tfkzNNLQtYOwNjfwFxvioY2VCbtBNJYqgPwaoinP/aiAQQ 4LCulbwVXm7ni3sIsA9NZIoVzwwUC3BBZdh5Ov3G4nItXsJptffLu3+Chat3rndWKRij FM72m8v3zFix1jT7ROTSqSRyyNp+ytUyXyJFe5NibxRgEA8extzbbGCtEjnFpM/N43J5 vXfaubhYen/KgsXZTvbiA+Ifj8IOznboKfIEcRa/Ndxt2OhQ9zprbbirKkP6AEnjWJ/W wXlI/vjhsyzu5r74s7rH92b5blfa5M2v7U15EousCUOYDtPQCp5ID7RRIaiBZ8s+MA7T o3Kg== X-Forwarded-Encrypted: i=1; AJvYcCWLx7ttMyGehn+FOw892vBx2MpUmAbRwRu/uhrSHyr104qmI8v7z1xf9wzixMOjHMBlfsjn0mo/TO26xfA=@vger.kernel.org X-Gm-Message-State: AOJu0Yz/nOv6r0ppq+C5d/5Yt5JV4YhqZyewGAwdXbH6SvQyg/Cjy7Ap fw0hOlNW5wyh0jv1crB+s9Xt4l+SOA7czsSMQAwtpHn3k5oICF5tb6OQgf3rax5Z4pU= X-Gm-Gg: ASbGncvd4CHt79oVfTZP9x1u/F9wfVMxDkepz830AGv5Y6S4Zq9cXuOs8qBwjv8raZ+ Y3+/5ai4lqOZ9ovllrxmMR2VxAvAZIGTFdjhhwwBRpOrw0Y6iw7U21UfUPGw9Uke4RRLTYVu41g zGeU4lHoiCZDh2q0jJIKyxclFj3SdqCNirEmaDVB6C0dlxatJ6qlF7mJYKWqLyexYBGncmRDdF3 5y78UoVAmlxCHfFZ+42H/SWusOZgztSYcTKlpz44DmMVEBnSzW7NUlEe/p48xWt/z49oTE8SZIe 1wMfxysujML1+obaA7xdO2oITMQLdiYoR2MtltJtECXGFbB7oUbruzpPBABedc0M5OcPUFWDTGq OWMOYs8ggDrOLZ86klh4ZSWsg4p8XXtsR2T8df8GraGmyBnagIBVviNsRzOEHgbaX4a6Ncbdfg4 Y5OfZGWmiAA6Vp3KAzKTNvy1xowbY= X-Google-Smtp-Source: AGHT+IF17rmdp5RFNg6kmMqYr9tYvGHfwa2QHnZkDzl2I/vBSSLY/k6vA/+nMv85qGYklo9B258YMw== X-Received: by 2002:a05:6000:61e:b0:429:d6dc:ae30 with SMTP id ffacd0b85a97d-42cc1d19914mr34066767f8f.46.1764427856782; Sat, 29 Nov 2025 06:50:56 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-42e1c5c3016sm15993129f8f.1.2025.11.29.06.50.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Nov 2025 06:50:56 -0800 (PST) Date: Sat, 29 Nov 2025 17:50:53 +0300 From: Dan Carpenter To: Rob Herring Cc: Bjorn Andersson , Mathieu Poirier , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/4] remoteproc: qcom_q6v5_adsp: Fix a NULL vs IS_ERR() check in adsp_alloc_memory_region() Message-ID: <6d6b1b0fb6a61b5155a640507217fd7e658858cf.1764427595.git.dan.carpenter@linaro.org> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The devm_ioremap_resource_wc() function never returns NULL, it returns error pointers. Update the check to match. Fixes: c70b9d5fdcd7 ("remoteproc: qcom: Use of_reserved_mem_region_* functi= ons for "memory-region"") Signed-off-by: Dan Carpenter Reviewed-by: Konrad Dybcio --- drivers/remoteproc/qcom_q6v5_adsp.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/remoteproc/qcom_q6v5_adsp.c b/drivers/remoteproc/qcom_= q6v5_adsp.c index d3933a66ed3d..b5c8d6d38c9c 100644 --- a/drivers/remoteproc/qcom_q6v5_adsp.c +++ b/drivers/remoteproc/qcom_q6v5_adsp.c @@ -637,9 +637,10 @@ static int adsp_alloc_memory_region(struct qcom_adsp *= adsp) adsp->mem_phys =3D adsp->mem_reloc =3D res.start; adsp->mem_size =3D resource_size(&res); adsp->mem_region =3D devm_ioremap_resource_wc(adsp->dev, &res); - if (!adsp->mem_region) { + if (IS_ERR(adsp->mem_region)) { dev_err(adsp->dev, "unable to map memory region: %pR\n", &res); - return -EBUSY; + return PTR_ERR(adsp->mem_region); + } =20 return 0; --=20 2.51.0 From nobody Mon Dec 1 22:36:28 2025 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A9A730FC33 for ; Sat, 29 Nov 2025 14:51:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764427869; cv=none; b=KLgkmFu2PaFGBJLOqQ/oOP1o9oXNSDAiqSUeV7j3oNxJubFw2CvDk2sMpcxOW7ZcvqyRdbG/QzViOxbJEZ1sjeytEXXTkTCAnFlevvZ0jKx9OApOrwnoi4c4xxbjXWiaTBZIlBok+okJ4JbP3Q1UI32SpyW00vEeFFWWbqRtQVU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764427869; c=relaxed/simple; bh=X/RTVwC1oGN6z5Dka28hemcDQEwsfiKSfg6YdtWaW+k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XSRaw5Y4vVyA6EMNbjiIgNN7R6FNAZXEk665tNDzIPy1HgPrO7tJqocyk5NgvVRaRznPWdPP3IRX6NnTnhjqoG8A2y7OXAf8f0b74oLivw2JDDACO67eZi1lROirgNe3w33nj4bK8RWTxtu5smSk8lHWKo+BFW5R0/OToUaPQ64= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Edb7YlTM; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Edb7YlTM" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-42b387483bbso2239976f8f.1 for ; Sat, 29 Nov 2025 06:51:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764427864; x=1765032664; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=f3+pjSj3t+U3wmCCuCdgSBWbp2oqy9bpefHhTr0B/p4=; b=Edb7YlTMKW3UOrRT81YS5BSR99iJ91d/nQS/bgTAUfcE05sG/LVymlvwCFxWNpIuA3 zGXTsdAZDAobQ0D0//VpI5OINXNMGFjLqr+C+xle/Sw6zUd+vpFTYtnPNmw53KJxMTEA 54vIEUB5Obth+i95O9p8DGH+2hmqwwQoiIqTILAR8GQ1Pn5nNRN46PH/mR2A9E07u5pt ieh2/qft8jTaczN2bbM9pgtn25azuQVtybOGwdzGotO6U6pwcNCawY0XElWB7gh/TqDu NPwfXWrQ3s5XdWIBxGO+nkwEQgPYVIaQVLUxlR9kdQPZSonkAjEXtN57rSwWf7Dyy+gB TWhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764427864; x=1765032664; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=f3+pjSj3t+U3wmCCuCdgSBWbp2oqy9bpefHhTr0B/p4=; b=us3pkY8FNTT+nl6X9ujuwvaFs0qAQxDzpwjPil9pBA3KgP/vB+tcA8KeG5xbjxwRIE BGoVhB/0CDElXfULHpWmrpuZwl18U3cCFGsFxiS+ol6YAW33sLp4DvHYfrvQdgYSSEtA tEOKrwLwYkEYvdoPsqs5z6TFi11O1u5gRujkxUt3Q8NViRd/+YkUS3gSBoYNkdwCQqnO Y9Xu2y0TDdHTbcVcHK/0HSxQL6OlXykDAvhyB4RWC3Lo7fXrlCavQnyfktoJ8ar7PwUq Bz1TxvvIaWcvIb0i0dKpH54gNX9VA+GZaObRyXTL8v0svI68/R5kfoy/o8U3jqhHvS0M zYNQ== X-Forwarded-Encrypted: i=1; AJvYcCWYxwM/yOxiiUNTjt/BTCOhVM9hFzctGJt2638NPJAUGmOscwVzNmjY8wJuoglMMZ3nVSMcG8fbsgRwcIU=@vger.kernel.org X-Gm-Message-State: AOJu0Yyp4/DVPmKsZ6LSzhj1IjhGzptBncElXPwt2GLBwTbzIS91tXQo EZBLocyQWOuvZxmGc9s3CMjEJEB7vFwWTmmZw0s/g5qf7sV0/NvtzhaugM9wr9+Zjio= X-Gm-Gg: ASbGncsQNm8mm7gW5Ch3jFhjQA72piu9faB0NDt1C1UGNHO9a8O4fxXSwOWAfctS2Cg qdOIRbzFvf0m5QwWtF56bZgjCv+oP3bs/0okMtgbk0Hi57fAFwyn/KSvSonCvj284++x3+PMon2 SJbvKLmN9dEjgUg3biAKxhAfN679LLNvTp7gaLLM+J/IrNXVErDsWVs155goo58JLX5gwttoQP6 6i4o6w55Sbzc8G/peEYHv8u7mcvwl5gTt75yCEORQtGxbvAoN5OXElvQQB+nb3BNwF+I9UawrKJ Nkvny8AumvZkW7CWbwFfqjhJjJPd2japPm05W8mY03zrQOdYjw/HgSyjct1IQNc6cd+uwNHQiCi QA8IYeBLUDdBCXllIA+DofLB+6J+VKyuElSzvxQMpIw1bCpiWxyUihtFYvRT3xql43n+b2/NBuP pH1Zk4M06uoyNYxRkVFVY98dnHf0Y= X-Google-Smtp-Source: AGHT+IFXZI+MiyMb88/2TV0PWTJHmmEbApjR91PzKlDmX//1XB5OJjcUROKOaS3odKI4ruxOcHnq3w== X-Received: by 2002:a05:6000:2681:b0:429:c8e4:b691 with SMTP id ffacd0b85a97d-42cc1d5239amr32341226f8f.55.1764427864191; Sat, 29 Nov 2025 06:51:04 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-42e1c5c3022sm16478970f8f.4.2025.11.29.06.51.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Nov 2025 06:51:03 -0800 (PST) Date: Sat, 29 Nov 2025 17:51:00 +0300 From: Dan Carpenter To: Rob Herring Cc: Bjorn Andersson , Mathieu Poirier , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/4] remoteproc: qcom: pas: Fix a couple NULL vs IS_ERR() bugs Message-ID: <0599691acc394d9390da8fa0b5de3399b132b187.1764427595.git.dan.carpenter@linaro.org> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The devm_ioremap_resource_wc() function never returns NULL, it returns error pointers. Update the checking to match. Fixes: c70b9d5fdcd7 ("remoteproc: qcom: Use of_reserved_mem_region_* functi= ons for "memory-region"") Signed-off-by: Dan Carpenter Reviewed-by: Konrad Dybcio --- drivers/remoteproc/qcom_q6v5_pas.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q= 6v5_pas.c index 609df141ecb1..52680ac99589 100644 --- a/drivers/remoteproc/qcom_q6v5_pas.c +++ b/drivers/remoteproc/qcom_q6v5_pas.c @@ -559,9 +559,9 @@ static int qcom_pas_alloc_memory_region(struct qcom_pas= *pas) pas->mem_phys =3D pas->mem_reloc =3D res.start; pas->mem_size =3D resource_size(&res); pas->mem_region =3D devm_ioremap_resource_wc(pas->dev, &res); - if (!pas->mem_region) { + if (IS_ERR(pas->mem_region)) { dev_err(pas->dev, "unable to map memory region: %pR\n", &res); - return -EBUSY; + return PTR_ERR(pas->mem_region); } =20 if (!pas->dtb_pas_id) @@ -576,9 +576,9 @@ static int qcom_pas_alloc_memory_region(struct qcom_pas= *pas) pas->dtb_mem_phys =3D pas->dtb_mem_reloc =3D res.start; pas->dtb_mem_size =3D resource_size(&res); pas->dtb_mem_region =3D devm_ioremap_resource_wc(pas->dev, &res); - if (!pas->dtb_mem_region) { + if (IS_ERR(pas->dtb_mem_region)) { dev_err(pas->dev, "unable to map dtb memory region: %pR\n", &res); - return -EBUSY; + return PTR_ERR(pas->dtb_mem_region); } =20 return 0; --=20 2.51.0 From nobody Mon Dec 1 22:36:28 2025 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A0D93101C4 for ; Sat, 29 Nov 2025 14:51:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764427873; cv=none; b=KUpaHB8/ni/hyqNS+/0EPsGaAxP+/FDHGK8uJrbWFhScgpNS+Lm3U4yxAAbP9oTRLGBITmEPuZNBWHHDL/Vm3cVnVSzbkxSX9xs9Jm1zBZ1GtSl7HCXTLUye6ymv3g9ecrUIVdZtA1Gwlbmb0DXNl1QbFKyOPIzEMOmZP+SIh5Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764427873; c=relaxed/simple; bh=liK4LfPiU0pY5XDiNJ+cSHVdLUrTAgHETaseY8tBJKk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=o/Oq83qhm+tvNtHgnmM8y9v2j07qlkJ/Vj857llFoY3xijX8/zrM838eZ5jDHyp0rzxcOgpXM/7l/2Jyq34rc6Ch0rYm84qY92nV6n5/DKnOcHMrTuc2KFC47OpXQoXtUeK66SiJ/Y7nDdjbngHFewAA9l2LmwYhWI47TS53YjE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=OTp0JeTY; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OTp0JeTY" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-42b31507ed8so2489069f8f.1 for ; Sat, 29 Nov 2025 06:51:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764427869; x=1765032669; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zkWGeeB7i8StC9hMxWOTKSpu55uDyb2ej0mWJX0OlQI=; b=OTp0JeTYcnM7wS0ZfC8saS190+0Jynbzk/rWFOrtBoOOPzuz+1fWIxOYfNiJ0j5Eaa Uq803kVZMCFUQ3w9P7SP1ApyyU2KvyYJz80Tc+cz24w9bHkOBTz4OPcqSrK6JLIV60CX ljOLeKI7CTotbb/ZqjowVUvhsm+uRPTUO9aRJTmDzEumR4UgxzRiHmCxZTjb+wGJ+Evc BXxDdCcfYgn5Y5+BNF5HM6dP5cLq7HJOwq9bbf6gDstWuetBMYUJmCd4hs5SWijY31Hl 39R67hIoGMPlOORmo9SCEaBCCjEnNvnNLYMIxxOYBcjFRlkDakuwWVyNMUlAoCt7IgKT 9vyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764427869; x=1765032669; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zkWGeeB7i8StC9hMxWOTKSpu55uDyb2ej0mWJX0OlQI=; b=Bm8Q7hkRBC9H0YG/XqDmJ8ARd7lbir83fk8u7d4t0jedDTdUE7tMnD6/xIeOsAOBHj Qe3d1OV9t3hyyj9EROaALwG1WZsGP/8HvQG52gB3cUNTHY5haS3ru2Oy/I6Y5Bk6ot4/ 1R7wQ95lU3dmkH2Km/yVrlnbtK3zqh4cPv7HJ4up9L92p38RaG7cEPqkE9GoAWA8ojZH WwI/4Fg4OB3zG0hxVLbDKmer6MwdDw94Oe2RTbnAFD+EV3Q3Z93PzuHTFLFUzyCzTyhR QGqPWv814FWfH43G3M50VdHTEm7AF1RCI7RV/j8GiMfWg3LvFGCoQZsu30RDQkgJfbkH 8kCg== X-Forwarded-Encrypted: i=1; AJvYcCWVpP9lqbkshHp/ZOH3MffY7xIjn/U7juK7KZM1QaYbUAnfLzk+/Wd/Z8hb77xG1fp4+1dnRnYJv2fgohU=@vger.kernel.org X-Gm-Message-State: AOJu0YzPuKIyAmyaNX5RtwpSEC8+W+Lnw11tNBIgWlbLANaN1g0YqpTa zJwb8kOe1TfJXhRDZiqM8Cg+mrLcpgExoC1GkDtJ6apdGFNIfkoXoehk9PB9/rqSz5E= X-Gm-Gg: ASbGncvvfk+DWVQWxYlaK9/lAf2tobJzBIqzdwSpfUq4SSNfe+NvukGzP/kS6hcS7NI 2XwyHAs0C5mphU5RKa3SuJVV63EvPJEyJh+ockeqqPjZa7IbaRVSjLq8oTbPcURw1HXVsCbsIW+ BxUjzofrjqW7ZGX5MnD0JXPlF9yQq1AES5WCBVNdRX2nNl0YD6YxiRhRuLF18HBS66dMYnJImNa thx3SThAwRutRnJ5+ksWRy38lSzmVo73IOm1BMp/7RBqBPV+diBt5/lIlQvPwPjgihqhHg1F95P dp/A3bPs0mU5+EBRlA79c4rq9P0YgPhyHrtSjQmWUn2rrxCp32ilrWBUNBdy0lUkcWsfEuEP299 FTD4ke0OZ2bdOzUiYKWVB2Rb5HHW6izxAqsr+m+GwhmJGNdVu0FLjgXyQ2qHtlTtPn5gTMcbbvp L1SxanHoBbhuUjfmTA X-Google-Smtp-Source: AGHT+IHtQkQGQCuMCo6bY3Ja5uUySeD4yPVpGdxPG7jpQTsa5cwSzFut7/w/KfuwVM8RFg93hJTJ6A== X-Received: by 2002:a05:6000:3106:b0:429:cda2:9ffe with SMTP id ffacd0b85a97d-42e0f1fb97amr21174292f8f.7.1764427869395; Sat, 29 Nov 2025 06:51:09 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-42e1ca1a38bsm16309890f8f.24.2025.11.29.06.51.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Nov 2025 06:51:08 -0800 (PST) Date: Sat, 29 Nov 2025 17:51:05 +0300 From: Dan Carpenter To: Rob Herring Cc: Bjorn Andersson , Mathieu Poirier , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/4] remoteproc: qcom: q6v5: Fix NULL vs IS_ERR() bug in q6v5_alloc_memory_region() Message-ID: <674b32a78563282adeaf3cdf941314a0b8181026.1764427595.git.dan.carpenter@linaro.org> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The devm_ioremap_resource_wc() function never returns NULL, it returns error pointers. Update the checking to match. Fixes: c70b9d5fdcd7 ("remoteproc: qcom: Use of_reserved_mem_region_* functi= ons for "memory-region"") Signed-off-by: Dan Carpenter Reviewed-by: Konrad Dybcio --- drivers/remoteproc/qcom_q6v5_wcss.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/remoteproc/qcom_q6v5_wcss.c b/drivers/remoteproc/qcom_= q6v5_wcss.c index ca748e3bcc7f..d96af0e0f665 100644 --- a/drivers/remoteproc/qcom_q6v5_wcss.c +++ b/drivers/remoteproc/qcom_q6v5_wcss.c @@ -887,9 +887,9 @@ static int q6v5_alloc_memory_region(struct q6v5_wcss *w= css) wcss->mem_reloc =3D res.start; wcss->mem_size =3D resource_size(&res); wcss->mem_region =3D devm_ioremap_resource_wc(dev, &res); - if (!wcss->mem_region) { + if (IS_ERR(wcss->mem_region)) { dev_err(dev, "unable to map memory region: %pR\n", &res); - return -EBUSY; + return PTR_ERR(wcss->mem_region); } =20 return 0; --=20 2.51.0 From nobody Mon Dec 1 22:36:28 2025 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBAE930FF2F for ; Sat, 29 Nov 2025 14:51:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764427878; cv=none; b=UaMZRbly+qdpp8DnMXUrFH6nMdmFtOtUlt6LduL9ZVcztxUyW0faCKIghHKtCez5lVluYAcXqZNVNKVb92VeVItttKLtBlhBaTHP9ePtoPnPGkaIomXIlIL0N9fIlA6PEsaiLmVFcirt/GOfhWdaAoFP+s2NLutihNfoKrdZnPM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764427878; c=relaxed/simple; bh=k0aIXU/reI+53H81Ixsu15XtjHUspATirIgbwnqrpAg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tuLgeysy8+ZFKpMFOiZCuLwJdLd6XvsMvHpoJM6OvHlGg19gid9N+aP9B77a4DKtJIaoTNZso6k0OkwNoJmJTJMIbUcucpBig2CyQVRpN802lRUs2SZA9GrQ/IhygLa28TOdGXlmVMXnmP2tbCTSzfMJaT8h0zoyPE1PjuEzUJo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=e6QWul9e; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="e6QWul9e" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-42b3b0d76fcso1686507f8f.3 for ; Sat, 29 Nov 2025 06:51:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764427874; x=1765032674; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=OKiAwlo9LZ0Y6EQWk7tLBh+YOq0wAbCqmwXrVpwlBTk=; b=e6QWul9eVkXu3AldsfdZpnEwyPb4cCSw2rh1580xlqie+o9vGgPGCc0I5vv7GD/9fQ 8l9D+fkMPTSZyBWQbrkpOOgHNIDevAhPplyFMUdwlZDrV7X3uzLEWGeUwK6uIykF3c+D VETW/vlda54+UFPfP1otbmf0VPW5bRimmi1zPMHJK20YwE+HlLRVmj8ocU++4LyIgdq3 ieEYIcto4zyTjqYdMMpNZ/+pguK5M0ByvAbSW1ZkVF007/U4mv0xvXjaGd37I9pGNktf LJDkYywSW89izgkZtrHr4PVrsR3QTptLRviMTJvYGlx1uV+zfgWqSL5SomRuTpgIYggA ScvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764427874; x=1765032674; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OKiAwlo9LZ0Y6EQWk7tLBh+YOq0wAbCqmwXrVpwlBTk=; b=IYf/PhYIpyEa/zF8DXs2221rWIzpIDwivwbBiROwFGd1jRRaqcPWnMJfqXcik6i1DI foG99g1ay+qv+3iFNzS06M4e7rAmFEJZ48yJSLU2ibF8wrt71KAwz/O7qcDgaH7jB+1s x9AZYcclZFdi06Xp9pHea+gCAcsxwTfKLnQ3t/RmYK4MIqgpIC+KUlJtkdwmnhPB2qJJ Rnlo4bSs304zTgYsRKl/72Rddsm+UjITO17ha/CzB7w1IIugEpigl+DKnC9TkggKnBI8 0j37YSKL/GOqyk6jz6fSne6jvRduuIaZVZjXhW6Uh+PjGJMRZEK+rfi5iZEQbdOS2IhW 4/gQ== X-Forwarded-Encrypted: i=1; AJvYcCUNk5qiGzJA3Zb1yNi9QZixodphZ2PtMP/8/cd6YmL2iG97iMlCaEwH9LP/Ub0YIv14+gQgGORPFhS1jIA=@vger.kernel.org X-Gm-Message-State: AOJu0YyAHxa0c6H1N0QKMF8vCeUV2MRS4zcKPt6FqiGV4GLEd0hFe5DI GQCoJ6Z9KZ1x8MLaWzY45GSUC1Jp0afpeQCPtdoAqmW7DBqvy+e2677KbEojDhPPgHs= X-Gm-Gg: ASbGncvDoZ+v+AijRJTEoygDFsxnfEoAtoujHY+FgHkNtGRTosP/2LszpBNIppT3qmv frz89OjvTpmvycIWB66GaNfzF5DIwVyEQ5AsW5slOojDSnq3BqkZYuaR9+YY/1km3iiTY3rdX8T HdgV5qnpAM+6nZnGBGRWdpspONCMnSxdH3+ILEs/uuYUUv5MMwyrsRDgLFL9yEhiTnXnw0WIpys 2naTkmHFUeV+QrSrm79aWMdyw9yMHrsgDccqMtm919DKFx/9O3s9EuaY5OwzYb/Egy8sYsDh42k jNZzVSPhPefx526K1nhzQHCGfRMq6qCnGKhdgpcWW/LtCqjbhgfZ4t9BZ5p9qxd/ZCBy7Ofiur0 MupOqgMmt8BbGUkSHF4WtVIYEDp/qFkqxsE/zuEi5Xo6ylG+k+ZKXklAvSAqPyiKRHQBqGoxY/v EOcYsoDe2ipeJqf/j6vBkNf+XgX5E= X-Google-Smtp-Source: AGHT+IGI6zgN1d5AOjsGAZRHPGRNf4EQ0mzqlTC7dJh5tDbKD0iL7abVcYqrVgB4mGVfZwt9HhaLKw== X-Received: by 2002:a05:6000:2387:b0:429:dc9a:ed35 with SMTP id ffacd0b85a97d-42cc1d3479cmr34440564f8f.43.1764427873971; Sat, 29 Nov 2025 06:51:13 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-42e1ca1a303sm16609079f8f.27.2025.11.29.06.51.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Nov 2025 06:51:13 -0800 (PST) Date: Sat, 29 Nov 2025 17:51:10 +0300 From: Dan Carpenter To: Rob Herring Cc: Bjorn Andersson , Mathieu Poirier , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/4] remoteproc: qcom_wcnss: Fix NULL vs IS_ERR() bug in wcnss_alloc_memory_region() Message-ID: <09a43da41ee277a80a3265348831e747f7b62620.1764427595.git.dan.carpenter@linaro.org> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The devm_ioremap_resource_wc() function never returns NULL, it returns error pointers. Update the checking to match. Fixes: c70b9d5fdcd7 ("remoteproc: qcom: Use of_reserved_mem_region_* functi= ons for "memory-region"") Signed-off-by: Dan Carpenter Reviewed-by: Konrad Dybcio --- drivers/remoteproc/qcom_wcnss.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/remoteproc/qcom_wcnss.c b/drivers/remoteproc/qcom_wcns= s.c index 14005fb049a2..ee18bf2e8054 100644 --- a/drivers/remoteproc/qcom_wcnss.c +++ b/drivers/remoteproc/qcom_wcnss.c @@ -538,9 +538,9 @@ static int wcnss_alloc_memory_region(struct qcom_wcnss = *wcnss) wcnss->mem_phys =3D wcnss->mem_reloc =3D res.start; wcnss->mem_size =3D resource_size(&res); wcnss->mem_region =3D devm_ioremap_resource_wc(wcnss->dev, &res); - if (!wcnss->mem_region) { + if (IS_ERR(wcnss->mem_region)) { dev_err(wcnss->dev, "unable to map memory region: %pR\n", &res); - return -EBUSY; + return PTR_ERR(wcnss->mem_region); } =20 return 0; --=20 2.51.0