[PATCH v3 00/32] clk: at91: add support for parent_data and

Ryan.Wanner@microchip.com posted 32 patches 2 months, 4 weeks ago
There is a newer version of this series
drivers/clk/at91/at91rm9200.c       |  95 ++++----
drivers/clk/at91/at91sam9260.c      | 136 ++++++------
drivers/clk/at91/at91sam9g45.c      |  89 ++++----
drivers/clk/at91/at91sam9n12.c      | 106 ++++-----
drivers/clk/at91/at91sam9rl.c       |  63 +++---
drivers/clk/at91/at91sam9x5.c       | 125 ++++++-----
drivers/clk/at91/clk-audio-pll.c    |  28 ++-
drivers/clk/at91/clk-generated.c    |   8 +-
drivers/clk/at91/clk-h32mx.c        |  11 +-
drivers/clk/at91/clk-i2s-mux.c      |   6 +-
drivers/clk/at91/clk-main.c         |  16 +-
drivers/clk/at91/clk-master.c       |  24 +-
drivers/clk/at91/clk-peripheral.c   |  16 +-
drivers/clk/at91/clk-pll.c          |   9 +-
drivers/clk/at91/clk-plldiv.c       |  11 +-
drivers/clk/at91/clk-programmable.c |   8 +-
drivers/clk/at91/clk-sam9x60-pll.c  |  14 +-
drivers/clk/at91/clk-slow.c         |   8 +-
drivers/clk/at91/clk-smd.c          |  10 +-
drivers/clk/at91/clk-system.c       |   8 +-
drivers/clk/at91/clk-usb.c          |  41 ++--
drivers/clk/at91/clk-utmi.c         |  16 +-
drivers/clk/at91/dt-compat.c        |  80 +++++--
drivers/clk/at91/pmc.h              |  66 +++---
drivers/clk/at91/sam9x60.c          | 117 +++++-----
drivers/clk/at91/sam9x7.c           | 328 ++++++++++++++++------------
drivers/clk/at91/sama5d2.c          | 168 +++++++-------
drivers/clk/at91/sama5d3.c          | 122 ++++++-----
drivers/clk/at91/sama5d4.c          | 129 +++++------
drivers/clk/at91/sama7d65.c         | 156 ++++++-------
drivers/clk/at91/sama7g5.c          | 111 +++++-----
31 files changed, 1134 insertions(+), 991 deletions(-)
[PATCH v3 00/32] clk: at91: add support for parent_data and
Posted by Ryan.Wanner@microchip.com 2 months, 4 weeks ago
From: Ryan Wanner <Ryan.Wanner@microchip.com>

This series adds support for parent data and parent _hw on the at91
clock drivers. This also updates all the SoC specific clock drivers to
use this format as well.

This is a continuation of the V1 of this series here [1].

This has been tested on the SAMA5* SoCs, the sam9x* SoCs, and the SAMA7*
SoCs.

Changes v1 -> V2:
- Remove all the small sama7g54 SoC driver changes and put them in their
  own patch.
- Add the SAMA7D65 and the SAM9X75 to this update.
- Add a patch to move all common used macros into the pmc.h file.
- Update changes from v6.6 to v6.16.
- Remove patches that where style fixes and include those in the update.

Changes v2 -> v3:
- Adjust each patch so they are fully atomic.
- Add a patch to have the SAMA7D65 systemclocks use parent_data and
  parent_hw.
- Add a formatting cleanup patch for the SAM9X75.
- Adjust commit messages that no longer show invalid information.


1) https://lore.kernel.org/all/20230727053156.13587-1-claudiu.beznea@tuxon.dev/


Claudiu Beznea (28):
  clk: at91: pmc: add macros for clk_parent_data
  clk: at91: clk-sam9x60-pll: use clk_parent_data
  clk: at91: clk-peripheral: switch to clk_parent_data
  clk: at91: clk-main: switch to clk parent data
  clk: at91: clk-utmi: use clk_parent_data
  clk: at91: clk-master: use clk_parent_data
  clk: at91: clk-programmable: use clk_parent_data
  clk: at91: clk-generated: use clk_parent_data
  clk: at91: clk-usb: add support for clk_parent_data
  clk: at91: clk-system: use clk_parent_data
  clk: at91: clk-pll: add support for parent_hw
  clk: at91: clk-audio-pll: add support for parent_hw
  clk: at91: clk-plldiv: add support for parent_hw
  clk: at91: clk-h32mx: add support for parent_hw
  clk: at91: clk-i2s-mux: add support for parent_hw
  clk: at91: clk-smd: add support for clk_parent_data
  clk: at91: clk-slow: add support for parent_hw
  clk: at91: dt-compat: switch to parent_hw and parent_data
  clk: at91: sam9x60: switch to parent_hw and parent_data
  clk: at91: sama5d2: switch to parent_hw and parent_data
  clk: at91: sama5d3: switch to parent_hw and parent_data
  clk: at91: sama5d4: switch to parent_hw and parent_data
  clk: at91: at91sam9x5: switch to parent_hw and parent_data
  clk: at91: at91rm9200: switch to parent_hw and parent_data
  clk: at91: at91sam9260: switch to parent_hw and parent_data
  clk: at91: at91sam9g45: switch to parent_hw and parent_data
  clk: at91: at91sam9n12: switch to parent_hw and parent_data
  clk: at91: at91sam9rl: switch to clk_parent_data

Ryan Wanner (4):
  clk: at91: pmc: Move macro to header file
  clk: at91: sam9x75: switch to parent_hw and parent_data
  clk: at91: sama7d65: switch to parent_hw and parent_data
  clk: at91: sam9x7: Clean up formatting

 drivers/clk/at91/at91rm9200.c       |  95 ++++----
 drivers/clk/at91/at91sam9260.c      | 136 ++++++------
 drivers/clk/at91/at91sam9g45.c      |  89 ++++----
 drivers/clk/at91/at91sam9n12.c      | 106 ++++-----
 drivers/clk/at91/at91sam9rl.c       |  63 +++---
 drivers/clk/at91/at91sam9x5.c       | 125 ++++++-----
 drivers/clk/at91/clk-audio-pll.c    |  28 ++-
 drivers/clk/at91/clk-generated.c    |   8 +-
 drivers/clk/at91/clk-h32mx.c        |  11 +-
 drivers/clk/at91/clk-i2s-mux.c      |   6 +-
 drivers/clk/at91/clk-main.c         |  16 +-
 drivers/clk/at91/clk-master.c       |  24 +-
 drivers/clk/at91/clk-peripheral.c   |  16 +-
 drivers/clk/at91/clk-pll.c          |   9 +-
 drivers/clk/at91/clk-plldiv.c       |  11 +-
 drivers/clk/at91/clk-programmable.c |   8 +-
 drivers/clk/at91/clk-sam9x60-pll.c  |  14 +-
 drivers/clk/at91/clk-slow.c         |   8 +-
 drivers/clk/at91/clk-smd.c          |  10 +-
 drivers/clk/at91/clk-system.c       |   8 +-
 drivers/clk/at91/clk-usb.c          |  41 ++--
 drivers/clk/at91/clk-utmi.c         |  16 +-
 drivers/clk/at91/dt-compat.c        |  80 +++++--
 drivers/clk/at91/pmc.h              |  66 +++---
 drivers/clk/at91/sam9x60.c          | 117 +++++-----
 drivers/clk/at91/sam9x7.c           | 328 ++++++++++++++++------------
 drivers/clk/at91/sama5d2.c          | 168 +++++++-------
 drivers/clk/at91/sama5d3.c          | 122 ++++++-----
 drivers/clk/at91/sama5d4.c          | 129 +++++------
 drivers/clk/at91/sama7d65.c         | 156 ++++++-------
 drivers/clk/at91/sama7g5.c          | 111 +++++-----
 31 files changed, 1134 insertions(+), 991 deletions(-)

-- 
2.43.0
Re: [PATCH v3 00/32] clk: at91: add support for parent_data and
Posted by Brian Masney 1 month, 1 week ago
Hi Ryan and Claudiu,

On Thu, Jul 10, 2025 at 01:06:53PM -0700, Ryan.Wanner@microchip.com wrote:
> From: Ryan Wanner <Ryan.Wanner@microchip.com>
> 
> This series adds support for parent data and parent _hw on the at91
> clock drivers. This also updates all the SoC specific clock drivers to
> use this format as well.
> 
> This is a continuation of the V1 of this series here [1].
> 
> This has been tested on the SAMA5* SoCs, the sam9x* SoCs, and the SAMA7*
> SoCs.
> 
> Changes v1 -> V2:
> - Remove all the small sama7g54 SoC driver changes and put them in their
>   own patch.
> - Add the SAMA7D65 and the SAM9X75 to this update.
> - Add a patch to move all common used macros into the pmc.h file.
> - Update changes from v6.6 to v6.16.
> - Remove patches that where style fixes and include those in the update.
> 
> Changes v2 -> v3:
> - Adjust each patch so they are fully atomic.
> - Add a patch to have the SAMA7D65 systemclocks use parent_data and
>   parent_hw.
> - Add a formatting cleanup patch for the SAM9X75.
> - Adjust commit messages that no longer show invalid information.
> 
> 
> 1) https://lore.kernel.org/all/20230727053156.13587-1-claudiu.beznea@tuxon.dev/
> 
> 
> Claudiu Beznea (28):
>   clk: at91: pmc: add macros for clk_parent_data
>   clk: at91: clk-sam9x60-pll: use clk_parent_data
>   clk: at91: clk-peripheral: switch to clk_parent_data
>   clk: at91: clk-main: switch to clk parent data
>   clk: at91: clk-utmi: use clk_parent_data
>   clk: at91: clk-master: use clk_parent_data
>   clk: at91: clk-programmable: use clk_parent_data
>   clk: at91: clk-generated: use clk_parent_data
>   clk: at91: clk-usb: add support for clk_parent_data
>   clk: at91: clk-system: use clk_parent_data
>   clk: at91: clk-pll: add support for parent_hw
>   clk: at91: clk-audio-pll: add support for parent_hw
>   clk: at91: clk-plldiv: add support for parent_hw
>   clk: at91: clk-h32mx: add support for parent_hw
>   clk: at91: clk-i2s-mux: add support for parent_hw
>   clk: at91: clk-smd: add support for clk_parent_data
>   clk: at91: clk-slow: add support for parent_hw
>   clk: at91: dt-compat: switch to parent_hw and parent_data
>   clk: at91: sam9x60: switch to parent_hw and parent_data
>   clk: at91: sama5d2: switch to parent_hw and parent_data
>   clk: at91: sama5d3: switch to parent_hw and parent_data
>   clk: at91: sama5d4: switch to parent_hw and parent_data
>   clk: at91: at91sam9x5: switch to parent_hw and parent_data
>   clk: at91: at91rm9200: switch to parent_hw and parent_data
>   clk: at91: at91sam9260: switch to parent_hw and parent_data
>   clk: at91: at91sam9g45: switch to parent_hw and parent_data
>   clk: at91: at91sam9n12: switch to parent_hw and parent_data
>   clk: at91: at91sam9rl: switch to clk_parent_data
> 
> Ryan Wanner (4):
>   clk: at91: pmc: Move macro to header file
>   clk: at91: sam9x75: switch to parent_hw and parent_data
>   clk: at91: sama7d65: switch to parent_hw and parent_data
>   clk: at91: sam9x7: Clean up formatting

What tree did you develop this against? When I try to apply this series
to Linus's tree (6.17-rc3) and linux-next, only 12 of these patches
actually apply with 'git am'.

Brian
Re: [PATCH v3 00/32] clk: at91: add support for parent_data and
Posted by Ryan Wanner 1 month, 1 week ago
On 8/28/25 08:51, Brian Masney wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Hi Ryan and Claudiu,
> 
> On Thu, Jul 10, 2025 at 01:06:53PM -0700, Ryan.Wanner@microchip.com wrote:
>> From: Ryan Wanner <Ryan.Wanner@microchip.com>
>>
>> This series adds support for parent data and parent _hw on the at91
>> clock drivers. This also updates all the SoC specific clock drivers to
>> use this format as well.
>>
>> This is a continuation of the V1 of this series here [1].
>>
>> This has been tested on the SAMA5* SoCs, the sam9x* SoCs, and the SAMA7*
>> SoCs.
>>
>> Changes v1 -> V2:
>> - Remove all the small sama7g54 SoC driver changes and put them in their
>>   own patch.
>> - Add the SAMA7D65 and the SAM9X75 to this update.
>> - Add a patch to move all common used macros into the pmc.h file.
>> - Update changes from v6.6 to v6.16.
>> - Remove patches that where style fixes and include those in the update.
>>
>> Changes v2 -> v3:
>> - Adjust each patch so they are fully atomic.
>> - Add a patch to have the SAMA7D65 systemclocks use parent_data and
>>   parent_hw.
>> - Add a formatting cleanup patch for the SAM9X75.
>> - Adjust commit messages that no longer show invalid information.
>>
>>
>> 1) https://lore.kernel.org/all/20230727053156.13587-1-claudiu.beznea@tuxon.dev/
>>
>>
>> Claudiu Beznea (28):
>>   clk: at91: pmc: add macros for clk_parent_data
>>   clk: at91: clk-sam9x60-pll: use clk_parent_data
>>   clk: at91: clk-peripheral: switch to clk_parent_data
>>   clk: at91: clk-main: switch to clk parent data
>>   clk: at91: clk-utmi: use clk_parent_data
>>   clk: at91: clk-master: use clk_parent_data
>>   clk: at91: clk-programmable: use clk_parent_data
>>   clk: at91: clk-generated: use clk_parent_data
>>   clk: at91: clk-usb: add support for clk_parent_data
>>   clk: at91: clk-system: use clk_parent_data
>>   clk: at91: clk-pll: add support for parent_hw
>>   clk: at91: clk-audio-pll: add support for parent_hw
>>   clk: at91: clk-plldiv: add support for parent_hw
>>   clk: at91: clk-h32mx: add support for parent_hw
>>   clk: at91: clk-i2s-mux: add support for parent_hw
>>   clk: at91: clk-smd: add support for clk_parent_data
>>   clk: at91: clk-slow: add support for parent_hw
>>   clk: at91: dt-compat: switch to parent_hw and parent_data
>>   clk: at91: sam9x60: switch to parent_hw and parent_data
>>   clk: at91: sama5d2: switch to parent_hw and parent_data
>>   clk: at91: sama5d3: switch to parent_hw and parent_data
>>   clk: at91: sama5d4: switch to parent_hw and parent_data
>>   clk: at91: at91sam9x5: switch to parent_hw and parent_data
>>   clk: at91: at91rm9200: switch to parent_hw and parent_data
>>   clk: at91: at91sam9260: switch to parent_hw and parent_data
>>   clk: at91: at91sam9g45: switch to parent_hw and parent_data
>>   clk: at91: at91sam9n12: switch to parent_hw and parent_data
>>   clk: at91: at91sam9rl: switch to clk_parent_data
>>
>> Ryan Wanner (4):
>>   clk: at91: pmc: Move macro to header file
>>   clk: at91: sam9x75: switch to parent_hw and parent_data
>>   clk: at91: sama7d65: switch to parent_hw and parent_data
>>   clk: at91: sam9x7: Clean up formatting
> 
> What tree did you develop this against? When I try to apply this series
> to Linus's tree (6.17-rc3) and linux-next, only 12 of these patches
> actually apply with 'git am'.

This was developed on 6.16 but when I bumped this thread I checked and
they all apply cleanly on the v6.17-rc3 tag. I also just tested on
next-20250828 tag and this set applies cleanly as well.

Ryan
> 
> Brian
>
Re: [PATCH v3 00/32] clk: at91: add support for parent_data and
Posted by Brian Masney 1 month, 1 week ago
On Thu, Aug 28, 2025 at 09:16:16AM -0700, Ryan Wanner wrote:
> On 8/28/25 08:51, Brian Masney wrote:
> > What tree did you develop this against? When I try to apply this series
> > to Linus's tree (6.17-rc3) and linux-next, only 12 of these patches
> > actually apply with 'git am'.
> 
> This was developed on 6.16 but when I bumped this thread I checked and
> they all apply cleanly on the v6.17-rc3 tag. I also just tested on
> next-20250828 tag and this set applies cleanly as well.

I initially used
'b4 mbox af762c93-c9d0-485e-a0d1-7792e6e37c09@microchip.com' to download
the series, and tried to apply it with 'git am', and that's when only 12
of the 32 patches apply cleanly. I expected to have to 'git am --skip'
on the cover letter.

However, if I download the series with
'b4 am af762c93-c9d0-485e-a0d1-7792e6e37c09@microchip.com', then all of
the patches apply cleanly.

I have a few minor questions on some of the patches.

Brian
Re: [PATCH v3 00/32] clk: at91: add support for parent_data and
Posted by Konstantin Ryabitsev 1 month, 1 week ago
On Thu, Aug 28, 2025 at 12:48:49PM -0400, Brian Masney wrote:
> > This was developed on 6.16 but when I bumped this thread I checked and
> > they all apply cleanly on the v6.17-rc3 tag. I also just tested on
> > next-20250828 tag and this set applies cleanly as well.
> 
> I initially used
> 'b4 mbox af762c93-c9d0-485e-a0d1-7792e6e37c09@microchip.com' to download
> the series, and tried to apply it with 'git am', and that's when only 12
> of the 32 patches apply cleanly. I expected to have to 'git am --skip'
> on the cover letter.

`b4 mbox` downloads the entire thread, including followups, and isn't really
intended to be passed directly to git -- it's more aimed at people who want to
read a whole thread in their preferred email agent.

> However, if I download the series with
> 'b4 am af762c93-c9d0-485e-a0d1-7792e6e37c09@microchip.com', then all of
> the patches apply cleanly.

This is because `b4 am` will make sure they are in the right order, etc. This
is, in fact, the command that is intended for this purpose.

Hope this helps.

-K
Re: [PATCH v3 00/32] clk: at91: add support for parent_data and
Posted by Ryan Wanner 1 month, 1 week ago
On 7/10/25 13:06, Ryan.Wanner@microchip.com wrote:
> From: Ryan Wanner <Ryan.Wanner@microchip.com>
> 
> This series adds support for parent data and parent _hw on the at91
> clock drivers. This also updates all the SoC specific clock drivers to
> use this format as well.
> 
> This is a continuation of the V1 of this series here [1].
> 
> This has been tested on the SAMA5* SoCs, the sam9x* SoCs, and the SAMA7*
> SoCs.
> 
> Changes v1 -> V2:
> - Remove all the small sama7g54 SoC driver changes and put them in their
>   own patch.
> - Add the SAMA7D65 and the SAM9X75 to this update.
> - Add a patch to move all common used macros into the pmc.h file.
> - Update changes from v6.6 to v6.16.
> - Remove patches that where style fixes and include those in the update.
> 
> Changes v2 -> v3:
> - Adjust each patch so they are fully atomic.
> - Add a patch to have the SAMA7D65 systemclocks use parent_data and
>   parent_hw.
> - Add a formatting cleanup patch for the SAM9X75.
> - Adjust commit messages that no longer show invalid information.
> 
> 
> 1) https://lore.kernel.org/all/20230727053156.13587-1-claudiu.beznea@tuxon.dev/
Hello,

Just Bumping this thread.

Ryan
> 
> 
> Claudiu Beznea (28):
>   clk: at91: pmc: add macros for clk_parent_data
>   clk: at91: clk-sam9x60-pll: use clk_parent_data
>   clk: at91: clk-peripheral: switch to clk_parent_data
>   clk: at91: clk-main: switch to clk parent data
>   clk: at91: clk-utmi: use clk_parent_data
>   clk: at91: clk-master: use clk_parent_data
>   clk: at91: clk-programmable: use clk_parent_data
>   clk: at91: clk-generated: use clk_parent_data
>   clk: at91: clk-usb: add support for clk_parent_data
>   clk: at91: clk-system: use clk_parent_data
>   clk: at91: clk-pll: add support for parent_hw
>   clk: at91: clk-audio-pll: add support for parent_hw
>   clk: at91: clk-plldiv: add support for parent_hw
>   clk: at91: clk-h32mx: add support for parent_hw
>   clk: at91: clk-i2s-mux: add support for parent_hw
>   clk: at91: clk-smd: add support for clk_parent_data
>   clk: at91: clk-slow: add support for parent_hw
>   clk: at91: dt-compat: switch to parent_hw and parent_data
>   clk: at91: sam9x60: switch to parent_hw and parent_data
>   clk: at91: sama5d2: switch to parent_hw and parent_data
>   clk: at91: sama5d3: switch to parent_hw and parent_data
>   clk: at91: sama5d4: switch to parent_hw and parent_data
>   clk: at91: at91sam9x5: switch to parent_hw and parent_data
>   clk: at91: at91rm9200: switch to parent_hw and parent_data
>   clk: at91: at91sam9260: switch to parent_hw and parent_data
>   clk: at91: at91sam9g45: switch to parent_hw and parent_data
>   clk: at91: at91sam9n12: switch to parent_hw and parent_data
>   clk: at91: at91sam9rl: switch to clk_parent_data
> 
> Ryan Wanner (4):
>   clk: at91: pmc: Move macro to header file
>   clk: at91: sam9x75: switch to parent_hw and parent_data
>   clk: at91: sama7d65: switch to parent_hw and parent_data
>   clk: at91: sam9x7: Clean up formatting
> 
>  drivers/clk/at91/at91rm9200.c       |  95 ++++----
>  drivers/clk/at91/at91sam9260.c      | 136 ++++++------
>  drivers/clk/at91/at91sam9g45.c      |  89 ++++----
>  drivers/clk/at91/at91sam9n12.c      | 106 ++++-----
>  drivers/clk/at91/at91sam9rl.c       |  63 +++---
>  drivers/clk/at91/at91sam9x5.c       | 125 ++++++-----
>  drivers/clk/at91/clk-audio-pll.c    |  28 ++-
>  drivers/clk/at91/clk-generated.c    |   8 +-
>  drivers/clk/at91/clk-h32mx.c        |  11 +-
>  drivers/clk/at91/clk-i2s-mux.c      |   6 +-
>  drivers/clk/at91/clk-main.c         |  16 +-
>  drivers/clk/at91/clk-master.c       |  24 +-
>  drivers/clk/at91/clk-peripheral.c   |  16 +-
>  drivers/clk/at91/clk-pll.c          |   9 +-
>  drivers/clk/at91/clk-plldiv.c       |  11 +-
>  drivers/clk/at91/clk-programmable.c |   8 +-
>  drivers/clk/at91/clk-sam9x60-pll.c  |  14 +-
>  drivers/clk/at91/clk-slow.c         |   8 +-
>  drivers/clk/at91/clk-smd.c          |  10 +-
>  drivers/clk/at91/clk-system.c       |   8 +-
>  drivers/clk/at91/clk-usb.c          |  41 ++--
>  drivers/clk/at91/clk-utmi.c         |  16 +-
>  drivers/clk/at91/dt-compat.c        |  80 +++++--
>  drivers/clk/at91/pmc.h              |  66 +++---
>  drivers/clk/at91/sam9x60.c          | 117 +++++-----
>  drivers/clk/at91/sam9x7.c           | 328 ++++++++++++++++------------
>  drivers/clk/at91/sama5d2.c          | 168 +++++++-------
>  drivers/clk/at91/sama5d3.c          | 122 ++++++-----
>  drivers/clk/at91/sama5d4.c          | 129 +++++------
>  drivers/clk/at91/sama7d65.c         | 156 ++++++-------
>  drivers/clk/at91/sama7g5.c          | 111 +++++-----
>  31 files changed, 1134 insertions(+), 991 deletions(-)
>