Tha patchset adds spaces around binary operators and also
provides clarity on sequence number wrapping by using a modulo operation
% 4096u, in place of the bitwise AND(&) operation & 0xfff.
The patches are required to be applied in sequence.

Changes in v5:
	- Converted the patch with the subject "Use % 4096 instead of & 0xfff"
	  patch to a patchset.
	- Added a patch to add spaces around binary operator.
Changes in v4:
	- Corrected patch to use '%' instead of '&'.
	- To ensure this change does not affect the functional
	behaviour, I compared the generated object files before and
	after the change using the `cmp` which compares the two
	object files byte by byte as shown below:

	$ make drivers/staging/rtl8723bs/core/rtw_xmit.o
	$ cmp rtw_xmit_before.o rtw_xmit_after.o

	No differences were found in the output, confirming that the
	change does not alter the compiled output.
Changes in v3:
	- Added more description to the commit message.
	- Removed blank line in the tag block.
	- Added more patch recipients.
Changes in v2:
	- Changed the commit message t a more descriptive message which
	makes it clear why the patch does the change.
	- changed the subject title to include `4096u` to show that an
	unsigned module is used.
Changes in v1:
	- Added more patch recipients.

Abraham Samuel Adekunle (2):
  staging: rtl8723bs: Add white spaces around binary operators
  staging: rtl8723bs: Use % 4096u instead of & 0xfff

 drivers/staging/rtl8723bs/core/rtw_xmit.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

-- 
2.34.1

On Tue, Apr 8, 2025 at 12:54 AM Abraham Samuel Adekunle
<abrahamadekunle50@gmail.com> wrote:
>
> Tha patchset adds spaces around binary operators and also
> provides clarity on sequence number wrapping by using a modulo operation
> % 4096u, in place of the bitwise AND(&) operation & 0xfff.
> The patches are required to be applied in sequence.

...

> Changes in v5:

This is v6. Are there any changes in comparison to v5?

>         - Converted the patch with the subject "Use % 4096 instead of & 0xfff"
>           patch to a patchset.
>         - Added a patch to add spaces around binary operator.

-- 
With Best Regards,
Andy Shevchenko

On Tue, Apr 8, 2025 at 8:21 AM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Tue, Apr 8, 2025 at 12:54 AM Abraham Samuel Adekunle
> <abrahamadekunle50@gmail.com> wrote:
> >
> > Tha patchset adds spaces around binary operators and also
> > provides clarity on sequence number wrapping by using a modulo operation
> > % 4096u, in place of the bitwise AND(&) operation & 0xfff.
> > The patches are required to be applied in sequence.
>
> ...
>
> > Changes in v5:
>
> This is v6. Are there any changes in comparison to v5?

I added a cover letter and named it v6 to show it's a continuation
from v5 and to show I added a
new patch for spaces.
I was not sure where would be best to add the change log so I put it
in the cover letter.
But as it concerns the patch for the % operation, there is no change
between v5 and v6

Thanks

Adekunle.

On Tue, Apr 08, 2025 at 10:28:36AM +0100, Samuel Abraham wrote:
> On Tue, Apr 8, 2025 at 8:21 AM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Tue, Apr 8, 2025 at 12:54 AM Abraham Samuel Adekunle
> > <abrahamadekunle50@gmail.com> wrote:

...

> > > Changes in v5:
> >
> > This is v6. Are there any changes in comparison to v5?
> 
> I added a cover letter and named it v6 to show it's a continuation
> from v5 and to show I added a
> new patch for spaces.
> I was not sure where would be best to add the change log so I put it
> in the cover letter.
> But as it concerns the patch for the % operation, there is no change
> between v5 and v6

Then it should have

Changes in v6:
- none

which then questions the purpose of v6 :-)

-- 
With Best Regards,
Andy Shevchenko

On Tue, Apr 8, 2025 at 10:46 AM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Tue, Apr 08, 2025 at 10:28:36AM +0100, Samuel Abraham wrote:
> > On Tue, Apr 8, 2025 at 8:21 AM Andy Shevchenko
> > <andy.shevchenko@gmail.com> wrote:
> > > On Tue, Apr 8, 2025 at 12:54 AM Abraham Samuel Adekunle
> > > <abrahamadekunle50@gmail.com> wrote:
>
> ...
>
> > > > Changes in v5:
> > >
> > > This is v6. Are there any changes in comparison to v5?
> >
> > I added a cover letter and named it v6 to show it's a continuation
> > from v5 and to show I added a
> > new patch for spaces.
> > I was not sure where would be best to add the change log so I put it
> > in the cover letter.
> > But as it concerns the patch for the % operation, there is no change
> > between v5 and v6
>
> Then it should have
>
> Changes in v6:
> - none
>
> which then questions the purpose of v6 :-)
>
Okay, what should I version the next patchset I will be sending as, and also
how about the change log. Do I write it in the individual patches
rather than the cover letter?

I am a bit confused with that please kindly clarify.
Thanks
Adekunle