From nobody Wed Dec 17 21:42:30 2025 Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12460221721 for ; Mon, 7 Apr 2025 21:54:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744062845; cv=none; b=DTj7Yq0xrcV9bm2cg/AZ9zTCOesFndmTFssNO8VwXQ/KGgFK2dG5I5MEUL4fUBvO+atYrn/aLUx+W0Gu8aXbzG0FyJTJhx5pOJtAsqD2YInEvrNxGBAsREBJEXE5HdTKTxU7AdCfjaSigE+6y2Y471FKsNyOvbujEWTqvtRxQdY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744062845; c=relaxed/simple; bh=CxAlPAdfHF9SCdrgxSt6LTMGsRjEdqf+DPORV3qKOIs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=LwbO8whrQ6mXr9im0cYy6wUkXUA2R+qdYFba45r471X0qD+Qih/ukac5jHFgZPRY6w0XAIioCr2sI55R/GAsB2QDcH5WBuPSmkKxaTepfwZmIp3Mm/3pVrDMFN9D1OX/ZXKMDdL+uHKjFjV//Qfzo6NnTJZ0xWd7KyHzfaRZpn8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=G872PjGg; arc=none smtp.client-ip=209.85.160.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G872PjGg" Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-47686580529so51872201cf.2 for ; Mon, 07 Apr 2025 14:54:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744062843; x=1744667643; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=niPceQCTeHJ7vtDpns+YHZrKH87gdGexFeeW8Ejww9Q=; b=G872PjGgFsUdUMJNb/zbSMb5A33exJmCdNy9UHjNx0T2/R24lBRJfq8gvatCiF8eNd C17lySGmQcE155yA0Epq7xHWmnVjMVmRGQlfh1XneOxqXfvETXOQKYfJ7kt5NhDouo0B 3cbeO/X5zDcjF8YafHJx6kPk2KauNHZb3sJ7YiNXdShCLQGLB6uMvQsBrCXzZ+fOZlQk t0xdtsrostrk+gcj+iNon/IZIwpa36Eutv/fDbludUvo1FjJhEmhCIzf496xi2m7mExI 5re7dsqXdpDaxE1u5LhKhPu6pztMCkNPHwCIeRMUwYGLDnVwBouC1WPh6NwkTmW/s8sS 6gbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744062843; x=1744667643; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=niPceQCTeHJ7vtDpns+YHZrKH87gdGexFeeW8Ejww9Q=; b=pwUpBmCZYfTJGQl9KsrM7+3I4aa37llVfhntRI4HdsgPlDZtKvTN5YlEIA+sM9uQug N8CUAb5Iy4qCLE/qawGVe+Ty2D1K4WndMgLUNbT/hJdKOOvwE9mgb5kSDXLLoHguGuRn 0H7aPHaNO8iG8xyVLVGXl3kWmD4Xvwnc/WgArmIKpX8f+w5vpIZcHRLnWLv+G6JBJEW2 k2QwpeCXr0DeNlY+QAGz2ENGL5oV9VybsYzfFA7Dr3HO7vzbE0mwkJiRrRHj3oCj1S18 TUFCU8COl0Ks3xBrHuGADE4cTm5UQIXbRg03pe8PU8ZVbdjH5cK+4a+gi7OAH2nOtAsT x/ng== X-Forwarded-Encrypted: i=1; AJvYcCVjM0x3V2PDFihd9JoYImch/T6IIYD64EMeJ4BQeMBsvXG73XmbWoHnONwpF37d2H8vZQwLLlZMSR98t7I=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0tQvn6ax0GpO+BziWTyfxNZhuJ8bOqLUGaepPr8Klpb0xOU5u O0M87nIzonS1RyxT3YjIiSceUC/u1LGB1Ga2AQe2qAaspGbLfoio X-Gm-Gg: ASbGncvLOor0Stl+XzmM3cRoL4dozIaF2ZWRoe53HSr2+WbPjZVbSSq4e6DDKk4MNys ZSU/DQDLHiPMa22MAb9RVioX8bAhDbdJpbPUaOioJx/r6ytDve7yYiF0WHQQ7hdzqWZCvTci/v0 bwVr+CFR7KTttWzZvjmQi0l+919jXrdWqR0xkjOw+ScbSaOJlL4tXm1CoVGnd8AyePTk/sgYlbO yZ0GpmQsC7RkXWIlKqwlnotvTghjrbaZhv044zJAebWnwvCWLwfSAUJENdK8GBV9awA7T7U1JIM kyHgqWQBJgzqZKVK50Pt8JZgISx7biqqQ7tTRqc1IAF4UKuBR+B2gWbtZrn9 X-Google-Smtp-Source: AGHT+IEuC+ZszV61UGBGwxDndYGW/DtNDNbYQiTlO6xLG1075WS4o+qrZdIPFvWNlxEsXkm+ImPymg== X-Received: by 2002:ac8:7d95:0:b0:476:ae71:eabe with SMTP id d75a77b69052e-47925a777c8mr255279851cf.50.1744062842955; Mon, 07 Apr 2025 14:54:02 -0700 (PDT) Received: from ubuntu ([105.112.230.142]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4791b07226fsm65766491cf.31.2025.04.07.14.54.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 14:54:02 -0700 (PDT) From: Abraham Samuel Adekunle To: outreachy@lists.linux.dev, gregkh@linuxfoundation.org, julia.lawall@inria.fr Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, david.laight.linux@gmail.com, andy@kernel.org, dan.carpenter@linaro.org, Abraham Samuel Adekunle Subject: [PATCH v6 1/2] staging: rtl8723bs: Add white spaces around binary operators Date: Mon, 7 Apr 2025 21:53:51 +0000 Message-Id: <4ccdbfd3e8d74d99679927f294f71cfb694fcc6c.1744061673.git.abrahamadekunle50@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The code contains no spaces around binary operators making it hard to read. This also doesn't adhere to Linux kernel coding style. Add white spaces around the binary operators to increase readability and endure adherence to Linux kernel coding styles. Signed-off-by: Abraham Samuel Adekunle --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index 297c93d65315..c41de6fd897b 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -963,11 +963,11 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hd= r, struct pkt_attrib *pattr if (SN_LESS(pattrib->seqnum, tx_seq)) { pattrib->ampdu_en =3D false;/* AGG BK */ } else if (SN_EQUAL(pattrib->seqnum, tx_seq)) { - psta->BA_starting_seqctrl[pattrib->priority & 0x0f] =3D (tx_seq+1)&0= xfff; + psta->BA_starting_seqctrl[pattrib->priority & 0x0f] =3D (tx_seq + 1)= & 0xfff; =20 pattrib->ampdu_en =3D true;/* AGG EN */ } else { - psta->BA_starting_seqctrl[pattrib->priority & 0x0f] =3D (pattrib->se= qnum+1)&0xfff; + psta->BA_starting_seqctrl[pattrib->priority & 0x0f] =3D (pattrib->se= qnum + 1) & 0xfff; pattrib->ampdu_en =3D true;/* AGG EN */ } } --=20 2.34.1 From nobody Wed Dec 17 21:42:30 2025 Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 354E52248A1 for ; Mon, 7 Apr 2025 21:54:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744062849; cv=none; b=uFi8eWGpmzgI59+qTL0LypOnphIDfmn2qD6oSxI+u8EiCi9VPVnx2tYRVxcI//pDi4cGcvxOCN5iN0kOsrPO2z/F+tfN9CJSoXmXCggwcGhPrj7HbU6kU+STMC90d/kfQv9R/cxz+N5QpclZ2vfZSFSV0H+XvmwrGNCywe1k1/w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744062849; c=relaxed/simple; bh=CuJKw85sIB3jPSdbWSjXk7Qh+Qwq6YcyZNhPTQyMLLM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=FLF3mKVk6DuQiw9eNCfrsM8bPKOpsXhuoZynGgf9mjB3VRqOCPlp7UhEKIudcahBbthswVLPipsxwnjcI1kkUnfzwenJuz07Vv0MHwM9TSA0SZaFHbv1a2GrXwvn5uv8zE9fJm3kDhBknKyuvBD8ENLbI8ZVZOgflF9iojgvm8g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CJnu2L6j; arc=none smtp.client-ip=209.85.160.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CJnu2L6j" Received: by mail-qt1-f174.google.com with SMTP id d75a77b69052e-476964b2c1dso82783011cf.3 for ; Mon, 07 Apr 2025 14:54:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744062847; x=1744667647; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Y6ANoDKw55NxNKPjSEdHj3uuN+vlytdVKuNoT+dKd5I=; b=CJnu2L6jXiUvzCH4N+EdCKY/21kg5xc4/iezzM4KvoHOk3TKN8ntU0ti0V04Kk7DT3 gqBqwmChEkVa+KYRvs26r4jPjrnRu6Neav72+OENG9bgrccLzF382EgEgufxQ7nKqwgZ MuEWXYTwfAG+Vi4ESAzf/auhoYAW/Rqc0DHkJlGRv2Z6fJvwlXZUjK3fS862nzCrj0uq BkwIqnY7OtT32aH7YTZ+lEBnTDdAzQU6rVNziremHF1xH/A4Vdi+Qyf3CkmBEDYldvak 2tczqVxfokjw+yIthzpDenotzkSxDni1osZAOipjbcKD2ciLL/YRQv28b6Bq7eATZBlo 3qNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744062847; x=1744667647; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y6ANoDKw55NxNKPjSEdHj3uuN+vlytdVKuNoT+dKd5I=; b=EpddBfJpYIFGiLaYAi6FAJfBQLA0X62BvLr/CfxszsDXT+eqS3AQNF8bAIimP0D4Ha fYTHZV/xhcrIR1HeEtw3UQhOt60Aq0cvt/YV7uwMb5yAmuJFwaqKlBGeiyJ6nZ796xC5 mwave+bJ/4DlyZ5NZ9YE3T0klj65X3osVR3+oCwPvYKuMMGjz1UkOHIjevzDkMh2+xQ0 YZRceq4qv81CofooHi49dmeAQ6mk6EPOZdfdCDrp8e3r7MrDD+Y8xFAlRXwZn4WBRk5H ho+38f6weS9+z9OTTpUs5VqA9GUzXEX6mvGxLr1PsUqopGhoWPSil31XicKv3zvxgshf Z8BQ== X-Forwarded-Encrypted: i=1; AJvYcCXl2JFmQx1PGA5N6yXRXI2+OKRu90PBkZzNOkAB6KZ4uXMURVQlNpiKQojYgSiejLXFvMVpiawVI6OoYus=@vger.kernel.org X-Gm-Message-State: AOJu0YxLf2ip+7oGzx05vFrzFFMLDxbOHNS7MyRErJhA6EexNjfzIabe 5o6yGxjXU6nz/y8I9INw69EIedbDy3RKNspqKCV2oyhLFNiLM1C4 X-Gm-Gg: ASbGncsVEN6Lhj0HFIDbnXBNxWlCBx/1n/xC8AfcdkhHPYaDKYmB/2L61r1HZ68PiNb HSfe8ps4UMH1ElnuR682ViQQD6I17YMsCnx/j7G1uYdy579wY9OpHSONwq4HR6y3yM8YKPYF6+4 /Dr0Baf7AGX83GVEvBpWZyhRpVyYBfHOuJWyMhH345kC6Tksmzk7IhnZ6ZA1vL/SimliAAS2/jt vE0Q4lQ61lMGnH54Yx3d+wWPABzmdLpLowEE6avmuOgc+Ujz4tIldzMeJ2ZeQ636ZsHnkYwvxhq Da0L2mnn6lLeKILOcS7ULCnWIYFffJuvN1rbOs8nxcb4221ZEw== X-Google-Smtp-Source: AGHT+IE7nyMXX+Xy8qvkiPVmR1l3wABcE2UMSA+MmU+jMLfuz9D+8aIpGyTv5KwqVT0MdKmwqr6lDQ== X-Received: by 2002:a05:622a:120d:b0:477:5c21:2e1e with SMTP id d75a77b69052e-479249040b7mr237768121cf.5.1744062847071; Mon, 07 Apr 2025 14:54:07 -0700 (PDT) Received: from ubuntu ([105.112.230.142]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4791b088346sm67375671cf.41.2025.04.07.14.54.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 14:54:06 -0700 (PDT) From: Abraham Samuel Adekunle To: outreachy@lists.linux.dev, gregkh@linuxfoundation.org, julia.lawall@inria.fr Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, david.laight.linux@gmail.com, andy@kernel.org, dan.carpenter@linaro.org, Abraham Samuel Adekunle Subject: [PATCH v6 2/2] staging: rtl8723bs: Use % 4096u instead of & 0xfff Date: Mon, 7 Apr 2025 21:53:52 +0000 Message-Id: <27ff98a2d721a19cb09ea5c0d39c7d1616f8a629.1744061673.git.abrahamadekunle50@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The sequence number is constrained to a range of [0, 4095], which is a total of 4096 values. The bitmask operation using `& 0xfff` is used to perform this wrap-around. While this is functionally correct, it obscures the intended semantic of a 4096-based wrap. Using a modulo operation `% 4096u` makes the wrap-around logic explicit and easier to understand. It clearly signals that the sequence number cycles through a range of 4096 values. It also makes the code robust against potential changes of the 4096 upper limit, especially when it becomes a non power of 2 value while the AND(&) works solely for power of 2 values. The use of `% 4096u` also guarantees that the modulo operation is performed with unsigned arithmetic, preventing potential issues with the signed types. Suggested-by: Andy Shevchenko Suggested-by: David Laight Signed-off-by: Abraham Samuel Adekunle --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index c41de6fd897b..5cfb6d1e9dae 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -943,7 +943,7 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr,= struct pkt_attrib *pattr =20 if (psta) { psta->sta_xmitpriv.txseq_tid[pattrib->priority]++; - psta->sta_xmitpriv.txseq_tid[pattrib->priority] &=3D 0xFFF; + psta->sta_xmitpriv.txseq_tid[pattrib->priority] %=3D 4096u; pattrib->seqnum =3D psta->sta_xmitpriv.txseq_tid[pattrib->priority]; =20 SetSeqNum(hdr, pattrib->seqnum); @@ -963,11 +963,11 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hd= r, struct pkt_attrib *pattr if (SN_LESS(pattrib->seqnum, tx_seq)) { pattrib->ampdu_en =3D false;/* AGG BK */ } else if (SN_EQUAL(pattrib->seqnum, tx_seq)) { - psta->BA_starting_seqctrl[pattrib->priority & 0x0f] =3D (tx_seq + 1)= & 0xfff; + psta->BA_starting_seqctrl[pattrib->priority & 0x0f] =3D (tx_seq + 1)= % 4096u; =20 pattrib->ampdu_en =3D true;/* AGG EN */ } else { - psta->BA_starting_seqctrl[pattrib->priority & 0x0f] =3D (pattrib->se= qnum + 1) & 0xfff; + psta->BA_starting_seqctrl[pattrib->priority & 0x0f] =3D (pattrib->se= qnum + 1) % 4096u; pattrib->ampdu_en =3D true;/* AGG EN */ } } --=20 2.34.1