From: Parker Newman <pnewman@connecttech.com>

Hello,
These patches add proper support for most of Connect Tech's (CTI) Exar
based serial cards. Previously, only a subset of CTI's cards would work
with the Exar driver while the rest required the CTI out-of-tree driver.
These patches are intended to phase out the out-of-tree driver.

I am new to the mailing lists and contributing to the kernel so please
let me know if I have made any mistakes or if you have any feedback.

Changes in v2:
- Put missing PCI IDs in 8250_exar.c instead of pci_ids.h
- Split large patch into smaller ones

Changes in v3:
- Refactored patches to be easier to follow (based on feedback of v2)
- Patch specific changes listed in corresponding patch

Thank you,

Parker Newman (8):
  serial: exar: adding missing CTI and Exar PCI ids
  serial: exar: remove old Connect Tech setup
  serial: exar: added a exar_get_nr_ports function
  serial: exar: add optional board_init function
  serial: exar: moved generic_rs485 further up in 8250_exar.c
  serial: exar: add CTI cards to exar_get_nr_ports
  serial: exar: add CTI specific setup code
  serial: exar: fix: fix crash during shutdown if setup fails

 drivers/tty/serial/8250/8250_exar.c | 1079 +++++++++++++++++++++++++--
 1 file changed, 1013 insertions(+), 66 deletions(-)


base-commit: fec50db7033ea478773b159e0e2efb135270e3b7
--
2.43.2

On Tue, Apr 16, 2024 at 08:55:27AM -0400, Parker Newman wrote:
> From: Parker Newman <pnewman@connecttech.com>
> 
> Hello,
> These patches add proper support for most of Connect Tech's (CTI) Exar
> based serial cards. Previously, only a subset of CTI's cards would work
> with the Exar driver while the rest required the CTI out-of-tree driver.
> These patches are intended to phase out the out-of-tree driver.
> 
> I am new to the mailing lists and contributing to the kernel so please
> let me know if I have made any mistakes or if you have any feedback.

Much better.  I took the 1st patch already in my tree to make it
hopefully easire for you to rebase and redo the rest.

thanks,

greg k-h

On Wed, 17 Apr 2024 13:24:49 +0200
Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:

> On Tue, Apr 16, 2024 at 08:55:27AM -0400, Parker Newman wrote:
> > From: Parker Newman <pnewman@connecttech.com>
> >
> > Hello,
> > These patches add proper support for most of Connect Tech's (CTI) Exar
> > based serial cards. Previously, only a subset of CTI's cards would work
> > with the Exar driver while the rest required the CTI out-of-tree driver.
> > These patches are intended to phase out the out-of-tree driver.
> >
> > I am new to the mailing lists and contributing to the kernel so please
> > let me know if I have made any mistakes or if you have any feedback.
>
> Much better.  I took the 1st patch already in my tree to make it
> hopefully easire for you to rebase and redo the rest.
>
> thanks,
>
> greg k-h

I will resend with the updates.
I have been using the "main" branch of gregkh/tty.git so far. Is that correct?
Or should I be using "tty-testing"?

Thanks again for bearing with me while I figure this out :).
Parker

On Wed, Apr 17, 2024 at 09:26:41AM -0400, Parker Newman wrote:
> On Wed, 17 Apr 2024 13:24:49 +0200
> Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> 
> > On Tue, Apr 16, 2024 at 08:55:27AM -0400, Parker Newman wrote:
> > > From: Parker Newman <pnewman@connecttech.com>
> > >
> > > Hello,
> > > These patches add proper support for most of Connect Tech's (CTI) Exar
> > > based serial cards. Previously, only a subset of CTI's cards would work
> > > with the Exar driver while the rest required the CTI out-of-tree driver.
> > > These patches are intended to phase out the out-of-tree driver.
> > >
> > > I am new to the mailing lists and contributing to the kernel so please
> > > let me know if I have made any mistakes or if you have any feedback.
> >
> > Much better.  I took the 1st patch already in my tree to make it
> > hopefully easire for you to rebase and redo the rest.
> >
> > thanks,
> >
> > greg k-h
> 
> I will resend with the updates.
> I have been using the "main" branch of gregkh/tty.git so far. Is that correct?
> Or should I be using "tty-testing"?

tty-testing is where things go before they are considered "good enough"
to get into "tty-next" which is never rebased, and is what will be sent
to Linus for the "next" kernel release (not this one.)

Sometimes it is rebased if I mess things up, but usually it's pretty
stable.  Patches only sit in there for 24 hours usually before ending up
in "tty-next"

"main" just tracks Linus's branch, don't use it, I just need a branch to
diff against.

"tty-linus" is what will be sent to Linus for "this" release (i.e. bug
fixes only.)

Or you can just work off of the linux-next tree, which merges in both of
my tty-next and tty-linus branches together (and all other maintainer
trees/branches), every day, and is usually a good base for what will be
the "next" release after this one.

hope this helps,

greg k-h