Hello,

this series converts the two platform drivers below drivers/uio that
make use of .remove() to use .remove_new() instead.

See commit 5c5a7680e67b ("platform: Provide a remove callback that
returns no value") for an extended explanation and the eventual goal.
The TL;DR; is to make it harder for driver authors to leak resources
without noticing. The drivers here get it right though and so can be
converted trivially.

This is merge window material. The two patches are independent of each
other so they can be applied individually if necessary. But I assume
and suggest that Greg will pick them up together.

Best regards
Uwe

Uwe Kleine-König (2):
  uio: fsl_elbc_gpcm: Convert to platform remove callback returning void
  uio: pruss: Convert to platform remove callback returning void

 drivers/uio/uio_fsl_elbc_gpcm.c | 6 ++----
 drivers/uio/uio_pruss.c         | 5 ++---
 2 files changed, 4 insertions(+), 7 deletions(-)


base-commit: 8ffc8b1bbd505e27e2c8439d326b6059c906c9dd
-- 
2.43.0

Hello,

On Fri, Mar 08, 2024 at 10:31:00PM +0100, Uwe Kleine-König wrote:
> this series converts the two platform drivers below drivers/uio that
> make use of .remove() to use .remove_new() instead.
> 
> See commit 5c5a7680e67b ("platform: Provide a remove callback that
> returns no value") for an extended explanation and the eventual goal.
> The TL;DR; is to make it harder for driver authors to leak resources
> without noticing. The drivers here get it right though and so can be
> converted trivially.
> 
> This is merge window material. The two patches are independent of each
> other so they can be applied individually if necessary. But I assume
> and suggest that Greg will pick them up together.
> 
> [..]
> 
> Uwe Kleine-König (2):
>   uio: fsl_elbc_gpcm: Convert to platform remove callback returning void
>   uio: pruss: Convert to platform remove callback returning void

The commit 1019fa4839c9 ("uio: pruss: Remove this driver") (currently in
next) makes the pruss patch obsolete. The fsl_elbc_gpcm patch was
applied.

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

On Mon, Apr 15, 2024 at 09:19:00AM +0200, Uwe Kleine-König wrote:
> Hello,
> 
> On Fri, Mar 08, 2024 at 10:31:00PM +0100, Uwe Kleine-König wrote:
> > this series converts the two platform drivers below drivers/uio that
> > make use of .remove() to use .remove_new() instead.
> > 
> > See commit 5c5a7680e67b ("platform: Provide a remove callback that
> > returns no value") for an extended explanation and the eventual goal.
> > The TL;DR; is to make it harder for driver authors to leak resources
> > without noticing. The drivers here get it right though and so can be
> > converted trivially.
> > 
> > This is merge window material. The two patches are independent of each
> > other so they can be applied individually if necessary. But I assume
> > and suggest that Greg will pick them up together.
> > 
> > [..]
> > 
> > Uwe Kleine-König (2):
> >   uio: fsl_elbc_gpcm: Convert to platform remove callback returning void
> >   uio: pruss: Convert to platform remove callback returning void
> 
> The commit 1019fa4839c9 ("uio: pruss: Remove this driver") (currently in
> next) makes the pruss patch obsolete. The fsl_elbc_gpcm patch was
> applied.

Yes, that's why I only applied one, sorry if I didn't let you know.

greg k-h

Hello Greg,

On Mon, Apr 15, 2024 at 09:31:35AM +0200, Greg Kroah-Hartman wrote:
> On Mon, Apr 15, 2024 at 09:19:00AM +0200, Uwe Kleine-König wrote:
> > > Uwe Kleine-König (2):
> > >   uio: fsl_elbc_gpcm: Convert to platform remove callback returning void
> > >   uio: pruss: Convert to platform remove callback returning void
> > 
> > The commit 1019fa4839c9 ("uio: pruss: Remove this driver") (currently in
> > next) makes the pruss patch obsolete. The fsl_elbc_gpcm patch was
> > applied.
> 
> Yes, that's why I only applied one, sorry if I didn't let you know.

Everything's fine on my end. Given I monitor next now with the goal to
change struct platform_driver::remove after the upcoming merge window, I
noticed myself. My message was only informational, no blame intended.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |