From nobody Sun Feb 8 06:04:48 2026 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBB4E6025A for ; Fri, 8 Mar 2024 21:31:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709933474; cv=none; b=h1avMjGRqhO3OVb5E1jZHW+KPwcZAUNs8A+h1QC+5A+IyG2g7Y2o0RR9dI9tfcZHF5vrjiDCDhmVAg2XZKzrrxeCGl0P1WOlNcfI+SKlE4i7H3bMD5pTCJe/vK/yynXyzRY2MfCZCu4rG7+VWa0d8IcbEiipdq8E7jA+N7Mtx8Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709933474; c=relaxed/simple; bh=TaaqNOWSJkXy0F7IVf1n1RlIVD1t1MB7sGe+8dh1j5c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=FuTvfzjHco+w9pAq/MUjBV1qUj84KsB38MaoTM6i4v9TR1oJocWuG1rbZU74GMpZe+ThdS+84bmiKc8oXK3GX5cEOaahBi4tdVW5Da+R8NYC3ENIAqrY50fMV4S5WzCoR5u/ifjqNKIvKEyuubugCkISCaLZjbAeatwa0xXKysw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1riho6-0004g3-2Y; Fri, 08 Mar 2024 22:31:10 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1riho5-005D0L-JU; Fri, 08 Mar 2024 22:31:09 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1riho5-002WXI-1h; Fri, 08 Mar 2024 22:31:09 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 1/2] uio: fsl_elbc_gpcm: Convert to platform remove callback returning void Date: Fri, 8 Mar 2024 22:31:01 +0100 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1968; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=TaaqNOWSJkXy0F7IVf1n1RlIVD1t1MB7sGe+8dh1j5c=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBl64OX5hGi8U+O8ERDHKk5tBdjHmB1RtxmODPI3 c5O+zpssPWJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZeuDlwAKCRCPgPtYfRL+ ThvXB/4kRwJH5O6Hz7qioa4qf5+hLEFdR42Y0OXbKcCcA0oxiZuFrnnmzbDI4GnwE9OBSaaRSqW 8/U2QXE8Oh26byjqShSXRO8z4nnKbnzm1l6mJJCdx7ubY6k4jA0weNZphR8RmD9oRZJnqGM+LW+ sq/k1bbH/vUR+jHdk9PAvMHg7xc2JBIRR2Ws58dFwt8Ih/Hxb6uuwxWoJ3+izRGIyd5fndfAMPz pR54KNAf4f1ArVnXsLnDMQfLuYFgMOcu/V4dcsFvitYS7RCtZynT1u44rVzj4k587YJDohC4kay detX9m1Ho5bv7ATQvfQJiWgtsDC6CJNDB4KODn9kz4rUf1Hy X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/uio/uio_fsl_elbc_gpcm.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/uio/uio_fsl_elbc_gpcm.c b/drivers/uio/uio_fsl_elbc_gpc= m.c index 82dda799f327..496caff66e7e 100644 --- a/drivers/uio/uio_fsl_elbc_gpcm.c +++ b/drivers/uio/uio_fsl_elbc_gpcm.c @@ -427,7 +427,7 @@ static int uio_fsl_elbc_gpcm_probe(struct platform_devi= ce *pdev) return ret; } =20 -static int uio_fsl_elbc_gpcm_remove(struct platform_device *pdev) +static void uio_fsl_elbc_gpcm_remove(struct platform_device *pdev) { struct uio_info *info =3D platform_get_drvdata(pdev); struct fsl_elbc_gpcm *priv =3D info->priv; @@ -438,8 +438,6 @@ static int uio_fsl_elbc_gpcm_remove(struct platform_dev= ice *pdev) priv->shutdown(info, false); iounmap(info->mem[0].internal_addr); =20 - return 0; - } =20 static const struct of_device_id uio_fsl_elbc_gpcm_match[] =3D { @@ -455,7 +453,7 @@ static struct platform_driver uio_fsl_elbc_gpcm_driver = =3D { .dev_groups =3D uio_fsl_elbc_gpcm_groups, }, .probe =3D uio_fsl_elbc_gpcm_probe, - .remove =3D uio_fsl_elbc_gpcm_remove, + .remove_new =3D uio_fsl_elbc_gpcm_remove, }; module_platform_driver(uio_fsl_elbc_gpcm_driver); =20 --=20 2.43.0 From nobody Sun Feb 8 06:04:48 2026 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBB175FB8F for ; Fri, 8 Mar 2024 21:31:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709933475; cv=none; b=vEj8gYR2opEIOUYoHNjcjr1sk2GcrFiBHUctg/gIOEexyZdWrvNZU16Fk84s1kUSAZ7HnfKv71uOlI4YDdUjuJiVb5R/iBvRQ9GRxX/vwSH//bv6Y+3mK/IjOtd2L9gPU8RjHVdkU9muHd3uhQKurR8eD5v3adO3xFZH+BM6gC8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709933475; c=relaxed/simple; bh=e4QWWPA5Cs+kCP0dOK0A8iAqYDs/2ITiIBiXdA0C+tY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=jZIcDNEiS8GnxtMu2qgXfUalYNJqVw+WBbIGFV3ipzVVCqG4BSfUUAALMr++jIC/u61feeeL+bv7XZDegejwUx9cIrEvk0GZIFtMl233kqTP8PDHe7DHBJslh4a4yJBoH9kZl3vFjfzVslvyMad1UxqlK9TK/YNF38ZhbgHeXrY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1riho6-0004iK-6x; Fri, 08 Mar 2024 22:31:10 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1riho5-005D0O-PQ; Fri, 08 Mar 2024 22:31:09 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1riho5-002WXM-2H; Fri, 08 Mar 2024 22:31:09 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 2/2] uio: pruss: Convert to platform remove callback returning void Date: Fri, 8 Mar 2024 22:31:02 +0100 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1531; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=e4QWWPA5Cs+kCP0dOK0A8iAqYDs/2ITiIBiXdA0C+tY=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBl64OY/Mhq2wkRNkJmOkndodCTyVS0sWAaKJ5sh kluygqQVVyJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZeuDmAAKCRCPgPtYfRL+ ThfYB/9JdOTSOwytRG7bQS8eB2ewlp/5ERnj+Ys5xSPLKA8Q1u5EJavym3by61+9NLtkirXIM6f p27Y1+DGx3axEo64PXgz2drYdPnvJHTu2g+MvyIHqzKt7LDlxMWu9fO2HjGAfw6ZePlm2S+cFQ5 JzfeL9KBhRh/+dI14tNV4nzNztvG/4mkI9UnIiaHsbjg5LBPZxBJH19m3oJqD3YFXYghXevQlDt j+wFDk3OlCO/bPl8j2h5emRgsAMyGzu0NAnDEfjPUWm7HWzgFTev/wGZbF5ra8+UweFlVLObx0f XXrxxHbae416EvN2ElnrDvuAyhxd4AUFf7kVCQkXe/h8ellF X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/uio/uio_pruss.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/uio/uio_pruss.c b/drivers/uio/uio_pruss.c index 77e2dc404885..fb9f26468ae4 100644 --- a/drivers/uio/uio_pruss.c +++ b/drivers/uio/uio_pruss.c @@ -229,17 +229,16 @@ static int pruss_probe(struct platform_device *pdev) return ret; } =20 -static int pruss_remove(struct platform_device *dev) +static void pruss_remove(struct platform_device *dev) { struct uio_pruss_dev *gdev =3D platform_get_drvdata(dev); =20 pruss_cleanup(&dev->dev, gdev); - return 0; } =20 static struct platform_driver pruss_driver =3D { .probe =3D pruss_probe, - .remove =3D pruss_remove, + .remove_new =3D pruss_remove, .driver =3D { .name =3D DRV_NAME, }, --=20 2.43.0