[v1] staging: rtl8192e: code cleanup patches

[PATCH 0/4] staging: rtl8192e: code cleanup patches

Posted by Khadija Kamran 2 years, 10 months ago

Fix several cleanup issues reported by checkpatch.pl in module
staging/rtl8192e in file rtllib_rx.c

Khadija Kamran (4):
  staging: rtl8192e: remove extra blank lines
  staging: rtl8192e: add blank lines after declarations
  staging: rtl8192e: add spaces around binary operators
  staging: rtl8192e: remove blank lines after '{'

 drivers/staging/rtl8192e/rtllib_rx.c | 73 +++++++++++-----------------
 1 file changed, 29 insertions(+), 44 deletions(-)

-- 
2.34.1

Re: [PATCH 0/4] staging: rtl8192e: code cleanup patches

Posted by Philipp Hortmann 2 years, 10 months ago

On 3/22/23 23:07, Khadija Kamran wrote:
> Fix several cleanup issues reported by checkpatch.pl in module
> staging/rtl8192e in file rtllib_rx.c
> 
> Khadija Kamran (4):
>    staging: rtl8192e: remove extra blank lines
>    staging: rtl8192e: add blank lines after declarations
>    staging: rtl8192e: add spaces around binary operators
>    staging: rtl8192e: remove blank lines after '{'
> 
>   drivers/staging/rtl8192e/rtllib_rx.c | 73 +++++++++++-----------------
>   1 file changed, 29 insertions(+), 44 deletions(-)
> 

Checkpatch:
WARNING: From:/Signed-off-by: email address mismatch: 'From: Khadija 
Kamran <kkamran.bese16seecs@seecs.edu.pk>' != 'Signed-off-by: Khadija 
Kamran <kamrankhadijadj@gmail.com>'

Is this wanted?


Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>

Re: [PATCH 0/4] staging: rtl8192e: code cleanup patches

Posted by Khadija Kamran 2 years, 10 months ago

On Thu, Mar 23, 2023 at 06:56:32AM +0100, Philipp Hortmann wrote:
> On 3/22/23 23:07, Khadija Kamran wrote:
> > Fix several cleanup issues reported by checkpatch.pl in module
> > staging/rtl8192e in file rtllib_rx.c
> > 
> > Khadija Kamran (4):
> >    staging: rtl8192e: remove extra blank lines
> >    staging: rtl8192e: add blank lines after declarations
> >    staging: rtl8192e: add spaces around binary operators
> >    staging: rtl8192e: remove blank lines after '{'
> > 
> >   drivers/staging/rtl8192e/rtllib_rx.c | 73 +++++++++++-----------------
> >   1 file changed, 29 insertions(+), 44 deletions(-)
> > 
> 
> Checkpatch:
> WARNING: From:/Signed-off-by: email address mismatch: 'From: Khadija Kamran
> <kkamran.bese16seecs@seecs.edu.pk>' != 'Signed-off-by: Khadija Kamran
> <kamrankhadijadj@gmail.com>'
> 
> Is this wanted?
>

Hey Philipp,

Sorry about this. 
Let me resend the patch and fix this problem.

Regards,
Khadija 

> 
> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>