From nobody Sun Feb 8 01:30:43 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D7DAC6FD1C for ; Wed, 22 Mar 2023 22:07:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229796AbjCVWHl (ORCPT ); Wed, 22 Mar 2023 18:07:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229756AbjCVWHi (ORCPT ); Wed, 22 Mar 2023 18:07:38 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B567D1A658 for ; Wed, 22 Mar 2023 15:07:36 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id w9so78980382edc.3 for ; Wed, 22 Mar 2023 15:07:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=seecs.edu.pk; s=google; t=1679522855; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2qlJwucxS9YsM3710vjGoZ2YHREnKLXbsqoSCiO7TnI=; b=gPXSR/6CQUuHvcu8ph+2uLp4ghyNKEBCx4AIpOi1WC5Jow3aQc2iTrRDKKmeprIXEz TPlS+FMUFFLfQMoBfW5mwv/5VVJTefVxqTR0rFafvQrdGsGuUXMlBiLQqPES83D+Y7Ux P5NB2/26JpPnrnKd5kMMz8TLx+5GD58EWTt4k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679522855; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2qlJwucxS9YsM3710vjGoZ2YHREnKLXbsqoSCiO7TnI=; b=SYFsnTvSULrA3Y85AmjGba3XjrQ3YULy5YJlOEdITs5q4QXpt+BODioJrXZFc+4f7h YpdFpmvsHYsLU50NSwMHegvfUTmjqKvmLZTHyfYTVh9m5g11Zm6c7BhLYwToAAhuCLwp oloD9yPi2+0kH3Fg2EeqV11cNoEGV6SHW5BB7NgVWXc58tuILQGDQtsvuWVpdr01LbWT bpq6nDDRCIJq3o3qJ2uI7xeVWTscbO9x0Vh0oLzR8tT+iJeOqiDPt6gEUCmBKvKPEcK/ p84vXg+hnVU29v2TG1rJKPs0bZMnKqJJ3421JM6IdECoi8tb46XIIuQBaT4xR7S0fJot uKSw== X-Gm-Message-State: AO0yUKWNQvdlNEd2LKpKUB+OgYjeMCOibTsl4Rbpn++Mw/EmPzef+qoP GOdwTkzNcSatqj/M+wKz/vk0sw== X-Google-Smtp-Source: AK7set/3fSUAw7kZj//xOAYh+vvAqiu6Mzaryf+EugaMQP8MYCEUVcza/jzStA07Q6dx4kwNd2VQlA== X-Received: by 2002:a17:906:5410:b0:931:86cf:9556 with SMTP id q16-20020a170906541000b0093186cf9556mr9343600ejo.23.1679522855286; Wed, 22 Mar 2023 15:07:35 -0700 (PDT) Received: from khadija-virtual-machine.localdomain ([39.41.14.14]) by smtp.gmail.com with ESMTPSA id v19-20020a17090651d300b0092b86d41dbasm7787935ejk.114.2023.03.22.15.07.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Mar 2023 15:07:35 -0700 (PDT) From: Khadija Kamran X-Google-Original-From: Khadija Kamran To: outreachy@lists.linux.dev Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Khadija Kamran Subject: [PATCH 1/4] staging: rtl8192e: remove extra blank lines Date: Thu, 23 Mar 2023 03:07:01 +0500 Message-Id: <43d5864fc42e51089a0a0626278204bac8313eb0.1679521517.git.kamrankhadijadj@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Remove extra blank lines as reported by checkpatch.pl "CHECK: Please don't use multiple blank lines" Signed-off-by: Khadija Kamran Tested-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtllib_rx.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index c394c21beefb..c6114d99829b 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -154,7 +154,6 @@ rtllib_frag_cache_get(struct rtllib_device *ieee, return skb; } =20 - /* Called only as a tasklet (software IRQ) */ static int rtllib_frag_cache_invalidate(struct rtllib_device *ieee, struct rtllib_hdr_4addr *hdr) @@ -318,7 +317,6 @@ rtllib_rx_frame_decrypt(struct rtllib_device *ieee, str= uct sk_buff *skb, return res; } =20 - /* Called only as a tasklet (software IRQ), by rtllib_rx */ static inline int rtllib_rx_frame_decrypt_msdu(struct rtllib_device *ieee, struct sk_buff *s= kb, @@ -355,7 +353,6 @@ rtllib_rx_frame_decrypt_msdu(struct rtllib_device *ieee= , struct sk_buff *skb, return 0; } =20 - /* this function is stolen from ipw2200 driver*/ #define IEEE_PACKET_RETRY_TIME (5*HZ) static int is_duplicate_packet(struct rtllib_device *ieee, @@ -887,7 +884,6 @@ static u8 parse_subframe(struct rtllib_device *ieee, st= ruct sk_buff *skb, return rxb->nr_subframes; } =20 - static size_t rtllib_rx_get_hdrlen(struct rtllib_device *ieee, struct sk_buff *skb, struct rtllib_rx_stats *rx_stats) @@ -1569,7 +1565,6 @@ static int rtllib_verify_qos_info(struct rtllib_qos_i= nformation_element return 0; } =20 - /* Parse a QoS parameter element */ static int rtllib_read_qos_param_element( struct rtllib_qos_parameter_info *element_param, @@ -1599,7 +1594,6 @@ static int rtllib_read_qos_info_element( return rtllib_verify_qos_info(element_info, QOS_OUI_INFO_SUB_TYPE); } =20 - /* Write QoS parameters from the ac parameters. */ static int rtllib_qos_convert_ac_to_parameters(struct rtllib_qos_parameter= _info *param_elm, struct rtllib_qos_data *qos_data) @@ -1843,7 +1837,6 @@ static void rtllib_parse_mife_generic(struct rtllib_d= evice *ieee, } } =20 - if (*tmp_htinfo_len =3D=3D 0) { if (info_element->len >=3D 4 && info_element->data[0] =3D=3D 0x00 && @@ -1932,7 +1925,6 @@ static void rtllib_parse_mife_generic(struct rtllib_d= evice *ieee, info_element->data[2] =3D=3D 0x96) network->cisco_cap_exist =3D true; =20 - if (info_element->len >=3D 3 && info_element->data[0] =3D=3D 0x00 && info_element->data[1] =3D=3D 0x0a && @@ -2142,13 +2134,11 @@ int rtllib_parse_info_param(struct rtllib_device *i= eee, =20 network->dtim_data =3D RTLLIB_DTIM_VALID; =20 - if (info_element->data[2] & 1) network->dtim_data |=3D RTLLIB_DTIM_MBCAST; =20 offset =3D (info_element->data[2] >> 1)*2; =20 - if (ieee->assoc_id < 8*offset || ieee->assoc_id > 8*(offset + info_element->len - 3)) break; @@ -2203,7 +2193,6 @@ int rtllib_parse_info_param(struct rtllib_device *iee= e, &tmp_htcap_len); break; =20 - case MFIE_TYPE_HT_INFO: netdev_dbg(ieee->dev, "MFIE_TYPE_HT_INFO: %d bytes\n", info_element->len); @@ -2392,7 +2381,6 @@ static inline int is_same_network(struct rtllib_netwo= rk *src, (dst->capability & WLAN_CAPABILITY_ESS))); } =20 - static inline void update_network(struct rtllib_device *ieee, struct rtllib_network *dst, struct rtllib_network *src) @@ -2580,7 +2568,6 @@ static inline void rtllib_process_probe_response( goto free_network; } =20 - if (!rtllib_legal_channel(ieee, network->channel)) goto free_network; =20 --=20 2.34.1 From nobody Sun Feb 8 01:30:43 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 538EAC6FD1C for ; Wed, 22 Mar 2023 22:07:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229893AbjCVWHn (ORCPT ); Wed, 22 Mar 2023 18:07:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229806AbjCVWHj (ORCPT ); Wed, 22 Mar 2023 18:07:39 -0400 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7539E1A642 for ; Wed, 22 Mar 2023 15:07:38 -0700 (PDT) Received: by mail-ed1-x52a.google.com with SMTP id r11so78943121edd.5 for ; Wed, 22 Mar 2023 15:07:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=seecs.edu.pk; s=google; t=1679522857; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bNg7iZ+PuRMN0DqLdZrW00PMhOD0f4GRznXTT5Ec9ug=; b=Tu0kJyknJ1v6iH//+q5ZfDMvt0rY1p/4T/YYsEa/38n9mUAQ+R51ip28tUYR6N8OtW ZSV1sDRWvKVVPPGh6n3KkRyhLonpqmarMlDm3mNzO0gM1d5SU1Sevp48Yes1YW1ZlHrv fLgiz9w+NNBQJ5wx7ykUxmSJfRYuhC2raDpUY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679522857; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bNg7iZ+PuRMN0DqLdZrW00PMhOD0f4GRznXTT5Ec9ug=; b=0hyyaqFDTncPj7Hh9RM3H4H+YJBms2WMLmswQis5rXN6UKuSojHUiCHK8XseYLMusK VCc9F9yDEWucNAZuR0vALnXxFaEykOBFtm6Y0mngz6cEGviM9PbEmk1ZcupuuSQH0IjX 9L8a2aCPS+ESx2qRcnROF1fnAQ8I4KDI689W7zhU7TCoa5stByEbU+R5wWkEFluvtBOW jV4nrffGuXHHaei9qhMVqc0VN+MrIgHJ7c0n0yb32L9qPwS3V88eiiZFKkRzdtG2JvNg VlWobBFAAb8r0yFCdEldEQMCUwRxdPD5WkAhM6sih3t0VNM0tbjYuJC2ha8ODC9GZ1Yv /zdQ== X-Gm-Message-State: AO0yUKUYWfCaD4T8iQw2rcvYJrbDDLKk/V6VjnD5Pa/VY/joVcB65vFl yFfEZ6DJbDzrrWEwNFoBSbs8QougOenDo7ZxhQE= X-Google-Smtp-Source: AK7set/Go4nTDvGsSsr8EOi4LAu7QSXAanN9vrFV1yKOh/zWi4mwbDzpIza4iTG9e7p13fUM7x2A8w== X-Received: by 2002:a17:906:9493:b0:870:b950:18d4 with SMTP id t19-20020a170906949300b00870b95018d4mr9240963ejx.5.1679522856995; Wed, 22 Mar 2023 15:07:36 -0700 (PDT) Received: from khadija-virtual-machine.localdomain ([39.41.14.14]) by smtp.gmail.com with ESMTPSA id v19-20020a17090651d300b0092b86d41dbasm7787935ejk.114.2023.03.22.15.07.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Mar 2023 15:07:36 -0700 (PDT) From: Khadija Kamran X-Google-Original-From: Khadija Kamran To: outreachy@lists.linux.dev Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Khadija Kamran Subject: [PATCH 2/4] staging: rtl8192e: add blank lines after declarations Date: Thu, 23 Mar 2023 03:07:02 +0500 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add blank lines after declarations as reported by checkpatch.pl "CHECK: Please use a blank line after function/struct/union/enum declarations" Signed-off-by: Khadija Kamran Tested-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtllib_rx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index c6114d99829b..7144a0630ea6 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -231,10 +231,12 @@ rtllib_rx_frame_mgmt(struct rtllib_device *ieee, stru= ct sk_buff *skb, static unsigned char rfc1042_header[] =3D { 0xaa, 0xaa, 0x03, 0x00, 0x00, 0x00 }; + /* Bridge-Tunnel header (for EtherTypes ETH_P_AARP and ETH_P_IPX) */ static unsigned char bridge_tunnel_header[] =3D { 0xaa, 0xaa, 0x03, 0x00, 0x00, 0xf8 }; + /* No encapsulation header if EtherType < 0x600 (=3Dlength) */ =20 /* Called by rtllib_rx_frame_decrypt */ --=20 2.34.1 From nobody Sun Feb 8 01:30:43 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7775EC6FD1F for ; Wed, 22 Mar 2023 22:07:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229931AbjCVWHr (ORCPT ); Wed, 22 Mar 2023 18:07:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229810AbjCVWHl (ORCPT ); Wed, 22 Mar 2023 18:07:41 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4486A1A4BA for ; Wed, 22 Mar 2023 15:07:40 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id h8so78888953ede.8 for ; Wed, 22 Mar 2023 15:07:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=seecs.edu.pk; s=google; t=1679522859; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=weAoEEZiI2mKD//rUNwkb5TZGAcwsmwF1BER0SC0aPA=; b=IXWt4G2ZA3GukJB/z5rnjE2Wa9BXVCQGEfpPTDAh13aVrCWjr6FuvXKVggBShCxYkN Yntj9unSvSiwAnyCu1Xl+TGTotq2cx0ZwN3Cjk8y+Mgk2NL77R6qAyvSkUE27T9NR1Ef sy20YsS0BcXlyJXKeWjaVcXcVy8220hDcIAEg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679522859; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=weAoEEZiI2mKD//rUNwkb5TZGAcwsmwF1BER0SC0aPA=; b=UlffYmMq2rfF2cgJb+Co/SygZu0CoYxTFSqFR/v73SEnvIG7zqYfBKA6kCNxvhSzOd jqoPSwgqb/aW+3p3M4RQbf22ZC/EOr3SxHJP+goAfM6aiPP4reFeoZgX1mskHO3ndmJn aG9ZE8+atWGYUDRBrvGCXmJUggNeh6bBD1QthWIMd66LLjDZZqRqbLLhChn+WshW4ETv Flu8hN2c+MJFVZgEUE7OEwXfKkl6RXQBPJRuHGUQ7LPcvJsVls+Vsi1B7qhbeXW9gRf8 BH2gJPIf95xpd+2j+ZkdKbm2HKUmOGa+1M8EZMuCxhG8IU7nq8xEvbl9wj8jg0evGdIT Ua5Q== X-Gm-Message-State: AO0yUKVKQ2PGqxkeHF5ra1Pi17P3/J2yiH0FxQkCCx1wo93iu0l2QTT5 7VZYBoFZDbZugHKbFlM8zrmxVruwaPISCIma5IM= X-Google-Smtp-Source: AK7set9mL7YFAbWNwcmS+drZUv7tSXxh/dqipCJRAzWc5sIUbkUEH1mhKIxWJhGALWQSn4Lowox+9A== X-Received: by 2002:a17:907:765a:b0:8b1:7684:dfab with SMTP id kj26-20020a170907765a00b008b17684dfabmr9659463ejc.38.1679522858718; Wed, 22 Mar 2023 15:07:38 -0700 (PDT) Received: from khadija-virtual-machine.localdomain ([39.41.14.14]) by smtp.gmail.com with ESMTPSA id v19-20020a17090651d300b0092b86d41dbasm7787935ejk.114.2023.03.22.15.07.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Mar 2023 15:07:38 -0700 (PDT) From: Khadija Kamran X-Google-Original-From: Khadija Kamran To: outreachy@lists.linux.dev Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Khadija Kamran Subject: [PATCH 3/4] staging: rtl8192e: add spaces around binary operators Date: Thu, 23 Mar 2023 03:07:03 +0500 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Use spaces around binary operators as suggested by Linux kernel coding style. Issues reported by checkpatch.pl for the following binary operators: + , - , * , | , << Signed-off-by: Khadija Kamran Tested-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtllib_rx.c | 54 ++++++++++++++-------------- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index 7144a0630ea6..f627dfe66d90 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -356,7 +356,7 @@ rtllib_rx_frame_decrypt_msdu(struct rtllib_device *ieee= , struct sk_buff *skb, } =20 /* this function is stolen from ipw2200 driver*/ -#define IEEE_PACKET_RETRY_TIME (5*HZ) +#define IEEE_PACKET_RETRY_TIME (5 * HZ) static int is_duplicate_packet(struct rtllib_device *ieee, struct rtllib_hdr_4addr *header) { @@ -936,7 +936,7 @@ static int rtllib_rx_check_duplicate(struct rtllib_devi= ce *ieee, =20 if (GetTs(ieee, (struct ts_common_info **)&pRxTS, hdr->addr2, (u8)Frame_QoSTID((u8 *)(skb->data)), RX_DIR, true)) { - if ((fc & (1<<11)) && (frag =3D=3D pRxTS->rx_last_frag_num) && + if ((fc & (1 << 11)) && (frag =3D=3D pRxTS->rx_last_frag_num) && (WLAN_GET_SEQ_SEQ(sc) =3D=3D pRxTS->rx_last_seq_num)) return -1; pRxTS->rx_last_frag_num =3D frag; @@ -1619,23 +1619,23 @@ static int rtllib_qos_convert_ac_to_parameters(stru= ct rtllib_qos_parameter_info case 1: /* BIT(0) | BIT(3) */ if (acm) - qos_data->wmm_acm |=3D (0x01<<0)|(0x01<<3); + qos_data->wmm_acm |=3D (0x01 << 0) | (0x01 << 3); break; case 2: /* BIT(4) | BIT(5) */ if (acm) - qos_data->wmm_acm |=3D (0x01<<4)|(0x01<<5); + qos_data->wmm_acm |=3D (0x01 << 4) | (0x01 << 5); break; case 3: /* BIT(6) | BIT(7) */ if (acm) - qos_data->wmm_acm |=3D (0x01<<6)|(0x01<<7); + qos_data->wmm_acm |=3D (0x01 << 6) | (0x01 << 7); break; case 0: default: /* BIT(1) | BIT(2) */ if (acm) - qos_data->wmm_acm |=3D (0x01<<1)|(0x01<<2); + qos_data->wmm_acm |=3D (0x01 << 1) | (0x01 << 2); break; } =20 @@ -1979,7 +1979,7 @@ static void rtllib_parse_mife_generic(struct rtllib_d= evice *ieee, info_element->data[3] =3D=3D 0x04) { netdev_dbg(ieee->dev, "MFIE_TYPE_WZC: %d bytes\n", info_element->len); - network->wzc_ie_len =3D min(info_element->len+2, MAX_WZC_IE_LEN); + network->wzc_ie_len =3D min(info_element->len + 2, MAX_WZC_IE_LEN); memcpy(network->wzc_ie, info_element, network->wzc_ie_len); } } @@ -2139,10 +2139,10 @@ int rtllib_parse_info_param(struct rtllib_device *i= eee, if (info_element->data[2] & 1) network->dtim_data |=3D RTLLIB_DTIM_MBCAST; =20 - offset =3D (info_element->data[2] >> 1)*2; + offset =3D (info_element->data[2] >> 1) * 2; =20 - if (ieee->assoc_id < 8*offset || - ieee->assoc_id > 8*(offset + info_element->len - 3)) + if (ieee->assoc_id < 8 * offset || + ieee->assoc_id > 8 * (offset + info_element->len - 3)) break; =20 offset =3D (ieee->assoc_id / 8) - offset; @@ -2357,7 +2357,7 @@ static inline int rtllib_network_init( if (rtllib_is_empty_essid(network->ssid, network->ssid_len)) network->flags |=3D NETWORK_EMPTY_ESSID; stats->signal =3D 30 + (stats->SignalStrength * 70) / 100; - stats->noise =3D rtllib_translate_todbm((u8)(100-stats->signal)) - 25; + stats->noise =3D rtllib_translate_todbm((u8)(100 - stats->signal)) - 25; =20 memcpy(&network->stats, stats, sizeof(network->stats)); =20 @@ -2545,22 +2545,22 @@ static inline void rtllib_process_probe_response( "'%s' ( %pM ): %c%c%c%c %c%c%c%c-%c%c%c%c %c%c%c%c\n", escape_essid(info_element->data, info_element->len), beacon->header.addr3, - (le16_to_cpu(beacon->capability) & (1<<0xf)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0xe)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0xd)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0xc)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0xb)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0xa)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x9)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x8)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x7)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x6)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x5)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x4)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x3)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x2)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x1)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x0)) ? '1' : '0'); + (le16_to_cpu(beacon->capability) & (1 << 0xf)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0xe)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0xd)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0xc)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0xb)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0xa)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x9)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x8)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x7)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x6)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x5)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x4)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x3)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x2)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x1)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x0)) ? '1' : '0'); =20 if (rtllib_network_init(ieee, beacon, network, stats)) { netdev_dbg(ieee->dev, "Dropped '%s' ( %pM) via %s.\n", --=20 2.34.1 From nobody Sun Feb 8 01:30:43 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB8C6C6FD1C for ; Wed, 22 Mar 2023 22:07:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229973AbjCVWHt (ORCPT ); Wed, 22 Mar 2023 18:07:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229806AbjCVWHn (ORCPT ); Wed, 22 Mar 2023 18:07:43 -0400 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC0701A67B for ; Wed, 22 Mar 2023 15:07:41 -0700 (PDT) Received: by mail-ed1-x531.google.com with SMTP id eg48so78808280edb.13 for ; Wed, 22 Mar 2023 15:07:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=seecs.edu.pk; s=google; t=1679522860; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jRIhiCMIYhlzOxpqNUvBzZ/DfwkIA0+Cejq18uIa0y0=; b=Vayg/s7IU/T//J5ygUx8W93dQ1yMAPQ6wpM2Kml2UBPoShghd2Q1Adkx1mGiBLsoFF 8vgEMzcKqQvSI1+sU6tw2/oEXAoFs9eWPhKz4WvITlv3igw6d7xUgfzdeldDQmvJ4bFk 7srUtmt3rCorsT74+qfCVk4YsUtBPPOaWSI90= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679522860; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jRIhiCMIYhlzOxpqNUvBzZ/DfwkIA0+Cejq18uIa0y0=; b=ygMBigkLXXbl6+RlT3zaH2zhrVI4JRLpNmb5Ua0Ufk9Ns08bh+B8hsjCUMui3j/Kwd adl0v+3s7UYUZ5GTgnaCDwaRLzHT9ZP51o56LPjUz0d6beHMpA3bnfu4aGDmsHe5857m xPAAqTsn6r6aRQ1/Lm+NknyhG7eL3gRj3Qv8y+tK2zcW7jCbrlkD1vdvwwDSW/LG59Hj F0xHIG0O4U7BXb+ZZvwuLpoxAhsC+YXxd3gMsRXqIVR35fhLRH2mbLdcFAg+jImdiPy5 Cqawh4Gq0oqBenqF0tMphM8ncuorwD1s23HfJYGo6fsykODEh0xK2Z9ErjvvV91TXD3l JTuw== X-Gm-Message-State: AO0yUKWbi4T7p4QBIvyd0Z2UHAaEBv8OHMiB5e8aJzuh0RUcmURZKWtB O2nDx5d/nfjIb3nQu+N3FY7TPw== X-Google-Smtp-Source: AK7set9u8/YsDflK7FkGY0lgh0NX2peBT8VOq+aLiQWweYgWgxpaMlUnP2iQj3cQuGG4PHMysrb/1Q== X-Received: by 2002:a17:907:b0f:b0:930:e634:3d52 with SMTP id h15-20020a1709070b0f00b00930e6343d52mr8203320ejl.24.1679522860416; Wed, 22 Mar 2023 15:07:40 -0700 (PDT) Received: from khadija-virtual-machine.localdomain ([39.41.14.14]) by smtp.gmail.com with ESMTPSA id v19-20020a17090651d300b0092b86d41dbasm7787935ejk.114.2023.03.22.15.07.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Mar 2023 15:07:40 -0700 (PDT) From: Khadija Kamran X-Google-Original-From: Khadija Kamran To: outreachy@lists.linux.dev Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Khadija Kamran Subject: [PATCH 4/4] staging: rtl8192e: remove blank lines after '{' Date: Thu, 23 Mar 2023 03:07:04 +0500 Message-Id: <303a41480220a6c31cee91d40ece40b3fae3bddf.1679521517.git.kamrankhadijadj@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Remove unnecessary blank lines after an open brace as reported by checkpatch.pl "CHECK: Blank lines aren't necessary after an open brace '{'" Signed-off-by: Khadija Kamran Tested-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtllib_rx.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index f627dfe66d90..b649d02dc5c8 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -1167,7 +1167,6 @@ static int rtllib_rx_decrypt(struct rtllib_device *ie= ee, struct sk_buff *skb, if (crypt && !(fc & RTLLIB_FCTL_WEP) && !ieee->open_wep) { if (/*ieee->ieee802_1x &&*/ rtllib_is_eapol_frame(ieee, skb, hdrlen)) { - /* pass unencrypted EAPOL frames even if encryption is * configured */ @@ -1207,7 +1206,6 @@ static void rtllib_rx_check_leave_lps(struct rtllib_d= evice *ieee, u8 unicast, u8 nr_subframes) { if (unicast) { - if (ieee->state =3D=3D RTLLIB_LINKED) { if (((ieee->link_detect_info.NumRxUnicastOkInPeriod + ieee->link_detect_info.NumTxOkInPeriod) > 8) || @@ -1552,7 +1550,6 @@ static u8 qos_oui[QOS_OUI_LEN] =3D { 0x00, 0x50, 0xF2= }; static int rtllib_verify_qos_info(struct rtllib_qos_information_element *info_element, int sub_type) { - if (info_element->elementID !=3D QOS_ELEMENT_ID) return -1; if (info_element->qui_subtype !=3D sub_type) @@ -2696,7 +2693,6 @@ static void rtllib_rx_mgt(struct rtllib_device *ieee, ieee->last_rx_ps_time =3D jiffies; =20 switch (WLAN_FC_GET_STYPE(le16_to_cpu(header->frame_ctl))) { - case RTLLIB_STYPE_BEACON: netdev_dbg(ieee->dev, "received BEACON (%d)\n", WLAN_FC_GET_STYPE(le16_to_cpu(header->frame_ctl))); --=20 2.34.1