[PATCH 0/3] staging: greybus: Cleanups in loopback_test

Jack Schofield posted 3 patches 2 years, 9 months ago
drivers/staging/greybus/tools/loopback_test.c | 15 +--------------
1 file changed, 1 insertion(+), 14 deletions(-)
[PATCH 0/3] staging: greybus: Cleanups in loopback_test
Posted by Jack Schofield 2 years, 9 months ago
Correct issues found by checkpatch.

Jack Schofield (3):
  staging: greybus: loopback_test: Add blank line after declaration.
  staging: greybus: loopback_test: Remove void function return statement
  staging: greybus: loopback_test: Remove extra blank lines

 drivers/staging/greybus/tools/loopback_test.c | 15 +--------------
 1 file changed, 1 insertion(+), 14 deletions(-)


base-commit: 9dadff066244543780e5d9ee406b3ec7af19e22c
-- 
2.25.1
Re: [PATCH 0/3] staging: greybus: Cleanups in loopback_test
Posted by Johan Hovold 2 years, 9 months ago
On Wed, Nov 30, 2022 at 09:38:49PM -0800, Jack Schofield wrote:
> Correct issues found by checkpatch.
> 
> Jack Schofield (3):
>   staging: greybus: loopback_test: Add blank line after declaration.

Nit: no need for a full stop in the commit summary.

>   staging: greybus: loopback_test: Remove void function return statement
>   staging: greybus: loopback_test: Remove extra blank lines
> 
>  drivers/staging/greybus/tools/loopback_test.c | 15 +--------------
>  1 file changed, 1 insertion(+), 14 deletions(-)

Other than that, all of these look good to me:

Reviewed-by: Johan Hovold <johan@kernel.org>

Johan
Re: [PATCH 0/3] staging: greybus: Cleanups in loopback_test
Posted by Jack Schofield 2 years, 9 months ago
On Thu, Dec 01, 2022 at 08:17:06AM +0100, Johan Hovold wrote:
> On Wed, Nov 30, 2022 at 09:38:49PM -0800, Jack Schofield wrote:
> >   staging: greybus: loopback_test: Add blank line after declaration.
> 
> Nit: no need for a full stop in the commit summary.
> 
> Other than that, all of these look good to me:
> 
> Reviewed-by: Johan Hovold <johan@kernel.org>

Thank you for the review. I've realized I've left off maintainers and
will revise and resend, with correct maintainers and the correction you
suggest.

Jack Schofield