From nobody Thu Sep 18 23:10:59 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5797C43217 for ; Thu, 1 Dec 2022 05:39:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229617AbiLAFi7 (ORCPT ); Thu, 1 Dec 2022 00:38:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229569AbiLAFi5 (ORCPT ); Thu, 1 Dec 2022 00:38:57 -0500 Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7E8B6E57D for ; Wed, 30 Nov 2022 21:38:56 -0800 (PST) Received: by mail-pj1-x102e.google.com with SMTP id 3-20020a17090a098300b00219041dcbe9so905829pjo.3 for ; Wed, 30 Nov 2022 21:38:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oregonstate-edu.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Qzd7T7c88aZQcOpjF7mk1g5wAmp98SNe8kgkrI3AbJ0=; b=CedsK0vqoJwz3a+jhzg3J8h8zWDk2DCZ7uK/Exfjsb2mwChoCqRBmA9xfSyhlU8LBI P5p9gzV3GijCYxamcfjA9HtwH9ydD9QJVwIOOf9iQLHK+6p9kWpnq3CSNXAALX1MUr/u xnlN5q3tQVkjnLb8sVb2pquxr9u1ehlXqTAiii42IQrYezYHThzHWKQDhfsvFNBmWA28 Z6wrzATv5RJeXzI/oZ8CdPm35tO3VYs8wi83Pgn0ueMIpYmg69JtFOWRi7Uj6r3cQwxa LJcNI30UPOx976SMtIXgHuewxr9pufXw/iUV6Rlg6QRSuf/QkDdtPo8+vPFQjAXS/ezo /VXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Qzd7T7c88aZQcOpjF7mk1g5wAmp98SNe8kgkrI3AbJ0=; b=F0On65lJaHoFdyhg92DDeJY2zsM7ezYDuXADaEMXNgCkauTSr5sxzEWWngzjVC5E9H epHeu17XhB4jrONbvYXt5XG0N2yQwSgUgl1Xy+8CZ5PrmEMZj6YHt20/IhT7az5f8UMB FkSpELGvM94/vcRuei5M4THIwhfgnJiTA70d/ttJgkc5lY9d/EeUi3DCWZRUxYcxO/Pf lAPDtyIIVRbmiwFj+dwWAli1RF7N/EccCnNVwdk4qggr0Aj+GqLHKaLKgXQUrQAEt7YJ yA2iBC1Cw4THLyp25A52SElrFCeRShy2Cofo6kuFBqNMuzF/daN7i4WNNHghOx0wrGM5 vHjQ== X-Gm-Message-State: ANoB5pmbNMLBA1nqTVU3fEyTvxWKhrZMAlaG6gujJjeORDDupCz91lY7 sfBPjw7f3Ha58FkrOgXtpC5maXBf+x8UJcJUNDg= X-Google-Smtp-Source: AA0mqf5ve22NoC+ei00xHE87/cE+o70Wl9tMVVuhnNNHbKszB3a5kdKZGtJoN+bGghrhf1a7C/Nb2w== X-Received: by 2002:a17:90a:930f:b0:218:9107:381b with SMTP id p15-20020a17090a930f00b002189107381bmr62438828pjo.75.1669873136401; Wed, 30 Nov 2022 21:38:56 -0800 (PST) Received: from ubu ([76.27.231.73]) by smtp.gmail.com with ESMTPSA id 17-20020a170902e9d100b0018997f6fc88sm2523547plk.34.2022.11.30.21.38.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Nov 2022 21:38:56 -0800 (PST) From: Jack Schofield To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Jack Schofield Subject: [PATCH 1/3] staging: greybus: loopback_test: Add blank line after declaration. Date: Wed, 30 Nov 2022 21:38:50 -0800 Message-Id: <048967b5c3b157e19ccf4608f71da8418fc31877.1669872193.git.schofija@oregonstate.edu> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Declarations are to be followed by a blank line. Add to follow Linux Kernel coding style. Issue reported by checkpatch. Signed-off-by: Jack Schofield Reviewed-by: Johan Hovold --- drivers/staging/greybus/tools/loopback_test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/greybus/tools/loopback_test.c b/drivers/stagin= g/greybus/tools/loopback_test.c index 4c42e393cd3d..242138c4f6cf 100644 --- a/drivers/staging/greybus/tools/loopback_test.c +++ b/drivers/staging/greybus/tools/loopback_test.c @@ -675,6 +675,7 @@ static int open_poll_files(struct loopback_test *t) static int close_poll_files(struct loopback_test *t) { int i; + for (i =3D 0; i < t->poll_count; i++) close(t->fds[i].fd); =20 --=20 2.25.1 From nobody Thu Sep 18 23:10:59 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51AB5C43217 for ; Thu, 1 Dec 2022 05:39:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229644AbiLAFjC (ORCPT ); Thu, 1 Dec 2022 00:39:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229607AbiLAFi7 (ORCPT ); Thu, 1 Dec 2022 00:38:59 -0500 Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD0A45AE3C for ; Wed, 30 Nov 2022 21:38:57 -0800 (PST) Received: by mail-pg1-x52d.google.com with SMTP id w37so752706pga.5 for ; Wed, 30 Nov 2022 21:38:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oregonstate-edu.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tzXcxEhY206rBEzs9pZWVugpUSKJxpd3SA2u/++FFEo=; b=nTBGN+TxqobVpNVk5u779lh6sCrYGmQUfTv23baPBaJBsfbFVn2yeMJdZ0OgMVb7cf KMq79c/+6kZB/HlT6g+mWoOFQNKAJLxeEbZavIbdNqOd8Zf1b/zTxMf797jvcAhMeaA2 jfsW9tlfn/m/e5K+1nHHuotMBnA8ibMaEBiiEG6j6u5yuqPazkWLsveIEA3D5r3JAaTj T+UZNnfYC6LFPg7nYQvRfeEPvt0Nq1AwI86JWuK2CzMllD/4UqDVsfrk9kMLhe/hf68x btbClZmceoUpj1y7TXDYCqMYRE7CkbFQFg5v5T7mdMStAQVPexmBttElEZJChqmxaLBw 5KNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tzXcxEhY206rBEzs9pZWVugpUSKJxpd3SA2u/++FFEo=; b=SoPPieObTeoK+ei2DBkz2J2MCkwrK9wEzWMzarldC3QI6uKgGxL0CdHDxVO0r1UdbX HSsqjwdMshCVGaS3SdowJoIv0rfCpCC334cssvoPdKscNcxIDwqtRF64K4F8ahuRZWoQ D+ossRjz7Al4ejjGzXpuVS8sdPYd6VfGNWXCh1YuX0FlCzmOro82Q7+/+/qzqgFEY68b kK8liwBO9gtSJ97BheiqvH/qAnguA2q95unylLyw4OGl15N/UHOZ4H14ULfeEwEoQdHJ aDH1KPKCPqmtUac6amtognSPPyqP1tJWwWvYxd7/PnVngXaENxybjCIY57AlovGwOdYn Qy5A== X-Gm-Message-State: ANoB5pkpuolipvtDs8nOthjzMCe8jbg4isl7ttuQ2BhyTmRwFsPbvBmQ KEwZIVtnQeQVpP66KDQYxYXq6c1icS2Bmg8APLE= X-Google-Smtp-Source: AA0mqf5wrrGDIjuBXPbh2ixyzd37b5q+71oNaWfElX1EHUxAIGdrdZnxc5DJjW/ALu85TqfqVWbyUw== X-Received: by 2002:a63:2043:0:b0:477:5e25:4ca8 with SMTP id r3-20020a632043000000b004775e254ca8mr42709541pgm.511.1669873137434; Wed, 30 Nov 2022 21:38:57 -0800 (PST) Received: from ubu ([76.27.231.73]) by smtp.gmail.com with ESMTPSA id q4-20020a170902dac400b00189651e5c26sm2514657plx.236.2022.11.30.21.38.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Nov 2022 21:38:57 -0800 (PST) From: Jack Schofield To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Jack Schofield Subject: [PATCH 2/3] staging: greybus: loopback_test: Remove void function return statement Date: Wed, 30 Nov 2022 21:38:51 -0800 Message-Id: <5d465d56a6e3de2cb9d2f34377cbb82678cc67b1.1669872193.git.schofija@oregonstate.edu> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Void function return statement is not useful in this case. Issue reported by checkpatch. Signed-off-by: Jack Schofield Reviewed-by: Johan Hovold --- drivers/staging/greybus/tools/loopback_test.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/greybus/tools/loopback_test.c b/drivers/stagin= g/greybus/tools/loopback_test.c index 242138c4f6cf..7c1697304ab4 100644 --- a/drivers/staging/greybus/tools/loopback_test.c +++ b/drivers/staging/greybus/tools/loopback_test.c @@ -862,7 +862,6 @@ void loopback_run(struct loopback_test *t) =20 err: printf("Error running test\n"); - return; } =20 static int sanity_check(struct loopback_test *t) --=20 2.25.1 From nobody Thu Sep 18 23:10:59 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AB9CC43217 for ; Thu, 1 Dec 2022 05:39:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229640AbiLAFjF (ORCPT ); Thu, 1 Dec 2022 00:39:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229613AbiLAFi7 (ORCPT ); Thu, 1 Dec 2022 00:38:59 -0500 Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE959A1A3A for ; Wed, 30 Nov 2022 21:38:58 -0800 (PST) Received: by mail-pf1-x42b.google.com with SMTP id z17so900032pff.1 for ; Wed, 30 Nov 2022 21:38:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oregonstate-edu.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gRfrpCcdqhoeRuzp0v0IXZ5eoT0+P8wQNToDtSeombQ=; b=B1o+NjOouQZew+heE6cm5PhgsIcyy1P3Hsc8vVzE0C/9e3esOd6qr+Qc3h+rzm8PS/ PJmO4eSqErWMiypt13e3lWSpO9WHbPSLvrij11cWHOSp6enEvg4hAwHcWFSCB1Dxutgl z3pYnMa6PRethsqm68NXIaS99oRI0qzb7yyopvR6VjM2yiG2I5U09x99JsAWptmrkeHc w32uQgTH1LWQaV0sPkvnDH9eYc6Y+qTbY36Qnvttw6wvvuUlltEZuHZKgx3jk33r3FPZ 37GP3yowNEGApdcLw2YSka5I9xbXqCO5zZWQrUtcQrs/lWx7hXOaWYkTRx/I0vObK15+ rsNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gRfrpCcdqhoeRuzp0v0IXZ5eoT0+P8wQNToDtSeombQ=; b=niWsq53nOh9OIYRP9HTdGo2Qi9H7X6ytSO6IHZIvN3TNZfVXe4bzBqI3hfErLxjqbZ zQSdWGBEi5zafqdR00aOB36HW1IbqxMhz5d1cf2kawqZk3RaHhNLXnPssPfbKAK1+gRO Xp5ZYZkjsIxrmCxaMITTVL9b5tld27l7fJy+Pe7rAZY81yxPlsUn+MNvEPm6ogGG+fmk DAy1sLWvEHxGl5Fr8kyLjAyG7TcwrlWd41TtQ302MtbcCv0B6Z6HvHAY9NYT4cPwycEQ nRZLxbLmVlDvClu7wDCOlJNk3Di5j/Vx34pr/pxXqHqAlTPmX/nNV/pzVNgM5M3Tz7Cy 3SDw== X-Gm-Message-State: ANoB5plMWqHjwYarj3lL/eW4Uc6Wptt/Esq4+isCz77S1rak0h467QBh u06c+erGO7UiOR3MciFLH2SVkA== X-Google-Smtp-Source: AA0mqf5LPxEjAzNgW88Jnl+1oVaRnxxuYa8oFMCErDjxgH0BduX8j7GonuWToggh9lLYlQMtaVjQ3Q== X-Received: by 2002:a63:4d49:0:b0:46f:b030:7647 with SMTP id n9-20020a634d49000000b0046fb0307647mr39012597pgl.13.1669873138369; Wed, 30 Nov 2022 21:38:58 -0800 (PST) Received: from ubu ([76.27.231.73]) by smtp.gmail.com with ESMTPSA id d77-20020a621d50000000b00575fea99db9sm1282958pfd.27.2022.11.30.21.38.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Nov 2022 21:38:58 -0800 (PST) From: Jack Schofield To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Jack Schofield Subject: [PATCH 3/3] staging: greybus: loopback_test: Remove extra blank lines Date: Wed, 30 Nov 2022 21:38:52 -0800 Message-Id: <51edbcc7583d64d3fe5a203d3a8649a695ef4a75.1669872193.git.schofija@oregonstate.edu> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Clean up extra uses of blank lines that do not follow the kernel coding style. Issue reported by checkpatch. Signed-off-by: Jack Schofield Reviewed-by: Johan Hovold --- drivers/staging/greybus/tools/loopback_test.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/drivers/staging/greybus/tools/loopback_test.c b/drivers/stagin= g/greybus/tools/loopback_test.c index 7c1697304ab4..d7ad51ff60c5 100644 --- a/drivers/staging/greybus/tools/loopback_test.c +++ b/drivers/staging/greybus/tools/loopback_test.c @@ -239,7 +239,6 @@ static void show_loopback_devices(struct loopback_test = *t) =20 for (i =3D 0; i < t->device_count; i++) printf("device[%d] =3D %s\n", i, t->devices[i].name); - } =20 int open_sysfs(const char *sys_pfx, const char *node, int flags) @@ -274,7 +273,6 @@ float read_sysfs_float_fd(int fd, const char *sys_pfx, = const char *node) char buf[SYSFS_MAX_INT]; =20 if (read(fd, buf, sizeof(buf)) < 0) { - fprintf(stderr, "unable to read from %s%s %s\n", sys_pfx, node, strerror(errno)); close(fd); @@ -367,7 +365,6 @@ static int get_results(struct loopback_test *t) r->apbridge_unipro_latency_max - r->apbridge_unipro_latency_min; r->gbphy_firmware_latency_jitter =3D r->gbphy_firmware_latency_max - r->gbphy_firmware_latency_min; - } =20 /*calculate the aggregate results of all enabled devices */ @@ -407,7 +404,6 @@ static int get_results(struct loopback_test *t) r->apbridge_unipro_latency_max - r->apbridge_unipro_latency_min; r->gbphy_firmware_latency_jitter =3D r->gbphy_firmware_latency_max - r->gbphy_firmware_latency_min; - } =20 return 0; @@ -536,7 +532,6 @@ static int log_results(struct loopback_test *t) fprintf(stderr, "unable to open %s for appending\n", file_name); abort(); } - } for (i =3D 0; i < t->device_count; i++) { if (!device_enabled(t, i)) @@ -550,10 +545,8 @@ static int log_results(struct loopback_test *t) if (ret =3D=3D -1) fprintf(stderr, "unable to write %d bytes to csv.\n", len); } - } =20 - if (t->aggregate_output) { len =3D format_output(t, &t->aggregate_results, "aggregate", data, sizeof(data), &tm); @@ -741,7 +734,6 @@ static int wait_for_complete(struct loopback_test *t) ts =3D &t->poll_timeout; =20 while (1) { - ret =3D ppoll(t->fds, t->poll_count, ts, &mask_old); if (ret <=3D 0) { stop_tests(t); @@ -781,7 +773,6 @@ static void prepare_devices(struct loopback_test *t) if (t->stop_all || device_enabled(t, i)) write_sysfs_val(t->devices[i].sysfs_entry, "type", 0); =20 - for (i =3D 0; i < t->device_count; i++) { if (!device_enabled(t, i)) continue; @@ -824,7 +815,6 @@ static int start(struct loopback_test *t) return 0; } =20 - void loopback_run(struct loopback_test *t) { int i; @@ -853,7 +843,6 @@ void loopback_run(struct loopback_test *t) if (ret) goto err; =20 - get_results(t); =20 log_results(t); @@ -881,10 +870,8 @@ static int sanity_check(struct loopback_test *t) fprintf(stderr, "Bad device mask %x\n", (1 << i)); return -1; } - } =20 - return 0; } =20 --=20 2.25.1