[v2] some checkpatch fixes in the file rxtx.c

[PATCH v2 0/2] some checkpatch fixes in the file rxtx.c

Posted by Tanjuate Brunostar 3 years, 5 months ago

These fixes are focused on the function s_vFillRTSHead

v2: changed confusing changelog messages

Tanjuate Brunostar (2):
  change the function name s_vFillRTSHead
  Join some lines of code to avoid code lines ending in (

 drivers/staging/vt6655/rxtx.c | 48 ++++++++++++++++-------------------
 1 file changed, 22 insertions(+), 26 deletions(-)

-- 
2.34.1

Re: [PATCH v2 0/2] some checkpatch fixes in the file rxtx.c

Posted by Greg KH 3 years, 5 months ago

On Tue, Nov 01, 2022 at 12:37:58PM +0000, Tanjuate Brunostar wrote:
> These fixes are focused on the function s_vFillRTSHead
> 
> v2: changed confusing changelog messages
> 
> Tanjuate Brunostar (2):
>   change the function name s_vFillRTSHead
>   Join some lines of code to avoid code lines ending in (
> 
>  drivers/staging/vt6655/rxtx.c | 48 ++++++++++++++++-------------------
>  1 file changed, 22 insertions(+), 26 deletions(-)

Please look at your subject lines you are using here, and look at the
mailing list for previous patch submissions, and at the git log for this
file, and fix them up to have the proper prefixes on them.

As is, I can't take these.

thanks,

greg k-h

Re: [PATCH v2 0/2] some checkpatch fixes in the file rxtx.c

Posted by Tanju Brunostar 3 years, 5 months ago

On Tue, Nov 1, 2022 at 7:20 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Tue, Nov 01, 2022 at 12:37:58PM +0000, Tanjuate Brunostar wrote:
> > These fixes are focused on the function s_vFillRTSHead
> >
> > v2: changed confusing changelog messages
> >
> > Tanjuate Brunostar (2):
> >   change the function name s_vFillRTSHead
> >   Join some lines of code to avoid code lines ending in (
> >
> >  drivers/staging/vt6655/rxtx.c | 48 ++++++++++++++++-------------------
> >  1 file changed, 22 insertions(+), 26 deletions(-)
>
> Please look at your subject lines you are using here, and look at the
> mailing list for previous patch submissions, and at the git log for this
> file, and fix them up to have the proper prefixes on them.
>
> As is, I can't take these.
>
> thanks,
>
> greg k-h

There is a version 3 of this. Please review it instead

thanks

Tanju