From nobody Thu Apr 9 01:47:38 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E71FAFA373D for ; Tue, 1 Nov 2022 12:38:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230339AbiKAMix (ORCPT ); Tue, 1 Nov 2022 08:38:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230349AbiKAMii (ORCPT ); Tue, 1 Nov 2022 08:38:38 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DADF4E91 for ; Tue, 1 Nov 2022 05:38:32 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id j4so23418931lfk.0 for ; Tue, 01 Nov 2022 05:38:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iH9vhU7zv5GDc91Wl04v1T86uct201Qybf+k0VYUxHY=; b=EjZ6e9OVZvrI71SL4MWaxmryGcntIUx9723MW27hUMhjG+dn5Lv5KBAVfTUaImKFe9 veyEUi93Njbdqj6+lzd/Qr3ll83KrIFT3twvl8CWAhm4i4gdTuLQ+OIbxjyhSOOK2Yfb wSTN63ulqw2GzsPl0DYqh6ZPbFT3/6o/7XiJItmVatnpNHMy6VUV+71i0BSfknMZLCwk OeDF4zRda9EjgdkpS3/GYkBRpvJVbjc1CUxgoPDTqJgeYfNlvDoNW7FV2N2PZHheNSwj xZG9Bq6iWk0XM3L9IL4OS/7qfwn5gdstZGBcDa32zf8iTQXvUbitfNI53G7M1Nbs9YBs 9T6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iH9vhU7zv5GDc91Wl04v1T86uct201Qybf+k0VYUxHY=; b=6x44bjGleqmZRaTpTFSwYGIOBrxfV7f9pPZAsBOfd32bHqqIyGz3XD8cS57H9IG3U6 yK4jlVhjmb3/gHzxxcr1RRh7SZ2h0U/fxcA6fnFpDxP6Zl+8xMD4Y+HCJ6YumrxgXpz8 IojXTain5QECauXz7KHC9G9UupjzQW8vgVmhQCF1fG7oMCvWY13ZPH66kvkp5tzMYy9E L6XtyHWxdlMl3HmgLnJhinxVx/sPz8zBi4hFvW6UkO2nlE29SLTPcGixCYtVB5QO1P0X vPy17qigEe/D8aam9iWeQ/EHHMyhMYYLeENce25F+ATuIMpfpMaNYi6yTpcsztDpMYF2 2p/A== X-Gm-Message-State: ACrzQf3+V2QKNrQUB8+j5fbBz/qvKJhzYk1ayxawDJxFNjy5P4BrXzSB A/qKFU96mPvmw62EPxozlKY= X-Google-Smtp-Source: AMsMyM6xU01iBBnD4wgyTps3ciOLOEnhuAAcCU9m9LJnE4Qb5Lh0e1ZnMCt3TI18lfpEhD/vrHFUFg== X-Received: by 2002:a05:6512:16a9:b0:4a0:349d:d30c with SMTP id bu41-20020a05651216a900b004a0349dd30cmr6843068lfb.149.1667306310957; Tue, 01 Nov 2022 05:38:30 -0700 (PDT) Received: from elroy-temp-vm.gaiao0uenmiufjlowqgp5yxwdh.gvxx.internal.cloudapp.net ([20.240.130.248]) by smtp.googlemail.com with ESMTPSA id p21-20020a2eb7d5000000b0026e897e3236sm1771625ljo.6.2022.11.01.05.38.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Nov 2022 05:38:30 -0700 (PDT) From: Tanjuate Brunostar To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, Tanjuate Brunostar Subject: [PATCH v2 1/2] change the function name s_vFillRTSHead Date: Tue, 1 Nov 2022 12:37:59 +0000 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Remove the use of Hungarian notation, which is not used in the Linux kernel. Reported by checkpatch Signed-off-by: Tanjuate Brunostar --- drivers/staging/vt6655/rxtx.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c index 31ae99b3cb35..d7e439cd8675 100644 --- a/drivers/staging/vt6655/rxtx.c +++ b/drivers/staging/vt6655/rxtx.c @@ -23,7 +23,7 @@ * s_uGetTxRsvTime- get frame reserved time * s_vFillCTSHead- fulfill CTS ctl header * s_vFillFragParameter- Set fragment ctl parameter. - * s_vFillRTSHead- fulfill RTS ctl header + * fill_rts_head- fulfill RTS ctl header * s_vFillTxKey- fulfill tx encrypt key * s_vSWencryption- Software encrypt header * vDMA0_tx_80211- tx 802.11 frame via dma0 @@ -85,15 +85,15 @@ static const unsigned short fb_opt1[2][5] =3D { #define DATADUR_A_F1 13 =20 /*--------------------- Static Functions --------------------------*/ -static void s_vFillRTSHead(struct vnt_private *pDevice, - unsigned char byPktType, - void *pvRTS, - unsigned int cbFrameLength, - bool bNeedAck, - bool bDisCRC, - struct ieee80211_hdr *hdr, - unsigned short wCurrentRate, - unsigned char byFBOption); +static void fill_rts_head(struct vnt_private *pDevice, + unsigned char byPktType, + void *pvRTS, + unsigned int cbFrameLength, + bool bNeedAck, + bool bDisCRC, + struct ieee80211_hdr *hdr, + unsigned short wCurrentRate, + unsigned char byFBOption); =20 static void s_vGenerateTxParameter(struct vnt_private *pDevice, unsigned char byPktType, @@ -912,7 +912,7 @@ s_vGenerateTxParameter( buf->rrv_time_a =3D vnt_rxtx_rsvtime_le16(pDevice, byPktType, cbFrameSi= ze, wCurrentRate, bNeedACK); buf->rrv_time_b =3D vnt_rxtx_rsvtime_le16(pDevice, PK_TYPE_11B, cbFrame= Size, pDevice->byTopCCKBasicRate, bNeedACK); =20 - s_vFillRTSHead(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDisCR= C, psEthHeader, wCurrentRate, byFBOption); + fill_rts_head(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDisCRC= , psEthHeader, wCurrentRate, byFBOption); } else {/* RTS_needless, PCF mode */ struct vnt_rrv_time_cts *buf =3D pvRrvTime; =20 @@ -931,7 +931,7 @@ s_vGenerateTxParameter( buf->rrv_time =3D vnt_rxtx_rsvtime_le16(pDevice, byPktType, cbFrameSize= , wCurrentRate, bNeedACK); =20 /* Fill RTS */ - s_vFillRTSHead(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDisCR= C, psEthHeader, wCurrentRate, byFBOption); + fill_rts_head(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDisCRC= , psEthHeader, wCurrentRate, byFBOption); } else if (!pvRTS) {/* RTS_needless, non PCF mode */ struct vnt_rrv_time_ab *buf =3D pvRrvTime; =20 @@ -945,7 +945,7 @@ s_vGenerateTxParameter( buf->rrv_time =3D vnt_rxtx_rsvtime_le16(pDevice, PK_TYPE_11B, cbFrameSi= ze, wCurrentRate, bNeedACK); =20 /* Fill RTS */ - s_vFillRTSHead(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDisCR= C, psEthHeader, wCurrentRate, byFBOption); + fill_rts_head(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDisCRC= , psEthHeader, wCurrentRate, byFBOption); } else { /* RTS_needless, non PCF mode */ struct vnt_rrv_time_ab *buf =3D pvRrvTime; =20 --=20 2.34.1 From nobody Thu Apr 9 01:47:38 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D112AFA373D for ; Tue, 1 Nov 2022 12:38:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230350AbiKAMi6 (ORCPT ); Tue, 1 Nov 2022 08:38:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230371AbiKAMik (ORCPT ); Tue, 1 Nov 2022 08:38:40 -0400 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B4CD60C0 for ; Tue, 1 Nov 2022 05:38:37 -0700 (PDT) Received: by mail-lj1-x230.google.com with SMTP id c25so7110055ljr.8 for ; Tue, 01 Nov 2022 05:38:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZlF0TxgQdB9El9HMgVNkTNkSGlJ7JQkiUcra0SV3NJs=; b=RiuNuV6nMsbcTgUz7pjtL2BQMXHduzlKBqVSBRHcEKIXtt6nlr7VSsLb7k4YT5/yQZ WGx2IqMXqzn3eWQpRJuYMPrzBy3wP/fr76BFRBTTEOTwC+7ARRauDtTnwtwL+oJvAmtc unDPCbIsyxnmymgUzTRv4XD9KR6YGp8FrrRlFOVHTBN0H1JdkN+vJ55C4zk1YcUtAHbo 977nnMtd8y5A431ynshkAfwOKwVlvsKjicaeHGzD1Afv47SUYtNxjLc97eZ3grwQfHQ/ xAxabuXGh1Cuaydtgd8vkweYX14ssjGPbBwOvVbfGpuDckDsitmarZXfxvSIDC0Z+1Nc CDiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZlF0TxgQdB9El9HMgVNkTNkSGlJ7JQkiUcra0SV3NJs=; b=ws+kLTjdQhsKLs/adgjkRua8wgW/eMu1ORxzZb+W/nmdyydX+iG2rqR+eCsi0ZZAJA B95fGKMhj7+KA0zgOUSF5PZdMPvChFbilyG2FbQDaQBrg3O2QQacLWGOxrW4HKYBYZNP Q6VdjxnKpFAKVUoTYemGrAx5xBzQx36Z0ZXuyZb7Xq35n5+a+mgurba1T1zz/Efk4kIn e0WghP9Dp6ofTGjscfgwejnOl1LWBTcD0Q0seBV0B3ryqlLQI7ZBBwlZkalybHo5ttXH hCux7oZzUHiwCMNyHDr5uTJo+ysO348mRAScGFDP5Jhncj/sOxe3/cRClx8UWsjrFO3G Z/rg== X-Gm-Message-State: ACrzQf1HWty1p6D+NZSCRqbJniJD8D9TZvNKQk/we2rNsm3wn/0Uu9HC NxxHDLonoeo4BjRSnFQkJBIrtBltNkGLFQ== X-Google-Smtp-Source: AMsMyM7nNIiARjaLTsBqKh2XT1ggp+KS7+iocKtcVW5UZrOI+mCtoJ//DXkSrajuYUgAQEspsj0ziw== X-Received: by 2002:a2e:9018:0:b0:277:a4e:98f2 with SMTP id h24-20020a2e9018000000b002770a4e98f2mr829467ljg.358.1667306316170; Tue, 01 Nov 2022 05:38:36 -0700 (PDT) Received: from elroy-temp-vm.gaiao0uenmiufjlowqgp5yxwdh.gvxx.internal.cloudapp.net ([20.240.130.248]) by smtp.googlemail.com with ESMTPSA id p21-20020a2eb7d5000000b0026e897e3236sm1771625ljo.6.2022.11.01.05.38.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Nov 2022 05:38:35 -0700 (PDT) From: Tanjuate Brunostar To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, Tanjuate Brunostar Subject: [PATCH v2 2/2] Join some lines of code to avoid code lines ending in ( Date: Tue, 1 Nov 2022 12:38:00 +0000 Message-Id: <04122308bf02e5c99329f120fe076bcffc16b08f.1667305446.git.tanjubrunostar0@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Fix checkpatch error related to code line ends with a '(', by joining some lines and indenting correctly. This improves visibility Signed-off-by: Tanjuate Brunostar --- drivers/staging/vt6655/rxtx.c | 22 +++++++++------------- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c index d7e439cd8675..df7473155704 100644 --- a/drivers/staging/vt6655/rxtx.c +++ b/drivers/staging/vt6655/rxtx.c @@ -555,19 +555,15 @@ s_uFillDataHead( return buf->duration; } =20 -static -void -s_vFillRTSHead( - struct vnt_private *pDevice, - unsigned char byPktType, - void *pvRTS, - unsigned int cbFrameLength, - bool bNeedAck, - bool bDisCRC, - struct ieee80211_hdr *hdr, - unsigned short wCurrentRate, - unsigned char byFBOption -) +static void fill_rts_head(struct vnt_private *pDevice, + unsigned char byPktType, + void *pvRTS, + unsigned int cbFrameLength, + bool bNeedAck, + bool bDisCRC, + struct ieee80211_hdr *hdr, + unsigned short wCurrentRate, + unsigned char byFBOption) { unsigned int uRTSFrameLen =3D 20; =20 --=20 2.34.1