iio: Implement and utilize register structures for ISA drivers

[PATCH v2 0/2] iio: Implement and utilize register structures for ISA drivers

Posted by William Breathitt Gray 3 years, 9 months ago

Changes in v2:
 - Rename 'ad' member to 'ssr_ad' to indicate access to Software Strobe
   Register as well; relevant comments updated
 - Dereference DAC channel address via array subscripts in the
   stx104_write_raw() function in order to match rest of code
 - Replace struct cio_dac_reg with direct u16 pointer to the DAC
   address; this greatly simplifies the cio-dac patch

The STX104 and CIO-DAC drivers were updated to use I/O memory accessor
calls such as ioread8()/iowrite8() in previous patch series [1]. This
patch series is a continuation of the effort to improve the code
readability and reduce magic numbers by implementing and utilizing named
register data structures.

[1] https://lore.kernel.org/all/cover.1652201921.git.william.gray@linaro.org/

William Breathitt Gray (2):
  iio: adc: stx104: Implement and utilize register structures
  iio: dac: cio-dac: Cleanup indexing for DAC writes

 drivers/iio/adc/stx104.c  | 74 ++++++++++++++++++++++++++-------------
 drivers/iio/dac/cio-dac.c | 10 +++---
 2 files changed, 55 insertions(+), 29 deletions(-)


base-commit: 338222d8e1121bcb78a86fb39982eddcc367a5bc
-- 
2.36.1

Re: [PATCH v2 0/2] iio: Implement and utilize register structures for ISA drivers

Posted by Jonathan Cameron 3 years, 9 months ago

On Thu,  7 Jul 2022 13:21:23 -0400
William Breathitt Gray <william.gray@linaro.org> wrote:

> Changes in v2:
>  - Rename 'ad' member to 'ssr_ad' to indicate access to Software Strobe
>    Register as well; relevant comments updated
>  - Dereference DAC channel address via array subscripts in the
>    stx104_write_raw() function in order to match rest of code
>  - Replace struct cio_dac_reg with direct u16 pointer to the DAC
>    address; this greatly simplifies the cio-dac patch
> 
> The STX104 and CIO-DAC drivers were updated to use I/O memory accessor
> calls such as ioread8()/iowrite8() in previous patch series [1]. This
> patch series is a continuation of the effort to improve the code
> readability and reduce magic numbers by implementing and utilizing named
> register data structures.
Series applied to the togreg branch of iio.git.  Given timing in cycle, I'll
only push that out as testing (for 0-day etc) and then rebase it after rc1.

Thanks,

Jonathan

> 
> [1] https://lore.kernel.org/all/cover.1652201921.git.william.gray@linaro.org/
> 
> William Breathitt Gray (2):
>   iio: adc: stx104: Implement and utilize register structures
>   iio: dac: cio-dac: Cleanup indexing for DAC writes
> 
>  drivers/iio/adc/stx104.c  | 74 ++++++++++++++++++++++++++-------------
>  drivers/iio/dac/cio-dac.c | 10 +++---
>  2 files changed, 55 insertions(+), 29 deletions(-)
> 
> 
> base-commit: 338222d8e1121bcb78a86fb39982eddcc367a5bc