[v2] staging: vt6656: Fix CamelCase, add comments, change macro to function

[PATCH v2 0/6] staging: vt6656: Fix CamelCase, add comments, change macro to function

Philipp Hortmann posted 6 patches 4 years, 4 months ago

Diff against v1
Download series mbox

drivers/staging/vt6656/device.h | 11 ++---------
drivers/staging/vt6656/mac.c    | 14 +++++++-------
drivers/staging/vt6656/mac.h    | 22 +++++++++++-----------
drivers/staging/vt6656/rxtx.c   |  8 ++------
drivers/staging/vt6656/wcmd.c   | 13 +++++++++++--
5 files changed, 33 insertions(+), 35 deletions(-)

Expand all Fold all

[PATCH v2 0/6] staging: vt6656: Fix CamelCase, add comments, change macro to function

Posted by Philipp Hortmann 4 years, 4 months ago

Various checkpatch.pl fixes as liste below
Tested with device VNT6656G6A40
Transferred this patches over VNT6656G6A40

v2: Patch #1
    Changed EN_CFG_PKT_BURST_MO to EN_CFG_PKT_BURST_MD
    Patch #2
    Devided into three patches
    Patch #3
    Devided into two patches

Philipp Hortmann (6):
  staging: vt6656: Fix CamelCase warnings in mac.h and mac.c
  staging: vt6656: Add comment for locks
  staging: vt6656: Fix CamelCase warnings in macro
  staging: vt6656: Change macro to function and moved to better file
  staging: vt6656: Remove ftrace-like logging
  staging: vt6656: Remove unnecessary line breaks

 drivers/staging/vt6656/device.h | 11 ++---------
 drivers/staging/vt6656/mac.c    | 14 +++++++-------
 drivers/staging/vt6656/mac.h    | 22 +++++++++++-----------
 drivers/staging/vt6656/rxtx.c   |  8 ++------
 drivers/staging/vt6656/wcmd.c   | 13 +++++++++++--
 5 files changed, 33 insertions(+), 35 deletions(-)

-- 
2.25.1

Re: [PATCH v2 0/6] staging: vt6656: Fix CamelCase, add comments, change macro to function

Posted by Dan Carpenter 4 years, 4 months ago

On Mon, Feb 21, 2022 at 10:24:52PM +0100, Philipp Hortmann wrote:
> Various checkpatch.pl fixes as liste below
> Tested with device VNT6656G6A40
> Transferred this patches over VNT6656G6A40
> 
> v2: Patch #1
>     Changed EN_CFG_PKT_BURST_MO to EN_CFG_PKT_BURST_MD
>     Patch #2
>     Devided into three patches
>     Patch #3
>     Devided into two patches

Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

The one thing per patch rule is slightly complicated and different
maintainers have slightly different lines that they draw.  You could
have merged patches 3 and 4 together and it would have been fine.  But
what you sent is also fine.

regards,
dan carpenter