From nobody Fri Jun 26 12:32:33 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B2ACC433EF for ; Mon, 21 Feb 2022 21:25:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234849AbiBUVZf (ORCPT ); Mon, 21 Feb 2022 16:25:35 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:40920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234729AbiBUVZ1 (ORCPT ); Mon, 21 Feb 2022 16:25:27 -0500 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F17C112AF4 for ; Mon, 21 Feb 2022 13:25:02 -0800 (PST) Received: by mail-ed1-x531.google.com with SMTP id q17so32185566edd.4 for ; Mon, 21 Feb 2022 13:25:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=3iOaemryxFEi0e/+jdU0nqxQQNzituL4kMRU9dWLTYs=; b=Jh/ZCi75MemQA/Qs0viCHqUIzOrvPef7jBgD+1xx1DdQnQIFQwZa2oOJeptg2vqJo3 m/OSthzCYeu0bSWecJYJKqletDZQ0BZhz3/Lve6ynf1NoyjnVzuScbX8do+eZ7eWf5ja IkZb2AeLWx0Wt5p2tr5i5BkkYWTLBMhivdmbEoIxV9GatL3vtz87WXFPixtLqQFaGNZP Wm81xmJtd/DmfUxmw4J7vkTZQE6ca9+J7lTqm0GdzAY5wZE5a4gNj5pZ3z2KRsZZuTFq A3M1HkD4ZQYGMUx5lSZr4rZMNsnywrWT5n45Xo4kLiRh4GufIinwU76vWhbmumT1VuyV 4YNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3iOaemryxFEi0e/+jdU0nqxQQNzituL4kMRU9dWLTYs=; b=XdrRjqiTlxI+am2q84IHEzqCyPpsPhzv9oB+aKHZJ9+k1FomUDPs8ddtPYHT9i0Rp1 cUX16DWu4WLXQuNvEsUVGkhJqYiC4L1ubH1+mDUa0Wuv4drCeHWNC47z0gGCFVWIlS60 zV7jQCJAezYItDQO2o0OPSiE3vwG2jYAUlPIHChQEDQE9t8NQM4lfXbMw9LQ3bXrbHkX WYgwXuIg3PbGyqqcSK6FTOMyzfW9BZVMH1Fb/x61/NXKd0eIcisZrzpjnjlx3pFsaCr8 8/Szg8udF/50FqHn6Yco7u+eldh2zTIPzqoIB3xGJjVX+JTGKoquxPtDbLUV3Z0JZBfr 07cw== X-Gm-Message-State: AOAM5309gAzmRAVQ5ZJiB/coWsHsrn3zOSGwm4hDb9VZX5vRWtT/gOMl IcTRFMxm7sGUiV2k36MgLoY= X-Google-Smtp-Source: ABdhPJyA2Ev7fa08B9hHevUNXo9Mg3QtTF2dSehbM7Tfai26QTSeZOWZ/ojfVE5NaMwtbm5pZ39dkw== X-Received: by 2002:a50:fc05:0:b0:408:4d18:5070 with SMTP id i5-20020a50fc05000000b004084d185070mr23717566edr.365.1645478701457; Mon, 21 Feb 2022 13:25:01 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935aa6.dip0.t-ipconnect.de. [87.147.90.166]) by smtp.gmail.com with ESMTPSA id e9sm4933398edy.53.2022.02.21.13.25.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Feb 2022 13:25:01 -0800 (PST) Date: Mon, 21 Feb 2022 22:24:59 +0100 From: Philipp Hortmann To: Forest Bond , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/6] staging: vt6656: Fix CamelCase warnings in mac.h and mac.c Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This patch fixes the checkpatch.pl warnings like: CHECK: Avoid CamelCase: 175: FILE: drivers/staging/vt6656/mac.h:175: +#define EnCFG_BBType_a 0x00 and affected places in mac.c Signed-off-by: Philipp Hortmann Reviewed-by: Dan Carpenter --- V1 -> V2: Changed EN_CFG_PKT_BURST_MO to EN_CFG_PKT_BURST_MD --- drivers/staging/vt6656/mac.c | 14 +++++++------- drivers/staging/vt6656/mac.h | 22 +++++++++++----------- 2 files changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/staging/vt6656/mac.c b/drivers/staging/vt6656/mac.c index 4f1f9b03a678..49430c0a99b8 100644 --- a/drivers/staging/vt6656/mac.c +++ b/drivers/staging/vt6656/mac.c @@ -39,7 +39,7 @@ int vnt_mac_set_bb_type(struct vnt_private *priv, u8 type) u8 data[2]; =20 data[0] =3D type; - data[1] =3D EnCFG_BBType_MASK; + data[1] =3D EN_CFG_BB_TYPE_MASK; =20 return vnt_control_out(priv, MESSAGE_TYPE_WRITE_MASK, MAC_REG_ENCFG0, MESSAGE_REQUEST_MACREG, ARRAY_SIZE(data), @@ -120,8 +120,8 @@ int vnt_mac_enable_protect_mode(struct vnt_private *pri= v) { u8 data[2]; =20 - data[0] =3D EnCFG_ProtectMd; - data[1] =3D EnCFG_ProtectMd; + data[0] =3D EN_CFG_PROTECT_MD; + data[1] =3D EN_CFG_PROTECT_MD; =20 return vnt_control_out(priv, MESSAGE_TYPE_WRITE_MASK, MAC_REG_ENCFG0, MESSAGE_REQUEST_MACREG, ARRAY_SIZE(data), data); @@ -132,7 +132,7 @@ int vnt_mac_disable_protect_mode(struct vnt_private *pr= iv) u8 data[2]; =20 data[0] =3D 0; - data[1] =3D EnCFG_ProtectMd; + data[1] =3D EN_CFG_PROTECT_MD; =20 return vnt_control_out(priv, MESSAGE_TYPE_WRITE_MASK, MAC_REG_ENCFG0, MESSAGE_REQUEST_MACREG, ARRAY_SIZE(data), data); @@ -142,8 +142,8 @@ int vnt_mac_enable_barker_preamble_mode(struct vnt_priv= ate *priv) { u8 data[2]; =20 - data[0] =3D EnCFG_BarkerPream; - data[1] =3D EnCFG_BarkerPream; + data[0] =3D EN_CFG_BARKER_PREAM; + data[1] =3D EN_CFG_BARKER_PREAM; =20 return vnt_control_out(priv, MESSAGE_TYPE_WRITE_MASK, MAC_REG_ENCFG2, MESSAGE_REQUEST_MACREG, ARRAY_SIZE(data), data); @@ -154,7 +154,7 @@ int vnt_mac_disable_barker_preamble_mode(struct vnt_pri= vate *priv) u8 data[2]; =20 data[0] =3D 0; - data[1] =3D EnCFG_BarkerPream; + data[1] =3D EN_CFG_BARKER_PREAM; =20 return vnt_control_out(priv, MESSAGE_TYPE_WRITE_MASK, MAC_REG_ENCFG2, MESSAGE_REQUEST_MACREG, ARRAY_SIZE(data), data); diff --git a/drivers/staging/vt6656/mac.h b/drivers/staging/vt6656/mac.h index 05af9ca7d69c..0ac845bd3c5a 100644 --- a/drivers/staging/vt6656/mac.h +++ b/drivers/staging/vt6656/mac.h @@ -172,20 +172,20 @@ #define TFTCTL_TSFCNTREN BIT(0) =20 /* Bits in the EnhanceCFG_0 register */ -#define EnCFG_BBType_a 0x00 -#define EnCFG_BBType_b BIT(0) -#define EnCFG_BBType_g BIT(1) -#define EnCFG_BBType_MASK (EnCFG_BBType_b | EnCFG_BBType_g) -#define EnCFG_ProtectMd BIT(5) +#define EN_CFG_BB_TYPE_A 0x00 +#define EN_CFG_BB_TYPE_B BIT(0) +#define EN_CFG_BB_TYPE_G BIT(1) +#define EN_CFG_BB_TYPE_MASK (EN_CFG_BB_TYPE_B | EN_CFG_BB_TYPE_G) +#define EN_CFG_PROTECT_MD BIT(5) =20 /* Bits in the EnhanceCFG_1 register */ -#define EnCFG_BcnSusInd BIT(0) -#define EnCFG_BcnSusClr BIT(1) +#define EN_CFG_BCN_SUS_IND BIT(0) +#define EN_CFG_BCN_SUS_CLR BIT(1) =20 /* Bits in the EnhanceCFG_2 register */ -#define EnCFG_NXTBTTCFPSTR BIT(0) -#define EnCFG_BarkerPream BIT(1) -#define EnCFG_PktBurstMode BIT(2) +#define EN_CFG_NXTBTTCFPSTR BIT(0) +#define EN_CFG_BARKER_PREAM BIT(1) +#define EN_CFG_PKT_BURST_MD BIT(2) =20 /* Bits in the CFG register */ #define CFG_TKIPOPT BIT(7) @@ -333,7 +333,7 @@ #define PKT_TYPE_ERROR_CRC BIT(1) #define PKT_TYPE_BSSID BIT(0) =20 -#define Default_BI 0x200 +#define DEFAULT_BI 0x200 =20 /* MiscFIFO Offset */ #define MISCFIFO_KEYETRY0 32 --=20 2.25.1 From nobody Fri Jun 26 12:32:33 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC38EC433EF for ; Mon, 21 Feb 2022 21:25:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230456AbiBUVZo (ORCPT ); Mon, 21 Feb 2022 16:25:44 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:41194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234875AbiBUVZk (ORCPT ); Mon, 21 Feb 2022 16:25:40 -0500 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4907F12AF2 for ; Mon, 21 Feb 2022 13:25:09 -0800 (PST) Received: by mail-ej1-x636.google.com with SMTP id qx21so36362759ejb.13 for ; Mon, 21 Feb 2022 13:25:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Oauo1b7HT73p7Gr1WROI5Ol6cUloVjrlNqIzfwLAH/Y=; b=qtDA+iJMSbeae+4uVqNcUJeGpB0jUbHeP+Z/CRB55izmjZBEeHLuRBuE7pxkTR8piY LmNUU9sysUfzKHzgLUYQ1BCvuw34D8vMmhkq2sTJhLZAiM4cz9PdG3h3VGOgn32aGGLi Dhm0uYXhKRl7f9hlF3OuUClNj3vFLBUkrEKlpB1Sjqb9HApqr2bG+dOzLoaXYAyrzW3C 9k5Sht3x5lqVh04VlKNP1ic1Gunbv/oPpxnUTuWYPgnoPHuz3WLPZISfW+grsngacH6y Nma/d0rQ5DeM5P3ceyXJZlgJVdaJc9kIc5fYxvoNlqcJqJgZEMnuFhF0o7BB9yZRVGwp 8vDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Oauo1b7HT73p7Gr1WROI5Ol6cUloVjrlNqIzfwLAH/Y=; b=0S7J7KKtNQ/1J/rWi5NYlg1WqVcsA7+BiwfTruGvUfnI1LDAjSQhIpBVOnC9alqi30 y5MVTbpikIMhtbxKd3UYECPUszN5kjE4rP1jYdQbLg5jiBa0eZf5QmkwAogyDAD3vQRo RTYxCjJg9i+IyT3+eC1kFtsP2vCiRkJpzfzRKDSIvaeiLqbsRMTTcnSpFiQ43qn4vwgf yqFlhRDwSjzRkM2W09teXiNFP0eI+RgVSa7KoccXRTPmVmclDGnhsnt3fx2E6cLS8iKk GOEihoQI7vJtrlEetINIIxip2z3fIkXBGc60f3C+tyqouW0ZBPbhMkGdTXSJ7Wogzf46 TX0g== X-Gm-Message-State: AOAM530H+WFoujxKHkbKoxukTpnlZk4gmE7eavJDH0DcuN0C002CZIDb uTkUpaUWJ5WiBE7LzmlvqRY= X-Google-Smtp-Source: ABdhPJyKDULWkIgC0AqNbiYLCH6Pf/SIodgvrqrgbYRagMi4siuwq0/bpO5ZkNczpb4tMCU2nDEcPg== X-Received: by 2002:a17:906:6693:b0:6cf:3cb:89c9 with SMTP id z19-20020a170906669300b006cf03cb89c9mr17455135ejo.23.1645478707569; Mon, 21 Feb 2022 13:25:07 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935aa6.dip0.t-ipconnect.de. [87.147.90.166]) by smtp.gmail.com with ESMTPSA id vs2sm5421682ejb.64.2022.02.21.13.25.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Feb 2022 13:25:07 -0800 (PST) Date: Mon, 21 Feb 2022 22:25:05 +0100 From: Philipp Hortmann To: Forest Bond , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/6] staging: vt6656: Add comment for locks Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This patch fixes the checkpatch.pl warnings like: - CHECK: spinlock_t definition without comment Signed-off-by: Philipp Hortmann Reviewed-by: Dan Carpenter --- V1 -> V2: Devided patch into three patches --- drivers/staging/vt6656/device.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vt6656/device.h b/drivers/staging/vt6656/devic= e.h index 8b6623a751f0..dda38c2a6f06 100644 --- a/drivers/staging/vt6656/device.h +++ b/drivers/staging/vt6656/device.h @@ -268,8 +268,8 @@ struct vnt_private { u32 rx_buf_sz; int mc_list_count; =20 - spinlock_t lock; - struct mutex usb_lock; + spinlock_t lock; /* prepare tx USB URB */ + struct mutex usb_lock; /* USB control messages */ =20 unsigned long flags; =20 --=20 2.25.1 From nobody Fri Jun 26 12:32:33 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1EECC433EF for ; Mon, 21 Feb 2022 21:25:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234875AbiBUVZr (ORCPT ); Mon, 21 Feb 2022 16:25:47 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:41230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234900AbiBUVZl (ORCPT ); Mon, 21 Feb 2022 16:25:41 -0500 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D4D413CD0 for ; Mon, 21 Feb 2022 13:25:14 -0800 (PST) Received: by mail-ej1-x632.google.com with SMTP id a23so36362666eju.3 for ; Mon, 21 Feb 2022 13:25:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=JWjYfqXasCYEUfZcDuCmAcewGNZu47MK/PX+0VAxPLM=; b=Di05ReSn75HTTnV/xV+063h7YXUIJNIUfTSmixmKczxJxPu8eCzNM7Ar5HTzlO96Jp SHUfPWxlkV8NFxfHgfCcXNeK1D90SMct9LNxnww86f26wxK79xcRn3O7dzw+Cb9auOuh ITAtC9/YL8h0B8Rmm4hps6ExwAonjLs70UKGruWcvLxTI+5inrcmTFC5AVbtQQsgxrfF hf0GdAaT861gDX9hHQp32FoVqqoJOWwpaS21I79pT8nW3cfYylqBuA+x1ZpYg0pvg7oK ZqKbH6qCjMnl7zTxQ+bkiGTLN3ynNadoAGGfHrJeSkxluHQAQoZ3dLFxlxbkBlB1R/G2 ORag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=JWjYfqXasCYEUfZcDuCmAcewGNZu47MK/PX+0VAxPLM=; b=MRModPLiRm5BAzpKJ4XTtR/zjZRG01GpdB+sy3HUJM/XJk49yKY8brDadqj+zikq6T tI7IlYpIzYlXlI7eUATy/u7eMppoO8XZVvLx/yoHyH3CjsoGDJjq4LK2LIuGku/Bgt5O oPpul18VnivJM53baWu7AIbJ1qGb/F74U4jt5zqeqJ3jh1LuogiVZ3X8AVInlXqe1+vy A/8cuqEsaYrSjT7xciuxKPYSGQju1O+IITqGeno+amLR2oUImd/1JdjDwNif+QIZD6Tk oRaVUVOolLN3oBh3kszeyNv/6PaK7JV7j8HOuAVZ18729coLLw0TreYzEsoaKUCjhNIX 8XhQ== X-Gm-Message-State: AOAM533FdGLAkeHZ9pOeKlINY6GTkbEagy6Lu6mYebLZYDM0wY5leVV5 XApF4EZorEG5x6aISU0H6Us= X-Google-Smtp-Source: ABdhPJwngm1nPQDLcrGttoKbc3qyTiAwa5bkoKD1xHpoJtrVHFT/viemRNdvBvdj/rDEhH0nF8Iewg== X-Received: by 2002:a17:906:a145:b0:6ae:e45d:15b6 with SMTP id bu5-20020a170906a14500b006aee45d15b6mr17107775ejb.714.1645478712790; Mon, 21 Feb 2022 13:25:12 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935aa6.dip0.t-ipconnect.de. [87.147.90.166]) by smtp.gmail.com with ESMTPSA id m4sm5598757ejl.45.2022.02.21.13.25.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Feb 2022 13:25:12 -0800 (PST) Date: Mon, 21 Feb 2022 22:25:10 +0100 From: Philipp Hortmann To: Forest Bond , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/6] staging: vt6656: Fix CamelCase warnings in macro Message-ID: <53072a97348b08276b083ce18188b9199cbfaae6.1645477326.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This patch fixes the checkpatch.pl warnings like: - CHECK: Avoid CamelCase: Signed-off-by: Philipp Hortmann Reviewed-by: Dan Carpenter --- V1 -> V2: Devided patch into three --- drivers/staging/vt6656/device.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/vt6656/device.h b/drivers/staging/vt6656/devic= e.h index dda38c2a6f06..0ab2d60204e8 100644 --- a/drivers/staging/vt6656/device.h +++ b/drivers/staging/vt6656/device.h @@ -381,11 +381,11 @@ struct vnt_private { struct ieee80211_low_level_stats low_stats; }; =20 -#define ADD_ONE_WITH_WRAP_AROUND(uVar, uModulo) { \ - if ((uVar) >=3D ((uModulo) - 1)) \ - (uVar) =3D 0; \ +#define ADD_ONE_WITH_WRAP_AROUND(var, modulo) { \ + if ((var) >=3D ((modulo) - 1)) \ + (var) =3D 0; \ else \ - (uVar)++; \ + (var)++; \ } =20 int vnt_init(struct vnt_private *priv); --=20 2.25.1 From nobody Fri Jun 26 12:32:33 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9138C433EF for ; Mon, 21 Feb 2022 21:25:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234887AbiBUVZu (ORCPT ); Mon, 21 Feb 2022 16:25:50 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:41284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234869AbiBUVZo (ORCPT ); Mon, 21 Feb 2022 16:25:44 -0500 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B39C12AE8 for ; Mon, 21 Feb 2022 13:25:20 -0800 (PST) Received: by mail-ed1-x52e.google.com with SMTP id w3so32034858edu.8 for ; Mon, 21 Feb 2022 13:25:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=hRNEJYkXr+PwSGSW5oI3rp0CXIsPeHFtIOlhCAUsWYo=; b=Og3vrovv6LTZwDBZk1v459NGVWUMEHl6mUBfs/6JKezdMuBldc2tHbo614J6H/39ec m8W+9YGfXZnCZ9xoYRGIBDqEBeJ8q90A8Vzgtxq2nqLgDwrBaitIZboNLsV9ks8mpR3z lfxw5Q3lJHJboK8Eu8qQC/G6BnSkJeWDayF3anq2zCAcDW2Gyv72QW+tAurVtle++97c 4q98CoxPo2dW6A9FHJSJqmDCVGO3K/A4tBsnjElGHbeK3kTBn41nhOc4pe6zDz4MIMk8 hV00lF7vi5VupVJYx5NUJzZpqjhydSagD1oCi8l/9ItkcEywO5SoibblZaL6GOJCwUDU dcfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=hRNEJYkXr+PwSGSW5oI3rp0CXIsPeHFtIOlhCAUsWYo=; b=WzN2w0N3juN+9PcztBTPFprJFM56mA3w/oJGQZqubynHKOQgZkLGBMBkfuktSlaXv5 X58rL91YIXayCGVZ2c5vYLPiRohkajdV3oAzbsaXs+bz6hTEvJVxjrv4UJrOiBc8jkgv c5jCAjzKsoQIa2+Z6pVSyt2dZoSZCAcn9IxxbPzrmhLOzFX0B6BPRZ0UMLV+pyiaq7kp YeT2SbX5v60MQOavN0yc/WNbiBdPsdQrPChMwd93dU8qCXmHf/gSfLJrjH1igqawYTLc DeO3t2dX+sFkY4eQ9j6luxQix8aWkET8ANuOAOPP2bGsuFcASqd8bQTiXJVwfbpvnCzp G11w== X-Gm-Message-State: AOAM532H+NOk0+pMzMkdKakmzRgisLjUwbaixTo3PoCLgXTWuN6wWyOx AEUqjuP3q+Mg9KCo+BBSm9o= X-Google-Smtp-Source: ABdhPJzmtpRHxuS6X84WUIbiaEuDt83WewKyJDe0iPuKShXYAJZWJN9IGS53x868g7pBjR4OsBHlkw== X-Received: by 2002:a05:6402:5209:b0:412:7cd8:a8fc with SMTP id s9-20020a056402520900b004127cd8a8fcmr23392496edd.51.1645478718822; Mon, 21 Feb 2022 13:25:18 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935aa6.dip0.t-ipconnect.de. [87.147.90.166]) by smtp.gmail.com with ESMTPSA id ho34sm1660725ejc.122.2022.02.21.13.25.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Feb 2022 13:25:18 -0800 (PST) Date: Mon, 21 Feb 2022 22:25:16 +0100 From: Philipp Hortmann To: Forest Bond , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 4/6] staging: vt6656: Change macro to function and moved to better file Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This patch fixes the checkpatch.pl warning like: - CHECK: Macro argument reuse 'uVar' - possible side-effects? Moved the only twice used function to the file where it is used. Signed-off-by: Philipp Hortmann Reviewed-by: Dan Carpenter --- V1 -> V2: Devided patch into three --- drivers/staging/vt6656/device.h | 7 ------- drivers/staging/vt6656/wcmd.c | 13 +++++++++++-- 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/staging/vt6656/device.h b/drivers/staging/vt6656/devic= e.h index 0ab2d60204e8..ca974d61d3f4 100644 --- a/drivers/staging/vt6656/device.h +++ b/drivers/staging/vt6656/device.h @@ -381,13 +381,6 @@ struct vnt_private { struct ieee80211_low_level_stats low_stats; }; =20 -#define ADD_ONE_WITH_WRAP_AROUND(var, modulo) { \ - if ((var) >=3D ((modulo) - 1)) \ - (var) =3D 0; \ - else \ - (var)++; \ -} - int vnt_init(struct vnt_private *priv); =20 #endif diff --git a/drivers/staging/vt6656/wcmd.c b/drivers/staging/vt6656/wcmd.c index e8ee2fbee76c..14b8aa587119 100644 --- a/drivers/staging/vt6656/wcmd.c +++ b/drivers/staging/vt6656/wcmd.c @@ -31,6 +31,15 @@ static void vnt_cmd_timer_wait(struct vnt_private *priv,= unsigned long msecs) schedule_delayed_work(&priv->run_command_work, msecs_to_jiffies(msecs)); } =20 +static u32 add_one_with_wrap_around(u32 var, u8 modulo) +{ + if (var >=3D (modulo - 1)) + var =3D 0; + else + var++; + return var; +} + static int vnt_cmd_complete(struct vnt_private *priv) { priv->command_state =3D WLAN_CMD_IDLE; @@ -42,7 +51,7 @@ static int vnt_cmd_complete(struct vnt_private *priv) =20 priv->command =3D priv->cmd_queue[priv->cmd_dequeue_idx]; =20 - ADD_ONE_WITH_WRAP_AROUND(priv->cmd_dequeue_idx, CMD_Q_SIZE); + priv->cmd_dequeue_idx =3D add_one_with_wrap_around(priv->cmd_dequeue_idx,= CMD_Q_SIZE); priv->free_cmd_queue++; priv->cmd_running =3D true; =20 @@ -157,7 +166,7 @@ int vnt_schedule_command(struct vnt_private *priv, enum= vnt_cmd command) =20 priv->cmd_queue[priv->cmd_enqueue_idx] =3D command; =20 - ADD_ONE_WITH_WRAP_AROUND(priv->cmd_enqueue_idx, CMD_Q_SIZE); + priv->cmd_enqueue_idx =3D add_one_with_wrap_around(priv->cmd_enqueue_idx,= CMD_Q_SIZE); priv->free_cmd_queue--; =20 if (!priv->cmd_running) --=20 2.25.1 From nobody Fri Jun 26 12:32:33 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87CF5C433F5 for ; Mon, 21 Feb 2022 21:25:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234899AbiBUVZx (ORCPT ); Mon, 21 Feb 2022 16:25:53 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:41372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234869AbiBUVZu (ORCPT ); Mon, 21 Feb 2022 16:25:50 -0500 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1B5C12763 for ; Mon, 21 Feb 2022 13:25:26 -0800 (PST) Received: by mail-ej1-x632.google.com with SMTP id r13so13415827ejd.5 for ; Mon, 21 Feb 2022 13:25:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=nVDTTWQgHFeL3Z4LBBVvYUyauggJWpdgcasV3J7UgOs=; b=KBwq2co572wFjFwOjkiuBKxrbk513P2a3q1cyMsPdcrqS6PsiDNt+uVR6I+wUY9hot hWnDpvPCMasCAnC/C4Sn7dkUE8h/3WeAxvW66DdxZxW3hJf1xeI/Yf3hECujD/yzPf/y jYzr1kIwUpD0qWMJIz55divIHmfuFW8CjoRtFoXoeP/aNIxFxRwezEbTqAyKquTw7XSi mOQ9EkWbyqjyGGDv/+QKz55Lr883LLq07zPnR8bKTRy7atB67i40hThv+LPMZQkOU14i +J6nQwXaJ0S+FXuAgYO0BMCnzP3roxImoFzPlAfDchd4JI73KUn4hFwqaHU0ZRJCSKnp i/qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nVDTTWQgHFeL3Z4LBBVvYUyauggJWpdgcasV3J7UgOs=; b=Rw9IY2n9L6yEOVNteFUglvzYrWirNb9emrSEMJUG5wsAqYiFYbGr2yPyzfU4Csd94T 0edAXYJQDCWi1AoAEkr01ZNb5opqUaUDD6ACIsgXZibrs6GIM8j49fPSO3p/dqq75P4Q N+QJh4yiUgpy8TPPwoQ1Y4KgI+3Joib3fyuw8A9ZjHNGHwKwWvrKj/hAMEi+4qepWFLi r4CAzvsy25l5sLpq672XmVb4IHBD9lqb/tHFCKnd17hkpuL+LF6QJ68SOotXdC1s2T9z Seg4CdVpjK/ld4pYZpha942F4fDU1D4/xdopIwBP1MfqwA5W6z6B1JGkrjCsVfib+MXb lEFw== X-Gm-Message-State: AOAM531WwyReRxWB5b7He74cw0v1ent8VCVnfjrKl/yItoYM1uCHDJIw w3QvvhX/HRqNVYF9Grl41f4= X-Google-Smtp-Source: ABdhPJzD96yGsJKvfZ8rYVMlWsj0ov6XbqTZOXDzvInq0ZEs5lzhYB+XiB5nQQDuhVo+vKa/sQhAJw== X-Received: by 2002:a17:907:205a:b0:6cf:ced7:4e73 with SMTP id pg26-20020a170907205a00b006cfced74e73mr17397238ejb.536.1645478725413; Mon, 21 Feb 2022 13:25:25 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935aa6.dip0.t-ipconnect.de. [87.147.90.166]) by smtp.gmail.com with ESMTPSA id 2sm5631226ejl.2.2022.02.21.13.25.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Feb 2022 13:25:25 -0800 (PST) Date: Mon, 21 Feb 2022 22:25:23 +0100 From: Philipp Hortmann To: Forest Bond , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 5/6] staging: vt6656: Remove ftrace-like logging Message-ID: <084064a5c94aad940600ae62d6c21bb26629cb2c.1645477326.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This patch fixes the checkpatch.pl warning like: WARNING: Unnecessary ftrace-like logging - prefer using ftrace Signed-off-by: Philipp Hortmann Reviewed-by: Dan Carpenter --- V1 -> V2: Devided patch into two --- drivers/staging/vt6656/rxtx.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c index a31947f2620d..5839b34b2e93 100644 --- a/drivers/staging/vt6656/rxtx.c +++ b/drivers/staging/vt6656/rxtx.c @@ -58,8 +58,6 @@ static struct vnt_usb_send_context struct vnt_usb_send_context *context =3D NULL; int ii; =20 - dev_dbg(&priv->usb->dev, "%s\n", __func__); - for (ii =3D 0; ii < priv->num_tx_context; ii++) { if (!priv->tx_context[ii]) return NULL; --=20 2.25.1 From nobody Fri Jun 26 12:32:33 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED7F7C433EF for ; Mon, 21 Feb 2022 21:25:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234908AbiBUV0A (ORCPT ); Mon, 21 Feb 2022 16:26:00 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:41502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234904AbiBUVZ5 (ORCPT ); Mon, 21 Feb 2022 16:25:57 -0500 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05D2812AF3 for ; Mon, 21 Feb 2022 13:25:33 -0800 (PST) Received: by mail-ej1-x630.google.com with SMTP id a8so36519780ejc.8 for ; Mon, 21 Feb 2022 13:25:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=I80ySfiXhu5cxVRWbKi4neSx3+uPEnbFkKrvK2nAmUk=; b=WwQ8r86FA3/GDA8Kgxf9cwrsnzEZ46xyJ/oY0OkCh0pFbs1ClcKC89/dpog+m/sDNt j7tdCQChDDBEXCglyTmMdL/BeBMTWo2EgmMc2BN4TgbxdIGZD+c4OfzlDkPTygaOfqCb MOMyBLp3D+W1ld2YzWlcGXntMWsmnqV81vG7VjSRMtDIW0am5o6GY0eny7g+uAKcW+Jm aCyZiJJe2yRb83i6OLbdVo/sf53d+Mm7j+phdvnO0C1gGZtcjlfasXtimww/omE2mgxL 9l4hLdBVVRdin8jq5zGeHp2sM9Dk/aGX8rzQtRyD3ivFftMyN7UQv1oUuLUvd/3k1uCq i84g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=I80ySfiXhu5cxVRWbKi4neSx3+uPEnbFkKrvK2nAmUk=; b=BLxPv2NvYr1XEoG5DwLW3ttfUDvElkSOvElWJMvvjitRXy5FZrZGyNwmDt/uD2zaLr 7PsKFV+WmdDmsyg5oRFLC4dlM5UqTZbbQ3e+MfT56DY77C2pJORSH9iD7vjdIDs80Kza n4fp89Dd6Yur/9vMW4YxF0yDXn2AgF8fAh868GEI4TQyV8G6yE7r46fZ2Uu8kivRY5+f bHTZcvVEoI/bgbTonPBCBeXxCGwl/Tk+NXcDQFVaLbh/c96eMdiCvm1Poq9BhsrqFdOD WXl0e/CoTIatm430+GuqUYsGZbtV4owwM5/R4NgvsNZoEMXteQ8UhIkOJ90XwyEmNAM0 1RpQ== X-Gm-Message-State: AOAM530rJDwRjkXpSB829CXjT28vpDwTsdKmgeMjcShRT+Yaoa+UhnU6 K7QpW3P8XgnQOuSp75DhGkA= X-Google-Smtp-Source: ABdhPJwHCYxW9Ia4ML0WjlgOFGuyUKpOSBtrvpuVVl3B7xYPpYxN8PM3EIOqKQde1vWpMQZVnFT18A== X-Received: by 2002:a17:906:c211:b0:6ce:e221:4c21 with SMTP id d17-20020a170906c21100b006cee2214c21mr16927813ejz.691.1645478731537; Mon, 21 Feb 2022 13:25:31 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935aa6.dip0.t-ipconnect.de. [87.147.90.166]) by smtp.gmail.com with ESMTPSA id d10sm5472313ejo.207.2022.02.21.13.25.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Feb 2022 13:25:31 -0800 (PST) Date: Mon, 21 Feb 2022 22:25:29 +0100 From: Philipp Hortmann To: Forest Bond , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 6/6] staging: vt6656: Remove unnecessary line breaks Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This patch fixes the checkpatch.pl warning like: CHECK: Lines should not end with a '(' Signed-off-by: Philipp Hortmann Reviewed-by: Dan Carpenter --- V1 -> V2: Devided patch into two --- drivers/staging/vt6656/rxtx.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c index 5839b34b2e93..4d29f8ebb393 100644 --- a/drivers/staging/vt6656/rxtx.c +++ b/drivers/staging/vt6656/rxtx.c @@ -353,10 +353,8 @@ static bool vnt_fill_txkey(struct vnt_tx_buffer *tx_bu= ffer, struct sk_buff *skb) ether_addr_copy(mic_hdr->addr2, hdr->addr2); ether_addr_copy(mic_hdr->addr3, hdr->addr3); =20 - mic_hdr->frame_control =3D cpu_to_le16( - le16_to_cpu(hdr->frame_control) & 0xc78f); - mic_hdr->seq_ctrl =3D cpu_to_le16( - le16_to_cpu(hdr->seq_ctrl) & 0xf); + mic_hdr->frame_control =3D cpu_to_le16(le16_to_cpu(hdr->frame_control) &= 0xc78f); + mic_hdr->seq_ctrl =3D cpu_to_le16(le16_to_cpu(hdr->seq_ctrl) & 0xf); =20 if (ieee80211_has_a4(hdr->frame_control)) ether_addr_copy(mic_hdr->addr4, hdr->addr4); --=20 2.25.1