iommu/vsi: Use list_for_each_entry()

[PATCH] iommu/vsi: Use list_for_each_entry()

Posted by Dan Carpenter 4 days, 18 hours ago

Smatch complains about the NULL check on "iommu" because list_entry()
can't be NULL.  Clean up this code by using list_for_each_entry().

Signed-off-by: Dan Carpenter <error27@gmail.com>
---
Untested, but it compiled on the first try (no typos!)

 drivers/iommu/vsi-iommu.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/drivers/iommu/vsi-iommu.c b/drivers/iommu/vsi-iommu.c
index 5d0721bd2c7a..9954ed414526 100644
--- a/drivers/iommu/vsi-iommu.c
+++ b/drivers/iommu/vsi-iommu.c
@@ -366,15 +366,9 @@ static int vsi_iommu_map_iova(struct vsi_iommu_domain *vsi_domain, u32 *pte_addr
 static void vsi_iommu_flush_tlb(struct iommu_domain *domain)
 {
 	struct vsi_iommu_domain *vsi_domain = to_vsi_domain(domain);
-	struct list_head *pos;
-
-	list_for_each(pos, &vsi_domain->iommus) {
-		struct vsi_iommu *iommu;
-
-		iommu = list_entry(pos, struct vsi_iommu, node);
-		if (!iommu)
-			continue;
+	struct vsi_iommu *iommu;
 
+	list_for_each_entry(iommu, &vsi_domain->iommus, node) {
 		if (pm_runtime_get(iommu->dev) < 0)
 			continue;
 
-- 
2.53.0

Re: [PATCH] iommu/vsi: Use list_for_each_entry()

Posted by Benjamin Gaignard 4 days, 11 hours ago

Le 20/05/2026 à 08:00, Dan Carpenter a écrit :
> Smatch complains about the NULL check on "iommu" because list_entry()
> can't be NULL.  Clean up this code by using list_for_each_entry().
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>

Reviewed-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>

> ---
> Untested, but it compiled on the first try (no typos!)
>
>   drivers/iommu/vsi-iommu.c | 10 ++--------
>   1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/iommu/vsi-iommu.c b/drivers/iommu/vsi-iommu.c
> index 5d0721bd2c7a..9954ed414526 100644
> --- a/drivers/iommu/vsi-iommu.c
> +++ b/drivers/iommu/vsi-iommu.c
> @@ -366,15 +366,9 @@ static int vsi_iommu_map_iova(struct vsi_iommu_domain *vsi_domain, u32 *pte_addr
>   static void vsi_iommu_flush_tlb(struct iommu_domain *domain)
>   {
>   	struct vsi_iommu_domain *vsi_domain = to_vsi_domain(domain);
> -	struct list_head *pos;
> -
> -	list_for_each(pos, &vsi_domain->iommus) {
> -		struct vsi_iommu *iommu;
> -
> -		iommu = list_entry(pos, struct vsi_iommu, node);
> -		if (!iommu)
> -			continue;
> +	struct vsi_iommu *iommu;
>   
> +	list_for_each_entry(iommu, &vsi_domain->iommus, node) {
>   		if (pm_runtime_get(iommu->dev) < 0)
>   			continue;
>