From nobody Mon May 25 01:15:08 2026 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F17F42E9ED6 for ; Wed, 20 May 2026 06:00:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779256830; cv=none; b=COWcWykF/qpmMe/9AFWBm/WIdlHeJoimcJdXyEL2pIL2usYAiuy9bmiVL+4pECSIz9cksbFN0dVobL7M6u9Rq8mYNCn9rk1LhOW+JIR7WnkbrrLYAU08xJHpnWDNgA0YuQBO3ger4meiZt8nsWXyqqZu/3Qwbvz2gHkcsERWFGU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779256830; c=relaxed/simple; bh=ehA4ttutELSmlyGVel+w9zKQl/Ae6wxB/zvQoA5zHg4=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=LtdKJXzobgiOdpMC1lCsxBwQkInke2u1LUSKtUsQKykSE67oPtGe0ghfllHGJqZUzDwsLUGI7kswyKuOLlWueYVDMlZ0fJj0RXVyzPM6yEIePtVLUEsknm7xZamcpeMCrt3mc4Z3BxVFvinoFjVgYaXo5Sf48nuedbSgXqhid68= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RO1eSLOM; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RO1eSLOM" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-448528f4e69so2954190f8f.3 for ; Tue, 19 May 2026 23:00:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779256827; x=1779861627; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=S4BraLHhw1khrduXE2WhX+9/5GdBOzVf9xcCtOVB8Kk=; b=RO1eSLOMCxZFQ+rXdpPPfUaLJCdpMx53y+G14zsebdyPXPwwQSk+ubATRtxsCjsf4o b+F93p/cWGn/vMf1HYrz93ieF8+w3Mc+8+dMBSzzmwEC/213KamKaGDo6baui0M5MHAo G7nnlDYnf0stqDOkKCoJqPzVoq4g/hFk4pYonhDj5bA73YLF7fZqODJOnFzn2Gx+1lUS KXI7rqQzIyu7c9QON+7vbot0/vuD6QEcQ69zReb7MawT1+eg4RORoArY6xWxkIvyk01W 64s8qieO4l44aRzhJ3F/VSvoIQZ5mjmWeYmTkhtLPp+KFGBctYgpTYwavyt6KQwAOyAZ zUhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779256827; x=1779861627; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=S4BraLHhw1khrduXE2WhX+9/5GdBOzVf9xcCtOVB8Kk=; b=cBNjOViu92oVRMxX8ZXmpIVrSZsoYwIx66MTXZE35fctxRpDqT7T9MftsyiuQb70lK zMqJEj1h8lo9xaUCVKamEwdnyszrQkYWwC/Kc2Q/2+MUlUA2KdqMhManRU3dm9PI2XRc mNUDYZRvOEO+FQpj+HW15EqBNLAcvyssxEaizyMmRDNrl5xPsVLFf/8OB6EuGd1sBese Z1U6mItLRfSsBRuF2QQvm0nNvF+L5/D7Z/LKMAS8b0kGUpWh3T81iiDZVOL3A7mZ3mLe GiisNkDfiwqg2IwEIcCMz3B6tJ+ldgv/65ScWCnHVd3Tk/ra3t6tLhFU/M2vt8dOcioh xysQ== X-Forwarded-Encrypted: i=1; AFNElJ/JbkUIai8Q0zlVI2SkZXWKadm9WuOS+ww2zT3Q3id03cZaJNXGRJp29EVz7/xWgdJd6/MkQqvF5w9zfsk=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7xZ/b/Bk+0VmmI0ghvyjI8JeScHXq4RXuEg9dMWW880euTaMT ymDJt4RTDjD7yIAx4aXr0zMAZu3renv/cqYg8aIUKJvMZ6yQw8/yQGXs X-Gm-Gg: Acq92OH6VD/LMV7gFWcB1+1XD8dY4YnPaQVsZdEN5LcovGBtbYfssmVT9F8Wh+aOkOV FvnJwwYQ3xCOglqT+k7B6AiXtUf7cS7Risx+7VPP1J93QLzpQ5XLFeB5GDUsRPpFFnqZF4pQWXC z/7Irjlpr9UU5RmJluGUM1aeRuML73wHOcEr8vMAzS1qeK7BFO3TuVqirfByDxXrhC6PNzgby30 jEnGgOei/pwWqgijnyNOzYR5ePhJTM6F4LW/QMVG88B7CCSqjG9XUaEzsgHS+Zr7mGGfoVllnsE JbwuHPdrfxTK/PdkLrmge/DuUBbaj101PYxtT8BICEj0gEUNsyZTmD+dhbbz4RFDV/1mpcrcZHR 7FQPc3H490rWcKdydxlf4T4CJ+HWDn47sqIlklnNm6TUo91JIKG19Si1a9AuoP/d2MC8Rec2uNq ebZOt4qm6cX5S9YP475163Dj0= X-Received: by 2002:a05:6000:4205:b0:44f:9b70:2996 with SMTP id ffacd0b85a97d-45e5c5bfba8mr35320532f8f.21.1779256827186; Tue, 19 May 2026 23:00:27 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da15a562dsm52007643f8f.33.2026.05.19.23.00.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 23:00:26 -0700 (PDT) Date: Wed, 20 May 2026 09:00:23 +0300 From: Dan Carpenter To: Benjamin Gaignard Cc: Joerg Roedel , Will Deacon , Robin Murphy , iommu@lists.linux.dev, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] iommu/vsi: Use list_for_each_entry() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Smatch complains about the NULL check on "iommu" because list_entry() can't be NULL. Clean up this code by using list_for_each_entry(). Signed-off-by: Dan Carpenter Reviewed-by: Benjamin Gaignard --- Untested, but it compiled on the first try (no typos!) drivers/iommu/vsi-iommu.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/iommu/vsi-iommu.c b/drivers/iommu/vsi-iommu.c index 5d0721bd2c7a..9954ed414526 100644 --- a/drivers/iommu/vsi-iommu.c +++ b/drivers/iommu/vsi-iommu.c @@ -366,15 +366,9 @@ static int vsi_iommu_map_iova(struct vsi_iommu_domain = *vsi_domain, u32 *pte_addr static void vsi_iommu_flush_tlb(struct iommu_domain *domain) { struct vsi_iommu_domain *vsi_domain =3D to_vsi_domain(domain); - struct list_head *pos; - - list_for_each(pos, &vsi_domain->iommus) { - struct vsi_iommu *iommu; - - iommu =3D list_entry(pos, struct vsi_iommu, node); - if (!iommu) - continue; + struct vsi_iommu *iommu; =20 + list_for_each_entry(iommu, &vsi_domain->iommus, node) { if (pm_runtime_get(iommu->dev) < 0) continue; =20 --=20 2.53.0