PCI: sky1: Fix error codes in sky1_pcie_resource_get()

[PATCH next] PCI: sky1: Fix error codes in sky1_pcie_resource_get()

Posted by Dan Carpenter 1 week, 3 days ago

Return negative -ENODEV instead of positive ENODEV.

Fixes: 25b3feb70d64 ("PCI: sky1: Add PCIe host support for CIX Sky1")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 drivers/pci/controller/cadence/pci-sky1.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/controller/cadence/pci-sky1.c b/drivers/pci/controller/cadence/pci-sky1.c
index 99a1f3fae1b3..d8c216dc120d 100644
--- a/drivers/pci/controller/cadence/pci-sky1.c
+++ b/drivers/pci/controller/cadence/pci-sky1.c
@@ -65,7 +65,7 @@ static int sky1_pcie_resource_get(struct platform_device *pdev,
 
 	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "cfg");
 	if (!res)
-		return dev_err_probe(dev, ENODEV, "unable to get \"cfg\" resource\n");
+		return dev_err_probe(dev, -ENODEV, "unable to get \"cfg\" resource\n");
 	pcie->cfg_res = res;
 
 	base = devm_platform_ioremap_resource_byname(pdev, "rcsu_strap");
@@ -82,7 +82,7 @@ static int sky1_pcie_resource_get(struct platform_device *pdev,
 
 	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "msg");
 	if (!res)
-		return dev_err_probe(dev, ENODEV, "unable to get \"msg\" resource\n");
+		return dev_err_probe(dev, -ENODEV, "unable to get \"msg\" resource\n");
 	pcie->msg_res = res;
 	pcie->msg_base = devm_ioremap_resource(dev, res);
 	if (IS_ERR(pcie->msg_base)) {
-- 
2.51.0

Re: [PATCH next] PCI: sky1: Fix error codes in sky1_pcie_resource_get()

Posted by Bjorn Helgaas 1 week ago

On Fri, Nov 21, 2025 at 04:35:35PM +0300, Dan Carpenter wrote:
> Return negative -ENODEV instead of positive ENODEV.
> 
> Fixes: 25b3feb70d64 ("PCI: sky1: Add PCIe host support for CIX Sky1")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>

Squashed into the commit, thanks!

> ---
>  drivers/pci/controller/cadence/pci-sky1.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/controller/cadence/pci-sky1.c b/drivers/pci/controller/cadence/pci-sky1.c
> index 99a1f3fae1b3..d8c216dc120d 100644
> --- a/drivers/pci/controller/cadence/pci-sky1.c
> +++ b/drivers/pci/controller/cadence/pci-sky1.c
> @@ -65,7 +65,7 @@ static int sky1_pcie_resource_get(struct platform_device *pdev,
>  
>  	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "cfg");
>  	if (!res)
> -		return dev_err_probe(dev, ENODEV, "unable to get \"cfg\" resource\n");
> +		return dev_err_probe(dev, -ENODEV, "unable to get \"cfg\" resource\n");
>  	pcie->cfg_res = res;
>  
>  	base = devm_platform_ioremap_resource_byname(pdev, "rcsu_strap");
> @@ -82,7 +82,7 @@ static int sky1_pcie_resource_get(struct platform_device *pdev,
>  
>  	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "msg");
>  	if (!res)
> -		return dev_err_probe(dev, ENODEV, "unable to get \"msg\" resource\n");
> +		return dev_err_probe(dev, -ENODEV, "unable to get \"msg\" resource\n");
>  	pcie->msg_res = res;
>  	pcie->msg_base = devm_ioremap_resource(dev, res);
>  	if (IS_ERR(pcie->msg_base)) {
> -- 
> 2.51.0
>