From nobody Tue Dec 2 01:31:58 2025 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E5AB34CFA0 for ; Fri, 21 Nov 2025 13:35:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763732142; cv=none; b=LO8MsXx1vUaZUx/n4F6XWxX9HwZvk66ASitmK7tOU6+Vjt7ZkQtcarJOSahNZAliVtpmVxd7WkpXUFkJxIakecyC0nyiDLpOW5kqmJ5sy/K4VT6pmsVmikIHetbxEt0aHjpNPRCkBiAM4Td3vw00IAd1tTG8ge2MtBca78PnHpw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763732142; c=relaxed/simple; bh=drNEbA3TGFTz25pvYcWW3qcdRYeCRjiFF+YwTp5NrEg=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=K91gaQVneiGMLiZ73aA4mjoNpbZE+0UTBrz2rl+q4yWEmJZ8vdShdXA2XGML9dCAXjqcjRmiASh/YfhfUm1+29h7Gl4yNVD3uRLTwfpKGIxRHCkDaxguv8fcKaUyvjlhx7JB6rOtHO2FvArOp5WhnBAlsdxpo8qPLfQZL9IxkQU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=bgza6aNi; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bgza6aNi" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-42b379cd896so1207912f8f.3 for ; Fri, 21 Nov 2025 05:35:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763732139; x=1764336939; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=qf7aj+yc10CQJFCUa9U/IQT8bJQVst3NQGAAJzT7Ug8=; b=bgza6aNiKjTKHTmhAnHTBMa7gight++KoqJE4Mn2VeUMqsbsDSilaTiXltJJ6MjTkF gxlLecbECbo4+NiMcX9SWoRrD+XtwrJBPYpzaQOthC357sYCUKRClqaRXl7wWIHO88Gl zBgdNd/WplYLS4XsK7mbWCG3yDIrcinAksWIMZCKGQuaUrdjUmlVd349i5qyt7t0P7zH gDYoqFBeJTrFSZI1g566VXxanzbgn8h7wWI/uiz1TrXMZv8EoFlsRoGZG3lTF59zz43s 8qiSmMwXll3XGXEAlz4YIxtpd1c85d19yCGxgKC5oD9cWSTrZ1sfG0+fgoyxOzHJOftY EOCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763732139; x=1764336939; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qf7aj+yc10CQJFCUa9U/IQT8bJQVst3NQGAAJzT7Ug8=; b=vYrSArm25XeTvA04viNIhhWnYWoiwdbqKseo/lDpDQA3Dyy74GOWqSk/Zw1G++hhJW CHM/SBQ++Dh84MqJ7S0VRGafdYq7feg6Med557hFcOTWfJF4R7ZJTKVahschtbR7RiYf BKxnDU5u85LpfksS79hymzSCCTxmQfe5af5COYppUdjKi7zAHALG5jOFFCCjSe0h+13l K1ZyBcaxiCcgWDy1GRMb5z+tAF5XvIj6NGQu+K4qyJ8MM7Qz+QJMIL44LkFOFfCqsmtt oqKYtqO6YVILMCKbSJp8slZJHkeUwDG2OcN+mmW7o1NBp3e7D4/1T5q0yjU1XlbBq1/q h70w== X-Forwarded-Encrypted: i=1; AJvYcCUB4TKB/DFanczS3J7nQy6yqoNUrSQA5oCZGyN/zgqnedfJb03vVPDuYvRhbziIyMQS7J2HOgQ9cykgrMc=@vger.kernel.org X-Gm-Message-State: AOJu0YwnxdmTuv7JDzRRHdrvbNP7g5+OwY7WXCEjGo45IzbT/j2jwpun FyKeh/bjJ4IZqv0GEbQaZUAYBxn+fbe+dqkkFqn4GG7rR6SdpeAPDMLoAemWl7iskJ8= X-Gm-Gg: ASbGncs/kjVPNWN1/2peCP5sK8F6KDsmKjRJz0SGCIU+neYayoZgnyCiKQY2agTIw4Q sYxf35IsxuS9GwBNpByvijKFHGY/h5gnLsBzTL/hD+YNBQcMgaXQIBoMTlEgXG+kCpdD0pnwQTc DymV3NwLwdeMR3/epjbsuz983vhgwbHw+W9hO0Yu24Wq5ZayedJImUx4lEhh7WkEnraYZx6foF8 8Yw2gzx8fz7nJ0mWFjMhhk/tbCjEiSBO1r7LAEjbGGq6tF05idrGWWa1fI2JOHCmrBbDjFqiCF2 lGU5NcqGnPsN2YUe0H+xD+K+B14u+yM7m+GchsPvs5UkrDHAwRFqjo6Jx5/XnEyDJm5pdBem16I Prd/eq0+WmcwE0c3I10oGcsu7VW60+Y9jJObt4t7z8egQVdGRLsahuXwYyRnf+dlTxe3DJdnOC2 iIXYXZXAanREt96pQT X-Google-Smtp-Source: AGHT+IFMJQ1wANIBmqRUOFCIS/jFxvbxo35wZufea9yE3HbGd15lQ3zQbTa6IMYdQDLdKJljttL+tg== X-Received: by 2002:a05:6000:4012:b0:428:5673:11e0 with SMTP id ffacd0b85a97d-42cc1d1999dmr2595402f8f.40.1763732138738; Fri, 21 Nov 2025 05:35:38 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-42cb7fa41d2sm10902508f8f.22.2025.11.21.05.35.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Nov 2025 05:35:38 -0800 (PST) Date: Fri, 21 Nov 2025 16:35:35 +0300 From: Dan Carpenter To: Hans Zhang Cc: Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH next] PCI: sky1: Fix error codes in sky1_pcie_resource_get() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Return negative -ENODEV instead of positive ENODEV. Fixes: 25b3feb70d64 ("PCI: sky1: Add PCIe host support for CIX Sky1") Signed-off-by: Dan Carpenter --- drivers/pci/controller/cadence/pci-sky1.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pci/controller/cadence/pci-sky1.c b/drivers/pci/contro= ller/cadence/pci-sky1.c index 99a1f3fae1b3..d8c216dc120d 100644 --- a/drivers/pci/controller/cadence/pci-sky1.c +++ b/drivers/pci/controller/cadence/pci-sky1.c @@ -65,7 +65,7 @@ static int sky1_pcie_resource_get(struct platform_device = *pdev, =20 res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, "cfg"); if (!res) - return dev_err_probe(dev, ENODEV, "unable to get \"cfg\" resource\n"); + return dev_err_probe(dev, -ENODEV, "unable to get \"cfg\" resource\n"); pcie->cfg_res =3D res; =20 base =3D devm_platform_ioremap_resource_byname(pdev, "rcsu_strap"); @@ -82,7 +82,7 @@ static int sky1_pcie_resource_get(struct platform_device = *pdev, =20 res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, "msg"); if (!res) - return dev_err_probe(dev, ENODEV, "unable to get \"msg\" resource\n"); + return dev_err_probe(dev, -ENODEV, "unable to get \"msg\" resource\n"); pcie->msg_res =3D res; pcie->msg_base =3D devm_ioremap_resource(dev, res); if (IS_ERR(pcie->msg_base)) { --=20 2.51.0