crypto: qat/qat_6xxx - Fix NULL vs IS_ERR() check in adf_probe()

[PATCH next] crypto: qat/qat_6xxx - Fix NULL vs IS_ERR() check in adf_probe()

Posted by Dan Carpenter 7 months, 1 week ago

The pcim_iomap_region() returns error pointers.  It doesn't return NULL
pointers.  Update the check to match.

Fixes: 17fd7514ae68 ("crypto: qat - add qat_6xxx driver")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 drivers/crypto/intel/qat/qat_6xxx/adf_drv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/intel/qat/qat_6xxx/adf_drv.c b/drivers/crypto/intel/qat/qat_6xxx/adf_drv.c
index 2531c337e0dd..132e26501621 100644
--- a/drivers/crypto/intel/qat/qat_6xxx/adf_drv.c
+++ b/drivers/crypto/intel/qat/qat_6xxx/adf_drv.c
@@ -156,8 +156,8 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 
 		/* Map 64-bit PCIe BAR */
 		bar->virt_addr = pcim_iomap_region(pdev, bar_map[i], pci_name(pdev));
-		if (!bar->virt_addr) {
-			ret = -ENOMEM;
+		if (IS_ERR(bar->virt_addr)) {
+			ret = PTR_ERR(bar->virt_addr);
 			return dev_err_probe(dev, ret, "Failed to ioremap PCI region.\n");
 		}
 	}
-- 
2.47.2

Re: [PATCH next] crypto: qat/qat_6xxx - Fix NULL vs IS_ERR() check in adf_probe()

Posted by Herbert Xu 7 months ago

On Thu, May 08, 2025 at 09:26:25AM +0300, Dan Carpenter wrote:
> The pcim_iomap_region() returns error pointers.  It doesn't return NULL
> pointers.  Update the check to match.
> 
> Fixes: 17fd7514ae68 ("crypto: qat - add qat_6xxx driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
>  drivers/crypto/intel/qat/qat_6xxx/adf_drv.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH next] crypto: qat/qat_6xxx - Fix NULL vs IS_ERR() check in adf_probe()

Posted by Cabiddu, Giovanni 7 months, 1 week ago

Thanks Dan.

On Thu, May 08, 2025 at 09:26:25AM +0300, Dan Carpenter wrote:
> The pcim_iomap_region() returns error pointers.  It doesn't return NULL
> pointers.  Update the check to match.
> 
> Fixes: 17fd7514ae68 ("crypto: qat - add qat_6xxx driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
Acked-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>