From nobody Thu Dec 18 03:21:13 2025 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 917FA1EE03D for ; Thu, 8 May 2025 06:26:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746685592; cv=none; b=gH5sIJ4gGebGje5uz+pTi/k40/b/FcK3JFIK7zq8aalw0k0IqvRuzSQQ+V8uKuuvlPceLS75O385H+dt/vX52w6i9pV7akIVSoI/HITI3/ajX97rNPIRnVMy4a2xgsV0QmSmKCot8mHtzaaAqOibqr2XphiiSUECRsh4ZTmJthc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746685592; c=relaxed/simple; bh=RDPgm5xhma7QFLB18+5pqsvzgjikpNdaONSF0MiESTo=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=UwiJ+Vb2KfWCBdzOC4Zr6S7qCHsrRN5TV6sFMwIfOTRQIyJNymnTn7sJXwXAYtqAD9XYqAtB/A6W/5AzQfr2AtKxMjie9vXWkMmrxhv0O731u23fAFY8E1t5ibXOaG3o5KVk1Ai5gIJLemgGELQiVZx8dim9ybqPYiQKvWjoQEY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=fnS3IeSp; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fnS3IeSp" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-3a0b6aa08e5so923818f8f.1 for ; Wed, 07 May 2025 23:26:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746685589; x=1747290389; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=vrj9ukkKygc1G8rKTTqLX2onZSR0aOFlnCDnYrntq9Q=; b=fnS3IeSprMBvRYeEMrUA2d8rKUtOZPD13FDaKWxGfIhU0WsZJvvVdKDKQMf5+7e1t5 v206AGlMvxUm1T6Bq4Hf1SxlVefN01MJn3cmlFpGswzHy4PsPxeTo3UXlQUARs56Q3nb OkA223MdQu1harumoYixuEKA/lywl0gWJ6fn8JfhBiZTRmMrqMMy8mRBflCnZeuIP8rs noPQ0JBL0wTO7hbvdVyDo+VfAVwkxwA0/+2O5V2oiD1zIyQ1nDZo/uv0FYhwpnFLBxKE 87M4bZgooqdYCK4kK1L17GSuoucVq7LSHeeV5KZq7oFG2xCaKeT/4qHtXKLIn54QOxr2 CApQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746685589; x=1747290389; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vrj9ukkKygc1G8rKTTqLX2onZSR0aOFlnCDnYrntq9Q=; b=DmwL/0+l1da7isCWKyyzR6wgO1/HWb7LRRJ0fhO4TJq2zXsJFXDzywIoIy2pqgltJp mE0h+7SopRJejYLrAPPIhfgc3yjSgraqvdzcnDTIZ8Lk+f8Vu9hGz2GMx0tuNUCKHwKe 335bdhH21/3WCIY35xRi2h4mNmfDlG1CwydudD58CW9W+13YzEAM8JuuK3DkNFX8/Rz7 z/SnvdNSTQ4EtDaStiKLb72KHkKVWflFQr7PwBxiVb8GR92UVtS/0okznL6ITRcnTrWJ Gj6JrX8j2s7vILMdG5WUzSMJE3jK/ht9Bte5LjAc+Bsd1241KLWnUlQJ6ZLx5ai5SjhG 2VBQ== X-Forwarded-Encrypted: i=1; AJvYcCWrzNV/t6k6D6aRopaJN+9obsYwjCpvAPMRx6iU5HpXY3a3DtrKhVC9dcJYFowJPpoXQ5Pk0OWhXyQW0RA=@vger.kernel.org X-Gm-Message-State: AOJu0YwtraPdMkbHPZ5T+ljFi8DyKIYvIfrmk2yVojCauQsRKH0fZ8jd sbRdemrgv0z+mAP59KW6UQ9+s2a8kVQLZrmGMpJRxEADjQSzpzWST1W4CJQgpdg= X-Gm-Gg: ASbGncuJpjGg/8FXiKO5f6yJX12t1aWTe0o484UzlbEaUKMLhQ8aegqPlsvC1cmOD+B /kdTXB7YVkS/vXXtK3y+LfdUmmJlv/y4p+yTqxaFPGmp4jfIEQxAOXenSjLb06dbpKLMu4v+1k4 tmQms1Dj+QGCBoKsfihX9LC8KDdJg+AoCqP/W0W8pQPfuNTHRxiFN006pWneXBUBz4azovf9OMF sM1NLFOyDbIwxF/kQRv0N1j+gqU1sTztwncfUHiAmB1pvjhZQgLrIXoeyMVHswjR3F48ZzvU2Rn VHyXIxtog5Ug/LQqu23tY6PBqYEDU6F/7vJn7C4rgC60lw== X-Google-Smtp-Source: AGHT+IFAMx7JUFXY3xA7TDuVFEdfH0Qfm/mO3IujmuFv9MragYBfI8mgTfu7zRm8OHQ8pIMC9sOyhA== X-Received: by 2002:a5d:64ed:0:b0:3a0:b138:4810 with SMTP id ffacd0b85a97d-3a0b99171ecmr1632328f8f.17.1746685588890; Wed, 07 May 2025 23:26:28 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3a099b178absm19380008f8f.97.2025.05.07.23.26.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 May 2025 23:26:28 -0700 (PDT) Date: Thu, 8 May 2025 09:26:25 +0300 From: Dan Carpenter To: Laurent M Coquerel Cc: Giovanni Cabiddu , Herbert Xu , "David S. Miller" , George Abraham P , Suman Kumar Chakraborty , Karthikeyan Gopal , qat-linux@intel.com, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH next] crypto: qat/qat_6xxx - Fix NULL vs IS_ERR() check in adf_probe() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The pcim_iomap_region() returns error pointers. It doesn't return NULL pointers. Update the check to match. Fixes: 17fd7514ae68 ("crypto: qat - add qat_6xxx driver") Signed-off-by: Dan Carpenter Acked-by: Giovanni Cabiddu --- drivers/crypto/intel/qat/qat_6xxx/adf_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/intel/qat/qat_6xxx/adf_drv.c b/drivers/crypto/i= ntel/qat/qat_6xxx/adf_drv.c index 2531c337e0dd..132e26501621 100644 --- a/drivers/crypto/intel/qat/qat_6xxx/adf_drv.c +++ b/drivers/crypto/intel/qat/qat_6xxx/adf_drv.c @@ -156,8 +156,8 @@ static int adf_probe(struct pci_dev *pdev, const struct= pci_device_id *ent) =20 /* Map 64-bit PCIe BAR */ bar->virt_addr =3D pcim_iomap_region(pdev, bar_map[i], pci_name(pdev)); - if (!bar->virt_addr) { - ret =3D -ENOMEM; + if (IS_ERR(bar->virt_addr)) { + ret =3D PTR_ERR(bar->virt_addr); return dev_err_probe(dev, ret, "Failed to ioremap PCI region.\n"); } } --=20 2.47.2