[PATCH v2 0/5] fs/ntfs3: Fix and rename hidedotfiles mount option

Daniel Pinto posted 5 patches 3 years, 5 months ago
Documentation/filesystems/ntfs3.rst | 6 ++++++
fs/ntfs3/frecord.c                  | 9 +++++++++
fs/ntfs3/inode.c                    | 2 +-
fs/ntfs3/super.c                    | 6 ++++--
4 files changed, 20 insertions(+), 3 deletions(-)
[PATCH v2 0/5] fs/ntfs3: Fix and rename hidedotfiles mount option
Posted by Daniel Pinto 3 years, 5 months ago
Changes v1->v2:
- Add documentation for hidedotfiles mount option.

The current implementation of the hidedotfiles has some problems, namely:
- there is a bug where enabling it actually disables it and vice versa
- it only works when creating files, not when moving or renaming them
- it is not listed in the enabled options list by the mount command
- its name differs from the equivalent hide_dot_files mount option
  used by NTFS-3G, making it incompatible with it for no reason

This series of patches tries to fix those problems.

Daniel Pinto (5):
  fs/ntfs3: fix hidedotfiles mount option by reversing behaviour
  fs/ntfs3: make hidedotfiles mount option work when renaming files
  fs/ntfs3: add hidedotfiles to the list of enabled mount options
  fs/ntfs3: document the hidedotfiles mount option
  fs/ntfs3: rename hidedotfiles mount option to hide_dot_files

 Documentation/filesystems/ntfs3.rst | 6 ++++++
 fs/ntfs3/frecord.c                  | 9 +++++++++
 fs/ntfs3/inode.c                    | 2 +-
 fs/ntfs3/super.c                    | 6 ++++--
 4 files changed, 20 insertions(+), 3 deletions(-)
Re: [PATCH v2 0/5] fs/ntfs3: Fix and rename hidedotfiles mount option
Posted by Konstantin Komarov 3 years, 4 months ago

On 10/10/22 14:27, Daniel Pinto wrote:
> Changes v1->v2:
> - Add documentation for hidedotfiles mount option.
> 
> The current implementation of the hidedotfiles has some problems, namely:
> - there is a bug where enabling it actually disables it and vice versa
> - it only works when creating files, not when moving or renaming them
> - it is not listed in the enabled options list by the mount command
> - its name differs from the equivalent hide_dot_files mount option
>    used by NTFS-3G, making it incompatible with it for no reason
> 
> This series of patches tries to fix those problems.
> 
> Daniel Pinto (5):
>    fs/ntfs3: fix hidedotfiles mount option by reversing behaviour
>    fs/ntfs3: make hidedotfiles mount option work when renaming files
>    fs/ntfs3: add hidedotfiles to the list of enabled mount options
>    fs/ntfs3: document the hidedotfiles mount option
>    fs/ntfs3: rename hidedotfiles mount option to hide_dot_files
> 
>   Documentation/filesystems/ntfs3.rst | 6 ++++++
>   fs/ntfs3/frecord.c                  | 9 +++++++++
>   fs/ntfs3/inode.c                    | 2 +-
>   fs/ntfs3/super.c                    | 6 ++++--
>   4 files changed, 20 insertions(+), 3 deletions(-)

Good catch with differences between NTFS-3G and ntfs3.
Applied, thanks!