From nobody Mon Apr 6 22:49:38 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 977FCC4332F for ; Mon, 10 Oct 2022 11:30:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232080AbiJJLad (ORCPT ); Mon, 10 Oct 2022 07:30:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231400AbiJJLaU (ORCPT ); Mon, 10 Oct 2022 07:30:20 -0400 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 349B55141F; Mon, 10 Oct 2022 04:30:17 -0700 (PDT) Received: by mail-wm1-x335.google.com with SMTP id bg9-20020a05600c3c8900b003bf249616b0so6213450wmb.3; Mon, 10 Oct 2022 04:30:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=K3gXHoOtP/G7cPHnJm5sliNg7u+93Tq1/waVlo7q5Aw=; b=Dc2nT/4q8/jBUtQ7KRFrVaRYynz7726UdERw2EVrft35KrVuLTb7nmRSMT8vSSO+0r WvZEzNZUg7yVN9JxcxHbahdTc3OVbtvsQM3OuvdXpC2zXIPZJW8MibYM79tnGacCUh/h 7Key3Bbpt8SVl9iwM3aFWGrDBcRRMOH3sOP1NkH1zLNWa1h+4YSro/BoBW+/JWDE5f/G Y3dyaUck1t05h/fAKhiO8YXgwSpEbumBxWY7aQ2C6YWY+nex5rqsUrGnJdY2fo+HC6zd d/E+rGpVFGHE9C+B7PHpunITjgA3qIfup5hP028D9qDgCRbAt+y7G8ewp6ZHnl20xs77 S7jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=K3gXHoOtP/G7cPHnJm5sliNg7u+93Tq1/waVlo7q5Aw=; b=Iz/7UoE1PgjY8YVkc+Di8r57X6YfF5O7QQJWl8IBJTnjsxB/O3BDj1SsTJ/VAyMp4M t6Ejcl9yydI7Wat36rOq0V8kKksIcISdV/9j2ACseKZAhusgI+990Xo55irbt+Klhxll 4bXZAKIH3lJ0zODZVKcDLAlrOSf2MA4yZsGB/J6VvTgqgam2mPvih+QlnzphiEPQqM78 VHe1bCkSMLyPA/NlNEestrFo0KfeDGSovzGBRfEk5KP//ViXl52M/oHygNWDPgNNcbtO +Oo6nsbmOAtduCxMZ+stQi+Z2j5IqUTAe0Ml1OcfbmcnkpP1zygQiTfkGd05unZknUFi yYoA== X-Gm-Message-State: ACrzQf2ebSK5SRSICK0BLdZ1fQfxypafha6qFT/QLzZQk7ZCxFk04DAQ zCvL8TpTaVNbuBEHp1ErxXg= X-Google-Smtp-Source: AMsMyM7tOmkCJQGYoo8JZxnb/78cJD3WnQS0D3xmyynREYxFhKOPx4l/iKu4rWoyju7dzol8rwaPGQ== X-Received: by 2002:a05:600c:221a:b0:3b4:75b8:3f7f with SMTP id z26-20020a05600c221a00b003b475b83f7fmr11998187wml.175.1665401416375; Mon, 10 Oct 2022 04:30:16 -0700 (PDT) Received: from [192.168.42.102] (sm4-84-91-228-85.netvisao.pt. [84.91.228.85]) by smtp.gmail.com with ESMTPSA id t128-20020a1c4686000000b003b4a699ce8esm7713297wma.6.2022.10.10.04.30.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Oct 2022 04:30:16 -0700 (PDT) Message-ID: <51c60bcf-82a0-efbf-438d-4925c905503e@gmail.com> Date: Mon, 10 Oct 2022 12:30:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: [PATCH v2 1/5] fs/ntfs3: fix hidedotfiles mount option by reversing behaviour Content-Language: pt-PT From: Daniel Pinto To: Konstantin Komarov , ntfs3@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org References: <9c404576-856b-6935-f2e3-c4d0749f16ea@gmail.com> In-Reply-To: <9c404576-856b-6935-f2e3-c4d0749f16ea@gmail.com> Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Currently, the hidedotfiles mount option is behaving in the reverse way of what would be expected: enabling it disables setting the hidden attribute on files or directories with names starting with a dot and disabling it enables the setting. Reverse the behaviour of the hidedotfiles mount option so it matches what is expected. Signed-off-by: Daniel Pinto --- fs/ntfs3/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c index 1e2c04e48f98..c6fd2afde172 100644 --- a/fs/ntfs3/super.c +++ b/fs/ntfs3/super.c @@ -359,7 +359,7 @@ static int ntfs_fs_parse_param(struct fs_context *fc, opts->nohidden =3D result.negated ? 1 : 0; break; case Opt_hide_dot_files: - opts->hide_dot_files =3D result.negated ? 1 : 0; + opts->hide_dot_files =3D result.negated ? 0 : 1; break; case Opt_acl: if (!result.negated) From nobody Mon Apr 6 22:49:38 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 951ACC433FE for ; Mon, 10 Oct 2022 11:32:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232141AbiJJLch (ORCPT ); Mon, 10 Oct 2022 07:32:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232129AbiJJLcU (ORCPT ); Mon, 10 Oct 2022 07:32:20 -0400 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34E7C58159; Mon, 10 Oct 2022 04:32:15 -0700 (PDT) Received: by mail-wr1-x431.google.com with SMTP id a10so16535173wrm.12; Mon, 10 Oct 2022 04:32:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CGcpwMtrr4F0Rl9cO3XqszINhBjZp294W8XfrrtEik8=; b=Czw7WsXz6I0DhvuBx8oLZnLaTVnNrk2eYPyEIj8Jx9mSUWqqoc1uwvuJbhH67iKcKz NtcWdn1u6DrW2JhFsqQHnme3ignfqeUlgcHy0GOwwXU7xnTQDzfkhvGc6rxDDsfUScU/ qcZv446AA23ofK85cz2urgiOae4tQlVoxDzYpiIcBPaKLDUteC/ycIW3kQ9O9tUZ772Q 0AGNs9mIPAH6+vnG8rzyTMq6K6GbX7lWRuBKW/tV10n33czStFoJIohzG/g3TimIMTte Jvo4jAA8jtliNbD2GvaFcy02DpOzCzJQw5GswLiinjK7h0HrPsotb/Jx+f9ubHAmj818 +jqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CGcpwMtrr4F0Rl9cO3XqszINhBjZp294W8XfrrtEik8=; b=zHlV8reVJX8lpiQ8gBtCcO0yP3K7GZgp/HJIJ0bYUQgieQr2A3sXRYQhQ3D/HaBq6u 6g08RlQsuUCUYiWLE6mWnjyoIiagkuMB7PN233/0cdab6Ngnfb85hfcXxPuHehT0RWAf ynD7lPwfYCkF7DNFNga/9Zs9VJVit9fTSnqL3eS2WV9n0M6XQDC0K5hkcnKuuR3wczlZ uPl7R3o0qC2QXSi/g99gGdzZgfGnTejee3jNqO0OqXJpTqmL66hgWJZjBF/aBilMBMhh UixUi0CKyGeK9Q0Fb88jGrGOeQgeQc0l3wRmXH394XjDyppSd8wA7oE2tJ++qJXBkwA0 Hpyg== X-Gm-Message-State: ACrzQf0xwIMDHh7knIFVkZBunF/kg5vQbTyojRio8NhWtHKOM/JROBIY C3Sc4zvdFeKqyMoyPk/fiJ0= X-Google-Smtp-Source: AMsMyM6uVMrIO38uJtkfTAO5XLP7z6K4gFiOwMWvtXt+2oLX1fKOwCWF1vBsdrNqDwCjwQlhqQcz4Q== X-Received: by 2002:a5d:6384:0:b0:22e:6027:9da4 with SMTP id p4-20020a5d6384000000b0022e60279da4mr10653619wru.686.1665401534087; Mon, 10 Oct 2022 04:32:14 -0700 (PDT) Received: from [192.168.42.102] (sm4-84-91-228-85.netvisao.pt. [84.91.228.85]) by smtp.gmail.com with ESMTPSA id h5-20020a5d4305000000b0022ac1be009esm8675317wrq.16.2022.10.10.04.32.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Oct 2022 04:32:13 -0700 (PDT) Message-ID: <232b8d40-eb93-6a73-86bb-c664d7b2ccee@gmail.com> Date: Mon, 10 Oct 2022 12:32:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: [PATCH v2 2/5] fs/ntfs3: make hidedotfiles mount option work when renaming files Content-Language: pt-PT From: Daniel Pinto To: Konstantin Komarov , ntfs3@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org References: <9c404576-856b-6935-f2e3-c4d0749f16ea@gmail.com> In-Reply-To: <9c404576-856b-6935-f2e3-c4d0749f16ea@gmail.com> Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Currently, the hidedotfiles mount option only has an effect when creating new files. Removing or adding the starting dot when moving or renaming files does not update the hidden attribute. Make hidedotfiles also set or uset the hidden attribute when a file gains or loses its starting dot by being moved or renamed. Signed-off-by: Daniel Pinto --- fs/ntfs3/frecord.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/fs/ntfs3/frecord.c b/fs/ntfs3/frecord.c index 70a80f9412f7..41a20d71562a 100644 --- a/fs/ntfs3/frecord.c +++ b/fs/ntfs3/frecord.c @@ -3018,6 +3018,15 @@ int ni_add_name(struct ntfs_inode *dir_ni, struct nt= fs_inode *ni, struct ATTR_FILE_NAME *de_name =3D (struct ATTR_FILE_NAME *)(de + 1); u16 de_key_size =3D le16_to_cpu(de->key_size); =20 + /* If option "hidedotfiles" then set hidden attribute for dot files. */ + if (ni->mi.sbi->options->hide_dot_files) { + if (de_name->name_len > 0 && + le16_to_cpu(de_name->name[0]) =3D=3D '.') + ni->std_fa |=3D FILE_ATTRIBUTE_HIDDEN; + else + ni->std_fa &=3D ~FILE_ATTRIBUTE_HIDDEN; + } + mi_get_ref(&ni->mi, &de->ref); mi_get_ref(&dir_ni->mi, &de_name->home); From nobody Mon Apr 6 22:49:38 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60590C433F5 for ; Mon, 10 Oct 2022 11:34:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231512AbiJJLeP (ORCPT ); Mon, 10 Oct 2022 07:34:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231430AbiJJLeL (ORCPT ); Mon, 10 Oct 2022 07:34:11 -0400 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33C0A51417; Mon, 10 Oct 2022 04:34:09 -0700 (PDT) Received: by mail-wr1-x434.google.com with SMTP id bp11so3826780wrb.9; Mon, 10 Oct 2022 04:34:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TeL0o0yVihRehcTsidItMwxwi4VSKF8819s3pNgUkoA=; b=bJkgt8XBMOYlvYMRd60SqsD5SsRRa2mD22nqQul7gLCyl3sVtJGeJak1zQE8e3Q5H/ PMxmIeeit7bbDDmaasHyMKxQZPJ9NKiT2JVaaudImql6n0GSX98F35GMJt4q0ydiW0TA txD86vwQ4TRMmumInbvulZ+h0TjgEF270O6YZDGxhIH/yQCoL69sgNtp60v+dBFiYdtt 7CuNjbJdSV/41sveFiN1ZfAM9M//seU6iBDwSx/0pH/QkPr8NDVcw9ZKloJ7NYxs3QQc 2BgWyytVHjFQ6u9KC4jd6FBTGRS2lEpquLHkHEyMNl571mVNiEAq/yHSCvHohXGPvfbr wJCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TeL0o0yVihRehcTsidItMwxwi4VSKF8819s3pNgUkoA=; b=XslQ7I7VpogQzVnhJK7yI2g/HZ4SLx8B4O912iC7jgeLlHtZynF2px9IJmYvqSSns8 YeV4crRgPXGvF7uviisdUB7EzvJp0OprKENDUaCgbrHh2pL3jppYBAN0+Kj/s7c7TMKH +hnkd2vfVc89z1Mu9XyIc/oAQene5uMV6KLOgHKtWqgxeJz77R3kyJCoY2pVBjSDsSpx eE2fITBk1k13lVy6FwhiILdFemgnMGrjlweaT94sKP3LrnaFaFRHfmxC5VPeHR7KIrZ+ yMSbRa+AUvdI5ux+OQEzUZZUHpvuqlgm84Xk3M+LoJwZ85Ofs4piG+NIgRHO+a8riopQ zKcQ== X-Gm-Message-State: ACrzQf21pQ7VEbnS+vyfwkmCJ5s8peQPd9xjowA0e9OTCzKBOjctFPGD gd+UoyjgJHjJrNUBrpg+Yn4= X-Google-Smtp-Source: AMsMyM6tGY6fRMNDLA/tSbtiGWuEd/ro4K+ih7XhEt3DRhNSFFITKmTKqGjonek1rDh8nRYdI/DpjQ== X-Received: by 2002:a5d:490c:0:b0:22e:6545:996e with SMTP id x12-20020a5d490c000000b0022e6545996emr10729516wrq.523.1665401647825; Mon, 10 Oct 2022 04:34:07 -0700 (PDT) Received: from [192.168.42.102] (sm4-84-91-228-85.netvisao.pt. [84.91.228.85]) by smtp.gmail.com with ESMTPSA id h5-20020a5d4305000000b0022ac1be009esm8680012wrq.16.2022.10.10.04.34.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Oct 2022 04:34:07 -0700 (PDT) Message-ID: Date: Mon, 10 Oct 2022 12:34:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: [PATCH v2 3/5] fs/ntfs3: add hidedotfiles to the list of enabled mount options Content-Language: pt-PT From: Daniel Pinto To: Konstantin Komarov , ntfs3@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org References: <9c404576-856b-6935-f2e3-c4d0749f16ea@gmail.com> In-Reply-To: <9c404576-856b-6935-f2e3-c4d0749f16ea@gmail.com> Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Currently, the ntfs3 driver does return the hidedotfiles mount option in the list of enabled mount options. This can confuse users who may doubt they enabled the option when not seeing in the list provided by the mount command. Add hidedotfiles mount option to the list of enabled options provided by the mount command when it is enabled. Signed-off-by: Daniel Pinto --- fs/ntfs3/super.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c index c6fd2afde172..d796541e2a67 100644 --- a/fs/ntfs3/super.c +++ b/fs/ntfs3/super.c @@ -561,6 +561,8 @@ static int ntfs_show_options(struct seq_file *m, struct= dentry *root) seq_puts(m, ",showmeta"); if (opts->nohidden) seq_puts(m, ",nohidden"); + if (opts->hide_dot_files) + seq_puts(m, ",hidedotfiles"); if (opts->force) seq_puts(m, ",force"); if (opts->noacsrules) From nobody Mon Apr 6 22:49:38 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35F57C433FE for ; Mon, 10 Oct 2022 11:36:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232112AbiJJLf5 (ORCPT ); Mon, 10 Oct 2022 07:35:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232118AbiJJLfw (ORCPT ); Mon, 10 Oct 2022 07:35:52 -0400 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8147D6CD37; Mon, 10 Oct 2022 04:35:49 -0700 (PDT) Received: by mail-wr1-x42d.google.com with SMTP id a3so16645208wrt.0; Mon, 10 Oct 2022 04:35:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jr6QUg4W3KCMgn//RzqzYopSrHaXWN6D/2F2E2n78+o=; b=AsEfPf2TiJbvEz92D8N3jlqaxcRRjPXuD/oxHfnN7m+ZjrqWMdPul708x1RwSyRzEU qt+ioz8N1jDj/WbDAJb068bSX8UHXgUcDPF12gSzrvYYIBv4O+ievYINUZUDXSEADcBX BzzhbxS0aResm8dd/83NVjHxdiPUyQ7vYPqbblVk7iIsu7T27YhG620ZA2hvrW32Vaw1 M2SBUo8ck0gfpXfavGYpG4V+aOVtaPXSRkrhAZz5XZdpKcC61r3GLd8eV4pMTL9Nnh5w QotnJ9y7aEuYUclBw4PrkQzfQNhhg8A0qZZZqt/ukal0qcrX+dnlOtCgqNTKKaLboaUI 1kuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jr6QUg4W3KCMgn//RzqzYopSrHaXWN6D/2F2E2n78+o=; b=wpoCI02hg+qbhAGyEUeFyn7rj3TOBAQ89fRnEAoQhNVLbkOA2e/P6GXPlE8o71E82/ xCt8H3B10+2aEriMBvxsKb0mwJB41BLBCbPaBaPE45S7Ewiaigp9z6jtwqdrYBsRu7W4 p1ntxGUYwzwXisxWkglCS6bkA0opsXVK9N5IkJG2Ys33VRUE+aH3uo0INRV18h2hFlar sxHNxu35phHGyU9zg4V5tnU8tiZgRN9e59i4ijrSAl8DUtRrKd0OJtxyUbvepQOuBk64 RDbLJP4E9IDxpid4zoNiULadGC0z4N/cuqwprLHhJbw5DPBymlCuQXK6pcleGcaoCWmD 2OLQ== X-Gm-Message-State: ACrzQf3HzHRrakJxmzSHVDxTE/LklnGuf3bCw6yGjUzGgNk3YalFO0WE 0zQUNp9eBO7GVNGTXXIAeRU= X-Google-Smtp-Source: AMsMyM45nIQ+4isA/wR9XJ47XEZguYnuBIiLPwckYxxFL6SrsVMyMMFKTBJl6gLeGNn7t14z+Shsqw== X-Received: by 2002:a5d:4950:0:b0:230:cc5a:f6b0 with SMTP id r16-20020a5d4950000000b00230cc5af6b0mr1643870wrs.656.1665401747925; Mon, 10 Oct 2022 04:35:47 -0700 (PDT) Received: from [192.168.42.102] (sm4-84-91-228-85.netvisao.pt. [84.91.228.85]) by smtp.gmail.com with ESMTPSA id l10-20020adfe9ca000000b002286670bafasm8622031wrn.48.2022.10.10.04.35.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Oct 2022 04:35:47 -0700 (PDT) Message-ID: Date: Mon, 10 Oct 2022 12:35:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: [PATCH v2 4/5] fs/ntfs3: document the hidedotfiles mount option Content-Language: pt-PT From: Daniel Pinto To: Konstantin Komarov , ntfs3@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org References: <9c404576-856b-6935-f2e3-c4d0749f16ea@gmail.com> In-Reply-To: <9c404576-856b-6935-f2e3-c4d0749f16ea@gmail.com> Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add documentation for the hidedotfiles mount option. Signed-off-by: Daniel Pinto --- Documentation/filesystems/ntfs3.rst | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Documentation/filesystems/ntfs3.rst b/Documentation/filesystem= s/ntfs3.rst index d67ccd22c63b..fa03165f2310 100644 --- a/Documentation/filesystems/ntfs3.rst +++ b/Documentation/filesystems/ntfs3.rst @@ -75,6 +75,12 @@ this table marked with no it means default is without **= no**. - Files with the Windows-specific SYSTEM (FILE_ATTRIBUTE_SYSTEM) attr= ibute will be marked as system immutable files. =20 + * - hidedotfiles + - Updates the Windows-specific HIDDEN (FILE_ATTRIBUTE_HIDDEN) attribu= te + when creating and moving or renaming files. Files whose names start + with a dot will have the HIDDEN attribute set and files whose names + do not start with a dot will have it unset. + * - discard - Enable support of the TRIM command for improved performance on dele= te operations, which is recommended for use with the solid-state drives From nobody Mon Apr 6 22:49:38 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8A97C433F5 for ; Mon, 10 Oct 2022 11:37:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232149AbiJJLhT (ORCPT ); Mon, 10 Oct 2022 07:37:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232139AbiJJLhQ (ORCPT ); Mon, 10 Oct 2022 07:37:16 -0400 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C63F86E8A2; Mon, 10 Oct 2022 04:37:15 -0700 (PDT) Received: by mail-wm1-x329.google.com with SMTP id o20-20020a05600c4fd400b003b4a516c479so6248196wmq.1; Mon, 10 Oct 2022 04:37:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=C2EFIm4tesO4K1a7cSrq2x4CXgXoUEITju+DVHW6+iw=; b=ccPzMT3VJJ8v7DzPBzM1ZEtHzbEmIfYjtfYJ2k0FiNbwCHZPKU6nkzuSKhOr6OB8U7 lOuhDT2lO4vFdvHZjTKxIdL2SfTPKVDtTqPLVw6zeKALh4KG4tCEsf8OX6liE/5DIsbf JRdH2aK6txpHYM6YXo/ZCSAjVKKJF10fdIajaVpj9AePxmhyOCLTUlR9RgN3TulHZ7RT A4X7HTJlyzaWUQAkzUYTpk1kOOw2LRxeQ4uwIpM1ONXJXxr1S9EFre2Ie5C5/+2hY97e CuSJm/IKg2/DZbUjgrkcIvuRBT6UnoYV/OI3DOpqc8/hQ4wz7R5Hs2F7/rS8ZgLGWkhv ftYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=C2EFIm4tesO4K1a7cSrq2x4CXgXoUEITju+DVHW6+iw=; b=u7Cuemx4/FqC6i4WVJdpD8cCNKFUqy7rkjKNzidvfGBvEHLFuQmANfPSiGdxfhQIRQ Oy7eUDtwejSK5eoIvPyNcIfWlzBcmCcIeyAX/YYX25pVqNIz3Sm3on5vsKGwxdqPq1kQ i4RTluSG6TOWophNaHEGeH3/eNjIjTadLq8RqMv8lUoZ8ks2p17MbGTbV6A0byOj+lbt YQ/4FJvn0nZJV9AZqYp9TA4PPm09E6btzGJRpZde5rswR3itIBgIOlN1p89YOvjoaU0c CSxIzsAihYL078bJxQONiOe7wlEMTDq9+/Kyrg0eW21iRc6ABN/4J4uxiciQ8PqP82LM epiA== X-Gm-Message-State: ACrzQf39fuO7yiCvhZtcFFB61tvPf0cjZGPDXLRSZMuuqQ+XX1DiruIt OFJUuyCANPgDiHjJy+v3ydk= X-Google-Smtp-Source: AMsMyM7rSdwtUmlwD9h3eZ8YDRiviILWuOChr73nlodkc7/4oYafMcZ+iTeK/va4sRZ8PmRf0oP/7g== X-Received: by 2002:a7b:cb95:0:b0:3c6:c0e7:88ab with SMTP id m21-20020a7bcb95000000b003c6c0e788abmr340799wmi.147.1665401834383; Mon, 10 Oct 2022 04:37:14 -0700 (PDT) Received: from [192.168.42.102] (sm4-84-91-228-85.netvisao.pt. [84.91.228.85]) by smtp.gmail.com with ESMTPSA id o18-20020a1c7512000000b003b492753826sm9794969wmc.43.2022.10.10.04.37.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Oct 2022 04:37:14 -0700 (PDT) Message-ID: Date: Mon, 10 Oct 2022 12:37:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: [PATCH v2 5/5] fs/ntfs3: rename hidedotfiles mount option to hide_dot_files Content-Language: pt-PT From: Daniel Pinto To: Konstantin Komarov , ntfs3@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org References: <9c404576-856b-6935-f2e3-c4d0749f16ea@gmail.com> In-Reply-To: <9c404576-856b-6935-f2e3-c4d0749f16ea@gmail.com> Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The hidedotfiles mount option provides the same functionality as the NTFS-3G hide_dot_files mount option. As such, it should be named the same for compatibility with NTGS-3G. Rename the hidedotfiles to hide_dot_files for compatbility with NTFS-3G. Signed-off-by: Daniel Pinto --- Documentation/filesystems/ntfs3.rst | 2 +- fs/ntfs3/frecord.c | 2 +- fs/ntfs3/inode.c | 2 +- fs/ntfs3/super.c | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Documentation/filesystems/ntfs3.rst b/Documentation/filesystem= s/ntfs3.rst index fa03165f2310..4c6eb9fe9bea 100644 --- a/Documentation/filesystems/ntfs3.rst +++ b/Documentation/filesystems/ntfs3.rst @@ -75,7 +75,7 @@ this table marked with no it means default is without **n= o**. - Files with the Windows-specific SYSTEM (FILE_ATTRIBUTE_SYSTEM) attr= ibute will be marked as system immutable files. =20 - * - hidedotfiles + * - hide_dot_files - Updates the Windows-specific HIDDEN (FILE_ATTRIBUTE_HIDDEN) attribu= te when creating and moving or renaming files. Files whose names start with a dot will have the HIDDEN attribute set and files whose names diff --git a/fs/ntfs3/frecord.c b/fs/ntfs3/frecord.c index 41a20d71562a..552dbc5b80b1 100644 --- a/fs/ntfs3/frecord.c +++ b/fs/ntfs3/frecord.c @@ -3018,7 +3018,7 @@ int ni_add_name(struct ntfs_inode *dir_ni, struct ntf= s_inode *ni, struct ATTR_FILE_NAME *de_name =3D (struct ATTR_FILE_NAME *)(de + 1); u16 de_key_size =3D le16_to_cpu(de->key_size); =20 - /* If option "hidedotfiles" then set hidden attribute for dot files. */ + /* If option "hide_dot_files" then set hidden attribute for dot files. */ if (ni->mi.sbi->options->hide_dot_files) { if (de_name->name_len > 0 && le16_to_cpu(de_name->name[0]) =3D=3D '.') diff --git a/fs/ntfs3/inode.c b/fs/ntfs3/inode.c index e9cf00d14733..7ce2bb7646db 100644 --- a/fs/ntfs3/inode.c +++ b/fs/ntfs3/inode.c @@ -1272,7 +1272,7 @@ struct inode *ntfs_create_inode(struct user_namespace= *mnt_userns, fa =3D FILE_ATTRIBUTE_ARCHIVE; } =20 - /* If option "hidedotfiles" then set hidden attribute for dot files. */ + /* If option "hide_dot_files" then set hidden attribute for dot files. */ if (sbi->options->hide_dot_files && name->name[0] =3D=3D '.') fa |=3D FILE_ATTRIBUTE_HIDDEN; =20 diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c index d796541e2a67..af67756998df 100644 --- a/fs/ntfs3/super.c +++ b/fs/ntfs3/super.c @@ -268,7 +268,7 @@ static const struct fs_parameter_spec ntfs_fs_parameter= s[] =3D { fsparam_flag_no("force", Opt_force), fsparam_flag_no("sparse", Opt_sparse), fsparam_flag_no("hidden", Opt_nohidden), - fsparam_flag_no("hidedotfiles", Opt_hide_dot_files), + fsparam_flag_no("hide_dot_files", Opt_hide_dot_files), fsparam_flag_no("acl", Opt_acl), fsparam_flag_no("showmeta", Opt_showmeta), fsparam_flag_no("prealloc", Opt_prealloc), @@ -562,7 +562,7 @@ static int ntfs_show_options(struct seq_file *m, struct= dentry *root) if (opts->nohidden) seq_puts(m, ",nohidden"); if (opts->hide_dot_files) - seq_puts(m, ",hidedotfiles"); + seq_puts(m, ",hide_dot_files"); if (opts->force) seq_puts(m, ",force"); if (opts->noacsrules)