Amit Barzilai <amit.barzilai22@gmail.com> writes:
Hello Amit,
> This series adds support for the Solomon SSD1351, a 128x128 65k-color
> RGB OLED controller, to the ssd130x DRM driver:
>
> - Patch 1 adds the device tree binding.
>
> - Patch 2 switches the SSD133X family from RGB332 to RGB565, bringing
> 65k color to the SSD1331.
>
> - Patches 3 to 5 are preparatory cleanups requested on v3: constify
> the ssd130x_write_data() 'values' parameter, convert
> ssd130x_spi_id[] to C99 initializers, and reimplement
> ssd130x_write_cmd() as a variadic wrapper around
> ssd130x_write_cmds() so a single loop remains.
>
> - Patch 6 adds the SSD1351 as a new SSD135X_FAMILY. It gets its own
> primary plane update/disable, encoder enable and backlight
> callbacks; only the callbacks with no family-specific logic
> (ssd133x_primary_plane_atomic_check(), ssd133x_crtc_atomic_check()
> and ssd130x_encoder_atomic_disable()) are reused as is. It also
> sends command parameters on the data path, handled in
> ssd130x_write_cmds() via a new cmd_params_are_data flag; see [2]
> for why the split lives there rather than in the SPI transport.
>
> Testing:
>
> - Patches 1, 3, 4, 5 and 6 are tested on an SSD1351.
> - The SSD1331 RGB565 change (patch 2) was kindly tested by Javier on
> his SSD1331.
>
> Thanks to Javier, Andy, Krzysztof and Fabio for the reviews.
>
> [1] v5 of this series:
> https://lore.kernel.org/dri-devel/20260823111959.17029-1-amit.barzilai22@gmail.com
> [2] Command parameter path discussion:
> https://lore.kernel.org/dri-devel/20260811122603.30773-1-amit.barzilai22@gmail.com
>
> ---
>
> Changes since v5 [1]:
> - Patch 6: move the zero length check to the top of
> ssd130x_write_cmds() so it guards both command paths, and comment
> the len == 1 early return.
> - Use the "Assisted-by: LLM" attribution form.
> - Rebased on drm-misc-next.
> - Collect Andy's Reviewed-by on patch 2 and Javier's on patches 4, 5
> and 6.
>
> Amit Barzilai (6):
> dt-bindings: display: Add Solomon SSD1351 OLED controller
> drm/ssd130x: Change SSD133X color format to RGB565 from RGB332
> drm/ssd130x: Constify ssd130x_write_data() 'values' parameter
> drm/ssd130x: Replace positional ssd130x_spi_id[] initialization with
> C99
> drm/ssd130x: Implement ssd130x_write_cmd() on top of
> ssd130x_write_cmds()
> drm/ssd130x: Add SSD135X_FAMILY and SSD1351 support
>
> .../bindings/display/solomon,ssd1351.yaml | 42 ++
> drivers/gpu/drm/solomon/ssd130x-spi.c | 25 +-
> drivers/gpu/drm/solomon/ssd130x.c | 421 +++++++++++++++---
> drivers/gpu/drm/solomon/ssd130x.h | 10 +-
> 4 files changed, 433 insertions(+), 65 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/display/solomon,ssd1351.yaml
>
> base-commit: 766bfba0f3bae329f99b42dcabc3ef11fa368f0b
> --
> 2.55.0
>
Pushed to drm-misc (drm-misc-next). Thanks!
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat