[v2] Novatek NT51021 DSI panel IC driver

[PATCH v2 0/3] Novatek NT51021 DSI panel IC driver

Posted by Nickolay Goppen 1 week, 6 days ago

This series adds support for Novatek NT51021-based panels 
for upcoming xiaomi-clover submission

Although according to datasheet, the IС has three power rails 
in the use case of xiaomi-clover, all of them are wired to one 
fixed regulator

Maybe I should create a dt option for enabling CABC for panel

Signed-off-by: Nickolay Goppen <setotau@mainlining.org>
---
Changes in v2:
- Use devm_functions and renamed structs and functions (Neil)
- Added delay before deasserting reset for stable initialization (Sashiko and Ryan)
- Fixed dt-bindings (Sashiko and Neil)
- Added a comment about set_display_on command
- Link to v1: https://patch.msgid.link/20260829-qcom-novatek-nt51021-panels-v1-0-cc1ca61bd261@mainlining.org

To: Nickolay Goppen <setotau@mainlining.org>
To: Neil Armstrong <neil.armstrong@linaro.org>
To: Jessica Zhang <jesszhan0024@gmail.com>
To: David Airlie <airlied@gmail.com>
To: Simona Vetter <simona@ffwll.ch>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: Maxime Ripard <mripard@kernel.org>
To: Thomas Zimmermann <tzimmermann@suse.de>
To: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzk+dt@kernel.org>
To: Conor Dooley <conor+dt@kernel.org>
Cc: dri-devel@lists.freedesktop.org
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: ryanbrue.dev@gmail.com

---
Nickolay Goppen (3):
      dt-bindings: display: panel: Add bindings for Novatek NT51021
      drivers: gpu: drm: panel: Add BOE NT51021 driver
      MAINTAINERS: Add myself as a maintainer of NT51021 panel driver

 .../bindings/display/panel/novatek,nt51021.yaml    |  89 +++
 MAINTAINERS                                        |   6 +
 drivers/gpu/drm/panel/Kconfig                      |   9 +
 drivers/gpu/drm/panel/Makefile                     |   1 +
 drivers/gpu/drm/panel/panel-novatek-nt51021.c      | 791 +++++++++++++++++++++
 5 files changed, 896 insertions(+)
---
base-commit: 99cc957e3ef3cccd72d2119c8eacbab39af0d1d6
change-id: 20260829-qcom-novatek-nt51021-panels-e2f9db85a967

Best regards,
--  
Nickolay Goppen <setotau@mainlining.org>

Re: [PATCH v2 0/3] Novatek NT51021 DSI panel IC driver

Posted by Ryan Brue 1 week, 6 days ago

On 9/11/26 10:37 AM, Nickolay Goppen wrote:
> This series adds support for Novatek NT51021-based panels
> for upcoming xiaomi-clover submission
>
> Although according to datasheet, the IС has three power rails
> in the use case of xiaomi-clover, all of them are wired to one
> fixed regulator
>
> Maybe I should create a dt option for enabling CABC for panel
>
> Signed-off-by: Nickolay Goppen <setotau@mainlining.org>
> ---
> Changes in v2:
> - Use devm_functions and renamed structs and functions (Neil)
> - Added delay before deasserting reset for stable initialization (Sashiko and Ryan)
> - Fixed dt-bindings (Sashiko and Neil)
> - Added a comment about set_display_on command
> - Link to v1: https://patch.msgid.link/20260829-qcom-novatek-nt51021-panels-v1-0-cc1ca61bd261@mainlining.org
>
> To: Nickolay Goppen <setotau@mainlining.org>
> To: Neil Armstrong <neil.armstrong@linaro.org>
> To: Jessica Zhang <jesszhan0024@gmail.com>
> To: David Airlie <airlied@gmail.com>
> To: Simona Vetter <simona@ffwll.ch>
> To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> To: Maxime Ripard <mripard@kernel.org>
> To: Thomas Zimmermann <tzimmermann@suse.de>
> To: Rob Herring <robh@kernel.org>
> To: Krzysztof Kozlowski <krzk+dt@kernel.org>
> To: Conor Dooley <conor+dt@kernel.org>
> Cc: dri-devel@lists.freedesktop.org
> Cc: devicetree@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: ryanbrue.dev@gmail.com
>
> ---
> Nickolay Goppen (3):
>        dt-bindings: display: panel: Add bindings for Novatek NT51021
>        drivers: gpu: drm: panel: Add BOE NT51021 driver
>        MAINTAINERS: Add myself as a maintainer of NT51021 panel driver
>
>   .../bindings/display/panel/novatek,nt51021.yaml    |  89 +++
>   MAINTAINERS                                        |   6 +
>   drivers/gpu/drm/panel/Kconfig                      |   9 +
>   drivers/gpu/drm/panel/Makefile                     |   1 +
>   drivers/gpu/drm/panel/panel-novatek-nt51021.c      | 791 +++++++++++++++++++++
>   5 files changed, 896 insertions(+)
> ---
> base-commit: 99cc957e3ef3cccd72d2119c8eacbab39af0d1d6
> change-id: 20260829-qcom-novatek-nt51021-panels-e2f9db85a967
>
> Best regards,
> --
> Nickolay Goppen <setotau@mainlining.org>
Hi Nickolay,
I have patches ready on top of your v2 series for the Amazon Fire HD 10 
(2017)'s panel; however, given that Sashiko has found an issue with this 
series, would it be best for me to wait for a v3, or would you like my 
patches now to incorporate into your next series?

Thank you,
Ryan

Re: [PATCH v2 0/3] Novatek NT51021 DSI panel IC driver

Posted by Nickolay Goppen 1 week, 6 days ago

12.09.2026 05:58, Ryan Brue пишет:
>
> On 9/11/26 10:37 AM, Nickolay Goppen wrote:
>> This series adds support for Novatek NT51021-based panels
>> for upcoming xiaomi-clover submission
>>
>> Although according to datasheet, the IС has three power rails
>> in the use case of xiaomi-clover, all of them are wired to one
>> fixed regulator
>>
>> Maybe I should create a dt option for enabling CABC for panel
>>
>> Signed-off-by: Nickolay Goppen <setotau@mainlining.org>
>> ---
>> Changes in v2:
>> - Use devm_functions and renamed structs and functions (Neil)
>> - Added delay before deasserting reset for stable initialization 
>> (Sashiko and Ryan)
>> - Fixed dt-bindings (Sashiko and Neil)
>> - Added a comment about set_display_on command
>> - Link to v1: 
>> https://patch.msgid.link/20260829-qcom-novatek-nt51021-panels-v1-0-cc1ca61bd261@mainlining.org
>>
>> To: Nickolay Goppen <setotau@mainlining.org>
>> To: Neil Armstrong <neil.armstrong@linaro.org>
>> To: Jessica Zhang <jesszhan0024@gmail.com>
>> To: David Airlie <airlied@gmail.com>
>> To: Simona Vetter <simona@ffwll.ch>
>> To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> To: Maxime Ripard <mripard@kernel.org>
>> To: Thomas Zimmermann <tzimmermann@suse.de>
>> To: Rob Herring <robh@kernel.org>
>> To: Krzysztof Kozlowski <krzk+dt@kernel.org>
>> To: Conor Dooley <conor+dt@kernel.org>
>> Cc: dri-devel@lists.freedesktop.org
>> Cc: devicetree@vger.kernel.org
>> Cc: linux-kernel@vger.kernel.org
>> Cc: ryanbrue.dev@gmail.com
>>
>> ---
>> Nickolay Goppen (3):
>>        dt-bindings: display: panel: Add bindings for Novatek NT51021
>>        drivers: gpu: drm: panel: Add BOE NT51021 driver
>>        MAINTAINERS: Add myself as a maintainer of NT51021 panel driver
>>
>>   .../bindings/display/panel/novatek,nt51021.yaml    |  89 +++
>>   MAINTAINERS                                        |   6 +
>>   drivers/gpu/drm/panel/Kconfig                      |   9 +
>>   drivers/gpu/drm/panel/Makefile                     |   1 +
>>   drivers/gpu/drm/panel/panel-novatek-nt51021.c      | 791 
>> +++++++++++++++++++++
>>   5 files changed, 896 insertions(+)
>> ---
>> base-commit: 99cc957e3ef3cccd72d2119c8eacbab39af0d1d6
>> change-id: 20260829-qcom-novatek-nt51021-panels-e2f9db85a967
>>
>> Best regards,
>> -- 
>> Nickolay Goppen <setotau@mainlining.org>
> Hi Nickolay,
> I have patches ready on top of your v2 series for the Amazon Fire HD 
> 10 (2017)'s panel; however, given that Sashiko has found an issue with 
> this series, would it be best for me to wait for a v3, or would you 
> like my patches now to incorporate into your next series?
>
Maybe I can incorporate your panel to my driver.
> Thank you,
> Ryan

-- 
Best regards,
Nickolay

Re: [PATCH v2 0/3] Novatek NT51021 DSI panel IC driver

Posted by Ryan Brue 1 week, 5 days ago

On 9/12/26 7:05 AM, Nickolay Goppen wrote:
> Maybe I can incorporate your panel to my driver. 
Ack, sending out the patches on top of yours now. Thank you!