[RFC PATCH 0/3] ASoC: Intel: Add Lenovo Yoga Book RT5677 support

Maurizio Casciano posted 3 patches 1 month ago
There is a newer version of this series
MAINTAINERS                                   |   1 +
sound/soc/intel/boards/Kconfig                |  14 +
sound/soc/intel/boards/Makefile               |   2 +
sound/soc/intel/boards/cht_yogabook.c         | 616 ++++++++++++++++++
.../intel/common/soc-acpi-intel-cht-match.c   |   8 +
5 files changed, 641 insertions(+)
create mode 100644 sound/soc/intel/boards/cht_yogabook.c
[RFC PATCH 0/3] ASoC: Intel: Add Lenovo Yoga Book RT5677 support
Posted by Maurizio Casciano 1 month ago
The Lenovo Yoga Book YB1-X91F/L uses a Cherry Trail SSP2 connection to
an RT5677 codec, with board-specific amplifier, headphone and headset
detector wiring.  Add the machine driver, the SST machine-table match,
and the SOF topology filename used by the corresponding external SOF
topology.

The companion platform/x86 series supplies the TS3A227E device and codec
GPIO lookup entries.  The sof-cht-rt5677.tplg topology is maintained in
the SOF project and must be merged and distributed separately.

With the matching topology installed, the Yoga Book reaches the SOF
card-registration and stream setup path.  End-to-end playback and
capture acceptance is not complete, so this is posted as an RFC.

Maurizio Casciano (3):
  ASoC: Intel: Add Lenovo Yoga Book RT5677 machine driver
  ASoC: Intel: cht: Match the Yoga Book RT5677 machine
  ASoC: Intel: cht: Add Yoga Book SOF topology filename

 MAINTAINERS                                   |   1 +
 sound/soc/intel/boards/Kconfig                |  14 +
 sound/soc/intel/boards/Makefile               |   2 +
 sound/soc/intel/boards/cht_yogabook.c         | 616 ++++++++++++++++++
 .../intel/common/soc-acpi-intel-cht-match.c   |   8 +
 5 files changed, 641 insertions(+)
 create mode 100644 sound/soc/intel/boards/cht_yogabook.c


base-commit: a1a84efff65dd01a2608770d503ce297abf54c66
-- 
2.53.0
Re: [RFC PATCH 0/3] ASoC: Intel: Add Lenovo Yoga Book RT5677 support
Posted by Cezary Rojewski 1 month ago
On 8/26/2026 3:23 PM, Maurizio Casciano wrote:
> The Lenovo Yoga Book YB1-X91F/L uses a Cherry Trail SSP2 connection to
> an RT5677 codec, with board-specific amplifier, headphone and headset
> detector wiring.  Add the machine driver, the SST machine-table match,
> and the SOF topology filename used by the corresponding external SOF
> topology.
> 
> The companion platform/x86 series supplies the TS3A227E device and codec
> GPIO lookup entries.  The sof-cht-rt5677.tplg topology is maintained in
> the SOF project and must be merged and distributed separately.
> 
> With the matching topology installed, the Yoga Book reaches the SOF
> card-registration and stream setup path.  End-to-end playback and
> capture acceptance is not complete, so this is posted as an RFC.
> 
> Maurizio Casciano (3):
>    ASoC: Intel: Add Lenovo Yoga Book RT5677 machine driver
>    ASoC: Intel: cht: Match the Yoga Book RT5677 machine
>    ASoC: Intel: cht: Add Yoga Book SOF topology filename
Hello,

Unless I'm missing something, this looks like a resend of a patchset 
from earlier this year [1]. Previous owner of the subject, Yauhen 
Kharuzhy, is not even CC'ed here. I do not see any of the review points 
addressed here, moreover, I see a regression when compared to v3 from June.

Hiding behind RFC (not v4) is a weird move when viewed in context of 
CHT. The configuration is mature, CHT is over 12 years old. With basic 
playback/capture not enabled, does the review make sense?


[1]: 
https://lore.kernel.org/linux-sound/20260611-asoc-yogabook-v2-v3-0-3128447b67b6@gmail.com/

Kind regards,
Czarek
Re: [RFC PATCH 0/3] ASoC: Intel: Add Lenovo Yoga Book RT5677 support
Posted by Maurizio Casciano 1 month ago
You are right. Posting this as a new RFC, omitting Yauhen from CC, and not
making the relationship to his v3 explicit were mistakes.

I replaced the RFC with a versioned series based on Yauhen's work, restored
his copyright and provenance, and completed playback and capture validation
on the YB1-X91L. The follow-up v5 also restores Yauhen's Co-developed-by and
Signed-off-by trailers on both patches and addresses Mark's v4 review.

Thank you for pointing this out.

Maurizio
Re: [RFC PATCH 0/3] ASoC: Intel: Add Lenovo Yoga Book RT5677 support
Posted by Maurizio Casciano 1 month ago
Hi Cezary,

Thank you for the review. I addressed your feedback and sent the revised
v4 series here:

https://lore.kernel.org/linux-sound/20260827072517.1401173-1-mauriziocasciano7@gmail.com/

The driver is now named generically for Cherry Trail RT5677 systems,
uses per-device card, DAI-link and component copies, allocates the jack
separately with the device lifetime, and unwinds MCLK on the PLL and
sysclk error paths. I also documented the ASRC clock selections and
combined the complete SST/SOF machine entry into the series.

The v4 sources passed sparse and a clean kernel package build. They were
also tested on the Yoga Book YB1-X91L; playback and capture passed, and
the GNOME Settings speaker and microphone tests passed physical
verification.

Thanks,
Maurizio