From nobody Mon Sep 28 04:53:55 2026 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C0513EE1E5 for ; Wed, 26 Aug 2026 13:23:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787750632; cv=none; b=Jmowfq931OAhPZsr3+Y6s1pv6Z/2voQPU9k2HN1ca+db4VLOEJLAxYL2w1Xpxu1gRdwuy1q+RP0zCDyLcL+Ir340+MkHP3ajc8vscuO/yKA9MbT4WFRvdEA4SaIdEyE4ygUYfIsowtIyxz9ayPLaJoowHDmselfvVIQd8iuAv2c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787750632; c=relaxed/simple; bh=NmqCcR78ymtLuZfe3MCGyx++3o9NFt+yYBodAM2ofxc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CdwZF+A8cx/a/R80IX8NVnlOAAcEsmJyyDXfgfnPcv0u/RvU6ZAuFihigfRH0s5EdEUtsGB9E52QG1rwmsizWdArLC68OOKmZEIaJweMXBLWkKJoClwI5BmnMfEIcC9SPjj4kUv7GnoerTL7oHRov8qQIx+env1l9aUwOQh+bVc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=oWbSPvYa; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oWbSPvYa" Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-c1600d040e4so150872266b.1 for ; Wed, 26 Aug 2026 06:23:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787750626; x=1788355426; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=lopNt2daYcG9UmwYR1z0iRfYZcPrJRYdMxLBiWivbcA=; b=oWbSPvYaZDxzbnssTI8neJFcyR7OHAnRoFnzKLAiJrrTNxnyJMJ7yxDf8EqCwjwx69 Th8xA9ellNuh35fOsrgNneETl7jZDTiDQJQRkoaFfG5peQjP8uLnix7MO66UhHu1ev07 gIWlOzNLRbq2uYAo/t/iySyCdxNYV5wuiGms+JgS3aGsWDSiDIVVWR7OSdLNsGBBI/Rq xPV8ipMFgovZ/0cEAmwt0dHM6zJrQLJuweWxwUfS62M7ga/RAXMFsPb84YmBSOhB7bac 9v1XFbTBcFM9w+H4ucqGegVAa7HfdW8hAAqmkJ0V6xG7Vu4cN96uTAF9rOUGJW54bcc4 hYKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787750626; x=1788355426; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=lopNt2daYcG9UmwYR1z0iRfYZcPrJRYdMxLBiWivbcA=; b=DWr0rliVxvdhIH2wNRw0Tr4LgvtbMnH4qhH4lSTHz0jld3zV+7pcxcIlALfvX4sLu1 g+VOuvSjjp49rkO2UtDlZCwv4xHPO8CGLo5WXhENCq77hKXrahbh94oLzS2lfWO43D7z KGnsk6rcs6R5PRZM0z17/GonGmhaTDKQeNqdjbRXCIvKkJu8DOQPZXP3Xx9KsyJLl1Re wc8UBNSo/eYFaVuP3ONANQVRKGVQEp8FDYLAc50U+Z9u020NK5UEAZx1DF+umkDxqVPh q1ag4sAqEk9ADNcItFelnxxgKBnNHYBmeQGdtFd8zLwLQByTHMDprExhV1s7X/9XCEHj 7+Zg== X-Forwarded-Encrypted: i=1; AHgh+RozG9SZHvqHI3lpvZLDVJ0qxv+AGolXGUNcfzTgcwDGKGWwIeVPX5aTNUZJAOqe2ccln7zGiBZ/lR84Z+o=@vger.kernel.org X-Gm-Message-State: AFuF++n+aIcML/MTCsIVGvkcpx0AoFSM7890KsI8dKq+qM7zUY0gVGFD uEOneTtsEfw4cz0rzQsq3G1UhSQJx+CgskPxuShLhQ6gIg3XCSnmNOCQ X-Gm-Gg: AR+sD106aVRX02jVwQBzOG2JH2DmazMsCZckileyiKpcAQaxnCXE/tUA2aQAWyXA/pb aFNAbwMkUrnm3IBQLvkEBSkkpejk3gNGQdAt21hrMZPQOnBsY0fLzti1Fx8goYhmxF/JWuf/s/b DtuokXglpJquO4pEKTY+Kvrv7zyKHWPIQh0Rsf6sNEFDB28N9MBPRBYwhqe39MTb9H2SVQNdM82 i8sNHoNmEtRjImKgWjvWtJrfZEu9QMnLWPBgA4dQkdz5Zqmd43JB37Udwd7xHCLvp+xRjna1IFY Kxu2AJiiPQ2w1I8I+uLcnrchk3Pdwu/zhHUyT22rzChePf9/K+8VboPkYf8cFOWC9UGzMnV0K/s rARSE6XCxMSSOPO784y3NnF1l3c2mEt/4xsjqrGX3CCrNaKtCAcb5RPeeTx7f0+Jz3+BWdxAmc2 hWYZ5EZKkmejfo/V8wW4ZamiBEhUiVHgRMnyW0UgRedtFAEuRBhTyHIlqpqqfF8BLmhw+WqBduK uC8cXmchDIZMG+8fwVD8w9n917XS9Ni7ui8ztkTqXU= X-Received: by 2002:a17:906:9f92:b0:c20:a243:9a52 with SMTP id a640c23a62f3a-c250a7c9f4cmr942467066b.0.1787750625839; Wed, 26 Aug 2026 06:23:45 -0700 (PDT) Received: from 1Z10 ([37.163.238.51]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c250f99f6bdsm376856066b.0.2026.08.26.06.23.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2026 06:23:45 -0700 (PDT) From: Maurizio Casciano To: Mark Brown Cc: Cezary Rojewski , Liam Girdwood , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Jaroslav Kysela , Takashi Iwai , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Maurizio Casciano Subject: [RFC PATCH 1/3] ASoC: Intel: Add Lenovo Yoga Book RT5677 machine driver Date: Wed, 26 Aug 2026 15:23:32 +0200 Message-ID: <20260826132334.3344395-2-mauriziocasciano7@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260826132334.3344395-1-mauriziocasciano7@gmail.com> References: <20260826132334.3344395-1-mauriziocasciano7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Lenovo Yoga Book YB1-X91F/L uses the Cherry Trail SSP2 link with an RT5677 codec and a TS3A227E headset detector. Its amplifiers and headphone path also need board-specific GPIO sequencing. Add a Yoga Book machine driver derived from Yauhen Kharuzhy's GPL-2.0 cht_bsw_rt5677 implementation. Retain its copyright notice. Allocate the card, links, codec component and notifier per device so probing does not mutate global templates. Support SST and SOF parent naming, MCLK/PLL setup, jack buttons, microphones and output controls. Link: https://github.com/jekhor/yogabook-linux-kernel/commit/4e41d0ff72c1d1= fd8d5c59dda247e4ca8a1da999 Signed-off-by: Maurizio Casciano Assisted-by: Codex:gpt-5.6-sol sparse --- MAINTAINERS | 1 + sound/soc/intel/boards/Kconfig | 14 + sound/soc/intel/boards/Makefile | 2 + sound/soc/intel/boards/cht_yogabook.c | 616 ++++++++++++++++++++++++++ 4 files changed, 633 insertions(+) create mode 100644 sound/soc/intel/boards/cht_yogabook.c diff --git a/MAINTAINERS b/MAINTAINERS index 8014b9f8253e..83b49d9ad01c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -12909,6 +12909,7 @@ R: Pierre-Louis Bossart L: linux-sound@vger.kernel.org S: Supported F: sound/soc/intel/ +F: sound/soc/intel/boards/cht_yogabook.c =20 INTEL ATOMISP2 DUMMY / POWER-MANAGEMENT DRIVER M: Hans de Goede diff --git a/sound/soc/intel/boards/Kconfig b/sound/soc/intel/boards/Kconfig index cddbd2aa424e..fe5b1cb154e3 100644 --- a/sound/soc/intel/boards/Kconfig +++ b/sound/soc/intel/boards/Kconfig @@ -161,6 +161,20 @@ config SND_SOC_INTEL_CHT_BSW_RT5672_MACH Say Y or m if you have such a device. This is a recommended option. If unsure select "N". =20 +config SND_SOC_INTEL_CHT_YOGABOOK_MACH + tristate "Cherrytrail-based Lenovo Yoga Book tablet" + depends on X86_INTEL_LPSS && I2C && ACPI && SPI_MASTER + select SND_SOC_ACPI + select SND_SOC_RT5677 + select SND_SOC_RT5677_SPI + select SND_SOC_TS3A227E + help + This adds support for the RT5677 audio hardware in the Lenovo Yoga + Book YB1-X91 Cherry Trail tablets. + The machine driver connects the Cherry Trail audio platform to the + RT5677 codec and TS3A227E headset-jack detector. + Say Y or m if you have such a device. + config SND_SOC_INTEL_CHT_BSW_RT5645_MACH tristate "Cherrytrail & Braswell with RT5645/5650 codec" depends on I2C && ACPI diff --git a/sound/soc/intel/boards/Makefile b/sound/soc/intel/boards/Makef= ile index 25a1a9066cbf..bf521aaab4e7 100644 --- a/sound/soc/intel/boards/Makefile +++ b/sound/soc/intel/boards/Makefile @@ -9,6 +9,7 @@ snd-soc-sst-bytcr-rt5640-y :=3D bytcr_rt5640.o snd-soc-sst-bytcr-rt5651-y :=3D bytcr_rt5651.o snd-soc-sst-bytcr-wm5102-y :=3D bytcr_wm5102.o snd-soc-sst-cht-bsw-rt5672-y :=3D cht_bsw_rt5672.o +snd-soc-sst-cht-yogabook-y :=3D cht_yogabook.o snd-soc-sst-cht-bsw-rt5645-y :=3D cht_bsw_rt5645.o snd-soc-sst-cht-bsw-max98090_ti-y :=3D cht_bsw_max98090_ti.o snd-soc-sst-cht-bsw-nau8824-y :=3D cht_bsw_nau8824.o @@ -41,6 +42,7 @@ obj-$(CONFIG_SND_SOC_INTEL_BYTCR_RT5640_MACH) +=3D snd-so= c-sst-bytcr-rt5640.o obj-$(CONFIG_SND_SOC_INTEL_BYTCR_RT5651_MACH) +=3D snd-soc-sst-bytcr-rt565= 1.o obj-$(CONFIG_SND_SOC_INTEL_BYTCR_WM5102_MACH) +=3D snd-soc-sst-bytcr-wm510= 2.o obj-$(CONFIG_SND_SOC_INTEL_CHT_BSW_RT5672_MACH) +=3D snd-soc-sst-cht-bsw-r= t5672.o +obj-$(CONFIG_SND_SOC_INTEL_CHT_YOGABOOK_MACH) +=3D snd-soc-sst-cht-yogaboo= k.o obj-$(CONFIG_SND_SOC_INTEL_CHT_BSW_RT5645_MACH) +=3D snd-soc-sst-cht-bsw-r= t5645.o obj-$(CONFIG_SND_SOC_INTEL_CHT_BSW_MAX98090_TI_MACH) +=3D snd-soc-sst-cht-= bsw-max98090_ti.o obj-$(CONFIG_SND_SOC_INTEL_CHT_BSW_NAU8824_MACH) +=3D snd-soc-sst-cht-bsw-= nau8824.o diff --git a/sound/soc/intel/boards/cht_yogabook.c b/sound/soc/intel/boards= /cht_yogabook.c new file mode 100644 index 000000000000..a4def23fb5e0 --- /dev/null +++ b/sound/soc/intel/boards/cht_yogabook.c @@ -0,0 +1,616 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * cht_yogabook.c - ASoC machine driver for the Lenovo Yoga Book + * + * Copyright (C) 2019 Yauhen Kharuzhy + * + * Based on cht_bsw_rt5672.c: + * Copyright (C) 2014 Intel Corp + * Author: Subhransu S. Prusty + * Mengdong Lin + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include "../../codecs/rt5677.h" +#include "../../codecs/ts3a227e.h" +#include "../atom/sst-atom-controls.h" + +#define RT5677_I2C "i2c-rt5677" + +/* Platform clock 3 provides the codec's 19.2 MHz I2S master clock. */ +#define CHT_PLAT_CLK_3_HZ 19200000 +#define CHT_CODEC_DAI "rt5677-aif1" + +struct cht_mc_private { + char codec_name[SND_ACPI_I2C_ID_LEN]; + struct snd_soc_jack jack; + struct notifier_block jack_nb; + struct clk *mclk; + struct gpio_desc *gpio_spk_en1; + struct gpio_desc *gpio_spk_en2; + struct gpio_desc *gpio_hp_en; +}; + +static int platform_clock_control(struct snd_soc_dapm_widget *w, + struct snd_kcontrol *k, int event) +{ + struct snd_soc_dapm_context *dapm =3D w->dapm; + struct snd_soc_card *card =3D snd_soc_dapm_to_card(dapm); + struct snd_soc_dai *codec_dai; + struct cht_mc_private *ctx =3D snd_soc_card_get_drvdata(card); + int ret; + + dev_dbg(card->dev, "Setting platform clock\n"); + + codec_dai =3D snd_soc_card_get_codec_dai(card, CHT_CODEC_DAI); + if (!codec_dai) { + dev_err(card->dev, "Codec dai not found; Unable to set platform clock\n"= ); + return -EIO; + } + + if (SND_SOC_DAPM_EVENT_ON(event)) { + if (ctx->mclk) { + ret =3D clk_prepare_enable(ctx->mclk); + if (ret < 0) { + dev_err(card->dev, + "could not configure MCLK state"); + return ret; + } + } + + /* set codec PLL source to the 19.2MHz platform clock (MCLK) */ + ret =3D snd_soc_dai_set_pll(codec_dai, 0, RT5677_PLL1_S_MCLK, + CHT_PLAT_CLK_3_HZ, 48000 * 512); + if (ret < 0) { + dev_err(card->dev, "can't set codec pll: %d\n", ret); + goto disable_mclk; + } + + /* set codec sysclk source to PLL */ + ret =3D snd_soc_dai_set_sysclk(codec_dai, RT5677_SCLK_S_PLL1, + 48000 * 512, SND_SOC_CLOCK_IN); + if (ret < 0) { + dev_err(card->dev, "can't set codec sysclk: %d\n", ret); + goto disable_mclk; + } + } else { + /* + * Set codec sysclk source to its internal clock because codec + * PLL will be off when idle and MCLK will also be off by ACPI + * when codec is runtime suspended. Codec needs clock for jack + * detection and button press. + */ + snd_soc_dai_set_sysclk(codec_dai, RT5677_SCLK_S_RCCLK, + 48000 * 512, SND_SOC_CLOCK_IN); + + if (ctx->mclk) + clk_disable_unprepare(ctx->mclk); + } + return 0; + +disable_mclk: + if (ctx->mclk) + clk_disable_unprepare(ctx->mclk); + return ret; +} + +static int cht_yb_hp_event(struct snd_soc_dapm_widget *w, + struct snd_kcontrol *k, int event) +{ + struct snd_soc_dapm_context *dapm =3D w->dapm; + struct snd_soc_card *card =3D snd_soc_dapm_to_card(dapm); + struct cht_mc_private *ctx =3D snd_soc_card_get_drvdata(card); + + dev_dbg(card->dev, "HP event: %s\n", + SND_SOC_DAPM_EVENT_ON(event) ? "ON" : "OFF"); + + if (SND_SOC_DAPM_EVENT_ON(event)) { + msleep(20); + gpiod_set_value_cansleep(ctx->gpio_hp_en, 1); + msleep(50); + } else { + gpiod_set_value_cansleep(ctx->gpio_hp_en, 0); + } + + return 0; +} + +static int cht_yb_spk_event(struct snd_soc_dapm_widget *w, + struct snd_kcontrol *k, int event) +{ + struct snd_soc_dapm_context *dapm =3D w->dapm; + struct snd_soc_card *card =3D snd_soc_dapm_to_card(dapm); + struct cht_mc_private *ctx =3D snd_soc_card_get_drvdata(card); + + dev_dbg(card->dev, "SPK event: %s\n", + SND_SOC_DAPM_EVENT_ON(event) ? "ON" : "OFF"); + + /* Replicate the speaker-enable pulse sequence from Lenovo's kernel. */ + if (SND_SOC_DAPM_EVENT_ON(event)) { + gpiod_set_value_cansleep(ctx->gpio_spk_en1, 1); + udelay(2); + gpiod_set_value_cansleep(ctx->gpio_spk_en1, 0); + udelay(2); + gpiod_set_value_cansleep(ctx->gpio_spk_en1, 1); + udelay(2); + gpiod_set_value_cansleep(ctx->gpio_spk_en1, 0); + udelay(2); + } + + gpiod_set_value_cansleep(ctx->gpio_spk_en1, SND_SOC_DAPM_EVENT_ON(event)); + gpiod_set_value_cansleep(ctx->gpio_spk_en2, SND_SOC_DAPM_EVENT_ON(event)); + msleep(50); + + return 0; +} + +static const struct snd_soc_dapm_widget cht_dapm_widgets[] =3D { + SND_SOC_DAPM_HP("Headphone", cht_yb_hp_event), + SND_SOC_DAPM_MIC("Headset Mic", NULL), + SND_SOC_DAPM_MIC("Int Mic", NULL), + SND_SOC_DAPM_SPK("Speaker", cht_yb_spk_event), + SND_SOC_DAPM_SUPPLY("Platform Clock", SND_SOC_NOPM, 0, 0, + platform_clock_control, SND_SOC_DAPM_PRE_PMU | + SND_SOC_DAPM_POST_PMD), +}; + +static const struct snd_soc_dapm_route cht_audio_map[] =3D { + {"IN1P", NULL, "Headset Mic"}, + {"IN1N", NULL, "Headset Mic"}, + {"DMIC L1", NULL, "Int Mic"}, + {"DMIC R1", NULL, "Int Mic"}, + {"Headphone", NULL, "LOUT1"}, + {"Headphone", NULL, "LOUT2"}, + {"Speaker", NULL, "LOUT1"}, + {"Speaker", NULL, "LOUT2"}, + + {"AIF1 Playback", NULL, "ssp2 Tx"}, + {"ssp2 Tx", NULL, "codec_out0"}, + {"ssp2 Tx", NULL, "codec_out1"}, + {"codec_in0", NULL, "ssp2 Rx"}, + {"codec_in1", NULL, "ssp2 Rx"}, + {"ssp2 Rx", NULL, "AIF1 Capture"}, + {"Headphone", NULL, "Platform Clock"}, + {"Speaker", NULL, "Platform Clock"}, + {"Headset Mic", NULL, "Platform Clock"}, + {"Int Mic", NULL, "Platform Clock"}, +}; + +static const struct snd_kcontrol_new cht_mc_controls[] =3D { + SOC_DAPM_PIN_SWITCH("Headphone"), + SOC_DAPM_PIN_SWITCH("Headset Mic"), + SOC_DAPM_PIN_SWITCH("Int Mic"), + SOC_DAPM_PIN_SWITCH("Speaker"), +}; + +static int cht_aif1_hw_params(struct snd_pcm_substream *substream, + struct snd_pcm_hw_params *params) +{ + struct snd_soc_pcm_runtime *rtd =3D substream->private_data; + struct snd_soc_dai *codec_dai =3D snd_soc_rtd_to_codec(rtd, 0); + int ret; + + /* set codec PLL source to the 19.2MHz platform clock (MCLK) */ + ret =3D snd_soc_dai_set_pll(codec_dai, 0, RT5677_PLL1_S_MCLK, + CHT_PLAT_CLK_3_HZ, params_rate(params) * 512); + if (ret < 0) { + dev_err(rtd->dev, "can't set codec pll: %d\n", ret); + return ret; + } + + /* set codec sysclk source to PLL */ + ret =3D snd_soc_dai_set_sysclk(codec_dai, RT5677_SCLK_S_PLL1, + params_rate(params) * 512, + SND_SOC_CLOCK_IN); + if (ret < 0) { + dev_err(rtd->dev, "can't set codec sysclk: %d\n", ret); + return ret; + } + /* + * Default mode for SSP configuration is TDM 4 slot + */ + ret =3D snd_soc_dai_set_fmt(codec_dai, + SND_SOC_DAIFMT_DSP_B | + SND_SOC_DAIFMT_IB_NF | + SND_SOC_DAIFMT_CBC_CFC); + if (ret < 0) { + dev_err(codec_dai->dev, "can't set format to TDM %d\n", ret); + return ret; + } + + /* TDM 4 slots 24 bit, set Rx & Tx bitmask to 4 active slots */ + ret =3D snd_soc_dai_set_tdm_slot(codec_dai, 0xF, 0xF, 4, 25); + if (ret < 0) { + dev_err(rtd->dev, "can't set codec TDM slot %d\n", ret); + return ret; + } + + return 0; +} + +static int cht_yb_jack_event(struct notifier_block *nb, + unsigned long event, void *data) +{ + struct snd_soc_jack *jack =3D (struct snd_soc_jack *)data; + struct snd_soc_dapm_context *dapm =3D snd_soc_card_to_dapm(jack->card); + + if (event & SND_JACK_MICROPHONE) { + snd_soc_dapm_force_enable_pin(dapm, "MICBIAS1"); + snd_soc_dapm_sync(dapm); + } else { + snd_soc_dapm_disable_pin(dapm, "MICBIAS1"); + snd_soc_dapm_sync(dapm); + } + + return 0; +} + +static int cht_codec_init(struct snd_soc_pcm_runtime *runtime) +{ + struct snd_soc_dai *codec_dai =3D snd_soc_rtd_to_codec(runtime, 0); + struct snd_soc_component *component =3D codec_dai->component; + struct cht_mc_private *ctx =3D snd_soc_card_get_drvdata(runtime->card); + struct snd_soc_jack *jack =3D &ctx->jack; + int ret; + + /* + * Enable codec ASRC function for Stereo DAC/Stereo1 ADC/DMIC/I2S1. + * The ASRC clock source is clk_i2s1_asrc. + */ + rt5677_sel_asrc_clk_src(component, RT5677_DA_STEREO_FILTER | + RT5677_AD_STEREO1_FILTER | + RT5677_I2S1_SOURCE, + RT5677_CLK_SEL_I2S1_ASRC); + /* + * Enable codec ASRC function for Mono ADC L. + * The ASRC clock source is clk_sys2_asrc. + */ + rt5677_sel_asrc_clk_src(component, RT5677_AD_MONO_L_FILTER, RT5677_CLK_SE= L_SYS2); + + ctx->gpio_spk_en1 =3D devm_gpiod_get(component->dev, "speaker-enable", GP= IOD_OUT_LOW); + if (IS_ERR(ctx->gpio_spk_en1)) { + dev_err(component->dev, "Can't find speaker enable GPIO\n"); + return PTR_ERR(ctx->gpio_spk_en1); + } + + ctx->gpio_spk_en2 =3D devm_gpiod_get(component->dev, "speaker-enable2", G= PIOD_OUT_LOW); + if (IS_ERR(ctx->gpio_spk_en2)) { + dev_err(component->dev, "Can't find speaker enable 2 GPIO\n"); + return PTR_ERR(ctx->gpio_spk_en2); + } + + ctx->gpio_hp_en =3D devm_gpiod_get(component->dev, "headphone-enable", GP= IOD_OUT_LOW); + if (IS_ERR(ctx->gpio_hp_en)) { + dev_err(component->dev, "Can't find headphone enable GPIO\n"); + return PTR_ERR(ctx->gpio_hp_en); + } + + snd_soc_jack_notifier_register(jack, &ctx->jack_nb); + + if (ctx->mclk) { + /* + * The firmware might enable the clock at + * boot (this information may or may not + * be reflected in the enable clock register). + * To change the rate we must disable the clock + * first to cover these cases. Due to common + * clock framework restrictions that do not allow + * to disable a clock that has not been enabled, + * we need to enable the clock first. + */ + ret =3D clk_prepare_enable(ctx->mclk); + if (!ret) + clk_disable_unprepare(ctx->mclk); + + ret =3D clk_set_rate(ctx->mclk, CHT_PLAT_CLK_3_HZ); + + if (ret) { + dev_err(runtime->dev, "unable to set MCLK rate\n"); + return ret; + } + } + + return 0; +} + +static int cht_codec_fixup(struct snd_soc_pcm_runtime *rtd, + struct snd_pcm_hw_params *params) +{ + struct snd_interval *rate =3D hw_param_interval(params, + SNDRV_PCM_HW_PARAM_RATE); + struct snd_interval *channels =3D hw_param_interval(params, + SNDRV_PCM_HW_PARAM_CHANNELS); + + /* The DSP will convert the FE rate to 48k, stereo, 24bits */ + rate->min =3D 48000; + rate->max =3D 48000; + channels->min =3D 2; + channels->max =3D 2; + + /* + * Configure SSP2 for the 24-bit format expected by the codec. The SST + * ssp2-port front end still advertises S16_LE and converts the stream. + */ + params_set_format(params, SNDRV_PCM_FORMAT_S24_LE); + + return 0; +} + +static struct snd_soc_jack_pin cht_yb_jack_pins[] =3D { + { + .pin =3D "Headphone", + .mask =3D SND_JACK_HEADPHONE, + }, + { + .pin =3D "Headset Mic", + .mask =3D SND_JACK_MICROPHONE, + }, +}; + +static int cht_yb_headset_init(struct snd_soc_component *component) +{ + struct snd_soc_card *card =3D component->card; + struct cht_mc_private *ctx =3D snd_soc_card_get_drvdata(card); + struct snd_soc_jack *jack =3D &ctx->jack; + int jack_type; + int ret; + + /* + * TI supports four headset buttons: + * KEY_MEDIA + * KEY_VOICECOMMAND + * KEY_VOLUMEUP + * KEY_VOLUMEDOWN + */ + jack_type =3D SND_JACK_HEADPHONE | SND_JACK_MICROPHONE | + SND_JACK_BTN_0 | SND_JACK_BTN_1 | + SND_JACK_BTN_2 | SND_JACK_BTN_3; + + ret =3D snd_soc_card_jack_new_pins(card, "Headset Jack", jack_type, + jack, cht_yb_jack_pins, + ARRAY_SIZE(cht_yb_jack_pins)); + if (ret) { + dev_err(card->dev, "Headset Jack creation failed %d\n", ret); + return ret; + } + + return ts3a227e_enable_jack_detect(component, jack); +} + +static int cht_aif1_startup(struct snd_pcm_substream *substream) +{ + return snd_pcm_hw_constraint_single(substream->runtime, + SNDRV_PCM_HW_PARAM_RATE, 48000); +} + +static const struct snd_soc_ops cht_aif1_ops =3D { + .startup =3D cht_aif1_startup, +}; + +static const struct snd_soc_ops cht_be_ssp2_ops =3D { + .hw_params =3D cht_aif1_hw_params, +}; + +static const struct snd_soc_aux_dev cht_yb_headset_dev =3D { + .dlc =3D COMP_AUX("i2c-ts3a227e"), + .init =3D cht_yb_headset_init, +}; + +SND_SOC_DAILINK_DEF(dummy, DAILINK_COMP_ARRAY(COMP_DUMMY())); + +SND_SOC_DAILINK_DEF(media, DAILINK_COMP_ARRAY(COMP_CPU("media-cpu-dai"))); + +SND_SOC_DAILINK_DEF(deepbuffer, DAILINK_COMP_ARRAY(COMP_CPU("deepbuffer-cp= u-dai"))); + +SND_SOC_DAILINK_DEF(ssp2_port, DAILINK_COMP_ARRAY(COMP_CPU("ssp2-port"))); +SND_SOC_DAILINK_DEF(ssp2_codec, DAILINK_COMP_ARRAY(COMP_CODEC(RT5677_I2C, = CHT_CODEC_DAI))); + +SND_SOC_DAILINK_DEF(platform, DAILINK_COMP_ARRAY(COMP_PLATFORM("sst-mfld-p= latform"))); + +static const struct snd_soc_dai_link cht_dailink[] =3D { + /* Front End DAI links */ + [MERR_DPCM_AUDIO] =3D { + .name =3D "Audio Port", + .stream_name =3D "Audio", + .nonatomic =3D true, + .dynamic =3D 1, + .ops =3D &cht_aif1_ops, + SND_SOC_DAILINK_REG(media, dummy, platform), + }, + [MERR_DPCM_DEEP_BUFFER] =3D { + .name =3D "Deep-Buffer Audio Port", + .stream_name =3D "Deep-Buffer Audio", + .nonatomic =3D true, + .dynamic =3D 1, + .playback_only =3D 1, + .ops =3D &cht_aif1_ops, + SND_SOC_DAILINK_REG(deepbuffer, dummy, platform), + }, + + /* Back End DAI links */ + { + /* SSP2 - Codec */ + .name =3D "SSP2-Codec", + .id =3D 0, + .no_pcm =3D 1, + .nonatomic =3D true, + .init =3D cht_codec_init, + .be_hw_params_fixup =3D cht_codec_fixup, + .ops =3D &cht_be_ssp2_ops, + SND_SOC_DAILINK_REG(ssp2_port, ssp2_codec, platform), + }, +}; + +/* SoC card */ +static const struct snd_soc_card snd_soc_card_cht =3D { + .owner =3D THIS_MODULE, + .num_links =3D ARRAY_SIZE(cht_dailink), + .num_aux_devs =3D 1, + .dapm_widgets =3D cht_dapm_widgets, + .num_dapm_widgets =3D ARRAY_SIZE(cht_dapm_widgets), + .dapm_routes =3D cht_audio_map, + .num_dapm_routes =3D ARRAY_SIZE(cht_audio_map), + .controls =3D cht_mc_controls, + .num_controls =3D ARRAY_SIZE(cht_mc_controls), +}; + +static const struct acpi_gpio_params speaker_enable_gpio =3D { 2, 0, false= }; +static const struct acpi_gpio_mapping cht_yb_gpios[] =3D { + { "speaker-enable-gpios", &speaker_enable_gpio, 1 }, + { NULL } +}; + +#define SOF_CARD_NAME "cht yogabook" +#define SOF_DRIVER_NAME "SOF" + +#define CARD_NAME "cht-yogabook" +#define DRIVER_NAME NULL + +static int snd_cht_mc_probe(struct platform_device *pdev) +{ + struct cht_mc_private *drv; + struct snd_soc_acpi_mach *mach =3D pdev->dev.platform_data; + struct snd_soc_aux_dev *aux_dev; + struct snd_soc_dai_link_component *codecs; + struct snd_soc_dai_link *dai_links; + struct snd_soc_card *card; + const void *codec_template; + size_t codecs_size; + const char *platform_name; + struct acpi_device *adev; + struct device *codec_dev; + bool has_acpi_codec =3D false; + bool sof_parent; + int ret; + int i; + + drv =3D devm_kzalloc(&pdev->dev, sizeof(*drv), GFP_KERNEL); + if (!drv) + return -ENOMEM; + + card =3D devm_kmemdup(&pdev->dev, &snd_soc_card_cht, sizeof(*card), GFP_K= ERNEL); + if (!card) + return -ENOMEM; + + dai_links =3D devm_kmemdup(&pdev->dev, cht_dailink, sizeof(cht_dailink), = GFP_KERNEL); + if (!dai_links) + return -ENOMEM; + + aux_dev =3D devm_kmemdup(&pdev->dev, &cht_yb_headset_dev, + sizeof(cht_yb_headset_dev), GFP_KERNEL); + if (!aux_dev) + return -ENOMEM; + + card->dai_link =3D dai_links; + card->aux_dev =3D aux_dev; + drv->jack_nb.notifier_call =3D cht_yb_jack_event; + + strscpy(drv->codec_name, RT5677_I2C, sizeof(drv->codec_name)); + + /* fixup codec name based on HID if ACPI node is present */ + adev =3D acpi_dev_get_first_match_dev(mach->id, NULL, -1); + if (adev) { + has_acpi_codec =3D true; + snprintf(drv->codec_name, sizeof(drv->codec_name), + "i2c-%s", acpi_dev_name(adev)); + dev_info(&pdev->dev, "real codec name: %s\n", drv->codec_name); + + put_device(&adev->dev); + for (i =3D 0; i < card->num_links; i++) { + if (dai_links[i].codecs->name && + !strcmp(dai_links[i].codecs->name, + RT5677_I2C)) { + codecs_size =3D sizeof(*codecs) * dai_links[i].num_codecs; + codec_template =3D dai_links[i].codecs; + codecs =3D devm_kmemdup(&pdev->dev, codec_template, codecs_size, + GFP_KERNEL); + if (!codecs) + return -ENOMEM; + + codecs->name =3D drv->codec_name; + dai_links[i].codecs =3D codecs; + break; + } + } + } + + codec_dev =3D bus_find_device_by_name(&i2c_bus_type, NULL, + drv->codec_name); + if (!codec_dev) + return -EPROBE_DEFER; + + if (has_acpi_codec) { + ret =3D devm_acpi_dev_add_driver_gpios(codec_dev, cht_yb_gpios); + if (ret) + dev_warn(&pdev->dev, "Unable to add GPIO mapping table: %d\n", + ret); + } + put_device(codec_dev); + + /* Override platform name, if required. */ + card->dev =3D &pdev->dev; + platform_name =3D mach->mach_params.platform; + + ret =3D snd_soc_fixup_dai_links_platform_name(card, platform_name); + if (ret) { + dev_err(&pdev->dev, "snd_soc_fixup_dai_links_platform_name failed: %d\n", + ret); + return ret; + } + + drv->mclk =3D devm_clk_get(&pdev->dev, "pmc_plt_clk_3"); + if (IS_ERR(drv->mclk)) { + dev_err(&pdev->dev, + "Failed to get MCLK from pmc_plt_clk_3: %ld\n", + PTR_ERR(drv->mclk)); + return PTR_ERR(drv->mclk); + } + snd_soc_card_set_drvdata(card, drv); + + sof_parent =3D snd_soc_acpi_sof_parent(&pdev->dev); + + /* set the card and driver name */ + if (sof_parent) { + card->name =3D SOF_CARD_NAME; + card->driver_name =3D SOF_DRIVER_NAME; + } else { + card->name =3D CARD_NAME; + card->driver_name =3D DRIVER_NAME; + } + + /* register the soc card */ + ret =3D devm_snd_soc_register_card(&pdev->dev, card); + if (ret) { + dev_err(&pdev->dev, + "snd_soc_register_card failed %d\n", ret); + return ret; + } + platform_set_drvdata(pdev, card); + + return 0; +} + +static struct platform_driver snd_cht_mc_driver =3D { + .driver =3D { + .name =3D "cht-yogabook", + }, + .probe =3D snd_cht_mc_probe, +}; + +module_platform_driver(snd_cht_mc_driver); + +MODULE_DESCRIPTION("Lenovo Yoga Book YB1-X91 machine driver"); +MODULE_LICENSE("GPL"); +MODULE_ALIAS("platform:cht-yogabook"); --=20 2.53.0 From nobody Mon Sep 28 04:53:55 2026 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBE7842466A for ; Wed, 26 Aug 2026 13:23:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787750635; cv=none; b=NOrcK5ySzd8oWqv1kW2roSEorQFDCXEfdpryNoXSk0mMMnRlQmVSUg+a5kmk/VvVE1xN0oVj9acm7MP2hYrUJj2m7uGrU8gfIG5yTipP6Qe2RMBEOok4Mfajr3qYIaILfoyty8qMCviWGiBl/3XcObGuusBmbC0CJiFE6eBLwyc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787750635; c=relaxed/simple; bh=NJ6RnEv70zpJM8I9fP8i0P+6NmKcI0fX6zr6eP4Q38k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qVgyLENGPOECytlS8tnucHPRqgDfzpB/RXS0lYV+TK2X/t6tnIA0wQqPw1yffylOsYR1M4vydefqh6mWcWjDc/JFqEs4kvjW4Qbi9ZmPiaGqrh/GcOv2baE5ZoCJE/bazL6j88gYtuG3xMoLP6oocijYBeXt7kBtElQ62MQbNn4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KJjUOdP2; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KJjUOdP2" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-c252cd2b3c1so70295866b.2 for ; Wed, 26 Aug 2026 06:23:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787750628; x=1788355428; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=4VAT0T5auzwEUMc8PKzeTgZNflNYpYN7TUG5tnzFp2w=; b=KJjUOdP2QR/TtXIVZQhuNN05dIUBAEj957g+SO8oZoDh+r71d46EWNZLsyUi5zaJI6 LBaLmU8sKpRoTTC85tMG4Md0d8vCrGmgFZCk4f4wPlhIOGc39PEJEKDqLLNtKVpgxOsn WA8eVyGiQGgOf71p2xHfV2KsIxPfHAuX0s0b53KDm45/xXXKynqvW1TuOfhzz3Tce8WQ 4ghboFwrqHuLt8WMMVNRnmHPN2owkiSRA6LfCRXd41VvKIIZ5df3/7faYBFsy3iRPFTc i/xpSj6sqY7RJb/ybgPd8BhGjqwGM/pvk8DLwjdUf+dPeyKSssZ7JQRWDPJFP+RmQZst 6xpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787750628; x=1788355428; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=4VAT0T5auzwEUMc8PKzeTgZNflNYpYN7TUG5tnzFp2w=; b=bRpVWZumoi7R9FYWcjrjBXuEg4sPAdzh21lpOxbsLbp7mO6FDVXg28SG5epBRPtlfw UB2G4NEzrhsiBGWQ2OAOM5TxlpOvzsxglDblADkHORNAGh8yl4q+18zMK8Zi4E1ADEv/ PBlJwUudGV3+6otJRQCsP9GZAtvsspwTjdkrdlt42kF7knr4jnfBbqvYYQVOdpJB5Uek 6xpNqFxX9dk2YXwhe7nzT7wtGdA5lawVaxIybBnBEzBavTaUswPdYn9bc1NzzCCKxnnO rQMDwA3wPfZK1e+V/XydNAl8O7YD2/8sJNhLOfBF7tyPGPEHYIpz+Du3vPfT1p3pLly5 TmBg== X-Forwarded-Encrypted: i=1; AHgh+RrSIwOVkzjmczOtTeVLlnlF+GjmqRx7UDDpEXM9QzOs9SuL02FKq9FlCH5ZMcXPhUV04+LSGavdpkFNLkU=@vger.kernel.org X-Gm-Message-State: AFuF++nhI1B3bLUngZ/0eCz7o7G3UiE1FsDs2HLPuhpJNPw1JczbQw/I v362HqsCFasCXRLPEaimvxzOERrLVuKDxJRzaScgaT0KDhmmpGHDClWL X-Gm-Gg: AR+sD12YYaFMAh4cL+jhZyIj62L6fYPk+OTApJMDbbN04+YkC6n2uMrzszigb+s5Jv1 wZSDmtfN4cSBPhD0sGo+7dYA96pnJuqzdNNuMXCDR7S9pJcTWG73sF2RDMREe0CUhGHM1w+Ehfd 7pVcECegvXuV1rTYv8jHtq/SUsfVq/IzZkA8dPjthamCUXb5Fs7Xe0ZqKyo/ZTpkyKn7JS0E5SI Bhm06boIg+EQVJzrb4UsVEhsy10hO2JPAs5ZyRoReRr8Wk0ZJcKfcFH2ZA/sNXHP6BpTEnRQJnG PSeSJCrse/QHJaRDGpR49EEho0jzad9soO7Prwo7EDsVCo3c2m7ZkbhOR/HQoWSIGDONy6WGGj7 QIItX8aIFdVp2+avckq0/jie7LKuJbkk3qkxdv2WFxQUkeQIgY6mfTEwtx/vMub1E7GPJq8/Hys pDhjPfMVL3JqLTNoBNF6riHbiyg2oKHHKFGJtpTpTBXzYvtpiGxAxwihxVlYyTk4rTLJuFsfRe3 q04Ra/VGxkBbvyvSRrtnWeKg6u5ulOS5Y5sujq2HJM= X-Received: by 2002:a17:907:9815:b0:c20:5798:7b9f with SMTP id a640c23a62f3a-c250bc1567amr880518666b.10.1787750627651; Wed, 26 Aug 2026 06:23:47 -0700 (PDT) Received: from 1Z10 ([37.163.238.51]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c250f99f6bdsm376856066b.0.2026.08.26.06.23.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2026 06:23:47 -0700 (PDT) From: Maurizio Casciano To: Mark Brown Cc: Cezary Rojewski , Liam Girdwood , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Jaroslav Kysela , Takashi Iwai , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Maurizio Casciano Subject: [RFC PATCH 2/3] ASoC: Intel: cht: Match the Yoga Book RT5677 machine Date: Wed, 26 Aug 2026 15:23:33 +0200 Message-ID: <20260826132334.3344395-3-mauriziocasciano7@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260826132334.3344395-1-mauriziocasciano7@gmail.com> References: <20260826132334.3344395-1-mauriziocasciano7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Yoga Book YB1-X91F/L exposes its RT5677 codec as ACPI device 10EC5677. Add a Cherry Trail machine-table entry so SST creates the cht-yogabook machine device and loads intel/fw_sst_22a8.bin. Keep SOF topology selection separate. The following patch names the matching topology and documents its external SOF project dependency. Signed-off-by: Maurizio Casciano Assisted-by: Codex:gpt-5.6-sol sparse --- sound/soc/intel/common/soc-acpi-intel-cht-match.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/sound/soc/intel/common/soc-acpi-intel-cht-match.c b/sound/soc/= intel/common/soc-acpi-intel-cht-match.c index e4c3492a0c28..f9acf6a41c1a 100644 --- a/sound/soc/intel/common/soc-acpi-intel-cht-match.c +++ b/sound/soc/intel/common/soc-acpi-intel-cht-match.c @@ -137,6 +137,13 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_cherrytra= il_machines[] =3D { .board =3D "cht-bsw", .sof_tplg_filename =3D "sof-cht-rt5670.tplg", }, + { + /* Lenovo Yoga Book YB1-X91F/L */ + .id =3D "10EC5677", + .drv_name =3D "cht-yogabook", + .fw_filename =3D "intel/fw_sst_22a8.bin", + .board =3D "cht-yogabook", + }, { .comp_ids =3D &rt5645_comp_ids, .drv_name =3D "cht-bsw-rt5645", --=20 2.53.0 From nobody Mon Sep 28 04:53:55 2026 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B17AE3F8ED6 for ; Wed, 26 Aug 2026 13:23:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787750635; cv=none; b=HGaOvn8+sUkpLs5rJhN6W/Jb+S1N/xbPSHCM/ybmU19l/IVeIVO9QM+l+KD1Qa+flwgLU4YAKUzmUxPQFbwroTTO54xMyd5J9GG5AakDrH3gJXW+OTniLstFsSeVtbzeFHzC571CZk/msyOQTn858Ux39qBdAefuDkUXPRSd5Gw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787750635; c=relaxed/simple; bh=T+joPVnG6nvb8UuuJNDmhlDnO5Nd91bhNAODW8Wk1i0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NchLdkr1GI5BO+7ZiAz56exnU4e6U4OGy/m2YGPOJAICEgiaZ2iqRZTqxGuLVZTZG1CX6sHf3gWTgQrYTu4Mq11pwSmLOtof9e/k7blAXC1SoSTENS4EeUX++CZvBI2oGeKNMkVsrMhqCU/J0jBV0rTLFEdzOT5nXn3ZQVza4mU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=giqvG1Qm; arc=none smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="giqvG1Qm" Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-6a0a4a28cbdso1714213a12.3 for ; Wed, 26 Aug 2026 06:23:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787750630; x=1788355430; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=GiQlsaqiCq4AJU78JobgI8TyOaikqXTsloeCjW9W5G8=; b=giqvG1QmNvWw+jfopHSS3fNNjtlZV5WfkhkHWcpkyZbXImoXfKcgdghjNqJFkeM2Pt yL3lrzZc7wvwaV4j9fecx5qKsZDkMZG34qT+TmHEn4xMosw7UcZU7eiV8uIPxmRctIMd OdM7b3HBpBT3eXwZW6e60Vtkz4n2BJTk4wDA+JzupkHjU8iuGGggru6av9o87yUsyYW6 kL+YfLUDAiZ5XltAOCUtXwR3tJrKQMyVnKNW+LmN9svbCe/c11XlT9worseifkK5vKCM FyLUplz3VGvWCYlYKH9oRa/x/hvqu3qdVLQqIAa+pXcLgpylZZBhq6bOmHMQyD/ccKje M4kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787750630; x=1788355430; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=GiQlsaqiCq4AJU78JobgI8TyOaikqXTsloeCjW9W5G8=; b=FgDgZjaK6ApWDQ6xaj5eezH4i4NivQ/Dd66TMN8LZUzdTU5Z6o4jqtE7NCr/VYuHYz BIETxNW4iPEoDHJz7zx2PSgsz0v1rNG7J6XxIEA8BjVTxX1VbhSy9WG8egc/LZE6P2A5 DG8z7ZwmQZXbFHUagCVjLdoPf2FsIUL3F95Z0OPcaItiTcea/AMdxRjSbL8V5ry6bn18 yAqFMjqX1MsZLMSRoBJLz4cV2wQQTLWyevEuOCg4hmKWXYOn1PCo99Aw9sZbiPKbJvTM 8tfM+SLd0VUqAgqMKiW/KCplVT/YXgezx/TcfUTn91U4c+GuizFjH2vhlwnPHXytJo6T n0iQ== X-Forwarded-Encrypted: i=1; AHgh+RoVTfHW75oDft/xA37Iu7r6HUaot4j5eewYe71chpKEZ4epZk+4b2EzRvHtCrkCdBIUfGftA51uVJowkrU=@vger.kernel.org X-Gm-Message-State: AFuF++ne7mm+aRQOXrcfoOQtROmX0wIM/QmJiIowl14v0w8AMNsHgTjs W6RHChLva7jnmQ1TVDPwFeZY7uClj4jKGAGiTJJoNZYFmxj84hA2Xnny X-Gm-Gg: AR+sD10Ms+kI5FQXnjKRstyIgXpRbGOsFbtMOX+S9iBuqHrB1aZykKJUHQB6Ior4JhL JkswMIFJGL33TnlbQxSckslVJT7+gtCFGaCoIGGheYGB9aVZzdeO1qNZ/vG7MRxOXdrhLRxFvrF hF7ImwIDHQC8yEHY6mJVKV6Ch64Ho3vbWqXFGZkn9f9H2fL7AK60ggiemGNklhPUDuz2qtLswom PyDKHgIXQ2+HDKSrA3JrteNxB0Ixv2SZq3/ntXhAuxfHdtkenVIBZrfZ2+0jUfxYg1l3SbvQ/1f FjgoITwC4gT9C+Ad9JoBPq+YggQeMkba2v3fMYnEfWa5cs9qK37PthAo5Q7KcBUMsuilZSa2XGC 20F6cQlPeZN8Nv0p07JsBRdiP/aEE/k0zSQPYCvKrjvB51mrg0y7qGr/BQqjy0qYpyQx0ysiJRn 8EG1iUF6e5HXvACCFaERapmxIiwz1wiC7Y3qGCYUU1k6m4KJAEFXBQ2v7dTTn1Z5Kah6hbOhtcB bkGQ8joz9YuPhtVu1YE/CZIZeZ31iS8PAHBH8xAvco= X-Received: by 2002:a17:907:5c3:b0:bec:64d4:3872 with SMTP id a640c23a62f3a-c250c3cc2eemr811074566b.24.1787750629533; Wed, 26 Aug 2026 06:23:49 -0700 (PDT) Received: from 1Z10 ([37.163.238.51]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c250f99f6bdsm376856066b.0.2026.08.26.06.23.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2026 06:23:48 -0700 (PDT) From: Maurizio Casciano To: Mark Brown Cc: Cezary Rojewski , Liam Girdwood , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Jaroslav Kysela , Takashi Iwai , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Maurizio Casciano Subject: [RFC PATCH 3/3] ASoC: Intel: cht: Add Yoga Book SOF topology filename Date: Wed, 26 Aug 2026 15:23:34 +0200 Message-ID: <20260826132334.3344395-4-mauriziocasciano7@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260826132334.3344395-1-mauriziocasciano7@gmail.com> References: <20260826132334.3344395-1-mauriziocasciano7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Cherry Trail SOF machine selection requires each matched machine to provide a topology filename. Without one, atom_machine_select() rejects the Yoga Book entry and the SOF sound card cannot register. Associate the RT5677 Yoga Book machine with sof-cht-rt5677.tplg. The IPC3 driver then loads intel/sof-tplg/sof-cht-rt5677.tplg through the standard firmware search path. The matching topology sources are maintained in the SOF project and must be merged and distributed separately; this kernel change only provides the standard firmware filename. Signed-off-by: Maurizio Casciano Assisted-by: Codex:gpt-5.6-sol sparse --- sound/soc/intel/common/soc-acpi-intel-cht-match.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/intel/common/soc-acpi-intel-cht-match.c b/sound/soc/= intel/common/soc-acpi-intel-cht-match.c index f9acf6a41c1a..4ffd4ab57b1f 100644 --- a/sound/soc/intel/common/soc-acpi-intel-cht-match.c +++ b/sound/soc/intel/common/soc-acpi-intel-cht-match.c @@ -143,6 +143,7 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_cherrytrai= l_machines[] =3D { .drv_name =3D "cht-yogabook", .fw_filename =3D "intel/fw_sst_22a8.bin", .board =3D "cht-yogabook", + .sof_tplg_filename =3D "sof-cht-rt5677.tplg", }, { .comp_ids =3D &rt5645_comp_ids, --=20 2.53.0