drivers/staging/rtl8723bs/core/rtw_efuse.c | 120 +++++++++--------- drivers/staging/rtl8723bs/include/rtw_efuse.h | 6 +- 2 files changed, 63 insertions(+), 63 deletions(-)
Avoid CamelCase naming for local variables, function parameters,
and static helper functions in rtw_efuse.c as well as associated
prototypes in rtw_efuse.h to adhere to the Linux
kernel coding style and clear checkpatch.pl checks.
Signed-off-by: Philip Nielsen <philipnielsen64@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_efuse.c | 120 +++++++++---------
drivers/staging/rtl8723bs/include/rtw_efuse.h | 6 +-
2 files changed, 63 insertions(+), 63 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
index 168ecb7a998f..8e795f23899f 100644
--- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
+++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
@@ -41,48 +41,48 @@ rtw_efuse_calculate_word_counts(u8 word_en)
* 09/23/2008 MHC Copy from WMAC.
*
*/
-u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address)
+u8 rtw_efuse_read_1_byte(struct adapter *adapter, u16 address)
{
- u8 Bytetemp = {0x00};
+ u8 byte_temp = {0x00};
u8 temp = {0x00};
u32 k = 0;
- u16 contentLen = 0;
+ u16 content_len = 0;
- Hal_GetEfuseDefinition(Adapter, EFUSE_WIFI, TYPE_EFUSE_REAL_CONTENT_LEN, &contentLen);
+ Hal_GetEfuseDefinition(adapter, EFUSE_WIFI, TYPE_EFUSE_REAL_CONTENT_LEN, &content_len);
- if (Address < contentLen) {/* E-fuse 512Byte */
+ if (address < content_len) {/* E-fuse 512Byte */
/* Write E-fuse Register address bit0~7 */
- temp = Address & 0xFF;
- rtw_write8(Adapter, EFUSE_CTRL + 1, temp);
- Bytetemp = rtw_read8(Adapter, EFUSE_CTRL + 2);
+ temp = address & 0xFF;
+ rtw_write8(adapter, EFUSE_CTRL + 1, temp);
+ byte_temp = rtw_read8(adapter, EFUSE_CTRL + 2);
/* Write E-fuse Register address bit8~9 */
- temp = ((Address >> 8) & 0x03) | (Bytetemp & 0xFC);
- rtw_write8(Adapter, EFUSE_CTRL + 2, temp);
+ temp = ((address >> 8) & 0x03) | (byte_temp & 0xFC);
+ rtw_write8(adapter, EFUSE_CTRL + 2, temp);
/* Write 0x30[31]= 0 */
- Bytetemp = rtw_read8(Adapter, EFUSE_CTRL + 3);
- temp = Bytetemp & 0x7F;
- rtw_write8(Adapter, EFUSE_CTRL + 3, temp);
+ byte_temp = rtw_read8(adapter, EFUSE_CTRL + 3);
+ temp = byte_temp & 0x7F;
+ rtw_write8(adapter, EFUSE_CTRL + 3, temp);
/* Wait Write-ready (0x30[31]= 1) */
- Bytetemp = rtw_read8(Adapter, EFUSE_CTRL + 3);
- while (!(Bytetemp & 0x80)) {
- Bytetemp = rtw_read8(Adapter, EFUSE_CTRL + 3);
+ byte_temp = rtw_read8(adapter, EFUSE_CTRL + 3);
+ while (!(byte_temp & 0x80)) {
+ byte_temp = rtw_read8(adapter, EFUSE_CTRL + 3);
k++;
if (k == 1000)
break;
}
- return rtw_read8(Adapter, EFUSE_CTRL);
+ return rtw_read8(adapter, EFUSE_CTRL);
} else {
return 0xFF;
}
} /* rtw_efuse_read_1_byte */
-/* 11/16/2008 MH Read one byte from real Efuse. */
+/* 11/16/2008 MH Read one byte from real efuse. */
u8 rtw_efuse_one_byte_read(struct adapter *padapter, u16 addr, u8 *data)
{
u32 tmpidx = 0;
- u8 bResult;
+ u8 b_result;
u8 readbyte;
/* <20130121, Kordan> For SMIC EFUSE specificatoin. */
@@ -107,19 +107,19 @@ u8 rtw_efuse_one_byte_read(struct adapter *padapter, u16 addr, u8 *data)
}
if (tmpidx < 100) {
*data = rtw_read8(padapter, EFUSE_CTRL);
- bResult = true;
+ b_result = true;
} else {
*data = 0xff;
- bResult = false;
+ b_result = false;
}
- return bResult;
+ return b_result;
}
/*-----------------------------------------------------------------------------
- * Function: Efuse_ReadAllMap
+ * Function: efuse_read_all_map
*
- * Overview: Read All Efuse content
+ * Overview: Read All efuse content
*
* Input: NONE
*
@@ -132,23 +132,23 @@ u8 rtw_efuse_one_byte_read(struct adapter *padapter, u16 addr, u8 *data)
* 11/11/2008 MHC Create Version 0.
*
*/
-static void Efuse_ReadAllMap(struct adapter *padapter, u8 efuseType, u8 *Efuse)
+static void efuse_read_all_map(struct adapter *padapter, u8 efuse_type, u8 *efuse)
{
- u16 mapLen = 0;
+ u16 map_len = 0;
Hal_EfusePowerSwitch(padapter, true);
- Hal_GetEfuseDefinition(padapter, efuseType, TYPE_EFUSE_MAP_LEN, &mapLen);
+ Hal_GetEfuseDefinition(padapter, efuse_type, TYPE_EFUSE_MAP_LEN, &map_len);
- Hal_ReadEFuse(padapter, efuseType, 0, mapLen, Efuse);
+ Hal_ReadEFuse(padapter, efuse_type, 0, map_len, efuse);
Hal_EfusePowerSwitch(padapter, false);
}
/*-----------------------------------------------------------------------------
- * Function: efuse_ShadowRead1Byte
- * efuse_ShadowRead2Byte
- * efuse_ShadowRead4Byte
+ * Function: efuse_shadow_read_1byte
+ * efuse_shadow_read_2byte
+ * efuse_shadow_read_4byte
*
* Overview: Read from efuse init map by one/two/four bytes !!!!!
*
@@ -163,35 +163,35 @@ static void Efuse_ReadAllMap(struct adapter *padapter, u8 efuseType, u8 *Efuse)
* 11/12/2008 MHC Create Version 0.
*
*/
-static void efuse_ShadowRead1Byte(struct adapter *padapter, u16 Offset, u8 *Value)
+static void efuse_shadow_read_1byte(struct adapter *padapter, u16 offset, u8 *value)
{
- struct eeprom_priv *pEEPROM = GET_EEPROM_EFUSE_PRIV(padapter);
+ struct eeprom_priv *eeprom = GET_EEPROM_EFUSE_PRIV(padapter);
- *Value = pEEPROM->efuse_eeprom_data[Offset];
+ *value = eeprom->efuse_eeprom_data[offset];
} /* EFUSE_ShadowRead1Byte */
/* Read Two Bytes */
-static void efuse_ShadowRead2Byte(struct adapter *padapter, u16 Offset, u16 *Value)
+static void efuse_shadow_read_2byte(struct adapter *padapter, u16 offset, u16 *value)
{
- struct eeprom_priv *pEEPROM = GET_EEPROM_EFUSE_PRIV(padapter);
+ struct eeprom_priv *eeprom = GET_EEPROM_EFUSE_PRIV(padapter);
- *Value = pEEPROM->efuse_eeprom_data[Offset];
- *Value |= pEEPROM->efuse_eeprom_data[Offset + 1] << 8;
+ *value = eeprom->efuse_eeprom_data[offset];
+ *value |= eeprom->efuse_eeprom_data[offset + 1] << 8;
} /* EFUSE_ShadowRead2Byte */
/* Read Four Bytes */
-static void efuse_ShadowRead4Byte(struct adapter *padapter, u16 Offset, u32 *Value)
+static void efuse_shadow_read_4byte(struct adapter *padapter, u16 offset, u32 *value)
{
- struct eeprom_priv *pEEPROM = GET_EEPROM_EFUSE_PRIV(padapter);
+ struct eeprom_priv *eeprom = GET_EEPROM_EFUSE_PRIV(padapter);
- *Value = pEEPROM->efuse_eeprom_data[Offset];
- *Value |= pEEPROM->efuse_eeprom_data[Offset + 1] << 8;
- *Value |= pEEPROM->efuse_eeprom_data[Offset + 2] << 16;
- *Value |= pEEPROM->efuse_eeprom_data[Offset + 3] << 24;
+ *value = eeprom->efuse_eeprom_data[offset];
+ *value |= eeprom->efuse_eeprom_data[offset + 1] << 8;
+ *value |= eeprom->efuse_eeprom_data[offset + 2] << 16;
+ *value |= eeprom->efuse_eeprom_data[offset + 3] << 24;
-} /* efuse_ShadowRead4Byte */
+} /* efuse_shadow_read_4byte */
/*-----------------------------------------------------------------------------
* Function: rtw_efuse_shadow_map_update
@@ -209,20 +209,20 @@ static void efuse_ShadowRead4Byte(struct adapter *padapter, u16 Offset, u32 *Val
* 11/13/2008 MHC Create Version 0.
*
*/
-void rtw_efuse_shadow_map_update(struct adapter *padapter, u8 efuseType)
+void rtw_efuse_shadow_map_update(struct adapter *padapter, u8 efuse_type)
{
- struct eeprom_priv *pEEPROM = GET_EEPROM_EFUSE_PRIV(padapter);
- u16 mapLen = 0;
+ struct eeprom_priv *eeprom = GET_EEPROM_EFUSE_PRIV(padapter);
+ u16 map_len = 0;
- Hal_GetEfuseDefinition(padapter, efuseType, TYPE_EFUSE_MAP_LEN, &mapLen);
+ Hal_GetEfuseDefinition(padapter, efuse_type, TYPE_EFUSE_MAP_LEN, &map_len);
- if (pEEPROM->bautoload_fail_flag)
- memset(pEEPROM->efuse_eeprom_data, 0xFF, mapLen);
+ if (eeprom->bautoload_fail_flag)
+ memset(eeprom->efuse_eeprom_data, 0xFF, map_len);
else
- Efuse_ReadAllMap(padapter, efuseType, pEEPROM->efuse_eeprom_data);
+ efuse_read_all_map(padapter, efuse_type, eeprom->efuse_eeprom_data);
/* PlatformMoveMemory((void *)&pHalData->EfuseMap[EFUSE_MODIFY_MAP][0], */
- /* void *)&pHalData->EfuseMap[EFUSE_INIT_MAP][0], mapLen); */
+ /* void *)&pHalData->EfuseMap[EFUSE_INIT_MAP][0], map_len); */
} /* rtw_efuse_shadow_map_update */
/*-----------------------------------------------------------------------------
@@ -241,13 +241,13 @@ void rtw_efuse_shadow_map_update(struct adapter *padapter, u8 efuseType)
* 11/12/2008 MHC Create Version 0.
*
*/
-void rtw_efuse_shadow_read(struct adapter *padapter, u8 Type, u16 Offset, u32 *Value)
+void rtw_efuse_shadow_read(struct adapter *padapter, u8 type, u16 offset, u32 *value)
{
- if (Type == 1)
- efuse_ShadowRead1Byte(padapter, Offset, (u8 *)Value);
- else if (Type == 2)
- efuse_ShadowRead2Byte(padapter, Offset, (u16 *)Value);
- else if (Type == 4)
- efuse_ShadowRead4Byte(padapter, Offset, (u32 *)Value);
+ if (type == 1)
+ efuse_shadow_read_1byte(padapter, offset, (u8 *)value);
+ else if (type == 2)
+ efuse_shadow_read_2byte(padapter, offset, (u16 *)value);
+ else if (type == 4)
+ efuse_shadow_read_4byte(padapter, offset, (u32 *)value);
} /* rtw_efuse_shadow_read*/
diff --git a/drivers/staging/rtl8723bs/include/rtw_efuse.h b/drivers/staging/rtl8723bs/include/rtw_efuse.h
index 808ba94a5998..d1b518be3b7d 100644
--- a/drivers/staging/rtl8723bs/include/rtw_efuse.h
+++ b/drivers/staging/rtl8723bs/include/rtw_efuse.h
@@ -71,8 +71,8 @@ struct efuse_hal {
u8 rtw_efuse_calculate_word_counts(u8 word_en);
u8 rtw_efuse_one_byte_read(struct adapter *padapter, u16 addr, u8 *data);
-u8 rtw_efuse_read_1_byte(struct adapter *padapter, u16 Address);
-void rtw_efuse_shadow_map_update(struct adapter *padapter, u8 efuseType);
-void rtw_efuse_shadow_read(struct adapter *padapter, u8 Type, u16 Offset, u32 *Value);
+u8 rtw_efuse_read_1_byte(struct adapter *padapter, u16 address);
+void rtw_efuse_shadow_map_update(struct adapter *padapter, u8 efuse_type);
+void rtw_efuse_shadow_read(struct adapter *padapter, u8 type, u16 offset, u32 *value);
#endif
--
2.55.0On Mon, Aug 17, 2026 at 05:45:55PM +0200, Philip Nielsen wrote: > Avoid CamelCase naming for local variables, function parameters, > and static helper functions in rtw_efuse.c as well as associated > prototypes in rtw_efuse.h to adhere to the Linux > kernel coding style and clear checkpatch.pl checks. > > Signed-off-by: Philip Nielsen <philipnielsen64@gmail.com> > --- > drivers/staging/rtl8723bs/core/rtw_efuse.c | 120 +++++++++--------- > drivers/staging/rtl8723bs/include/rtw_efuse.h | 6 +- > 2 files changed, 63 insertions(+), 63 deletions(-) Does not apply to the staging-testing branch. Can you rebase and resend? thanks, greg k-h
© 2016 - 2026 Red Hat, Inc.