From nobody Mon Sep 28 21:03:43 2026 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58DF0442FCB for ; Mon, 17 Aug 2026 15:46:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786981578; cv=none; b=Qd5Lo1swuPcaI5w/HEDtsB+LQU5BoZiUpSbe6TOkFEk25/CE9kaQXYV3nJvzjifcdaAv0EjQoL0Dx1C+4a4HTSm/eHvypEvENdgGaGyBtJbEFhSRuTkDE6Jqex4Ll52bVPGHpPsTZ5+eh6f5ROgguFTm2OngMTrgBQy4uMHmsjA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786981578; c=relaxed/simple; bh=fct7YRnWgARxx1I/WreV389DDBHqu5eSjVTb1oamc3g=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=koVW4iNIHPIEd5WrPT3ho0CseuwAuATYrWv4BjvHp1lWCPzBcTcpOHrqpD6iXtHOHj8JpiCgUi678lN7IbHbdb5W6s9KpMg3xpVkarvSwOrDvOC/vGD3kptekYl/MfWBgC9uzL+owWKkHdfRsVBRVkNHFp2nBI1GWpj0tSKi5l4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=S9+gb2sj; arc=none smtp.client-ip=209.85.167.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="S9+gb2sj" Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-5b2a3166398so3973670e87.3 for ; Mon, 17 Aug 2026 08:46:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786981571; x=1787586371; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=ss03K2Y3OPmIpRMBLQFW3Gbod8A3222sw4hXM/Va27Q=; b=S9+gb2sj2x/HR71VFYeU50Xf0yR2FjPD7iIhOKR7Lh0zi26dxFnPdUwMfwDvG6V1Ji NbwOl0exIrTOGm9G4le1gUszZGuT0yxNGe/+DKj82xt7psU7ocD8m3DYvGoOP3w7BkUa +wv6hFqZDho2jvBhwzPEyiddK3kbe8mknPGnKHCYcnIxkdUfmFlyRZNCv7lknshAouj0 rpb3UwKHo5oavBW1gsAKBMzMgKK5luS+NVN8iNpeTc8GelPMZistYc4kjGvU01hgQQ3b xWFSlkFaHbF07VuzOEIy0RIN6CRYyvwCAQ7/CbvX3MmFEMGeVUbj650QGB8V02RLKmyq KYPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786981571; x=1787586371; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ss03K2Y3OPmIpRMBLQFW3Gbod8A3222sw4hXM/Va27Q=; b=LudaXrT566HyAw3BENuBZE+wh3FdHEIqbQYsKTXUngGyQidfJxLarR4HkK5s5ThlPU JFZecr2I5HZ+0OXI7a6EcMZLIOnGsrgXa4UB4/OYw62fjrVD+rUFtNrSNo1E70/Rv84q 1m8YxptQ3a9pcECArSInWsBb+v3CaaoOGe5QncZvPclKUCOhz3ZNuJGa8NBFT1eYZd3J hX3g+WMCGoQIXh0mX/Q3YBPU+p9qZpgzYgNeSbfvbRBhv1ee/fy8uTCmSkP2/Sk3o3Td xJuk2w/OAPuisFgkIMTvtRn8CxB7oQ5OaPs+MAwZnsU4u9UHefX2zOEEOb2oodx8silA hhXA== X-Forwarded-Encrypted: i=1; AHgh+RphvQ0a8h4DgSZfscOWTq2fh5HSwvdVpqgGaXdtZgG9pw8MPMwe2AkGuJYe0gDORTnTAehRu1y0VmMzIU4=@vger.kernel.org X-Gm-Message-State: AOJu0YxQP8GpbuqpwPqIZGaY1Tpxgb8ePjkva48jZ8wauBQRwKhcF6Y9 zh5Es8J0xqktrD/cUZ96zNbaUwniptmLBVPLk0+rxnFW+Z3h6Hz93oGY X-Gm-Gg: AR+sD12nMDyxodlh7fByFoDfsWP3LrF+pn2bHX1H1t4yMGcDCu97Qb0KqSd3r2zFQVm nCn0Pt7cppoi89GIkXR9QGnWGcYSO+gd20vGJ9NuHpkCE7QYnoSiTPvcThnJZXsetS3a8hMA5wY ra+QQevuuGn2MqE1E2Vep6DipxkYNshT021cfQ5F7SmenZitgDOerRJNEVOEpdbd/EFhz647/cp Zh+hjP+igJg4PYMejnwxjtHfhFKha4qaHhtBrY5qcU7+qnU3tANmCTIaUW58cIbmOm2H/gLgtK3 W4RimRJ2uAFn5TgzKH4PZOUWbO2Jtq+IRQHqV+nSAR5SiCmmNWUYAZSNYt9Pz46NF0NhK0qjH9O z9hpc6uUvxRGAb+qnRHomPCCnkBzyoNb0nygWqXzsaM3cnstqMpv45lyIiRiDeQtXdsB2QTJSEp hY5qCKTXFbWbYiyF6zghmLa5C40YFafYN/ihtRlfWOBI0G6BsZiuPQDWOQ/gLnaE/AkK284/UV5 X0GvwTkwChHTtNgqHPpb/f9iS3DKeY= X-Received: by 2002:a05:6512:2341:b0:5b2:f453:1073 with SMTP id 2adb3069b0e04-5b45915e5c8mr4945718e87.2.1786981570425; Mon, 17 Aug 2026 08:46:10 -0700 (PDT) Received: from burk (46-162-75-122.cust.bredband2.com. [46.162.75.122]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3a16b0de90fsm5666791fa.11.2026.08.17.08.46.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 08:46:07 -0700 (PDT) From: Philip Nielsen To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Philip Nielsen Subject: [PATCH] staging: rtl8723bs: avoid CamelCase in rtw_efuse Date: Mon, 17 Aug 2026 17:45:55 +0200 Message-ID: <20260817154555.81451-1-philipnielsen64@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Avoid CamelCase naming for local variables, function parameters, and static helper functions in rtw_efuse.c as well as associated prototypes in rtw_efuse.h to adhere to the Linux kernel coding style and clear checkpatch.pl checks. Signed-off-by: Philip Nielsen --- drivers/staging/rtl8723bs/core/rtw_efuse.c | 120 +++++++++--------- drivers/staging/rtl8723bs/include/rtw_efuse.h | 6 +- 2 files changed, 63 insertions(+), 63 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/r= tl8723bs/core/rtw_efuse.c index 168ecb7a998f..8e795f23899f 100644 --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c @@ -41,48 +41,48 @@ rtw_efuse_calculate_word_counts(u8 word_en) * 09/23/2008 MHC Copy from WMAC. * */ -u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address) +u8 rtw_efuse_read_1_byte(struct adapter *adapter, u16 address) { - u8 Bytetemp =3D {0x00}; + u8 byte_temp =3D {0x00}; u8 temp =3D {0x00}; u32 k =3D 0; - u16 contentLen =3D 0; + u16 content_len =3D 0; =20 - Hal_GetEfuseDefinition(Adapter, EFUSE_WIFI, TYPE_EFUSE_REAL_CONTENT_LEN, = &contentLen); + Hal_GetEfuseDefinition(adapter, EFUSE_WIFI, TYPE_EFUSE_REAL_CONTENT_LEN, = &content_len); =20 - if (Address < contentLen) {/* E-fuse 512Byte */ + if (address < content_len) {/* E-fuse 512Byte */ /* Write E-fuse Register address bit0~7 */ - temp =3D Address & 0xFF; - rtw_write8(Adapter, EFUSE_CTRL + 1, temp); - Bytetemp =3D rtw_read8(Adapter, EFUSE_CTRL + 2); + temp =3D address & 0xFF; + rtw_write8(adapter, EFUSE_CTRL + 1, temp); + byte_temp =3D rtw_read8(adapter, EFUSE_CTRL + 2); /* Write E-fuse Register address bit8~9 */ - temp =3D ((Address >> 8) & 0x03) | (Bytetemp & 0xFC); - rtw_write8(Adapter, EFUSE_CTRL + 2, temp); + temp =3D ((address >> 8) & 0x03) | (byte_temp & 0xFC); + rtw_write8(adapter, EFUSE_CTRL + 2, temp); =20 /* Write 0x30[31]=3D 0 */ - Bytetemp =3D rtw_read8(Adapter, EFUSE_CTRL + 3); - temp =3D Bytetemp & 0x7F; - rtw_write8(Adapter, EFUSE_CTRL + 3, temp); + byte_temp =3D rtw_read8(adapter, EFUSE_CTRL + 3); + temp =3D byte_temp & 0x7F; + rtw_write8(adapter, EFUSE_CTRL + 3, temp); =20 /* Wait Write-ready (0x30[31]=3D 1) */ - Bytetemp =3D rtw_read8(Adapter, EFUSE_CTRL + 3); - while (!(Bytetemp & 0x80)) { - Bytetemp =3D rtw_read8(Adapter, EFUSE_CTRL + 3); + byte_temp =3D rtw_read8(adapter, EFUSE_CTRL + 3); + while (!(byte_temp & 0x80)) { + byte_temp =3D rtw_read8(adapter, EFUSE_CTRL + 3); k++; if (k =3D=3D 1000) break; } - return rtw_read8(Adapter, EFUSE_CTRL); + return rtw_read8(adapter, EFUSE_CTRL); } else { return 0xFF; } } /* rtw_efuse_read_1_byte */ =20 -/* 11/16/2008 MH Read one byte from real Efuse. */ +/* 11/16/2008 MH Read one byte from real efuse. */ u8 rtw_efuse_one_byte_read(struct adapter *padapter, u16 addr, u8 *data) { u32 tmpidx =3D 0; - u8 bResult; + u8 b_result; u8 readbyte; =20 /* <20130121, Kordan> For SMIC EFUSE specificatoin. */ @@ -107,19 +107,19 @@ u8 rtw_efuse_one_byte_read(struct adapter *padapter, = u16 addr, u8 *data) } if (tmpidx < 100) { *data =3D rtw_read8(padapter, EFUSE_CTRL); - bResult =3D true; + b_result =3D true; } else { *data =3D 0xff; - bResult =3D false; + b_result =3D false; } =20 - return bResult; + return b_result; } =20 /*------------------------------------------------------------------------= ----- - * Function: Efuse_ReadAllMap + * Function: efuse_read_all_map * - * Overview: Read All Efuse content + * Overview: Read All efuse content * * Input: NONE * @@ -132,23 +132,23 @@ u8 rtw_efuse_one_byte_read(struct adapter *padapter, = u16 addr, u8 *data) * 11/11/2008 MHC Create Version 0. * */ -static void Efuse_ReadAllMap(struct adapter *padapter, u8 efuseType, u8 *E= fuse) +static void efuse_read_all_map(struct adapter *padapter, u8 efuse_type, u8= *efuse) { - u16 mapLen =3D 0; + u16 map_len =3D 0; =20 Hal_EfusePowerSwitch(padapter, true); =20 - Hal_GetEfuseDefinition(padapter, efuseType, TYPE_EFUSE_MAP_LEN, &mapLen); + Hal_GetEfuseDefinition(padapter, efuse_type, TYPE_EFUSE_MAP_LEN, &map_len= ); =20 - Hal_ReadEFuse(padapter, efuseType, 0, mapLen, Efuse); + Hal_ReadEFuse(padapter, efuse_type, 0, map_len, efuse); =20 Hal_EfusePowerSwitch(padapter, false); } =20 /*------------------------------------------------------------------------= ----- - * Function: efuse_ShadowRead1Byte - * efuse_ShadowRead2Byte - * efuse_ShadowRead4Byte + * Function: efuse_shadow_read_1byte + * efuse_shadow_read_2byte + * efuse_shadow_read_4byte * * Overview: Read from efuse init map by one/two/four bytes !!!!! * @@ -163,35 +163,35 @@ static void Efuse_ReadAllMap(struct adapter *padapter= , u8 efuseType, u8 *Efuse) * 11/12/2008 MHC Create Version 0. * */ -static void efuse_ShadowRead1Byte(struct adapter *padapter, u16 Offset, u8= *Value) +static void efuse_shadow_read_1byte(struct adapter *padapter, u16 offset, = u8 *value) { - struct eeprom_priv *pEEPROM =3D GET_EEPROM_EFUSE_PRIV(padapter); + struct eeprom_priv *eeprom =3D GET_EEPROM_EFUSE_PRIV(padapter); =20 - *Value =3D pEEPROM->efuse_eeprom_data[Offset]; + *value =3D eeprom->efuse_eeprom_data[offset]; =20 } /* EFUSE_ShadowRead1Byte */ =20 /* Read Two Bytes */ -static void efuse_ShadowRead2Byte(struct adapter *padapter, u16 Offset, u1= 6 *Value) +static void efuse_shadow_read_2byte(struct adapter *padapter, u16 offset, = u16 *value) { - struct eeprom_priv *pEEPROM =3D GET_EEPROM_EFUSE_PRIV(padapter); + struct eeprom_priv *eeprom =3D GET_EEPROM_EFUSE_PRIV(padapter); =20 - *Value =3D pEEPROM->efuse_eeprom_data[Offset]; - *Value |=3D pEEPROM->efuse_eeprom_data[Offset + 1] << 8; + *value =3D eeprom->efuse_eeprom_data[offset]; + *value |=3D eeprom->efuse_eeprom_data[offset + 1] << 8; =20 } /* EFUSE_ShadowRead2Byte */ =20 /* Read Four Bytes */ -static void efuse_ShadowRead4Byte(struct adapter *padapter, u16 Offset, u3= 2 *Value) +static void efuse_shadow_read_4byte(struct adapter *padapter, u16 offset, = u32 *value) { - struct eeprom_priv *pEEPROM =3D GET_EEPROM_EFUSE_PRIV(padapter); + struct eeprom_priv *eeprom =3D GET_EEPROM_EFUSE_PRIV(padapter); =20 - *Value =3D pEEPROM->efuse_eeprom_data[Offset]; - *Value |=3D pEEPROM->efuse_eeprom_data[Offset + 1] << 8; - *Value |=3D pEEPROM->efuse_eeprom_data[Offset + 2] << 16; - *Value |=3D pEEPROM->efuse_eeprom_data[Offset + 3] << 24; + *value =3D eeprom->efuse_eeprom_data[offset]; + *value |=3D eeprom->efuse_eeprom_data[offset + 1] << 8; + *value |=3D eeprom->efuse_eeprom_data[offset + 2] << 16; + *value |=3D eeprom->efuse_eeprom_data[offset + 3] << 24; =20 -} /* efuse_ShadowRead4Byte */ +} /* efuse_shadow_read_4byte */ =20 /*------------------------------------------------------------------------= ----- * Function: rtw_efuse_shadow_map_update @@ -209,20 +209,20 @@ static void efuse_ShadowRead4Byte(struct adapter *pad= apter, u16 Offset, u32 *Val * 11/13/2008 MHC Create Version 0. * */ -void rtw_efuse_shadow_map_update(struct adapter *padapter, u8 efuseType) +void rtw_efuse_shadow_map_update(struct adapter *padapter, u8 efuse_type) { - struct eeprom_priv *pEEPROM =3D GET_EEPROM_EFUSE_PRIV(padapter); - u16 mapLen =3D 0; + struct eeprom_priv *eeprom =3D GET_EEPROM_EFUSE_PRIV(padapter); + u16 map_len =3D 0; =20 - Hal_GetEfuseDefinition(padapter, efuseType, TYPE_EFUSE_MAP_LEN, &mapLen); + Hal_GetEfuseDefinition(padapter, efuse_type, TYPE_EFUSE_MAP_LEN, &map_len= ); =20 - if (pEEPROM->bautoload_fail_flag) - memset(pEEPROM->efuse_eeprom_data, 0xFF, mapLen); + if (eeprom->bautoload_fail_flag) + memset(eeprom->efuse_eeprom_data, 0xFF, map_len); else - Efuse_ReadAllMap(padapter, efuseType, pEEPROM->efuse_eeprom_data); + efuse_read_all_map(padapter, efuse_type, eeprom->efuse_eeprom_data); =20 /* PlatformMoveMemory((void *)&pHalData->EfuseMap[EFUSE_MODIFY_MAP][0], */ - /* void *)&pHalData->EfuseMap[EFUSE_INIT_MAP][0], mapLen); */ + /* void *)&pHalData->EfuseMap[EFUSE_INIT_MAP][0], map_len); */ } /* rtw_efuse_shadow_map_update */ =20 /*------------------------------------------------------------------------= ----- @@ -241,13 +241,13 @@ void rtw_efuse_shadow_map_update(struct adapter *pada= pter, u8 efuseType) * 11/12/2008 MHC Create Version 0. * */ -void rtw_efuse_shadow_read(struct adapter *padapter, u8 Type, u16 Offset, = u32 *Value) +void rtw_efuse_shadow_read(struct adapter *padapter, u8 type, u16 offset, = u32 *value) { - if (Type =3D=3D 1) - efuse_ShadowRead1Byte(padapter, Offset, (u8 *)Value); - else if (Type =3D=3D 2) - efuse_ShadowRead2Byte(padapter, Offset, (u16 *)Value); - else if (Type =3D=3D 4) - efuse_ShadowRead4Byte(padapter, Offset, (u32 *)Value); + if (type =3D=3D 1) + efuse_shadow_read_1byte(padapter, offset, (u8 *)value); + else if (type =3D=3D 2) + efuse_shadow_read_2byte(padapter, offset, (u16 *)value); + else if (type =3D=3D 4) + efuse_shadow_read_4byte(padapter, offset, (u32 *)value); =20 } /* rtw_efuse_shadow_read*/ diff --git a/drivers/staging/rtl8723bs/include/rtw_efuse.h b/drivers/stagin= g/rtl8723bs/include/rtw_efuse.h index 808ba94a5998..d1b518be3b7d 100644 --- a/drivers/staging/rtl8723bs/include/rtw_efuse.h +++ b/drivers/staging/rtl8723bs/include/rtw_efuse.h @@ -71,8 +71,8 @@ struct efuse_hal { u8 rtw_efuse_calculate_word_counts(u8 word_en); u8 rtw_efuse_one_byte_read(struct adapter *padapter, u16 addr, u8 *data); =20 -u8 rtw_efuse_read_1_byte(struct adapter *padapter, u16 Address); -void rtw_efuse_shadow_map_update(struct adapter *padapter, u8 efuseType); -void rtw_efuse_shadow_read(struct adapter *padapter, u8 Type, u16 Offset, = u32 *Value); +u8 rtw_efuse_read_1_byte(struct adapter *padapter, u16 address); +void rtw_efuse_shadow_map_update(struct adapter *padapter, u8 efuse_type); +void rtw_efuse_shadow_read(struct adapter *padapter, u8 type, u16 offset, = u32 *value); =20 #endif --=20 2.55.0