[PATCH v3 0/5] staging: media: atomisp: cleanup pci/hmm/ code

Nikolay Kulikov posted 5 patches 1 month, 2 weeks ago
There is a newer version of this series
.../staging/media/atomisp/include/hmm/hmm.h   |  17 --
.../media/atomisp/include/hmm/hmm_bo.h        |  46 ----
.../media/atomisp/include/hmm/hmm_common.h    |  60 -----
drivers/staging/media/atomisp/pci/hmm/hmm.c   |  41 ---
.../staging/media/atomisp/pci/hmm/hmm_bo.c    | 246 ++++++++----------
5 files changed, 112 insertions(+), 298 deletions(-)
delete mode 100644 drivers/staging/media/atomisp/include/hmm/hmm_common.h
[PATCH v3 0/5] staging: media: atomisp: cleanup pci/hmm/ code
Posted by Nikolay Kulikov 1 month, 2 weeks ago
This series removes unused functions and replaces obscure
variable-checking macros with clear conditional statements.

Changes in v3:
	- Split the last patch into two (inlining macros and removing
	  the file).
	- Replace variable initialization with assignment, followed
	  immediately by a check.
Changes in v2:
	- Squashed the function removals in pci/hmm/hmm.c and
	  pci/hmm/hmm_bo.c into a single commit.
	- Add commits to cleanup macros from include/hmm/hmm_common.h,
	  as suggested by Andy Shevchenko.

Nikolay Kulikov (5):
  staging: media: atomisp: remove unused functions from pci/hmm/
  staging: media: atomisp: inline macros for checking the bo/bodev
    pointer
  staging: media: atomisp: inline the check_bo_status_*() macros
  staging: media: atomisp: inline the var_equal_return*() macros
  staging: media: atomisp: remove hmm/hmm_common.h file

 .../staging/media/atomisp/include/hmm/hmm.h   |  17 --
 .../media/atomisp/include/hmm/hmm_bo.h        |  46 ----
 .../media/atomisp/include/hmm/hmm_common.h    |  60 -----
 drivers/staging/media/atomisp/pci/hmm/hmm.c   |  41 ---
 .../staging/media/atomisp/pci/hmm/hmm_bo.c    | 246 ++++++++----------
 5 files changed, 112 insertions(+), 298 deletions(-)
 delete mode 100644 drivers/staging/media/atomisp/include/hmm/hmm_common.h

-- 
2.55.0
Re: [PATCH v3 0/5] staging: media: atomisp: cleanup pci/hmm/ code
Posted by Andy Shevchenko 1 month, 2 weeks ago
On Wed, Aug 12, 2026 at 11:51:33PM +0300, Nikolay Kulikov wrote:
> This series removes unused functions and replaces obscure
> variable-checking macros with clear conditional statements.

I believe I gave tags to some patches in v2. I don't see either.
What's going on?

> Changes in v3:
> 	- Split the last patch into two (inlining macros and removing
> 	  the file).
> 	- Replace variable initialization with assignment, followed
> 	  immediately by a check.
> Changes in v2:
> 	- Squashed the function removals in pci/hmm/hmm.c and
> 	  pci/hmm/hmm_bo.c into a single commit.
> 	- Add commits to cleanup macros from include/hmm/hmm_common.h,
> 	  as suggested by Andy Shevchenko.

Also two process hints:
- add --base when prepare patches
- add links (URLs to lore.kernel.org) for the previous versions.

-- 
With Best Regards,
Andy Shevchenko
Re: [PATCH v3 0/5] staging: media: atomisp: cleanup pci/hmm/ code
Posted by Andy Shevchenko 1 month, 2 weeks ago
On Thu, Aug 13, 2026 at 12:11:04PM +0300, Andy Shevchenko wrote:
> On Wed, Aug 12, 2026 at 11:51:33PM +0300, Nikolay Kulikov wrote:
> > This series removes unused functions and replaces obscure
> > variable-checking macros with clear conditional statements.
> 
> I believe I gave tags to some patches in v2. I don't see either.
> What's going on?

For _this_ time, please reply yourself to the patches I already tagged with my
Rb tags placed on a dedicated line.

> > Changes in v3:
> > 	- Split the last patch into two (inlining macros and removing
> > 	  the file).
> > 	- Replace variable initialization with assignment, followed
> > 	  immediately by a check.
> > Changes in v2:
> > 	- Squashed the function removals in pci/hmm/hmm.c and
> > 	  pci/hmm/hmm_bo.c into a single commit.
> > 	- Add commits to cleanup macros from include/hmm/hmm_common.h,
> > 	  as suggested by Andy Shevchenko.
> 
> Also two process hints:
> - add --base when prepare patches
> - add links (URLs to lore.kernel.org) for the previous versions.

Same here, just reply to your cover letter with these URLs, and for this time
just refer what the base was in a free form.

-- 
With Best Regards,
Andy Shevchenko
Re: [PATCH v3 0/5] staging: media: atomisp: cleanup pci/hmm/ code
Posted by Nikolay Kulikov 1 month, 2 weeks ago
On Thu, Aug 13, 2026 at 12:12:52PM +0300, Andy Shevchenko wrote:
> On Thu, Aug 13, 2026 at 12:11:04PM +0300, Andy Shevchenko wrote:
> > On Wed, Aug 12, 2026 at 11:51:33PM +0300, Nikolay Kulikov wrote:
> > > This series removes unused functions and replaces obscure
> > > variable-checking macros with clear conditional statements.
> > 
> > I believe I gave tags to some patches in v2. I don't see either.
> > What's going on?
> 
> For _this_ time, please reply yourself to the patches I already tagged with my
> Rb tags placed on a dedicated line.
> 
> > > Changes in v3:
> > > 	- Split the last patch into two (inlining macros and removing
> > > 	  the file).
> > > 	- Replace variable initialization with assignment, followed
> > > 	  immediately by a check.
> > > Changes in v2:
> > > 	- Squashed the function removals in pci/hmm/hmm.c and
> > > 	  pci/hmm/hmm_bo.c into a single commit.
> > > 	- Add commits to cleanup macros from include/hmm/hmm_common.h,
> > > 	  as suggested by Andy Shevchenko.
> > 
> > Also two process hints:
> > - add --base when prepare patches
> > - add links (URLs to lore.kernel.org) for the previous versions.
> 
> Same here, just reply to your cover letter with these URLs, and for this time
> just refer what the base was in a free form.

Sorry, I think I should have used b4 from the start.
I will send the new version with all the fixes.


Thanks,
Nikolay