[PATCH v4 0/5] staging: media: atomisp: cleanup pci/hmm/ code

Nikolay Kulikov posted 5 patches 1 month, 2 weeks ago
drivers/staging/media/atomisp/include/hmm/hmm.h    |  17 --
drivers/staging/media/atomisp/include/hmm/hmm_bo.h |  46 ----
.../staging/media/atomisp/include/hmm/hmm_common.h |  60 -----
drivers/staging/media/atomisp/pci/hmm/hmm.c        |  41 ----
drivers/staging/media/atomisp/pci/hmm/hmm_bo.c     | 272 ++++++++-------------
5 files changed, 100 insertions(+), 336 deletions(-)
[PATCH v4 0/5] staging: media: atomisp: cleanup pci/hmm/ code
Posted by Nikolay Kulikov 1 month, 2 weeks ago
This series removes unused functions and replaces obscure
variable-checking macros with clear conditional statements.

Changes in v4:
	- In commit 1, include the removal of the static 'hmm_bo_vm_ops'
	  structure and the hmm_bo_vm_open() and hmm_bo_vm_close()
	  functions (whose addresses are stored in that structure), as
	  they have also become unused and are triggering compiler
	  warinigs (I removed Andy Shevchenko's Rb tag because of this
	  change).
	- Add the Rb tag (commit 3).
	- Add the base commit hash.
	- Add links to v1/v2/v3.
Changes in v3:
	- Split the last patch into two (inlining macros and removing
	  the file).
	- Replace variable initialization with assignment, followed
	  immediately by a check.
Changes in v2:
	- Squashed the function removals in pci/hmm/hmm.c and
	  pci/hmm/hmm_bo.c into a single commit.
	- Add commits to cleanup macros from include/hmm/hmm_common.h,
	  as suggested by Andy Shevchenko.

v3: https://lore.kernel.org/linux-staging/20260812205429.39181-1-nikolayof23@gmail.com/
v2: https://lore.kernel.org/linux-staging/20260723185217.317981-1-nikolayof23@gmail.com/
v1: https://lore.kernel.org/linux-staging/20260721214238.840406-1-nikolayof23@gmail.com/

Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com>
---
Nikolay Kulikov (5):
      staging: media: atomisp: remove unused functions from pci/hmm/
      staging: media: atomisp: inline macros for checking the bo/bodev pointer
      staging: media: atomisp: inline the check_bo_status_*() macros
      staging: media: atomisp: inline the var_equal_return*() macros
      staging: media: atomisp: remove hmm/hmm_common.h file

 drivers/staging/media/atomisp/include/hmm/hmm.h    |  17 --
 drivers/staging/media/atomisp/include/hmm/hmm_bo.h |  46 ----
 .../staging/media/atomisp/include/hmm/hmm_common.h |  60 -----
 drivers/staging/media/atomisp/pci/hmm/hmm.c        |  41 ----
 drivers/staging/media/atomisp/pci/hmm/hmm_bo.c     | 272 ++++++++-------------
 5 files changed, 100 insertions(+), 336 deletions(-)
---
base-commit: cb08dcd0a896c3ac8073a57296f2377b106c35b4
change-id: 20260813-atomisp_remove_hmm-407662efafaa

Best regards,
--  
Nikolay Kulikov <nikolayof23@gmail.com>
Re: [PATCH v4 0/5] staging: media: atomisp: cleanup pci/hmm/ code
Posted by Andy Shevchenko 1 month, 1 week ago
On Fri, Aug 14, 2026 at 06:10:07PM +0300, Nikolay Kulikov wrote:
> This series removes unused functions and replaces obscure
> variable-checking macros with clear conditional statements.

> Nikolay Kulikov (5):
>       staging: media: atomisp: remove unused functions from pci/hmm/
>       staging: media: atomisp: inline macros for checking the bo/bodev pointer
>       staging: media: atomisp: inline the check_bo_status_*() macros
>       staging: media: atomisp: inline the var_equal_return*() macros
>       staging: media: atomisp: remove hmm/hmm_common.h file

I don't know what the problem is, but in all four versions of this series
I have never get patch 5 in my mailbox (yes, I can retrieve it from
lore.kernel.org, but the thing is that either corporate spam-filter or
something else gates the message to me).

Overall, LGTM, thanks for pursuing this!
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
for the entire series.

-- 
With Best Regards,
Andy Shevchenko