drm/msm/adreno: fix autosuspend cleanup during teardown

[PATCH] drm/msm/adreno: fix autosuspend cleanup during teardown

Posted by Guangshuo Li 1 month, 3 weeks ago

adreno_gpu_init() calls pm_runtime_use_autosuspend(), but
adreno_gpu_cleanup() does not call the matching
pm_runtime_dont_use_autosuspend() during teardown.

If the autosuspend delay is set to a negative value while autosuspend
is enabled, the runtime PM core increments usage_count to prevent
runtime suspend. Without calling pm_runtime_dont_use_autosuspend()
during teardown, this reference is not dropped and usage_count remains
unbalanced.

The documentation for pm_runtime_use_autosuspend() also notes that it
is important to undo it with pm_runtime_dont_use_autosuspend() at
driver exit time, unless runtime PM was initially enabled with
devm_pm_runtime_enable().

Add the missing pm_runtime_dont_use_autosuspend() call to
adreno_gpu_cleanup().

This issue was found by manual code inspection.

Fixes: eeb754746b14 ("drm/msm/gpu: use pm-runtime")
Cc: stable@vger.kernel.org
Signed-off-by: Guangshuo Li <lgs201920130244@gmail.com>
---
 drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
index c62c45bb0ddb..29c59899fdef 100644
--- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c
+++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
@@ -1252,6 +1252,8 @@ void adreno_gpu_cleanup(struct adreno_gpu *adreno_gpu)
 	for (i = 0; i < ARRAY_SIZE(adreno_gpu->info->fw); i++)
 		release_firmware(adreno_gpu->fw[i]);
 
+	pm_runtime_dont_use_autosuspend(&gpu->pdev->dev);
+
 	if (priv && pm_runtime_enabled(&priv->gpu_pdev->dev))
 		pm_runtime_disable(&priv->gpu_pdev->dev);
 
-- 
2.43.0

Re: [PATCH] drm/msm/adreno: fix autosuspend cleanup during teardown

Posted by Krzysztof Kozlowski 1 month, 1 week ago

On 08/08/2026 15:16, Guangshuo Li wrote:
> adreno_gpu_init() calls pm_runtime_use_autosuspend(), but
> adreno_gpu_cleanup() does not call the matching
> pm_runtime_dont_use_autosuspend() during teardown.
> 
> If the autosuspend delay is set to a negative value while autosuspend
> is enabled, the runtime PM core increments usage_count to prevent
> runtime suspend. Without calling pm_runtime_dont_use_autosuspend()
> during teardown, this reference is not dropped and usage_count remains
> unbalanced.
> 
> The documentation for pm_runtime_use_autosuspend() also notes that it
> is important to undo it with pm_runtime_dont_use_autosuspend() at
> driver exit time, unless runtime PM was initially enabled with
> devm_pm_runtime_enable().
> 
> Add the missing pm_runtime_dont_use_autosuspend() call to
> adreno_gpu_cleanup().
> 
> This issue was found by manual code inspection.
> 
> Fixes: eeb754746b14 ("drm/msm/gpu: use pm-runtime")
> Cc: stable@vger.kernel.org
> Signed-off-by: Guangshuo Li <lgs201920130244@gmail.com>
> ---

You sent vast amount of patches, all separate, making it very difficult
to track and respond in efficient way. Do not do that.

Group your work per subsystem.

You were asked to clarify and respond to incorrect fixes statement. I do
not see how you clarified and responded at all.


Best regards,
Krzysztof

Re: [PATCH] drm/msm/adreno: fix autosuspend cleanup during teardown

Posted by Konrad Dybcio 1 month, 1 week ago

On 8/8/26 3:16 PM, Guangshuo Li wrote:
> adreno_gpu_init() calls pm_runtime_use_autosuspend(), but
> adreno_gpu_cleanup() does not call the matching
> pm_runtime_dont_use_autosuspend() during teardown.
> 
> If the autosuspend delay is set to a negative value while autosuspend
> is enabled, the runtime PM core increments usage_count to prevent
> runtime suspend. Without calling pm_runtime_dont_use_autosuspend()
> during teardown, this reference is not dropped and usage_count remains
> unbalanced.
> 
> The documentation for pm_runtime_use_autosuspend() also notes that it
> is important to undo it with pm_runtime_dont_use_autosuspend() at
> driver exit time, unless runtime PM was initially enabled with
> devm_pm_runtime_enable().
> 
> Add the missing pm_runtime_dont_use_autosuspend() call to
> adreno_gpu_cleanup().
> 
> This issue was found by manual code inspection.
> 
> Fixes: eeb754746b14 ("drm/msm/gpu: use pm-runtime")
> Cc: stable@vger.kernel.org
> Signed-off-by: Guangshuo Li <lgs201920130244@gmail.com>
> ---

I think we can use devm_pm_runtime_enable() instead, which will take
care of cleaning up both the autosuspend and runpm halves

Konrad

Re: [PATCH] drm/msm/adreno: fix autosuspend cleanup during teardown

Posted by Dmitry Baryshkov 2 weeks, 1 day ago

On Tue, Aug 18, 2026 at 12:40:27PM +0200, Konrad Dybcio wrote:
> On 8/8/26 3:16 PM, Guangshuo Li wrote:
> > adreno_gpu_init() calls pm_runtime_use_autosuspend(), but
> > adreno_gpu_cleanup() does not call the matching
> > pm_runtime_dont_use_autosuspend() during teardown.
> > 
> > If the autosuspend delay is set to a negative value while autosuspend
> > is enabled, the runtime PM core increments usage_count to prevent
> > runtime suspend. Without calling pm_runtime_dont_use_autosuspend()
> > during teardown, this reference is not dropped and usage_count remains
> > unbalanced.
> > 
> > The documentation for pm_runtime_use_autosuspend() also notes that it
> > is important to undo it with pm_runtime_dont_use_autosuspend() at
> > driver exit time, unless runtime PM was initially enabled with
> > devm_pm_runtime_enable().
> > 
> > Add the missing pm_runtime_dont_use_autosuspend() call to
> > adreno_gpu_cleanup().
> > 
> > This issue was found by manual code inspection.
> > 
> > Fixes: eeb754746b14 ("drm/msm/gpu: use pm-runtime")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Guangshuo Li <lgs201920130244@gmail.com>
> > ---
> 
> I think we can use devm_pm_runtime_enable() instead, which will take
> care of cleaning up both the autosuspend and runpm halves

Not really, beacause the driver's group device is DPU / MDP4 / MDP5
(in case of a merged display+GPU), so the patch seems to be correct.


Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

-- 
With best wishes
Dmitry

Re: [PATCH] drm/msm/adreno: fix autosuspend cleanup during teardown

Posted by Krzysztof Kozlowski 1 month ago

On 18/08/2026 12:40, Konrad Dybcio wrote:
> On 8/8/26 3:16 PM, Guangshuo Li wrote:
>> adreno_gpu_init() calls pm_runtime_use_autosuspend(), but
>> adreno_gpu_cleanup() does not call the matching
>> pm_runtime_dont_use_autosuspend() during teardown.
>>
>> If the autosuspend delay is set to a negative value while autosuspend
>> is enabled, the runtime PM core increments usage_count to prevent
>> runtime suspend. Without calling pm_runtime_dont_use_autosuspend()
>> during teardown, this reference is not dropped and usage_count remains
>> unbalanced.
>>
>> The documentation for pm_runtime_use_autosuspend() also notes that it
>> is important to undo it with pm_runtime_dont_use_autosuspend() at
>> driver exit time, unless runtime PM was initially enabled with
>> devm_pm_runtime_enable().
>>
>> Add the missing pm_runtime_dont_use_autosuspend() call to
>> adreno_gpu_cleanup().
>>
>> This issue was found by manual code inspection.
>>
>> Fixes: eeb754746b14 ("drm/msm/gpu: use pm-runtime")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Guangshuo Li <lgs201920130244@gmail.com>
>> ---
> 
> I think we can use devm_pm_runtime_enable() instead, which will take
> care of cleaning up both the autosuspend and runpm halves
> 

Author here is unresponsive, he was told a few times to send corrections
for his vast amount of unthreaded patches and there is zero reaction.

Best regards,
Krzysztof

Re: [PATCH] drm/msm/adreno: fix autosuspend cleanup during teardown

Posted by Guangshuo Li 1 month ago

Hi Krzysztof,

On Mon, 24 Aug 2026 at 14:17, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 18/08/2026 12:40, Konrad Dybcio wrote:
> > On 8/8/26 3:16 PM, Guangshuo Li wrote:
> >> adreno_gpu_init() calls pm_runtime_use_autosuspend(), but
> >> adreno_gpu_cleanup() does not call the matching
> >> pm_runtime_dont_use_autosuspend() during teardown.
> >>
> >> If the autosuspend delay is set to a negative value while autosuspend
> >> is enabled, the runtime PM core increments usage_count to prevent
> >> runtime suspend. Without calling pm_runtime_dont_use_autosuspend()
> >> during teardown, this reference is not dropped and usage_count remains
> >> unbalanced.
> >>
> >> The documentation for pm_runtime_use_autosuspend() also notes that it
> >> is important to undo it with pm_runtime_dont_use_autosuspend() at
> >> driver exit time, unless runtime PM was initially enabled with
> >> devm_pm_runtime_enable().
> >>
> >> Add the missing pm_runtime_dont_use_autosuspend() call to
> >> adreno_gpu_cleanup().
> >>
> >> This issue was found by manual code inspection.
> >>
> >> Fixes: eeb754746b14 ("drm/msm/gpu: use pm-runtime")
> >> Cc: stable@vger.kernel.org
> >> Signed-off-by: Guangshuo Li <lgs201920130244@gmail.com>
> >> ---
> >
> > I think we can use devm_pm_runtime_enable() instead, which will take
> > care of cleaning up both the autosuspend and runpm halves
> >
>
> Author here is unresponsive, he was told a few times to send corrections
> for his vast amount of unthreaded patches and there is zero reaction.
>
> Best regards,
> Krzysztof

Sorry about that. I should have replied to the earlier review comments
explicitly, and I also should not have sent so many separate patches.

I will group future patches by subsystem and make sure to respond
clearly to review feedback before resending.

Thanks for pointing this out.

Best regards,
Guangshuo