From nobody Tue Sep 29 11:55:07 2026 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A7CD284896 for ; Sat, 8 Aug 2026 13:16:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786195011; cv=none; b=h+Lesay5nTq+tA2JvYfVapaMgO4K5u4KOeeLZN+JJG9U247FJOsU7P6GPU9dS+FJ+W5RfL+pYvGGp14jycWOvRYfzgZWIejPtXtwfxkb4ZyZCtq3kFLIZFLhI1QWsYB7VZqtvZpKXDNYZuetyyAUl3gpzUEZE96zWhjR+ZKNybw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786195011; c=relaxed/simple; bh=TMYGCPWzWxNWnWnXN5IMnP4GVuS1UaG4vXqIdbqa/6I=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=kXhkxYXXLHuQz58B9oD2nggSUAbOK5hkkcVRNShjYhJUgvfJuT4B+CXZZwNf6fMoClmc7FFDgXiCZA4iF/hbaqXkxPwRIBHBI0azk1Y7knVm1tB34ak3CLMImL8cq7dNMM1Pj60RyOdwgkC391QPct0f+hmgjmoZ1QevnR5+QxA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QxmTsUcN; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QxmTsUcN" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-381b831d535so608277a91.0 for ; Sat, 08 Aug 2026 06:16:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786195010; x=1786799810; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=ScR2OWx8A6oqcrYtXEp2YggGcFi1+8jFkpl9OoPWy+g=; b=QxmTsUcNhSUxb5SLxY269jXkQf5RzF0USGAxymK8Gpl2z3eOp47dvT5w8HeGXtxQK2 w6l8I3EShn3C8NCi2YjD9gNeS93m5/3DWkbyfx5BE+iqOP0JlB9CMyN9+1hYDz7eEnWO bXA7Kwhstex+LKQ9DC2MAqxWpWfQtBm/C80GmAgnS7pWHK5RDHv7HkB1PrFZD3uB5KR8 +UkTAusjmhKdO+1p+c89f8pJNms3/ftihQ2gR0yn40Lb+OWCZo6+um0KNxnyOCBzOwa8 +3+npu/9cMoiOVydP/LNE9heLIM6aaDnAw0KUoG/Mk7uO0o3ycc+dHzFqJlaSve/vMCo y/Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786195010; x=1786799810; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ScR2OWx8A6oqcrYtXEp2YggGcFi1+8jFkpl9OoPWy+g=; b=idXzA53sHv7OqxAOHZH5znRMA+0WDJqJdBbKvGylQFkzPoT9XFDpvVnvUuZZ1+qhFT C3pFZ3cHKrB0KH5c2UYIaCCKocPOj+p/EmtYN3ttBaiSH5zWzFKeYO3+8TTjpz4aa9Vi yvczc+iGLOBWeWarV3aWgRwF9qLkbolsIla2x59r/mYA+Ri8cbLEvMIAajCJ+Sd69jUY Z7RW2wqzsHw3kJOeFXuwxiwgD2io723q2kTxJr/cFxo/hlqJBxjWV8WJAzcfULducEh8 UtwFuHJWg9vDj0JA8GF5FH30vNnGWus6NUIiFuQaVEa7b1WBKLd34xlKYXvA5ZK2NOuW ksBw== X-Forwarded-Encrypted: i=1; AHgh+RqdOF1X32y0lpNpTA2OplJw/jlTRAJyS65OaK8XOo6yFj6mzc/TVWpjnY4OIUnAAkFsMPg/QGjD/h4uCy0=@vger.kernel.org X-Gm-Message-State: AOJu0Yy4Wy0zV6FoV2JU5a9eUwAQYlfOldId2XxOhwoC9hd1kHtdPGLm /6zz2L4AF3HKX0bu3MNokD3QNRABMXYDJk0AvEGgi/a52rAvMwXLOyic X-Gm-Gg: AR+sD10TJMqITOm50hd28+D83meSugiMxqpyrybCh2B64uslOrAP7z8+8ezikbHrlEP oh5Vuap7Q7fd+iKr/cQ8FvevLdyGv7d1O5aBkCGJNhFKwP+ZiIIx2hwN/Q65ui2xkGbHytO7GF9 9qY0Oq7DL6U4b0eTpOnmGvuwrBmZuFtxs5N+3ykEjpTBffu5N62U4UyW0V1wA1M+SIkxmOp0N4L SlKekEnL7aBwNIZ1Y5KD2RJHimEnGdXLOPAM/sL41BwhxFXm3ocIpQGWUfbsOMqitDacEGNAAAZ SPnIHzcszGuJ+onL2dvVbruN/o0s+nupTbWTm22F3nNcPLvDlVkrsS47k+Y1ySK8pPiXij0Xf5+ OdHi261cvwjRH76Hl6duuSA3+3eilMyYxH7wiJxuNYzQMGThfkEaBj455LJySSbeauCWmJ6LCP8 pJc11SnZky+2iFYTPcw0F4leCV3yvnnnMBufa8K/E31OzpHa5gpA== X-Received: by 2002:a17:90b:288d:b0:38f:26c7:165e with SMTP id 98e67ed59e1d1-39261ff3945mr13138690a91.9.1786195009547; Sat, 08 Aug 2026 06:16:49 -0700 (PDT) Received: from lgs.. ([118.193.33.13]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3925fd95c40sm6170661a91.8.2026.08.08.06.16.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Aug 2026 06:16:49 -0700 (PDT) From: Guangshuo Li To: Rob Clark , Sean Paul , Konrad Dybcio , Akhil P Oommen , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH] drm/msm/adreno: fix autosuspend cleanup during teardown Date: Sat, 8 Aug 2026 21:16:24 +0800 Message-ID: <20260808131624.2854412-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" adreno_gpu_init() calls pm_runtime_use_autosuspend(), but adreno_gpu_cleanup() does not call the matching pm_runtime_dont_use_autosuspend() during teardown. If the autosuspend delay is set to a negative value while autosuspend is enabled, the runtime PM core increments usage_count to prevent runtime suspend. Without calling pm_runtime_dont_use_autosuspend() during teardown, this reference is not dropped and usage_count remains unbalanced. The documentation for pm_runtime_use_autosuspend() also notes that it is important to undo it with pm_runtime_dont_use_autosuspend() at driver exit time, unless runtime PM was initially enabled with devm_pm_runtime_enable(). Add the missing pm_runtime_dont_use_autosuspend() call to adreno_gpu_cleanup(). This issue was found by manual code inspection. Fixes: eeb754746b14 ("drm/msm/gpu: use pm-runtime") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/= adreno/adreno_gpu.c index c62c45bb0ddb..29c59899fdef 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c @@ -1252,6 +1252,8 @@ void adreno_gpu_cleanup(struct adreno_gpu *adreno_gpu) for (i =3D 0; i < ARRAY_SIZE(adreno_gpu->info->fw); i++) release_firmware(adreno_gpu->fw[i]); =20 + pm_runtime_dont_use_autosuspend(&gpu->pdev->dev); + if (priv && pm_runtime_enabled(&priv->gpu_pdev->dev)) pm_runtime_disable(&priv->gpu_pdev->dev); =20 --=20 2.43.0