pinctrl: sx150x: IRQ handling updates

[PATCH 0/2] pinctrl: sx150x: IRQ handling updates

Posted by Tsz Shan Chan 1 month, 3 weeks ago

The sx150x driver currently hardcodes the parent IRQ trigger type and
always returns IRQ_HANDLED in its interrupt handler. This can cause
issues when the interrupt line is shared with other devices.

Patch 1 returns IRQ_NONE when no sx150x interrupt is pending.
Patch 2 parses the interrupt trigger type from firmware instead of
hardcoding it to falling edge.

---
Tsz Shan Chan (2):
      pinctrl: sx150x: Return IRQ_NONE if no pending irq
      pinctrl: sx150x: get parent IRQ trigger type from firmware

 drivers/pinctrl/pinctrl-sx150x.c | 20 +++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)
---
base-commit: c21bb4193868a8de71fc4693fa741e195fdf5d86
change-id: 20260805-sx1502-33a5a7bc2147

Best regards,
-- 
Tsz Shan Chan <tchan@jacques.com.au>

Re: [PATCH 0/2] pinctrl: sx150x: IRQ handling updates

Posted by Linus Walleij 1 month, 3 weeks ago

On Wed, Aug 5, 2026 at 7:55 AM Tsz Shan Chan <tsz.chan.dev@gmail.com> wrote:

> The sx150x driver currently hardcodes the parent IRQ trigger type and
> always returns IRQ_HANDLED in its interrupt handler. This can cause
> issues when the interrupt line is shared with other devices.
>
> Patch 1 returns IRQ_NONE when no sx150x interrupt is pending.
> Patch 2 parses the interrupt trigger type from firmware instead of
> hardcoding it to falling edge.

Both patches makes perfect sense so patches applied!

Yours,
Linus Walleij