From nobody Fri Oct 2 05:30:35 2026 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2ADA03DA5A3 for ; Wed, 5 Aug 2026 05:55:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785909334; cv=none; b=SBAeOdQtQIsECyJrhUi1tXdmJkY+MF1HSS+op1QXMKGvu4trJzP1pSuYoKp72yBPof2sTOe2Gggp1RARgMyxZIZyNI9tAubMNwTeQv7NTyxWPpsbNUHYKX+DEWls+HzxeyuYk0kn63lgOiv+Jy/aBx/sqjMXfSUIrXTEztVraOs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785909334; c=relaxed/simple; bh=R+hy63bnGwdOKhRFB9Y0mZkQ3+OfAzlsGgL7sz4SYaU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gZAu6cP3YyigHBz5G0bfJoLonlLYwpkJKsZmFIcjQVTGRSL6FAMHo8pBT72C4AHLFdWu7N+CDx9FHCkg5z43EfkzeRDppqkyCpkYaIjV2bJglbcdAXJCBJubnJTShQSWmRGmBj8UVWkM6z7+z/z24T0zGoHqrHFgqVVC3FrMS0k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=M4Z5jOrk; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M4Z5jOrk" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-ca913a601fbso510570a12.3 for ; Tue, 04 Aug 2026 22:55:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785909332; x=1786514132; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=k5VJVEduWNc70gjMM2xxRdfaqd5aIkPPMlpwcCO9KZM=; b=M4Z5jOrkGotBANOtZPLQymz1No63uv0q25gcqdhyEGcBYmqHCLNDWk+pW2OB5uvO6v cj7i16PDnWJN/8g340ChhS3zzS6AMrN3BA3QqeUs1A8uXaL+Tl/vYLR1XrAYkvSjv5cs rxl/iFAfjIB/gbjgN8pcEu2+rl8tN9OKrgzKzXE0NLeug5+5Y/QUgQTdKaYFjcGyiEfp /BOw5dHA7zQnzJf239VLNSAcM6j2WC2V+3+ZaxxpDCnUPumFpQYUfovhGH2A8EnDUc+Q Wtw4h+9PPKEdky+wwt5H4XW7PzZ8kKosCBZPU4TSl2mMJue+czeEgyJaJJu94RyCwEoJ R5MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785909332; x=1786514132; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=k5VJVEduWNc70gjMM2xxRdfaqd5aIkPPMlpwcCO9KZM=; b=mj6IAzQKekIZCaeKrU3Ziueu1A9GWRj8sZRaU1T9ECxfeVdFclSYbkGbIVoJEUKLRF T6etakybPo+vG/oHq87q2ySe2qJlTw+GN6q+QjTFCapY+J/UGXFWhoXxqkVH4Y13Mo6T dsUwYVZFVFjobA9fcOlp0hyEl8hM5I5nZQ6+Gc8fPBwuDkyvR3z5yCLO1UPvc4TZFvJK boTEHfzbuLbjS0dabNp1mxjkHEW2+nTRZFbTzhL9ZxyGStessKt+AiDKE1I87TGPZ996 R6BgRZxnA6pUfFWriLOzR8Kj1H+G3NBEj03QX9Vp7qHiRm/1WRH9j1d4M6cAMtkprpuJ VHqg== X-Forwarded-Encrypted: i=1; AHgh+Rod5j/RR4ysSLwydEg1hN4LAIuhVGfQHsv4VfAkugM4RBNs4CyPbP7a7D0lMdJsyudGON928ZMpUZxu7uk=@vger.kernel.org X-Gm-Message-State: AOJu0Yyv6ReZzKfznpxcu0DH3K4WhwTvNvhH22wdMMXztuouKtwtuT7R TTf0eVVOVlTjXLyx4jx4CyA/lP5NuEy6pA3280cWRms9fAC0NKoEZ3J2Ckb0N9R3 X-Gm-Gg: AR+sD11czqienQjPr11ypyB3iP27O8IOI/8mOk7DhzexC75roydgrRz9pY1MwXscPpR tmKSB1LFRG+GBz9pn8XUSzb3SOcwWMn+Mpumm+N7Rf+r1Zt0LyvhE3o75aQkMaSEzRSzo7pO67j LwUssQ6td4pQDYVV3UsoEI0zRUqlkynmQY/Kfofqv8WzR1TEFM1YfgSqpKx/laB1pwiVDUxNznf anhiCLJf+avQrLxWY2nih/DZo27pEQuOCfCnEil5qjvcvCpYoEIak+M29UfhH7e2FBG7siRe3Gj a0W6gkXLIAn3piRHYcUZf0fXQ/cELS0gQ5WVuTwzY2pdJ4zPErp/tAnXGgZ8CP6A8ex/G6qocZD eQPYMjSDHd/yu4JgBKFsPutOXvuvwhvAsqbF0amk5Nc9c3eRID5xi0qYuxpzSnLyLs9hVA6U1yA da51r9xwRhc/9rM0UXHeXZqatt1PBEuJUQskVHnjkUI1+zb+DkaFH1otemwpA5NBq5UQwNQR6Rd M/unjshvigiNNP/271E1qa5Ee63 X-Received: by 2002:a05:6a21:a04:b0:3bf:9aa9:b2a4 with SMTP id adf61e73a8af0-3cb85ef91f7mr5390244637.20.1785909332467; Tue, 04 Aug 2026 22:55:32 -0700 (PDT) Received: from [192.168.20.42] (115-70-157-242.ip4.superloop.au. [115.70.157.242]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-315867bc261sm11717163eec.28.2026.08.04.22.55.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 22:55:32 -0700 (PDT) From: Tsz Shan Chan X-Google-Original-From: Tsz Shan Chan Date: Wed, 05 Aug 2026 15:55:15 +1000 Subject: [PATCH 1/2] pinctrl: sx150x: Return IRQ_NONE if no pending irq Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260805-sx1502-v1-1-6434d51fe909@jacques.com.au> References: <20260805-sx1502-v1-0-6434d51fe909@jacques.com.au> In-Reply-To: <20260805-sx1502-v1-0-6434d51fe909@jacques.com.au> To: Linus Walleij Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Tsz Shan Chan X-Mailer: b4 0.14.3 The driver currently reads the interrupt source register, writes the value back to clear it, and always returns IRQ_HANDLED. When the IRQ is shared, the handler should not claim interrupts that are not from this device. Check for zero interrupt source first. It no interrupt is pending, return IRQ_NONE and skip the register write. Signed-off-by: Tsz Shan Chan --- drivers/pinctrl/pinctrl-sx150x.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/pinctrl/pinctrl-sx150x.c b/drivers/pinctrl/pinctrl-sx1= 50x.c index b59d913513d5..015b1d0744e4 100644 --- a/drivers/pinctrl/pinctrl-sx150x.c +++ b/drivers/pinctrl/pinctrl-sx150x.c @@ -550,6 +550,9 @@ static irqreturn_t sx150x_irq_thread_fn(int irq, void *= dev_id) if (err < 0) return IRQ_NONE; =20 + if (!val) + return IRQ_NONE; + err =3D regmap_write(pctl->regmap, pctl->data->reg_irq_src, val); if (err < 0) return IRQ_NONE; --=20 2.55.0 From nobody Fri Oct 2 05:30:35 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B51003DAACC for ; Wed, 5 Aug 2026 05:55:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785909339; cv=none; b=JzGNkBkGI7WHl47s+wGcQm00vSMiFcBAGL9mDSMEjyO0ObpGdOERiFh8UXK3n7CQtFkwIoMqz/Bwhhzh7cXjQC6vsZmDOHvMdMSmj0ygGy3/YmN/auGhubYuAxi1AlKkC1n5kVKK2SxUcZ+IhxxD/qaHebsfeWZ64mF4/URfW4A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785909339; c=relaxed/simple; bh=YndnRnIJzNP08VGoOkCcRoa2iLM6zllhm8/C1C7xUwc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CWhsXevDhOPWpV3JhVP+DhpQB3LCYP/9NPHD46xq4GFAN5IRywj7qvpvxFaitAgwswdwkYf3tqgKwFualE9h7hN2iJc7ga/jbw5oBeN8cEL0NwubMse314QP550vtjMaL6gBK2bOdNps1HuNgABpwmzfqDfo+efb1l5AWN0vWwg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NOl6v2wS; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NOl6v2wS" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2cf50c6f235so7796165ad.0 for ; Tue, 04 Aug 2026 22:55:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785909335; x=1786514135; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=fOIdjOr1d4mgFF8hvqH6IkNCcqLGziDH/BcL0uvYe64=; b=NOl6v2wSZ8I86nEKXT9/9iI4eLXMbHM7f9ljI8oVqzszlGX7OQfFAHBQq3DU5ingyN vhd3702BH6BU7Uo1t2SYb+h+y/fHm8ApJE1GoiZMCooHK2QOJvDqfH/qPiuXVRSWSWIB HMi+kiQDSpq84feSAVbGmj4dbgd9ez5nZnr7dle7pLlYMEZ5QqBmi/N/YA0XDKZ5rkg/ zJ6U9wb6hEoTk4sH6aQTCH7piIW0xzPJwuVsW2uPA6qNWUlK0xCtf/EczynMWR7ENhWP S/l1Nvwbp0yZxTq3Q4unLMdTsGNtT1WqjEagO07NuBczMhat+O6b61EbXQDjx5Nu7dwE AjPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785909335; x=1786514135; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=fOIdjOr1d4mgFF8hvqH6IkNCcqLGziDH/BcL0uvYe64=; b=UQ6pHpdQxfZEsV22Ykz6YcEW4uPXCLaS+pLSCbR6WGePdblFWFKRNFVL8p9f1A6KLl ShSC9e3Ahk10oJ0/0ShVblItOXgVGHBL6DpodaFzw71s4oZ3dQFTGk7z4sDf2DbxBLrJ 8tSh83LGhg100TL+O5UrcfocXhAk4GiOoVNkBBAuPJb2t/WcJXK4aCQxLsEPHTut6w/b N4OwnKBp4sKrTZE2pA3DRASGbCjLJ/Od4gLOI127HMgMEoQUeHgie1bgOfnsk8OLWyxH lDuv0EIkQXaTqDfRQzPQFWB5AoQVw3IguzZUezp7bxOfvqQzrgS4x2KI+PDWhaDmnXMd 6fcw== X-Forwarded-Encrypted: i=1; AHgh+RoWrWMtLt0t3K6xKq342aXhowJLRX5srYVm4h36D+nB8R5VXGq17JyvpM4mS2ppbWcw2bjlfdiZMEs6ymI=@vger.kernel.org X-Gm-Message-State: AOJu0Yyj2j4nau2X7ed1LKdAwmu1iANSvgvb0spJLRYKyl0ExZoMWNdP +xxxB9UdLJf0uThx/6zzdGxvN9C87jVeP4wRrcxcREFFg/1HMBwnAlhx0SQmTckg X-Gm-Gg: AR+sD12yutgIApQhA+etqeA8dC96zqHRsCxWGPdZaCqGlXs9+UkJui0IQwN85sHQ0Ar n3AcYy4eMVrzeEwHS2kkYmgXskj0yjn3/KB51ZJvDTt1ClsfHEFlzJUoKO2pdqkRd8OD/cYO/3I sMFfkgRKkisdQnGAIs0hJjwTKcmsFsbbntFqCCQimW1pSm3I+Ngy+Ogeoi409xM13emO5sghZeS /EqAMxvRcgePcJPKD8Kz8dQgivg6a47REqHWWTvYELMTJTAxtSuZ78uecwOCKNts1/r2Azl1qSH 3uOT7o15tfzKQswD6vloCIackGxkgS0QOWKaXoj4rOrUwYvZL/Sk77hg6803exYCe8P4EP+QHvS /UmggJuRwkiCjWnk3BwyC2JyptYkzAgU/QZYjkudV+lUXxQJALPV60P7fimsGA9RVSZxxFy86l3 IYcIpBp5TifvBQVqTSV1h/daJMQRMRN6Zy3crMPSYun6zTqcn+NugA6glbq1L83x2VwFzGqGDDp BbTOWaT5WfIL3i+jzvuuwGK74Vx X-Received: by 2002:a17:90b:580b:b0:38e:9e9d:9209 with SMTP id 98e67ed59e1d1-3903c5c51cdmr4272210a91.17.1785909334948; Tue, 04 Aug 2026 22:55:34 -0700 (PDT) Received: from [192.168.20.42] (115-70-157-242.ip4.superloop.au. [115.70.157.242]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-315867bc261sm11717163eec.28.2026.08.04.22.55.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 22:55:34 -0700 (PDT) From: Tsz Shan Chan X-Google-Original-From: Tsz Shan Chan Date: Wed, 05 Aug 2026 15:55:16 +1000 Subject: [PATCH 2/2] pinctrl: sx150x: get parent IRQ trigger type from firmware Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260805-sx1502-v1-2-6434d51fe909@jacques.com.au> References: <20260805-sx1502-v1-0-6434d51fe909@jacques.com.au> In-Reply-To: <20260805-sx1502-v1-0-6434d51fe909@jacques.com.au> To: Linus Walleij Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Tsz Shan Chan X-Mailer: b4 0.14.3 The driver currently hardcodes the parent interrupt trigger type to IRQF_TRIGGER_FALLING. Use the trigger type configured by firmware instead. If no trigger type is specified, fall back to IRQF_TRIGGER_FALLING to maintain current behaviour. Support IRQF_TRIGGER_FALLING and IRQF_TRIGGER_LOW, which match the sx150x open drain active low interrupt output. Reject unsupported trigger types. Signed-off-by: Tsz Shan Chan --- drivers/pinctrl/pinctrl-sx150x.c | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-sx150x.c b/drivers/pinctrl/pinctrl-sx1= 50x.c index 015b1d0744e4..62c582a52b3e 100644 --- a/drivers/pinctrl/pinctrl-sx150x.c +++ b/drivers/pinctrl/pinctrl-sx150x.c @@ -1125,6 +1125,7 @@ static int sx150x_probe(struct i2c_client *client) I2C_FUNC_SMBUS_WRITE_WORD_DATA; struct device *dev =3D &client->dev; struct sx150x_pinctrl *pctl; + u32 irq_type; int ret; =20 if (!i2c_check_functionality(client->adapter, i2c_funcs)) @@ -1224,10 +1225,24 @@ static int sx150x_probe(struct i2c_client *client) girq->handler =3D handle_bad_irq; girq->threaded =3D true; =20 + irq_type =3D irq_get_trigger_type(client->irq); + switch (irq_type) { + case IRQF_TRIGGER_FALLING: + case IRQF_TRIGGER_LOW: + break; + case IRQF_TRIGGER_NONE: + irq_type =3D IRQF_TRIGGER_FALLING; + break; + default: + return dev_err_probe(dev, -EINVAL, + "unsupported irq trigger type %x\n", + irq_type); + } + ret =3D devm_request_threaded_irq(dev, client->irq, NULL, sx150x_irq_thread_fn, IRQF_ONESHOT | IRQF_SHARED | - IRQF_TRIGGER_FALLING, + irq_type, client->name, pctl); if (ret < 0) return ret; --=20 2.55.0