[PATCH v2 0/3] staging: rtl8723bs: clean up management transmit return values

Hungyu Lin posted 3 patches 2 months ago
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c    | 13 ++++---------
drivers/staging/rtl8723bs/core/rtw_xmit.c        |  8 ++++----
drivers/staging/rtl8723bs/hal/hal_intf.c         |  9 +++++++--
drivers/staging/rtl8723bs/include/hal_intf.h     |  2 +-
drivers/staging/rtl8723bs/include/rtw_mlme_ext.h |  2 +-
drivers/staging/rtl8723bs/include/rtw_xmit.h     |  2 +-
6 files changed, 18 insertions(+), 18 deletions(-)
[PATCH v2 0/3] staging: rtl8723bs: clean up management transmit return values
Posted by Hungyu Lin 2 months ago
This series continues the cleanup of management transmit return values
in the rtl8723bs driver.

Patch 1 converts rtw_mgmt_xmitframe_coalesce() to return kernel-style
errno values.

Patch 2 propagates the new return value convention through
rtw_hal_mgnt_xmit().

Patch 3 makes dump_mgntframe_and_wait() return void, since none of its
current callers use its return value. It still uses the return value
from rtw_hal_mgnt_xmit() internally to determine whether to wait for
completion.

Changes in v2:
 - Clarify commit messages based on review feedback.
 - Make dump_mgntframe_and_wait() return void instead of converting it
   to errno values.

Hungyu Lin (3):
  staging: rtl8723bs: convert mgmt xmit coalesce to errno
  staging: rtl8723bs: propagate errno handling for mgmt xmit
  staging: rtl8723bs: make dump_mgntframe_and_wait() return void

 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c    | 13 ++++---------
 drivers/staging/rtl8723bs/core/rtw_xmit.c        |  8 ++++----
 drivers/staging/rtl8723bs/hal/hal_intf.c         |  9 +++++++--
 drivers/staging/rtl8723bs/include/hal_intf.h     |  2 +-
 drivers/staging/rtl8723bs/include/rtw_mlme_ext.h |  2 +-
 drivers/staging/rtl8723bs/include/rtw_xmit.h     |  2 +-
 6 files changed, 18 insertions(+), 18 deletions(-)

-- 
2.43.0
Re: [PATCH v2 0/3] staging: rtl8723bs: clean up management transmit return values
Posted by Dan Carpenter 2 months ago
On Fri, Jul 31, 2026 at 03:52:25PM +0000, Hungyu Lin wrote:
> This series continues the cleanup of management transmit return values
> in the rtl8723bs driver.
> 
> Patch 1 converts rtw_mgmt_xmitframe_coalesce() to return kernel-style
> errno values.
> 
> Patch 2 propagates the new return value convention through
> rtw_hal_mgnt_xmit().
> 
> Patch 3 makes dump_mgntframe_and_wait() return void, since none of its
> current callers use its return value. It still uses the return value
> from rtw_hal_mgnt_xmit() internally to determine whether to wait for
> completion.
> 
> Changes in v2:
>  - Clarify commit messages based on review feedback.
>  - Make dump_mgntframe_and_wait() return void instead of converting it
>    to errno values.
> 
> Hungyu Lin (3):
>   staging: rtl8723bs: convert mgmt xmit coalesce to errno
>   staging: rtl8723bs: propagate errno handling for mgmt xmit
>   staging: rtl8723bs: make dump_mgntframe_and_wait() return void

Thanks!

Reviewed-by: Dan Carpenter <error27@gmail.com>

regards,
dan carpenter