From nobody Fri Oct 2 12:20:16 2026 Received: from mail-pj2-f1.google.com (mail-pj2-f1.google.com [74.125.227.129]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D633D42E8EA for ; Fri, 31 Jul 2026 15:52:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.129 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785513173; cv=none; b=czE9W1JeONyHauPfxP9Cl80OTv1EMcc/aFnVXz0x5uEitxXaqltKeCLFtfzYtFM2M9xh3XVJAcyvUs2sLM0nBNJJ9APdPEDPizcW/np9r+ot6TlXqR+yfYEt9L165AwylsRb+PSxyY2OqoexAYMS2+0LKc8/l/BrdM2MSGXmf70= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785513173; c=relaxed/simple; bh=a0+Z9k6sMPSnzJ+y4Vd/U9aGI8y7mXfbpjtyaBPpXhM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=A8OD9NVhMZ36qN7B1//J/7df9FVyCerDlgCabjlBKvW+YIXVveJNTcM3U+CPaQBxwK3uCxdBjdMbxVNFss+0Wm7DkXjePHY1kOojh3eX02OaTL8xeRh2mq4luJkBOzNUn84FyksRXjLiQkgEmdRxZYSz1xUdm6nYtHPTpvRLzwA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aQ/pFXQ5; arc=none smtp.client-ip=74.125.227.129 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aQ/pFXQ5" Received: by mail-pj2-f1.google.com with SMTP id 98e67ed59e1d1-381072761d4so720385a91.0 for ; Fri, 31 Jul 2026 08:52:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785513170; x=1786117970; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=k6xscdSdqtSuRhxAG9/cpxfE7oRD8F29mqyv1hfzFk0=; b=aQ/pFXQ5XkNIh5NfbcvI0+tcRBUYzkBN3I3ChoztNcuDOfd687J6sNraw3235OUTDS K2WDE1QrjQIBZoC2ubmJkzdsLfVQN6t6gCYuve4NZIWouvQPR9SADKXdgzSIIj4DyF0o ODm8DZ1P1KJFMaCTXcHFcQs5aGJ5nzw1IXNqXw4IDu2PLAiWIuX7GiJsAyNDsWQclAsQ KSamRv8pkK1ZSM9X56WckPzNfw0O7uBQe7VyHqSGCupVXU8PCfw4I9HdCOJxf+GaxT/p E20k734jOAMd0Np43xlHwWUWXUFOjQG7Lpw18iGNvS8TjFszE7L5UrWmcGdMZKX7ef68 cOBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785513170; x=1786117970; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=k6xscdSdqtSuRhxAG9/cpxfE7oRD8F29mqyv1hfzFk0=; b=rI2H/Eyk7UCD9hMbX8KkXk1NW2PhYJE+dB3h929SvTiprSmjj0WAZkiJlc0cxYtnTP whhse+IdYz35JGBJ75Rwu3R+TPD9qwzhPn4tmRUjVxacIwTwaRE2it9kvTXkS5G7MQnd HTea0FnqNZ+25JP/BfHP/fwM0klu9DzZVj2bQ5UOP9mtikO67r87WFJW6gkCTP+s8Jn1 adoZbOGwmz678+8ToAupgWkZHoAb2+AW0qy2URlTpf21gcT+WlwVcggAtaMi3JdTGUPP D7ZYZTnwfAfD4O7l4g+NSqe3vgFyHKnnC3ax0LgeJGNHJVSIwnhO7CiK5/3MOR25Bwxz KW/A== X-Forwarded-Encrypted: i=1; AHgh+RoO8t3zNtQQGyyBpuz9O8TV486sBwEhqwKImUWdrOU/b2Ift53zQ7MVPglJo1De8OHU3hlETbuuTrhigIg=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5t79lfxgce7aIP7ICyueA2W13Cz1O2F3D2XeiJ4US6gApN6cG uJ3eCb+XWLyWxywXrPzCEZUHW9VH4+cFBuIPlR6WKNcye0LyyXJlrpjV X-Gm-Gg: AR+sD10EiKQXSgP/BwXQngRNjNrXvNM3XYKpB0MQTLA2NsKGhdqkDZQ/1Icf21CbVea cZCqICAjwEe1mkYwFgx6Y9Dr5+DYF/FSIeVjNVPLM3M39o3x6ZDn+fEPS422OdfDCmIdSqYV+fZ qrFPug+/Q+2xbYzwmbRQhtpKJXSjl9JpwltwkZ/0ZNfb9+9Y+JZnPRAiRcU1EAsdko5qGoZFA9G wRol8g1M8YBPnlb/mB5gSdlOBaw9+AljMN+kACzuL/pB0HSEFDxuau7uPJ8iDPptBwFQF0kCzdY rsAjzaT4CKCCwRpnq8P6J7ihX71qwnjDF5pn3dIXxvD5xCKSd1+2Q2On92JvNGvo79VakHsiCKL rgs1jnycfexTYCB8pATF7MpZPQrdcSZJQnBmIzEExQefqSma6qj9J9SlbOoCUyH5n6BP3ZQoDX+ 9skLXkTrZ5oJETxfcowtTH17Tv06mfpvjRNuNMH+03FE1dgaNdTx6Dew2teF/FMQPG+Kyvwy+wO oCRTGZ/m0wb7TSX6bgg X-Received: by 2002:a17:90b:5102:b0:38e:4b71:8b0 with SMTP id 98e67ed59e1d1-38fbc4ff425mr387767a91.25.1785513170338; Fri, 31 Jul 2026 08:52:50 -0700 (PDT) Received: from localhost.localdomain ([76.86.179.124]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153dd9c96asm7669604eec.7.2026.07.31.08.52.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 08:52:50 -0700 (PDT) From: Hungyu Lin To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, error27@gmail.com, Hungyu Lin Subject: [PATCH v2 1/3] staging: rtl8723bs: convert mgmt xmit coalesce to errno Date: Fri, 31 Jul 2026 15:52:26 +0000 Message-ID: <20260731155228.22526-2-dennylin0707@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260731155228.22526-1-dennylin0707@gmail.com> References: <20260731155228.22526-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Change rtw_mgmt_xmitframe_coalesce() to use kernel-style return values. Return 0 on success and negative errno on failure. The only caller currently doesn't check for errors, so this change does not affect runtime behavior. Later patches in this series will propagate error handling to the caller. Signed-off-by: Hungyu Lin Reviewed-by: Dan Carpenter --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 8 ++++---- drivers/staging/rtl8723bs/include/rtw_xmit.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index 16e6c9567224..01512f438295 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -1187,7 +1187,7 @@ int rtw_xmitframe_coalesce(struct adapter *padapter, = struct sk_buff *pkt, struct } =20 /* broadcast or multicast management pkt use BIP, unicast management pkt u= se CCMP encryption */ -s32 rtw_mgmt_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *= pkt, struct xmit_frame *pxmitframe) +int rtw_mgmt_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *= pkt, struct xmit_frame *pxmitframe) { u8 *pframe, *mem_start =3D NULL, *tmp_buf =3D NULL; u8 subtype; @@ -1210,7 +1210,7 @@ s32 rtw_mgmt_xmitframe_coalesce(struct adapter *padap= ter, struct sk_buff *pkt, s BIP_AAD =3D kzalloc(ori_len, GFP_ATOMIC); =20 if (!BIP_AAD) - return _FAIL; + return -ENOMEM; =20 tmp_buf =3D BIP_AAD; subtype =3D GetFrameSubType(pframe); /* bit(7)~bit(2) */ @@ -1341,12 +1341,12 @@ s32 rtw_mgmt_xmitframe_coalesce(struct adapter *pad= apter, struct sk_buff *pkt, s xmitframe_coalesce_success: spin_unlock_bh(&padapter->security_key_mutex); kfree(BIP_AAD); - return _SUCCESS; + return 0; =20 xmitframe_coalesce_fail: spin_unlock_bh(&padapter->security_key_mutex); kfree(BIP_AAD); - return _FAIL; + return -EINVAL; } =20 /* Logical Link Control(LLC) SubNetwork Attachment Point(SNAP) header diff --git a/drivers/staging/rtl8723bs/include/rtw_xmit.h b/drivers/staging= /rtl8723bs/include/rtw_xmit.h index 917e846e9ce2..31decc210e73 100644 --- a/drivers/staging/rtl8723bs/include/rtw_xmit.h +++ b/drivers/staging/rtl8723bs/include/rtw_xmit.h @@ -424,7 +424,7 @@ int rtw_xmitframe_enqueue(struct adapter *padapter, str= uct xmit_frame *pxmitfram extern u32 rtw_calculate_wlan_pkt_size_by_attribue(struct pkt_attrib *patt= rib); #define rtw_wlan_pkt_size(f) rtw_calculate_wlan_pkt_size_by_attribue(&f->a= ttrib) extern int rtw_xmitframe_coalesce(struct adapter *padapter, struct sk_buff= *pkt, struct xmit_frame *pxmitframe); -extern s32 rtw_mgmt_xmitframe_coalesce(struct adapter *padapter, struct sk= _buff *pkt, struct xmit_frame *pxmitframe); +extern int rtw_mgmt_xmitframe_coalesce(struct adapter *padapter, struct sk= _buff *pkt, struct xmit_frame *pxmitframe); s32 _rtw_init_hw_txqueue(struct hw_txqueue *phw_txqueue, u8 ac_tag); void _rtw_init_sta_xmit_priv(struct sta_xmit_priv *psta_xmitpriv); =20 --=20 2.43.0 From nobody Fri Oct 2 12:20:16 2026 Received: from mail-pz2-f1.google.com (mail-pz2-f1.google.com [74.125.228.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 922624457D4 for ; Fri, 31 Jul 2026 15:52:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.1 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785513175; cv=none; b=Cs8bMn9WtsfcK1z1Z/IXu/5hqbP/f3oaaVOeF/voLqQ8p5ZTG1EpPhR2a4S9sg9b5bwIw3pJTctRnWUbGLdtdvu5rB4STbrQtPn/Zw/AgRUA+EyJX+fvI/tZNlVdW9Nqj0tkQDclPIyd8aq9KqgGqkpDG72hPo48Ouqn9lfOrb0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785513175; c=relaxed/simple; bh=dl/mkrgMeB9TSEWmDgogvhLnGMjB3saQNaK8XEddEdw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TVZ9aqp6q3qVjF93zYNUWCYn9XJuTNZmFFNniPBNprvpPd/Q3ja24qOxR8Ej/dZFUgR0bBFCgiMNNxTWNoQc9dyia4wzwVkbuFs9Qv9/BKA3EFKH/UG9+lPq+5NxijaYzgk9kLvmRGMANwHOLOkDPa70TmR1hPyonYPh1pojL4A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SeeML4V0; arc=none smtp.client-ip=74.125.228.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SeeML4V0" Received: by mail-pz2-f1.google.com with SMTP id 41be03b00d2f7-ca696c4b152so346537a12.1 for ; Fri, 31 Jul 2026 08:52:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785513172; x=1786117972; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=SgxSm8O2Ph/vh7farPcof8o4aTta2ebVjrMlcZ8XUVI=; b=SeeML4V0382/yPLdjiyE407VioQMn3jwwoLW9G9Z2r3tIuXdXPSSBOD9E/Cyb2NQn0 vl8GzEmr+bXCtr+E6/M3HWlOO9kUMY4cqUqriXFa0YwJRQi5Z/3umT2E5k6zjks7K2jC 6/2PbJ0ZUo9eIQCk8PxSw45qaIEqHFPRXxkjfKg81yNaa/icZxyqtS3BBMFtPzhP9Wj4 fB9CLFM7PikJDu1apU9POOuu9DWCcPogZBWu9gNSDsoU4BlF4+HdRyPMMZjoPZW4JjU5 +KSlm5O/R6htYLkTG3Gngi+FDPGTXnx8j65ScjkOetvZ6q31ILnWtbXkP5lXtPjYIv2w 3siw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785513172; x=1786117972; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=SgxSm8O2Ph/vh7farPcof8o4aTta2ebVjrMlcZ8XUVI=; b=tDucVzC4CdvcnuYz/Q6bk+1xq4wrpVnxM4FQ1uby9x6EK2BQgDcRs+01Vk6XfXhlNa GJ60/TpvJyUh+SRfUq93AgGOKHLcVM4551MEfkAHXOuJgyR3raqDtF66F0sv9aFFTdBi BFrFaMg7RtLDKUXcoPicB+a9h6Q8eXPmzZWykRR6BwD3pQyWwcJelXRWv7j2pHguQd7X D3WsH+xasJJG4dr/r7eXxq0WGzWn9ZC8qCg2V/hzW2TlekRxLDv/bS+kxaTWTjfZwfZP C37ZBGcwElyLglQg/vLKjkxwDVuG8eJP5CcurrTV+laVKJPfW/OA6rGj2wK1ThxIENwH PC/g== X-Forwarded-Encrypted: i=1; AHgh+Ro07c4cdX4vSuPZQWInTH5ReM8v7cKnjs7M6oncCpd5Jt8AGv5Mb+1c9HQ8RSXusgYqpjta9Oc+IyoSLOw=@vger.kernel.org X-Gm-Message-State: AOJu0Ywj7Z2CBphswx5Z71MAdKvz0og5paoxadjuS0rW/jwcPfU1a2cC dYQl66SzishfmOjr6tkq+CQ055osshQ/EUxfcX9bbALQz/4Y1X63VlOC X-Gm-Gg: AR+sD12clmc3ose1JoJPOYub0NIWXYYAA5SsePXOM1+80zmHK62nIaFP7J9A8WLJXRg V6gByUhCm7QIIefMryH9kKdCnIgEK5l3GDbC1npOIr0fUby+oIRbrZzvyQ8CJZcwBVPBw06MIry UsmIFOjmpmju86yQr4HQM1r1+I3DrayFNuZ79NU5t1ZFqhI5sunswGMnI8LrWGMMjSxc373CMrF wyGxJWq1T+XE452hcJLCkG+xW5AIQ1+gZrrXGkEbEULSGmRgT4wk6piL8vApOAzxcK8Qqke+3Of i2I2j3JXJUZ/Wb9R+W048msfJCb6/PV3ENkGNWa0vFXCKdepnQeXbZm99a74bdyJApVVCgq3wxO WRWvUDLIMcSTNXaAhlKL4Uv5z3xHrQGs9FQ8VUqpoPuJikz+Nq8HeRFWOADi9Nf9r9JJnNvVvrl umZN80Bg3KH/C0d0VZxRU15NA/GG/iaZieL7NAdmsFayYJpjDCWUe1b3q2NmFEUB24Bt8O925Fq p4Yd/A1U1loygMY1BBO X-Received: by 2002:a05:6a20:728e:b0:3c0:adec:b3bd with SMTP id adf61e73a8af0-3c92a8a8fb7mr290227637.49.1785513171551; Fri, 31 Jul 2026 08:52:51 -0700 (PDT) Received: from localhost.localdomain ([76.86.179.124]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153dd9c96asm7669604eec.7.2026.07.31.08.52.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 08:52:51 -0700 (PDT) From: Hungyu Lin To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, error27@gmail.com, Hungyu Lin Subject: [PATCH v2 2/3] staging: rtl8723bs: propagate errno handling for mgmt xmit Date: Fri, 31 Jul 2026 15:52:27 +0000 Message-ID: <20260731155228.22526-3-dennylin0707@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260731155228.22526-1-dennylin0707@gmail.com> References: <20260731155228.22526-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Convert rtw_hal_mgnt_xmit() to return errno-style values and update the prototype in hal_intf.h. After this change, dump_mgntframe_and_wait() still uses the return value of rtw_hal_mgnt_xmit() to determine whether it should wait for completion. A follow-on patch will make dump_mgntframe_and_wait() return void since its return value is unused by all current callers. Signed-off-by: Hungyu Lin Reviewed-by: Dan Carpenter --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 4 ++++ drivers/staging/rtl8723bs/hal/hal_intf.c | 9 +++++++-- drivers/staging/rtl8723bs/include/hal_intf.h | 2 +- 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/stagin= g/rtl8723bs/core/rtw_mlme_ext.c index f5ab94a2d0a0..0027f9333738 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -1990,6 +1990,10 @@ s32 dump_mgntframe_and_wait(struct adapter *padapter= , struct xmit_frame *pmgntfr pxmitbuf->sctx =3D &sctx; =20 ret =3D rtw_hal_mgnt_xmit(padapter, pmgntframe); + if (ret) + ret =3D _FAIL; + else + ret =3D _SUCCESS; =20 if (ret =3D=3D _SUCCESS) ret =3D rtw_sctx_wait(&sctx); diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c b/drivers/staging/rtl= 8723bs/hal/hal_intf.c index 2caade1a8bdd..1443875d1369 100644 --- a/drivers/staging/rtl8723bs/hal/hal_intf.c +++ b/drivers/staging/rtl8723bs/hal/hal_intf.c @@ -115,8 +115,10 @@ s32 rtw_hal_xmit(struct adapter *padapter, struct xmit= _frame *pxmitframe) /* * [IMPORTANT] This function would be run in interrupt context. */ -s32 rtw_hal_mgnt_xmit(struct adapter *padapter, struct xmit_frame *pmgntfr= ame) +int rtw_hal_mgnt_xmit(struct adapter *padapter, struct xmit_frame *pmgntfr= ame) { + int ret; + update_mgntframe_attrib_addr(padapter, pmgntframe); /* pframe =3D (u8 *)(pmgntframe->buf_addr) + TXDESC_OFFSET; */ /* pwlanhdr =3D (struct rtw_ieee80211_hdr *)pframe; */ @@ -130,7 +132,10 @@ s32 rtw_hal_mgnt_xmit(struct adapter *padapter, struct= xmit_frame *pmgntframe) pmgntframe->attrib.encrypt =3D _AES_; pmgntframe->attrib.bswenc =3D true; } - rtw_mgmt_xmitframe_coalesce(padapter, pmgntframe->pkt, pmgntframe); + ret =3D rtw_mgmt_xmitframe_coalesce(padapter, pmgntframe->pkt, pmgntfram= e); + + if (ret) + return ret; } =20 return rtl8723bs_mgnt_xmit(padapter, pmgntframe); diff --git a/drivers/staging/rtl8723bs/include/hal_intf.h b/drivers/staging= /rtl8723bs/include/hal_intf.h index 8a85e8419e47..1b6b348435cb 100644 --- a/drivers/staging/rtl8723bs/include/hal_intf.h +++ b/drivers/staging/rtl8723bs/include/hal_intf.h @@ -197,7 +197,7 @@ u8 rtw_hal_check_ips_status(struct adapter *padapter); =20 int rtw_hal_xmitframe_enqueue(struct adapter *padapter, struct xmit_frame = *pxmitframe); s32 rtw_hal_xmit(struct adapter *padapter, struct xmit_frame *pxmitframe); -s32 rtw_hal_mgnt_xmit(struct adapter *padapter, struct xmit_frame *pmgntfr= ame); +int rtw_hal_mgnt_xmit(struct adapter *padapter, struct xmit_frame *pmgntfr= ame); =20 s32 rtw_hal_init_xmit_priv(struct adapter *padapter); void rtw_hal_free_xmit_priv(struct adapter *padapter); --=20 2.43.0 From nobody Fri Oct 2 12:20:16 2026 Received: from mail-pj2-f2.google.com (mail-pj2-f2.google.com [74.125.227.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A97A044212E for ; Fri, 31 Jul 2026 15:52:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.130 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785513177; cv=none; b=JazEOpW7Ub6t1zJFQ//DroVcufr4a1InBFS9KVGQdXPB7ug6Orlg0+G5M57eUmaC2QT1WaT3pQ9wpzXKhBQiGK/+abyFIQsG8TumCpNf46cvYaMb/66k2NgZpYmpZeA8n2V5ByRaxEGGWdCToricbzhDs9/DNKBTnWJo0bWHaDY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785513177; c=relaxed/simple; bh=7fYmSEJo0qt1KsiBzseFp7MKWs4c6z76dKmxrU1GCBk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=B5iqSlLI1mLPOMuYyGwecQItNdOhiWcjwx20iitEEt1QAlLgVpCST0qcOYlT1xaOnV5o/r3Sh/t9wxTkjv0Ye9lz8T08eNn4dU4Aq+OJdQ80BP3rL7s1XbK34RsX1/LqimVTDscwQckHtF8WKdMK3hCf3ShYsL+YW9tmpvz4dFg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ockb56CZ; arc=none smtp.client-ip=74.125.227.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ockb56CZ" Received: by mail-pj2-f2.google.com with SMTP id d9443c01a7336-2ccc2e84048so6226425ad.1 for ; Fri, 31 Jul 2026 08:52:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785513172; x=1786117972; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/U/K3yrZZAsmjUNPPmafsMwvP5MWR/doyv5T2RcThE4=; b=ockb56CZchmA/nSZyXBw55O8ji1NcSzH6ZJI9R0mRswT9O2A+22fvgolSrj6pbOPFN yEuOXlxLZVd49w/8uLe74p+q+XTXcqvN/XfQh2/en//daNfjsyu6qsAt/i0Gq59wNr23 bJnkZTpQeEzqvnyMr/p/J+5T8lADEeuzhf+iJTqMql8w+xOEKOSHkkuNUBoF8Dghi2J3 lsEiaMsOXd9qTtXS9p+yKV7fL2+tapyKMkSrSrKTxuhkr9sJU548hN13FyiptBsHy9s1 lH3LaLG7UYY5aaRkXJ1pgVL5uyCf8FQ09tAYvHbD/GedVda01c2N8jLBijtHjc0Sq0Os Ntmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785513172; x=1786117972; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=/U/K3yrZZAsmjUNPPmafsMwvP5MWR/doyv5T2RcThE4=; b=d5g/LxOasYt+jPomjV7lWKn1QjUx77Ikn6AevgvepXTgFdAJGOKkOeEPpgwE9AGy4y w8AGHpzfapSFjuFKEzzYmsvjXUcTXjr9Hm+BCpAA2LPbtwT5qU47ZW+dDEESBf3PuKBZ V+W1rRcNdSNpPCAxeOOzbYtWz6VH9jX1YRfdNCi2rRCEFJm0alJfIkHzs8R/jfdJhI7H iY8IzxKGzbrnslX8FKI35uAKQUGHVv+lqCurHdtu7gYpuof1UFhkYIHObaJmXQmxr0ER 5r/ccQCzxMJTdkKyzzSWn1nJfM15pw1HtHVJu9OaHxWgiAjnXE+zXmW1/mXTl/ptgaXD pzEQ== X-Forwarded-Encrypted: i=1; AHgh+Rqqd7dFb/f5PoNvTXyZu6q4Qg5CMedii3VPRlTID33IarDfmlGtsFcw6K7pm28zLrz9T8i48ptjw/+XMsU=@vger.kernel.org X-Gm-Message-State: AOJu0Yyu8LcKVDREj0oa3JtKxwZFFlCm8oxAKL4uCjyBumUVL5FigpiR L9YAcn0ZEv/d/lEUg39sD7wEb7VY46r3ZpdIgBHde9cxORFiq8k46aSSVxerETjM X-Gm-Gg: AR+sD13wGWHKTfPK8Z/aT6uQk4TfGavMS7Sb9qfRvLFy7VYYPxv76YGmSkEzyMkOAeI bV7ePpNft9WuXM8c/nxViwbENwP4k8qWD6TX/VJdO3fUI7c5iCVLqFw15phhV2ge5uXVadB5Ugj IXQTVUcacTkDW102OVPftMfBd0M3SxgeEOJEn1mTm47H7zNP34pqF5SRjPZFywnJ22TSNAyoh/n KLqb3YZikOdyGpuorxLlOWjhb9Ym8tuoxlHs2Wu6Dv64+k7uZ0jnehb9v3wCV3ZAerJXNIi6jCL Quo/IrbPhMKEsiQxb/UGz8ScDnGS0IWeMM/jCYg2mgEFLcerS8VdbLTI0N6/B9TolJUONQqWdHn SMxMylDPZiTuknyx7f/lp+jb5KS4NZto92g+enkTu5kdeIDM6PlSyaNCcTKfNqwGwD1AXfJniQZ uelgFvCutHie5WUi+0Hy7B3U3l8ojBq9c1VlnzXd+noaE6+xJQxRraxYNtSM/fNqdgLj99h+1V0 skN14evMVZYw3dIW5xfIN+nRTys6aI= X-Received: by 2002:a05:6a20:3ca2:b0:3c3:9aff:7a46 with SMTP id adf61e73a8af0-3c92a5d35b9mr351193637.32.1785513172303; Fri, 31 Jul 2026 08:52:52 -0700 (PDT) Received: from localhost.localdomain ([76.86.179.124]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153dd9c96asm7669604eec.7.2026.07.31.08.52.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 08:52:52 -0700 (PDT) From: Hungyu Lin To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, error27@gmail.com, Hungyu Lin Subject: [PATCH v2 3/3] staging: rtl8723bs: make dump_mgntframe_and_wait() return void Date: Fri, 31 Jul 2026 15:52:28 +0000 Message-ID: <20260731155228.22526-4-dennylin0707@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260731155228.22526-1-dennylin0707@gmail.com> References: <20260731155228.22526-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The return value of dump_mgntframe_and_wait() is ignored by all current callers. Keep using the return value of rtw_hal_mgnt_xmit() to determine whether to wait for completion. Make dump_mgntframe_and_wait() return void because no caller uses its return value. Suggested-by: Dan Carpenter Signed-off-by: Hungyu Lin Reviewed-by: Dan Carpenter --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 17 ++++------------- .../staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +- 2 files changed, 5 insertions(+), 14 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/stagin= g/rtl8723bs/core/rtw_mlme_ext.c index 0027f9333738..ae760e9c655a 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -1971,9 +1971,8 @@ void dump_mgntframe(struct adapter *padapter, struct = xmit_frame *pmgntframe) rtw_hal_mgnt_xmit(padapter, pmgntframe); } =20 -s32 dump_mgntframe_and_wait(struct adapter *padapter, struct xmit_frame *p= mgntframe, int timeout_ms) +void dump_mgntframe_and_wait(struct adapter *padapter, struct xmit_frame *= pmgntframe, int timeout_ms) { - s32 ret =3D _FAIL; unsigned long irqL; struct xmit_priv *pxmitpriv =3D &padapter->xmitpriv; struct xmit_buf *pxmitbuf =3D pmgntframe->pxmitbuf; @@ -1983,26 +1982,18 @@ s32 dump_mgntframe_and_wait(struct adapter *padapte= r, struct xmit_frame *pmgntfr padapter->bDriverStopped) { rtw_free_xmitbuf(&padapter->xmitpriv, pmgntframe->pxmitbuf); rtw_free_xmitframe(&padapter->xmitpriv, pmgntframe); - return ret; + return; } =20 rtw_sctx_init(&sctx, timeout_ms); pxmitbuf->sctx =3D &sctx; =20 - ret =3D rtw_hal_mgnt_xmit(padapter, pmgntframe); - if (ret) - ret =3D _FAIL; - else - ret =3D _SUCCESS; - - if (ret =3D=3D _SUCCESS) - ret =3D rtw_sctx_wait(&sctx); + if (!rtw_hal_mgnt_xmit(padapter, pmgntframe)) + rtw_sctx_wait(&sctx); =20 spin_lock_irqsave(&pxmitpriv->lock_sctx, irqL); pxmitbuf->sctx =3D NULL; spin_unlock_irqrestore(&pxmitpriv->lock_sctx, irqL); - - return ret; } =20 s32 dump_mgntframe_and_wait_ack(struct adapter *padapter, struct xmit_fram= e *pmgntframe) diff --git a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h b/drivers/sta= ging/rtl8723bs/include/rtw_mlme_ext.h index 0c2bd51b6bc2..73b89832d27a 100644 --- a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h +++ b/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h @@ -533,7 +533,7 @@ void update_mgnt_tx_rate(struct adapter *padapter, u8 r= ate); void update_mgntframe_attrib(struct adapter *padapter, struct pkt_attrib *= pattrib); void update_mgntframe_attrib_addr(struct adapter *padapter, struct xmit_fr= ame *pmgntframe); void dump_mgntframe(struct adapter *padapter, struct xmit_frame *pmgntfram= e); -s32 dump_mgntframe_and_wait(struct adapter *padapter, struct xmit_frame *p= mgntframe, int timeout_ms); +void dump_mgntframe_and_wait(struct adapter *padapter, struct xmit_frame *= pmgntframe, int timeout_ms); s32 dump_mgntframe_and_wait_ack(struct adapter *padapter, struct xmit_fram= e *pmgntframe); =20 void issue_beacon(struct adapter *padapter, int timeout_ms); --=20 2.43.0