watchdog: Remove redundant error messages on IRQ request failure

[PATCH 0/9] watchdog: Remove redundant error messages on IRQ request failure

Pan Chuang posted 9 patches 2 days, 14 hours ago

Download series mbox

drivers/watchdog/bd96801_wdt.c      | 3 +--
drivers/watchdog/cadence_wdt.c      | 6 +-----
drivers/watchdog/intel-mid_wdt.c    | 4 +---
drivers/watchdog/keembay_wdt.c      | 4 ++--
drivers/watchdog/marvell_gti_wdt.c  | 2 +-
drivers/watchdog/orion_wdt.c        | 8 ++------
drivers/watchdog/realtek_otto_wdt.c | 2 +-
drivers/watchdog/sama5d4_wdt.c      | 4 +---
drivers/watchdog/sprd_wdt.c         | 4 +---
9 files changed, 11 insertions(+), 26 deletions(-)

Expand all Fold all

[PATCH 0/9] watchdog: Remove redundant error messages on IRQ request failure

Posted by Pan Chuang 2 days, 14 hours ago

Commit
55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()")
added automatic error logging to devm_request_threaded_irq() and
devm_request_any_context_irq() via the new devm_request_result() helper,
which prints device name, IRQ number, handler functions, and error code
on failure.

Since devm_request_irq() is a static inline wrapper around
devm_request_threaded_irq(), it also benefits from this
automatic logging.

Remove the now-redundant dev_err() and dev_err_probe() calls
in watchdog drivers that follow these devm_request_*_irq()
functions, as the core now provides more detailed diagnostic
information on failure.

Pan Chuang (9):
  watchdog: bd96801_wdt: Remove redundant dev_err_probe()
  watchdog: cadence_wdt: Remove redundant dev_err()
  watchdog: intel-mid_wdt: Remove redundant dev_err()
  watchdog: keembay: Remove redundant dev_err_probe()
  watchdog: marvell_gti: Remove redundant dev_err_probe()
  watchdog: orion: Remove redundant dev_err()
  watchdog: realtek_otto: Remove redundant dev_err_probe()
  watchdog: sama5d4: Remove redundant dev_err()
  watchdog: sprd: Remove redundant dev_err()

 drivers/watchdog/bd96801_wdt.c      | 3 +--
 drivers/watchdog/cadence_wdt.c      | 6 +-----
 drivers/watchdog/intel-mid_wdt.c    | 4 +---
 drivers/watchdog/keembay_wdt.c      | 4 ++--
 drivers/watchdog/marvell_gti_wdt.c  | 2 +-
 drivers/watchdog/orion_wdt.c        | 8 ++------
 drivers/watchdog/realtek_otto_wdt.c | 2 +-
 drivers/watchdog/sama5d4_wdt.c      | 4 +---
 drivers/watchdog/sprd_wdt.c         | 4 +---
 9 files changed, 11 insertions(+), 26 deletions(-)

-- 
2.34.1

Re: [PATCH 0/9] watchdog: Remove redundant error messages on IRQ request failure

Posted by Guenter Roeck 1 day, 1 hour ago

On 7/22/26 01:42, Pan Chuang wrote:
> Commit
> 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()")
> added automatic error logging to devm_request_threaded_irq() and
> devm_request_any_context_irq() via the new devm_request_result() helper,
> which prints device name, IRQ number, handler functions, and error code
> on failure.
> 
> Since devm_request_irq() is a static inline wrapper around
> devm_request_threaded_irq(), it also benefits from this
> automatic logging.
> 
> Remove the now-redundant dev_err() and dev_err_probe() calls
> in watchdog drivers that follow these devm_request_*_irq()
> functions, as the core now provides more detailed diagnostic
> information on failure.
> 

Series applied.

Thanks,
Guenter