From nobody Fri Jul 24 23:31:01 2026 Received: from TYDPR03CU002.outbound.protection.outlook.com (mail-japaneastazon11013016.outbound.protection.outlook.com [52.101.127.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4389A480DC1; Wed, 22 Jul 2026 08:42:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.127.16 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784709766; cv=fail; b=srdBP2vRL+1QmnbQci2lIq5IicSEOC14rcWPqptzu0OZweATx9aGLWTCvutOLNm03GXeYGRIahvnKVTr5uCdDojLsniX5wS2uRIdwh1fmGpd9EmPVH6J8VMvscjiC9QeZMn9vycpOCIKFhB6ZDi5WPfIrYeRT+NXpiH23Plx0Jw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784709766; c=relaxed/simple; bh=7p2JDmhfptlOoNvnhiHwV5K0AuOoHX5W16IFDzMKYOE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=hjpJVTLwo8FytzQweXAzYpPUVsp+EHrZ//3Ru7M43Yx/XvtDvlUB5hDrsbFsnkalAiqJ1kSewKIJga84QUMs7ZBaFuGtDIgxz69KXy4+FvTpxWWCV8VTHS9GcHAY3QtnVT0Dm5QOokTcWxod9Og9ur0dx7R6ezgGaGNwyp94D3o= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=LbJE/Zus; arc=fail smtp.client-ip=52.101.127.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="LbJE/Zus" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FFPjUUlx5H0Sr+ThzTYlTC5zoBvJ4bL/PVV97ac/gDIRZIzJXysR5ZDWBNAlH7WNAzxJTUA2JWcVrfMIcB1jBo0LOYO+BufmNL7K88x5+veNqC3bpd91U9yiJBXeGyqv08gQ1qI78kwbHs+LOe3oxDMxUcUfFNkGlvpPhRLAfJzoetI42jgCFSK5kMWUfwc/O16e0HWnszs5Pg7VErc5SzT8e+vkSt0gNGd/UwAzpkEt1JQpvzgc31PNcAxv12by8FqcIpnySRtG37a1ejVNOQSfhhwwSFZy4n4/jLIH2rBJT7l23nX8c/FhqsNVewWTk4cYHP3E/oM+fYsAVFKQrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RM3BFPHm82wufRTrBKxd4pQDsH/pMUZlLEpt8R2xNos=; b=yPJ8Vr8WdAYQGARRdc0OTd+tn6Vwtwy56zPyKNSZSqUCNkViZXyRDZQjDmbyd8emZm02T4ZbXsJMj0SPtUGsUVnnO9Na2UQ1ojgWne5pP4xPjx03Zz6nfTnKdkIRVw9zigDjeMJQK67oyRoHiEiZs3mVBTrSkZvNul8fccKbPI1ddjcXZBCrNy1m8+mBV4tr+NfJ5h1QCQ3sdz4g0oCui9Tciffb5H5npCaKZYWK6yZqZ0GR2vAyIiOYnyFJbuJd+JyZLwflvBoYh63goDir9FZM3aP/ICaWo3xhFZ3WMEFY7eMnThTSfngdXQDzXdb+xNn4+cSki+4vgal7e029Ew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RM3BFPHm82wufRTrBKxd4pQDsH/pMUZlLEpt8R2xNos=; b=LbJE/ZusMmKDNfNqv9ZEswwNu4Wd1rYEu1bJOEO0a8G1nDkeTE2hkA4JnKFYph+PW3VdfA/vXBJVmj+YYxRg1gMk21DDPN3zACy+E/OhorDGZuH+I+W/pz27Jnv48zlYkvD45vv9EWMmq857c9yxTux7fevjkYtsNADzkd8a6+wJS0Yrbyr4Y1uMaqdYVc0YeuW7t1LC6ItJWTF/l2qiQbqkaTQBiOUCHEQVECVmpyzZ4SRBCS1H/z2HJVX2tOFjO9j5I4G7B2994cURYrrmQskK4E2oQ8bwNLWe8Jg1OfVfzage9ssOqQFClz+vFpozlib5JRz2BX5Y/vvhx/LZ5A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by TY1PPF6C31DB54F.apcprd06.prod.outlook.com (2603:1096:408::919) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.12; Wed, 22 Jul 2026 08:42:37 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0245.009; Wed, 22 Jul 2026 08:42:36 +0000 From: Pan Chuang To: Matti Vaittinen , Wim Van Sebroeck , Guenter Roeck , linux-watchdog@vger.kernel.org (open list:WATCHDOG DEVICE DRIVERS), linux-kernel@vger.kernel.org (open list) Cc: Pan Chuang Subject: [PATCH 1/9] watchdog: bd96801_wdt: Remove redundant dev_err_probe() Date: Wed, 22 Jul 2026 16:42:09 +0800 Message-Id: <20260722084218.79073-2-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260722084218.79073-1-panchuang@vivo.com> References: <20260722084218.79073-1-panchuang@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI3PR02CA0006.apcprd02.prod.outlook.com (2603:1096:4:295::13) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|TY1PPF6C31DB54F:EE_ X-MS-Office365-Filtering-Correlation-Id: 0a3c03da-0d2a-43e5-2a3a-08dee7cd2e68 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|23010399003|1800799024|376014|366016|18002099003|22082099003|38350700014|11063799006|6133799003|10067099003|56012099006; X-Microsoft-Antispam-Message-Info: TeDSFyjLYb3goegFllxFrcN1FPv5b2b6A57wb5yIspMUuJkZ6+sVYjwFRo+Qqfh4XRk9j4cR2oRVhgBJiMlTznCuq62CXK+e4gt9czpofr4ZIvS6wRxKuGoKchElq5mxiFs/y3NgfYKjWNzEBgoPqe85IySf5hTNrkEIztOlWELSXwQcXOOnlw1gDtFR8WYG3PbvPxfP7rPcygnPY+siicTpwPCV1GqDyZ3mc527LzNzldpclVngGY5bPF3F0O2tNl4Chjhy/JuO7D+utRonHqJwyG/ozSy459dpIo0GnNEATI9A/07lL5YxAD7eSnBN2WVnqSgzj7aR7MsdAtd5wGvT2J5NQmJ78+BzE+5Lnlnq8DfbGkYzb4mgHhAv9Ycsdwg2rzTSmE08dxHoz0BPtQJZN18rJOh2W3x5LhYX/SFVm2nR7fYY+9m9UJ9OPTl57v5kBd5jEtNi8HBcicXEgrTQ2n8X1m+9MWuQUsScgsoB64WIfPhs8cnCjGOZHaO+KGbB77On5Pftz53hMcF6oggJ3kAIalLyUAzWdwn/TNlHsWYS9Bn2+KHeYlwROMVK9QkE5+0cwokcALL1MmvPkexuL0clr8Hj4okfzRb3c/Qes/IZuvM9yD+APTGd8l0vkX91yIh3Koiv2GdSQh63D/efhN6gQW79820QJZFqgXgfH+vqPINwj3Rr+hEh+qllMYl6Gp7A9Do3W9+b+yHJRxJpnROOFbuAhAjvL9NhtzA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(23010399003)(1800799024)(376014)(366016)(18002099003)(22082099003)(38350700014)(11063799006)(6133799003)(10067099003)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?X+1tT9/swE78TMXihyltyz+ukeQIa7XIsNkggXss/R5pcQTSN2cym4hajufN?= =?us-ascii?Q?XwzC2+cqHJPaElRSLVh9Jpk7h6poybCf6vH5z64+P57CghvkyM8Wp+u9HnE3?= =?us-ascii?Q?oDodT13sdecw6nvl+aN9E4MZaOpoCwBkJXyZz3+PgdtUMMVJ3H8C7MXwCeho?= =?us-ascii?Q?TNSRjCgKFwrTG92XhkDVgcaOK0y4Vept3ZBRitNFd0I78xiMPHOhGi+eh3rl?= =?us-ascii?Q?RtHxNscIgxQl/SiPRqwmNLIz2llDKhXUOKUK5D+eBXhDXWIiV55LV/grpunD?= =?us-ascii?Q?8PiIJWTd57bE90m3YV64K1CecG0CB63pOTx2hOyJDLRLE7m/aKh+EHyw+R9H?= =?us-ascii?Q?uANQ0R8AXrzujiZRX50ikzARIGqRxzKGRTB/qISJ2Qhv7TtFiTAM1IKfW30w?= =?us-ascii?Q?jpjrPUB7Z/AHK+q5byvFA+8AG02u7Kjr6vGv9BJeu3HSCNBJlbf/GcyuZPdJ?= =?us-ascii?Q?lApMUtXFn9ZNsifZx9JKMIFeE6avDcjjpsnrC4METmhaXY5PX1Rcds8eEqyH?= =?us-ascii?Q?+6Xju4axnDj1i4N2hTDClkDHwDVkJ87QlcEpeHwCu0ruto41imsA40dr6m6g?= =?us-ascii?Q?/LJQshnIJI5ixWH0xQ9arExE8gz9X5iwW8tvlX7Al1+NIoTJyHQyVv++f2WX?= =?us-ascii?Q?tYHDpaWVT/Q3+qd5IoFcxInohDevRPFdyO5K0XcI4LIyOGlxzsnSG3ljZc6l?= =?us-ascii?Q?RI7bf5QK187v3KSdNQAt1yQr047bbOIRwcD7t0Bds8jEK1D26zDep+5bg6Pz?= =?us-ascii?Q?qjUs1JBI/oWkLeipaIbwkCXrDluYa8bAMUNA+qUVfs1lTNXJ7Tsd1xYrWA1j?= =?us-ascii?Q?8c8NKz4ZLh7kHkbaCkzPCIn4c4mVpnBL1fj64fXXOUWKEUPpA7+lTi00PXkl?= =?us-ascii?Q?M6orrWjt7mOSWkdQqHhF5LKZIRqhTYev6irrmNJ0casJyfSpdjCM3XsUT7rV?= =?us-ascii?Q?llT1LibVP65nSQDc9fIUq3XQu/Qh+P6RJTR8Mnxr48Lty6HR4zx+IFEoj0JN?= =?us-ascii?Q?e84Pnz65kq8YzDi0hKr20HTCtLKxuGoZ4phk+Mx0aNn2sQ/xVEjZaKATuxri?= =?us-ascii?Q?qHY5gQGf2eNZIirm4mzAPf3wzH9b3PVXMVQ4lNVVqZYg2aNQgnR070vukoc9?= =?us-ascii?Q?SFp+Lhnb1b49HdMHBUSL7uE/UQYfSCz5y/szDmVst1Tj6+65zgQiJn91jGnF?= =?us-ascii?Q?4lyIZzB+zJ4bs1bjFy8Cy6j9jNVavS9bVXsxkRuHw+sMp6aAOq06YUTrxsFn?= =?us-ascii?Q?c43Ti6k/49zQCpqaErYdCGvs6DpTQ+mWgwFRoIc6y1/bFz/+oaPy3x172CnR?= =?us-ascii?Q?22z0MsEoFIYLIxls8wBZTBClWSzXmi2++CwhUkwlIC2fybzkBEV0IcgKjwhq?= =?us-ascii?Q?Zaj2ty6XoHC7fuNo4BKJb6uHULty/TU7s6BSFJfH40mGrYV8RH6V2mG7nXA2?= =?us-ascii?Q?juqcfSM64OFIRkUNhqqtaLTSjfFPb3Ov1U6btdMLpjv2jvmfdL1FYtm6RMXR?= =?us-ascii?Q?fMr5aTen8KFzQ5XB9BEjNQFDzIid6ziOjLWej8WY2Ek0+CZr3OwBptS4qqNL?= =?us-ascii?Q?czWu70GWBLPoJkJNDg8DL7Xrix319LQ1Z83nXHhqtTEhyrjPN1Q0wWQLhC4J?= =?us-ascii?Q?0kwDTMKuDQoXXONeH1Vm6N5ZrC91T31oUQFR+++iqktPWIWi74NSHPqY4O39?= =?us-ascii?Q?9Ri6SMSqIjzGBFIJhaiO0kdcdIRAdwvoYY0FR5g7YW9GCerXN/O1egEJfucL?= =?us-ascii?Q?Qk054JQd/g=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0a3c03da-0d2a-43e5-2a3a-08dee7cd2e68 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2026 08:42:36.8387 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TSY73/kkrD7ieyn1kl3isC6U9J/XNxWrTaZIrjdL7gnlQZis89TAaGcM1yNOtfgBypW/PvALp+c7Jadu8LbCqg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY1PPF6C31DB54F Content-Type: text/plain; charset="utf-8" Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_threaded_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err_probe() call. Signed-off-by: Pan Chuang --- drivers/watchdog/bd96801_wdt.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/watchdog/bd96801_wdt.c b/drivers/watchdog/bd96801_wdt.c index 12b74fd2bc05..6a1c5a4d39bf 100644 --- a/drivers/watchdog/bd96801_wdt.c +++ b/drivers/watchdog/bd96801_wdt.c @@ -390,8 +390,7 @@ static int bd96801_wdt_probe(struct platform_device *pd= ev) IRQF_ONESHOT, "bd96801-wdg", NULL); if (ret) - return dev_err_probe(&pdev->dev, ret, - "Failed to register IRQ\n"); + return ret; } =20 return devm_watchdog_register_device(&pdev->dev, &w->wdt); --=20 2.34.1 From nobody Fri Jul 24 23:31:01 2026 Received: from TYDPR03CU002.outbound.protection.outlook.com (mail-japaneastazon11013016.outbound.protection.outlook.com [52.101.127.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C617403E9B; Wed, 22 Jul 2026 08:42:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.127.16 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784709771; cv=fail; b=VMVBT4GSR+l/ApfX5KdsLxnDHUyE86oM6wkzNOHcsRGkg8VQ4VOfu7EJkTjW/p0+dgGpsOUpSl6Fpe1zHMBxg+69q0mcuTvQ9hIRHRB//LkTVQ0xaIPENbleeQK5LyNvdd9Xmb/G+THTyftcaoA8EM+/heF96Q3fzV1khEaAw5g= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784709771; c=relaxed/simple; bh=DWw+OsPpsmC1Zh/H9cjqgJH6CrC6YMfyFgngcsCPM3Y=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=KAyZ1++nqPonnVtmrpTTtF2KYBbcOj1xI7Hdf2ak0lnAB+DqmqzVowVsOgpLo7C31JkcMQsYICXMS7itJwr12bPHQy5+WL01ltmA4uh0+Oiu1sgo28RZnoP0ypX2Rp/95sIlbxM+e7J0GiurDA3g5cB834BWamg2WJX8TZ1yPCc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=oc6TQG21; arc=fail smtp.client-ip=52.101.127.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="oc6TQG21" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=IETTeojTU8tFuW/G/24Qj7SWdmrb8snMm96+GSfwsVWVXmmyLDGsejou3qYVF28ugyzGhZzjc+xrRKnt1kkUuZxDB5qo6OdV2WmIiW5opAVlZTdjVL2ahHyIEza0ZxBjccQ2JX6itSRf4kHCCZxuZJtdsrDxVBLJciq3sdesQmgPkH81FFwvTJhnhauAcPHGit4c6/vDO+xR6Cub9Ko4OAEi96Hw8MYTixPpaHps4XUkvakj3N1VKxbmnIAjDSO3dYd9bUoABpR+YGwILBAmeQbAsUP47z2hem6RHiqRELG/9/V4UXnTGMdt7MhcDV86BuUtKjgqP5lsg0NTx4dfaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n9TLwDdOFoZ9uJVGKGzAzbfkgnJBlK3KC4lEMPqlTpg=; b=JJ3ykF8ztl7pYTsFg8wb5EC180/FmNH54UActEodHMhXpPHKOf91iFg2HgsbiuoLrEwejoyPwxccMnqo9Th9PN7AH664ERzK1gMbcBcwBzPZHuUgkISa1ssgAUVeoXHLHEnWNRSnU27KMncrpO9rvQPHm3H1HDY03dLWgbREHcs8Fajv/44mqmb7FE4EasFHhCAzMNMAembL2VRFfooO1UmQlxu/ImKzLQUd+yQlOY5bqwqjL2XsVioCFdtUY0TY6rSZxR3I1CnsXCZmln+haH523qZZvQXtugEAY5Eq3gw1OCPDzz8k11fUPAlhtu5kA5WcP46dmtYAwA50Qi4rLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n9TLwDdOFoZ9uJVGKGzAzbfkgnJBlK3KC4lEMPqlTpg=; b=oc6TQG21i8LqM5jbk03zvySBc4cc4c1LL8XoRkV+2VY9Lu28wMfVL4yzebZf0Q78Bb604NRHyOYmBVeDirGn235FGIXD5NB3gRj7JzlNLcONYmIeVORNO3M5qTB734kAJvgDmNw7yGTCTtaqaiQjXsZQoeGAm7tUd5hScYwq5mYn0A1P1gdrpRdhawzfxNgjw08Dy0Fi1nLdVUqUUdWKqTulNM30mVdCzOPJ8ZlK92x3tHmuIf11unloDiBOV9El4gm8GSS9XemTf+FZ6VQKDwxSA8TXsZyGOHuGCk3WFwrFXw1KFMzBgL34FaocZMnsOXF3h4/PnI6BwNM7TySh+A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by TY1PPF6C31DB54F.apcprd06.prod.outlook.com (2603:1096:408::919) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.12; Wed, 22 Jul 2026 08:42:38 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0245.009; Wed, 22 Jul 2026 08:42:38 +0000 From: Pan Chuang To: Wim Van Sebroeck , Guenter Roeck , linux-watchdog@vger.kernel.org (open list:WATCHDOG DEVICE DRIVERS), linux-kernel@vger.kernel.org (open list) Cc: Pan Chuang Subject: [PATCH 2/9] watchdog: cadence_wdt: Remove redundant dev_err() Date: Wed, 22 Jul 2026 16:42:10 +0800 Message-Id: <20260722084218.79073-3-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260722084218.79073-1-panchuang@vivo.com> References: <20260722084218.79073-1-panchuang@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI3PR02CA0006.apcprd02.prod.outlook.com (2603:1096:4:295::13) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|TY1PPF6C31DB54F:EE_ X-MS-Office365-Filtering-Correlation-Id: a0effc44-18bc-4a84-4316-08dee7cd2f67 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|23010399003|1800799024|376014|366016|18002099003|22082099003|38350700014|11063799006|6133799003|10067099003|56012099006; X-Microsoft-Antispam-Message-Info: v4cJZKtKJBsni3FIzqXqJlroCdUCPxadKJ3cw5jK1dxobs+CkFnwEr1SlW0BHX2V864X9RMm0YKpzMYm53OUxUl1+sK42ZQdcE9Xtx6afMwCJIJ1ZpGHgWPZ3uMdTMz2FDsGY9vbRkiIaX0lPuXUkYXgdiH9dQCHBYemx9xlzMP7qt3ebwpVm+rD2teFgnhsB/ezqWDVXs3aKubVhzrdpucAqC5wBUq0TWYPVsxBAUaUxuh22mJBrHihiKRxpuRJD08OKCI21WuHxdOfsbejA2vULdeLKF1DveAebQxj+ghmQQUblRsJ93uVjExO9ZYNl2p9RSdxM44AlPKhLkn1bssDvhN8E0sL2q3jrBUB4j2cnkuAgOcVGxzRCD6UUIQbbwu9KSJ6VwDttOJ8cbBlUnGFw79ZJqubSFLeaPmouqqeQIl4+VPU/8wAiG6er2WQ4YbsDUC867aN5vA/0M7mh9o6392AV7/3WLwoS3PkNMfpuL4NCTGn2Tiu+wMo5XUi+At8Cvxsgi0pfjixlYL1a1Kn6miACCm6ZYR3ELFiGCrC4xk946d+UXaIYLtFL1cLRUDTRUydSwAqOdgFVTadNWPJmCbCK29DroxH7jkmFyyTh1Ic31sKt1S+KL6WQTA0a9b4fDNDY9ihjrF1rpy9YqID7E0GiH3649UWUOT5dnU1RDu1JT++YCc4b6biyZc8DiTt1VsOBSJ8wYBzHMz92uUmvHDutPqub5GPZiQOS2s= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(23010399003)(1800799024)(376014)(366016)(18002099003)(22082099003)(38350700014)(11063799006)(6133799003)(10067099003)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ca564eSiTr+3ITm38hGF6Q7/eQPyanlSXATXX0LHJEa6I7XGsPutOFxTbRtk?= =?us-ascii?Q?1ppvJljjCq06NEhYlJojWIVOSG9ONnOF9nellTviEK2kDxRqCDp8rGsxp7+7?= =?us-ascii?Q?5pkl1ugxWOj7vIgLX2SED8OjsHMluZXb3InGNCRva0j7VcXZHkOEo5lDRoa2?= =?us-ascii?Q?39YQKfOX4qaR4DpXoksMkGQX3JXMMHVrPFQG6r63WbhcVBEI9Ek7S0zpAeyp?= =?us-ascii?Q?SXgrn1xj2/NDXSHX6KeLyu6JG5y0wrOnmPN2g691o8I13ykpdTYJSe8AiPoE?= =?us-ascii?Q?W0dXwyw3OMFoQCjgFgvxjEVPeI2pwRWDvWAru4eg9oWKTEW4aD9Edq+zmjVE?= =?us-ascii?Q?RsfVZaPp7RnEGdnwT4BYYSyaypc8V0X+SC+hvzpg026EWJaHuqnDipBkeNtw?= =?us-ascii?Q?v+DFUnvuNP9bqbcaIh9Isiap0YiybICpb6v40YOfFBx/grtaMJEAiubOwtju?= =?us-ascii?Q?Rg8xp4PMVe2dDRbPcwUugPgVmjGED/MUyWYRJFIL+EJ3JU4bYNIltuSIBwrP?= =?us-ascii?Q?DM2bS2CTKoWKt+gAGsYZqdZKJ+1SIh/4kYHYsDw3WzqnMEow5pTPwrjXEs14?= =?us-ascii?Q?9bCy/bDYGabdpwWY+/Qb2Z+si86DwrYbY14WgtgDC0qOs6q1YSqyDwlReuy/?= =?us-ascii?Q?Sxkp89WWxqstcNZv6KrCgOqlHayXpwQRLHJJC24EpK9qLhbIgjH8K4BD4XYg?= =?us-ascii?Q?9e+eBdBcb9tySf4k902PfGhn0JCMms9rA9DECa4yQuhOxvbAtTEX/eyCNLq8?= =?us-ascii?Q?INB736cbhedhEogG7Sw5sieYU8+MHfmenwFefWtKqoLGUZK59bDQC81eAbZf?= =?us-ascii?Q?RCpwNaxhUJ4CUPZYF8G8pZEbMebR3emiYxTLzRSQXhQCgS7G4gmHFIU5fz6h?= =?us-ascii?Q?/VxniMvUHr/ClRKM/rrl4rXb0XnyTDnHqshxCweOixbOkM9IBxw4IERLwKua?= =?us-ascii?Q?8V+ihVLHjDxrWbZhfXnx2HF5GncbllfJ0WyGMYMkxu/f/53eA99aatl/494z?= =?us-ascii?Q?x8wI9AcLZElz8yQvNfMVsxhdQ17Qn7tNV0UWDmJ0SDkIHm2Y3C/VFFDMYziW?= =?us-ascii?Q?EgzTmiTN5BVISbbHreWADjAsNVtyuBfqYsOplXJ5BCn+C8Qqx5gwd/ewjTW7?= =?us-ascii?Q?GUcyMGwkViQSMpVjuxCXL5vF5/4s/DURgTK1OnwotkuPdUHR/N3uix2pt9W/?= =?us-ascii?Q?30kmBsh+WMM642KiSjohjx/lSzA07SUVgMuFrV6jXbOhES0Z4ipNDFPPNzvv?= =?us-ascii?Q?1+M2mm7Jw9tnNDiZc2eaVjz7myEhynjW/fCOYpHnrpGHKB5wjjFl47axu6Pd?= =?us-ascii?Q?JBYtE1GH0yyp1CRVThsx86TKomeoREzt59e+ko37O+nC1WrlBptv0fsfU3VI?= =?us-ascii?Q?WneVtyZOEshre2Iqm5KJYQqLFu+IQ3tTmrbjdhk5zV3knBzP3hng7V91F0vF?= =?us-ascii?Q?rE4/tQBvnoxQF4FeTmu2nKn4zepXduV/gvklSZ6CngGQ7B+zHVfiyv4fBGAD?= =?us-ascii?Q?M2xMB8QDiPZPFVBye+wV4/zZ+y/6vG5VdBbHUfJ/iARwDrvM6VUvuTFFJ+Ia?= =?us-ascii?Q?9fyivx/2iqMgMj49dWEZLFuSuK/1KN1z7dJ+Jt+n0og9KZ0Ui4TIR5CONr3Y?= =?us-ascii?Q?syHjx8MSeP940gAGFV575pkDWW0xyK1dnIWYe9deJib6WI7VradhDQuudcV6?= =?us-ascii?Q?Yf36TSsWoIM6+nr9P+Bi/r4bZ44bSgZG6qhv043hlpoVxK+FwiH+EAEQ9wVv?= =?us-ascii?Q?Yeg9hpLf5Q=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: a0effc44-18bc-4a84-4316-08dee7cd2f67 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2026 08:42:38.4877 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iXyOIkJ1RLPEbKqZIK/OfX2T2agEXk+2gTjXaKrMxd/9kA+N0Oi6Rn6gjXTuY9gcjbFiawjtciuJRFxYP3unwA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY1PPF6C31DB54F Content-Type: text/plain; charset="utf-8" Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() call. Signed-off-by: Pan Chuang --- drivers/watchdog/cadence_wdt.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/watchdog/cadence_wdt.c b/drivers/watchdog/cadence_wdt.c index 23d41043863f..ad46b33ce5f2 100644 --- a/drivers/watchdog/cadence_wdt.c +++ b/drivers/watchdog/cadence_wdt.c @@ -312,12 +312,8 @@ static int cdns_wdt_probe(struct platform_device *pdev) if (!wdt->rst && irq >=3D 0) { ret =3D devm_request_irq(dev, irq, cdns_wdt_irq_handler, 0, pdev->name, pdev); - if (ret) { - dev_err(dev, - "cannot register interrupt handler err=3D%d\n", - ret); + if (ret) return ret; - } } =20 /* Initialize the members of cdns_wdt structure */ --=20 2.34.1 From nobody Fri Jul 24 23:31:01 2026 Received: from TYDPR03CU002.outbound.protection.outlook.com (mail-japaneastazon11013016.outbound.protection.outlook.com [52.101.127.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DDFB480DC5; Wed, 22 Jul 2026 08:42:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.127.16 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784709776; cv=fail; b=jqtNiA9a+G7TpGw6W/IocJY+MbnLzdvMLxY0dVA+f6zc41FriERDRApzJ1cZ+scvTPUKDjN6BsMH57kVvepuLaPzkFZ3+KHEK/R1LTHMkSrTNf4MKgvfpMchVuqxL37IeLNs3m/JE7WbzHrXgw3Ty1d8x3zdB54h2xg1lVHsrZE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784709776; c=relaxed/simple; bh=2GHfydUue+wkXQsoWqki7FcnuVUlZ2SvCiA4urqyPiA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=mmOjfd7dbDspxtFp9KaMmbA6KxtOq5zNtApZR2Vwhkm7rgYnXX5vB5yB4NRglHUpY8TzzpbWyotoPQ8ZmqnrEwdb/qJ3Ap/1VoIcXG0CkfgRaZ9chtvydHV7ZPPu/vThm0uUrqTSprXWn3sCulxklBGsc1meVxqP3hdwFTxrvaY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=UZbCuntg; arc=fail smtp.client-ip=52.101.127.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="UZbCuntg" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OLk06SG/+iXEcPNKCy9rl5gqk79o8CesGP5jbFJXc41h0qwhtS2Zjn8dzIglK/qIlefHyqe5c1Tvq4cVI3NSLdIjoajltCEpUCD9JwT9/wGJ3IM/4oSRQxBPQrQVfEqxwplcJrTzF2F+66u9P+Dmk9EF08MTpRDtFsR9c0JQ/72eMO2Yc20hzNogeD+uveTPAHPQ/BhBDL//+eHZoJPVbPh9kGIw7yEOoMHlh+sJlMXksWmvrKiiYBbFTvTHA5t5YxRkd2V4asDOgGRDjDe0oGoEJiLRky5hLPIcKAe1HiuZV4sIX16mSKf7V+dZVOy4W4+wRq7JsTmV+4jqQaSRaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I3XEp9K2NEWfbkdr4XQE4DVlR2tdcGjCxAXK7DopHag=; b=wQi7ulHAdiRTmtnWa8pUMC6tUoU84GD4XPutcvZxCWafimn/NcG3uEkmfzc26AF2Oniaba2c0Bil5jxTGlaUwv1G1/qyUv69kyVXssIF7sWlMeD+SJf2/ZQZcoTehWapqdryagSFIgjXJeb2hhbW4zXtEP8o495mQDtOPbNm09JyRKKiZ7GKjdvk8cKEKU2PVemJ/d78f+vsLJq1HAbdQO8AAVFTKg4C6zXAp6MnwMtvmmCAW1mILOnTpUrDUwXnbDKUGR1n0yZXbDm11bwl0aDIxdYFxT+bcNuziyNzkVnBrQWaMvUYaGoVLTSfSm+7krbRY4ukE0gr5QaykZPjXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I3XEp9K2NEWfbkdr4XQE4DVlR2tdcGjCxAXK7DopHag=; b=UZbCuntga8zoyeoSam6enh06ag0lfhgeFJaVV+Cbl7wbzHT2OKUoAcJrQ4Fz8GKv17CZq9slINR2l1PVDqngvOoQEzKkwLZxggu7UZMQNJs4L1xWl2X+P1pcMM8k9CAp3J/YA0u0mZrakAlTnkck6PHcasCrh2mjgPMxBzy9h1V1NFSHq67T7fGHXTarWbb/PCMGpoG3Z3CyCaBYnBUajZTMgBIW+gVHrDzrVJ0MkJJBdyFD3yk6C2xKafwPh5pblFvYWVxV0M4ClcmIH7lIFGG0Jb6F00wXWmqAV6BxkOdm+yrPuO0ZKkdi67+DUVclTIOCcxqqZ4QwMY5biSSjEg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by TY1PPF6C31DB54F.apcprd06.prod.outlook.com (2603:1096:408::919) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.12; Wed, 22 Jul 2026 08:42:40 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0245.009; Wed, 22 Jul 2026 08:42:40 +0000 From: Pan Chuang To: Andy Shevchenko , Wim Van Sebroeck , Guenter Roeck , linux-kernel@vger.kernel.org (open list:INTEL MID (Mobile Internet Device) PLATFORM), linux-watchdog@vger.kernel.org (open list:WATCHDOG DEVICE DRIVERS) Cc: Pan Chuang Subject: [PATCH 3/9] watchdog: intel-mid_wdt: Remove redundant dev_err() Date: Wed, 22 Jul 2026 16:42:11 +0800 Message-Id: <20260722084218.79073-4-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260722084218.79073-1-panchuang@vivo.com> References: <20260722084218.79073-1-panchuang@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI3PR02CA0006.apcprd02.prod.outlook.com (2603:1096:4:295::13) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|TY1PPF6C31DB54F:EE_ X-MS-Office365-Filtering-Correlation-Id: a98f7b51-cf59-4559-14c8-08dee7cd3075 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|23010399003|1800799024|376014|366016|18002099003|22082099003|38350700014|11063799006|6133799003|10067099003|56012099006; X-Microsoft-Antispam-Message-Info: H8+hXqNfXFKrVqBlYLq/1S6A4p5VTqo+HMO08lBvs5rXccT23U+naQo9/GILb8CTbSCwUbFZKldHuH2hnojSY6IH7vSdCvfGhXqpbYM1UrR1gKaTC+5cFo2mVHXEx3oXeHPe11bab1vjHwWt4JgVjJ8pYcTOo3UDaR6CGwXtWRUFKyvMw64kFkLuRYGwj0SCHVBqL0rHSxJ3MVGJXPIxlPPIBeSDBQXKelKNdqlPBnGoL/2QDB7JMaVT/H2w///ypyLKbVdjqQu1nP22qAAWf1u4YdhbiMgkK7c5DJKiSo3WIFtPhe/N2xVKPAfljaVbqXnBMFN4b7QJKHJPeQ8ojPSPGUIHZJWA/2x3Qy6SXmVu6AxtntitSjt1GnhQL6xbI0zeijpCwGMA6OELq1d1j5aGVefitR5Hc09stHgWa2P7wp4Q27P+8+25/Eqisj+4F9M3nY2Rsy2T7ioiHAifBY0oV8ZHxB/dz5YlAuyU45Fmj4org8sbgIwwkzgDMqA4ACeY6JOTlyDMBRf4e1zJ3w0FXRb8Qo6/tbOD4LNbapuIhZ/9e5BA3nA0EuiBjbwZmAlXAoo9tkLMB0NgC3feqW1OggghNejBviI7yhiHzB8HTq5UbZ2X9wjMIeBnxm4OJwcSL1jK2LpBS6Ri9E6z46WosQTotAx9pDT5WdqOkbWSkHz86CPcY2nkYlrPQ4d9vduymPtATuq2535xi/nRhCFnh+Omm1dN2+pH2IuSa64= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(23010399003)(1800799024)(376014)(366016)(18002099003)(22082099003)(38350700014)(11063799006)(6133799003)(10067099003)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7NozHST3YbiecE5rj5E5Ae5aMx41H7z4i+U3ChwJkRdP8pSbUWAe7NT9VnD+?= =?us-ascii?Q?r8o/igvFSH4oOVHuo+7vwrhyemqDnROCi8PIXIXThPNU77alTU9TlOYkUKjF?= =?us-ascii?Q?aNuJgrytFODajJt3JTjVfXW+Aa55ByA91G3d9tqFkcY1GvFDZsAzJArtbbLH?= =?us-ascii?Q?TvhbatRbzXGOUsffFGlkgeF9x4osWMvBEJ1laGnRUNscqAC2PzOlLVYhHPqi?= =?us-ascii?Q?BHU+fITAY0AUwfSEsClqQ0SgP3pFV3lL8tio2g0Iy9IL5gYbZlmQyg4vnBjn?= =?us-ascii?Q?yeFjHo88EvIi2sIy0KPiP73Qb7KejDSNuoP/gq7nn/i04Wc2uRCQxnilqJlV?= =?us-ascii?Q?DGEMRFN36qt43CpjgFf5OnURaSZ+TbFJEG/Q7XAMA8uiiX2Ll7TQ65QT7xZr?= =?us-ascii?Q?/2Z+EcJp2b049utvlwdDFHZeTmmhscopWJjPZlD9bvFOBO9Z8pxVbS/8B7Lk?= =?us-ascii?Q?Z1GF9gbbqpQCSLf9/FYRLpnt1bsF07s89/QR3oCe2GOTOYsGwoO9AqnQ2gpf?= =?us-ascii?Q?4BLpl/QsIhJSZMO1VW8CeBuhqcg9qwYLg0NQ3JUwkvFZMs1acKL3Fqqezq9S?= =?us-ascii?Q?4kXpsrix6Yf4ubdVpvdKJG1ajsVUfgOwA+tzZMt7PpM/t7SLVktRuMbCHsdD?= =?us-ascii?Q?Sp36p1WQy3haL8DWNL7x4Kj2sRe0JfZM8GN9AISDdGaWc4vJanSv7kHwFJdo?= =?us-ascii?Q?JTaPqpUzpsKVO9fbYBsUNcEFGHlw4r12lrjqeVU8n6HszoXPf9n5SdRHW1PB?= =?us-ascii?Q?p74ALyL9dcVrsU4Gqc+89dZYEsIDDuvY5DSJKGlOBXMieReQIPq7ZUuuRn5Q?= =?us-ascii?Q?cdwqpOtd7N99cVD5oEiI1FChJssB9kMomobmnI6Ycn6Xh+4JFjyGD+7l6NXa?= =?us-ascii?Q?9RFxEnamkvqj81OigUkhMi3nMYUdNfBVf+kRVKo+6+MeWb5SRFSY5j/aF8w3?= =?us-ascii?Q?I5xyHiydmSS7lCt2V/0X2PK98voFXRU3W1OUlSCTglqLv3gRkBJGGPdRBGcl?= =?us-ascii?Q?eOIsiINwK4Bvy9aTNfeJCwjoeCgDqnmuKkQGJ2mFJJFewCKNGn4eO1y1rD2S?= =?us-ascii?Q?SBXHFRq7az01kHqS/LDmDile9yds0+GzrYN7VM8L+O7UehR4mw475gPYFNQX?= =?us-ascii?Q?zkrgDtm7nPab7sHuKsB8zdyeDiVUCdBq4Vi/uAmncf/MxaZmoCnbV482KOv0?= =?us-ascii?Q?YLKzNgqOTzsjW6GN9jQJIwwfntUrdCWkafSRcQYAZRRNu3YwWjeRnbijy+Vd?= =?us-ascii?Q?zPgHXKhHf6AgllugiwrvJXKeQLFOuSf4+n+RuscGgiwsJ2MdLWAKNIHR78j+?= =?us-ascii?Q?lK9hF3y1ULq3Ka1xgUjXFbwEJpDqEM/PA7nOXJPB85/00fC+pcP5of2DHatb?= =?us-ascii?Q?m0NrJ2vtbVmWu3qUVsFnA9ZhEjLhQkH23G35aKn8ADAFbVRATX6XgiXziT0X?= =?us-ascii?Q?LwUZuAqKd71aA+1yL5pNQOd0xaDnWrth7jnUyb0UQ4q+oLgPokzE93plj7/b?= =?us-ascii?Q?NjVXiAqrSTJQENTVIRCR4XmfsM+j/21Vv4cunSm22mXQfarKb9JPt5ew3vj+?= =?us-ascii?Q?sCtQ0MpiCQf2LijxwVh80fRkgv9BRLeQJsEMW5rGD3xzLrgzF0q91unKEe1k?= =?us-ascii?Q?UG/A1nHf5lM27qDwe98FMt/XCEQ6ai3CmEk2TvPtzmxbkUoIcRqlC5HmgCqy?= =?us-ascii?Q?RSrvG+g/Hj6HjumOjcuG0zP4cOHoWUdPL1TebvJ2c9dLhLk1AclzBoKSGpwZ?= =?us-ascii?Q?Qg7UeHkGUA=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: a98f7b51-cf59-4559-14c8-08dee7cd3075 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2026 08:42:40.2498 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bfaWZ216sMX7cSE9zFD7jUbcuH3aizlGowZ0Hfe47rURO6YkXkUiz1VA0oTpOyZkWzvHJxtkdOhqxpRsPK5LDQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY1PPF6C31DB54F Content-Type: text/plain; charset="utf-8" Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() call. Signed-off-by: Pan Chuang --- drivers/watchdog/intel-mid_wdt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/watchdog/intel-mid_wdt.c b/drivers/watchdog/intel-mid_= wdt.c index 756d262dc580..b1e1b77ed190 100644 --- a/drivers/watchdog/intel-mid_wdt.c +++ b/drivers/watchdog/intel-mid_wdt.c @@ -165,10 +165,8 @@ static int mid_wdt_probe(struct platform_device *pdev) ret =3D devm_request_irq(dev, pdata->irq, mid_wdt_irq, IRQF_SHARED | IRQF_NO_SUSPEND, "watchdog", wdt_dev); - if (ret) { - dev_err(dev, "error requesting warning irq %d\n", pdata->irq); + if (ret) return ret; - } =20 /* * The firmware followed by U-Boot leaves the watchdog running --=20 2.34.1 From nobody Fri Jul 24 23:31:01 2026 Received: from TYDPR03CU002.outbound.protection.outlook.com (mail-japaneastazon11013016.outbound.protection.outlook.com [52.101.127.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FF9748097E; Wed, 22 Jul 2026 08:42:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.127.16 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784709782; cv=fail; b=CsPrR6m8em3WUrbNkGf4uHdM5IHH6fFfg7rUQdMOC6P+LmqHAltWdLqfFXbNDbCTPh/jjKVKl6te7Jm8L99+6W8JU3lNm4oJXxXIiD+D+UZEhsYpslBhg5+fSknoL472oJNBrYQxCtu5J1FIaOXu+Jr9XLWmDzgZU+I7zBXifj8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784709782; c=relaxed/simple; bh=1ssHhZEWpJ53NzI7v4L8uJ+PoWbOT0Z/8IZxO580lAI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=BYCya9iP+Zy+RW/mxnUBqjw0xosvUqR/wlAstbgLGMeMEbZEsSKdabpK+rHlvtyyvZJhUyJ/ASTjnn+066buhfqyXFdWJ20IAe+Qai5JnW76rYJmAepZiOB19iqZNCgbdqe6uk9wxv/qbcw9PCGDSpU5OTkQKdCbwt+3MwAxyPY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=Y3hMlUKx; arc=fail smtp.client-ip=52.101.127.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="Y3hMlUKx" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=j1AvahZRjxb8vctiCjVjk05xXQpMA5UZN6b361jmc4cJF74d2etxCEiX1Nh21rg6waU+DNQQ0Lk+n0aufPFU00+5OcGVavVDGet2YVKjLf59lRnPSUNv5A9CaRwkflO5p1yNJ0G7/6MJoUnecShHnqavE8i1tZYV1arqSryUven8uy1psVT1QxW4g1WWjGJcvs2o4TeGywXK05sa8zagz03W5RmZ1YKIjnCNXYWc8szpjcG6X91kPkP1kUtuxXk0W8CDtvaA6tiaG3pzmm0xU9/XotYpUAI9Rbp81zzRjUwxSsnnwWyq0WIvFBH28tODXObkL2epYtoHz6VQl7YcSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nNkpY0Mg68nbSJlRyK7B0M8PYDyU3rR68zAYBjpMzrI=; b=iJZCmyYgoc0G0dy3IEXvRp7YkJT01Qo6Jr0Pycw1LMvAld761QyFi9J8SJFxOLytZsAr5dH6SkdQ2oZ/UOU1gvfyTnE/lu6SapSyGKRDqIdmyfiS7RJ8rCmc/z231hNYzs1tgCb9iD2ahJDkIl3RITJ1aezkVGi0AoQvrv9GaMVth8sfzngMbFOcpYx2nmnJmhF0ziaTZ70u9FW/dPP4sHs9zWx26eFsEvnwwTUvWkW8P+fFGfp94uS4nZlu7f0NVdpy8h5BEQV7H7h/J9ZKtnhx09GQ5O7Eqefffd13CFbj7aQfHdM9acDUFy+JCbRSfQK8/EPGLeebqVbHMoxhXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nNkpY0Mg68nbSJlRyK7B0M8PYDyU3rR68zAYBjpMzrI=; b=Y3hMlUKx3UEgw2NrxtXWx1NEHMBTrDpGeMLAPFGIduPmsWx2BhoxMC4hWHAVVyS8ccMFyaIckRfHX7AxTJ1Unzy5Ty9JrUnyIBkyvheTTbW3nDGt4Tdt7MJYm9DwKCGhQ8q6Sd6dfpHF1rm0xuvJFaKlavvmzkTJuv55S6o9o12KcVj1k1kwcg1fqRLs5yUJw5gtWCb1wdGEyEYs/AJGdG6/mVZCPgcxRCTKejAruCBAlzCom7fWAe6gBWNjeHdIOYVPMmAVgw2S99+yyyqhQ79/zqDzUOCjbV0TupF2Dz2kPi23kXqM9BNEwndBUAixd+Hd2GaNgeSznyPVXT51Fg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by TY1PPF6C31DB54F.apcprd06.prod.outlook.com (2603:1096:408::919) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.12; Wed, 22 Jul 2026 08:42:42 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0245.009; Wed, 22 Jul 2026 08:42:42 +0000 From: Pan Chuang To: Wim Van Sebroeck , Guenter Roeck , linux-watchdog@vger.kernel.org (open list:WATCHDOG DEVICE DRIVERS), linux-kernel@vger.kernel.org (open list) Cc: Pan Chuang Subject: [PATCH 4/9] watchdog: keembay: Remove redundant dev_err_probe() Date: Wed, 22 Jul 2026 16:42:12 +0800 Message-Id: <20260722084218.79073-5-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260722084218.79073-1-panchuang@vivo.com> References: <20260722084218.79073-1-panchuang@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI3PR02CA0006.apcprd02.prod.outlook.com (2603:1096:4:295::13) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|TY1PPF6C31DB54F:EE_ X-MS-Office365-Filtering-Correlation-Id: 3d5ab609-5f2c-45fc-d71d-08dee7cd3173 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|23010399003|1800799024|376014|366016|18002099003|22082099003|38350700014|11063799006|6133799003|10067099003|56012099006; X-Microsoft-Antispam-Message-Info: iQ7DejpjBJOGNrY0MozhxH7Muzf8CgwEaheItO/zeWXg8rGx6wlDtk29h5PcN6FTeqGAGrrM8h2wyBDdE+ilOfEYf+ZJD6QiVkaVL2SHIb9RtN2Pwb6tGegduma+3at2LWbCb0EayO7pSCWPUB/c3vu7IlAP0g5K8Ry7WEllx2rKcTnSO8yFGWbJRvix2fjNcIbNlkVxxvahrFSIDej0AuYxZ1c4rcVHPa8rHbYZYSU8s24+CbtnNynwjHrfs3b0u/djbqk5zvvhjyq91k9twgQoCtWMZniY19Zv1514W55saCpnJX5z2Ycd/wRGVLR1FOFi4wJbb+BRRa8AskRbN5JYzrB2Xb8agJn8uNftBMwk/pbE341rHy6QKnmJHEYXAXjQjDexJ2r8yhQo74vYB6NxY7sDj9g+ZQ+gL4OzU35Jhyas8Gp0LFIb6Rvbdo0gBuW+aLg/jjuSOf6sDF2CKTPFKZ1xKe+mRkg3ALKEPeNC8f/mKJIGsYwk45fuCpPSU4YYJbGXqEMgm1TJTg5pE3hQZPs7+cl8/KFVNqi6qzs3EJY1UyuK/KpuHDSwfWQaqh/bjb78ms8IPiWwuj6b2fqwC/uOkKTEO4+7iAsiKPp6DIJKyVKMFMv085AJD4t/xtTmsMO4+vEMMUzkcieHOfew9cvu8PnhysZnWQ50CkO07VFawMHzv+l2bjBb8MjjUAMgP4Dcon8vFGG+HnIGoV7ZQtNTJWs6tI5unAIfsHk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(23010399003)(1800799024)(376014)(366016)(18002099003)(22082099003)(38350700014)(11063799006)(6133799003)(10067099003)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?oxSclGABZJKFarQPwXwooCX9YxeKWHh7/Izk5ieBg2ehZPYd6Q8Z25mtlBKm?= =?us-ascii?Q?+yQlFSzHAjIFOLxm8LD23cUsl00sa5lAPfhCQ/MTCE0IVJRpAd8x4hU5Gqe7?= =?us-ascii?Q?ALtNVj6YlkDNVYWwSqiNGyUzyPL93Mlm21cZhInw/JSmmxe+nuAjP2hMesj0?= =?us-ascii?Q?M9mHxrwm+PrBFqamX6jIeUkgq4Udmi+sg3+o1ax1HK9K/wREESM+Vy2J553q?= =?us-ascii?Q?pRLm+lqWrY3+yEe3daNBmd6rkWtqrRu7mVu3LR1M+TPz+Vez7y2UEtm+BnWG?= =?us-ascii?Q?7Ue5VvsEtJsRMjEeRawUizmNLrm0FbMl6UdZNYWKmkxuoVnK8vpe7zPG+4t6?= =?us-ascii?Q?QfmFgAG8PAl1WixCdhGSA5WpD5l0mVUeDTvjT5mNrp4E0VOImXq6TNBX27Rt?= =?us-ascii?Q?Ze9PGItVp06T4g5WbiHaGAfzlEgCs5HVlCn57W2V3Gsc3An276GVPifNfujf?= =?us-ascii?Q?kVThcKlC7ZwIsnHvN9M4zdfG/7URJbIIMnqVx+cDm3NBc+RVSDXO9PQyV+YL?= =?us-ascii?Q?RufCVqn/K5gavK0EVK0DZI/2ozk2yROR4uDNcP56DekutCYvaNPVsuZdnjoo?= =?us-ascii?Q?4uz0pxDW8C6D7sMwLuxysI0ca08JJJ8qhZO4Uouu+Vd8n9POgHbo3DaEQiqY?= =?us-ascii?Q?D7kGiHZiyl5BFTVq55LYGFkqNhugS0wt6NZymUA70CvCdmkYtRbEbeVSQ6nj?= =?us-ascii?Q?dSxhHtinmNcTN6F/LCewGVMu5kvGyJU2Ub4Q153RxKuCpQUds/6hgDhXs7GB?= =?us-ascii?Q?lQ0kDabZdKQsxeAvyNwsMW09MMhD9KUa6iLGYsB+qdu9zPOUBBDTlbj4DjJ4?= =?us-ascii?Q?rgCea/T0b3Nt6kUBfkLFWOgiMn74B4tFfc6S7j9pt0HHLhglDBDMKrdd8qA1?= =?us-ascii?Q?zdyGBtM3ivuK8Isv+zSwNGFUU29SGD9wZY3DOfqhdZ3BiadQsbsCdWrIJrFs?= =?us-ascii?Q?/RR39frKLFxepnRcA8UNgDzK07ibDKil3XUtaB36U9Z73rCmtFfv65NdT2nj?= =?us-ascii?Q?GarqnII3S65HiIReG4BrA/jY+tta66v9UV2lKl5Du1R+dWic3XefsQ4VvPg5?= =?us-ascii?Q?lOZVeqPWDcqMkGys80nb0ir4XHYiRPuwvzwPoNSJX3mcH5ELl/MmlC0tM5IB?= =?us-ascii?Q?1RldaWH7YW/qjL1h5hfyaCGa95yNKrL0Q88rsCb0QpZCWppXtKc5O3e4Sy3N?= =?us-ascii?Q?8TWrX597w6QmkjkfdRcuI56Vjpvjb+C16f3gn4auPWC9IhfNVqRpus8h9rpj?= =?us-ascii?Q?s+BFw/LfMJTAN/6TFdYmBmH/sURZWL+iyt46rlHEjCwaqSoHO+W/+zCMEU6b?= =?us-ascii?Q?BUKHPLzLr7/imfBkAEH6gxpXgTOT7tqmPXSdNmZJVYIqMEXnJ4fxOC67zjXw?= =?us-ascii?Q?XzPk2pznK9Xf9iwCeYN7EP9+ZkEgo7wgjhHIglSstWie64kGXQkfGIg4s84i?= =?us-ascii?Q?zqYNArlNg8mBHuOHStBdnGLICsgcO/oV2PI49QgvzGPo+tzx+uGTYGSOKY+F?= =?us-ascii?Q?sVLK1Olm1p3sz3o4ydmvb7237/MgIiTrKb/TuhhJvPHDhwXNJaNfzOniU+LR?= =?us-ascii?Q?VuhCoRYcoRPlHg7qaI2elqPVKi/mw51cB8iFth/1450jubBS8Cp1Ox+d4mva?= =?us-ascii?Q?WBuGcinVjb1hVb+0JL7ffVGUyY1HRsbcbwcXQMqkSPuAiCffhUSE0WP2y9BW?= =?us-ascii?Q?GZHzkEmXwoazWIBOE3bJISfX3TjjUC1bG0PK4hijgQld3tMcWIZT+L+N0ddG?= =?us-ascii?Q?P128/fyEnw=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3d5ab609-5f2c-45fc-d71d-08dee7cd3173 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2026 08:42:41.9397 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WQy6r7izBR54R1uMcFYsBLEOHVrKGoStctLPF4VGhxxGiBihDj6wHRYaXpt1OQYo6nFFS2Pnp1JpI1K/lb+PfA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY1PPF6C31DB54F Content-Type: text/plain; charset="utf-8" Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err_probe() calls. Signed-off-by: Pan Chuang --- drivers/watchdog/keembay_wdt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/watchdog/keembay_wdt.c b/drivers/watchdog/keembay_wdt.c index 3854249c7455..7c8e53921e40 100644 --- a/drivers/watchdog/keembay_wdt.c +++ b/drivers/watchdog/keembay_wdt.c @@ -214,7 +214,7 @@ static int keembay_wdt_probe(struct platform_device *pd= ev) ret =3D devm_request_irq(dev, wdt->th_irq, keembay_wdt_th_isr, 0, "keembay-wdt", wdt); if (ret) - return dev_err_probe(dev, ret, "Failed to request IRQ for threshold\n"); + return ret; =20 wdt->to_irq =3D platform_get_irq_byname(pdev, "timeout"); if (wdt->to_irq < 0) @@ -223,7 +223,7 @@ static int keembay_wdt_probe(struct platform_device *pd= ev) ret =3D devm_request_irq(dev, wdt->to_irq, keembay_wdt_to_isr, 0, "keembay-wdt", wdt); if (ret) - return dev_err_probe(dev, ret, "Failed to request IRQ for timeout\n"); + return ret; =20 wdt->wdd.parent =3D dev; wdt->wdd.info =3D &keembay_wdt_info; --=20 2.34.1 From nobody Fri Jul 24 23:31:01 2026 Received: from TYDPR03CU002.outbound.protection.outlook.com (mail-japaneastazon11013016.outbound.protection.outlook.com [52.101.127.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF6A7481A8B; Wed, 22 Jul 2026 08:43:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.127.16 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784709787; cv=fail; b=leYnZgBencmqhSB5it7p070ksYAiYRJvAss+TL/v+la+sQMc2+q5KcerCIUUmNAQ90WVNTqAwKbnSo24Gdy4VabPTdxIDbbBsa8840blVrP8ldzDcQjdyMqJLmMu9z1b4ATQhGH8dzjEM+sjU3SLiNWvf85qjKUx05PnZgvrxGA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784709787; c=relaxed/simple; bh=YjTSFrAV/wTF8E5WCMQhMQ8HcIFqmurwrjdDZhOdjeE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=Y9Y4kRfDQkuucWyOyWVs5Mpv20JCIPJvyNLen62ZZqyavVlgkgZGDPDsYAHS5KIh2pfuabSVAB9GyS2CX5DvrH38QerhOpLv4Y9mdRmSNMQqH91fhvn64RPXEvUM/1oD8Vq1E/1VShqMpDhBlOXhjpGwfuIgMV3q1zpdXskhNj4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=kDbo0B4V; arc=fail smtp.client-ip=52.101.127.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="kDbo0B4V" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=O98zhYlbncHm3Lk2asY4wWScBCC3CsCSZ5HRPvrJuJWMEBZXgrreTQ99eRL3b3js8WgcC/9LZzw8VxJCzT0N8kqxJjQnwL4o3JG2K6mELFzJ8LiT+FqrazS7HhKsYRUevYweo07j31nPy0oHGosgYql5BBErGFcdwJ+u3jNYU4llJFcMGqMoH/F5exU+5/RfiIVmjS9qbFqMmd46RRJzTqs9C4wa31f0Y0IFFNU+B2R1HMDsYv0iJ8glaUYpN5UInipnzpapBIbKI+ws4akb6lEVGow6VZFRGZwcnn0sbE/IH9Dg9xXGqBi4ltQBd5CM8RWsgtKHsm1E7ZVCUm2cOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OvTOFm2RS0P5DKQa+OSnvze/nSI3I8BajPrfxp3Hq84=; b=OSzGW/sNhnn8CVv7ysVJY6u4D7Eihqi1JyWkxPMXg49/EN1TJqdOgKusScALjTRiTznAP6gRKz5FcMG/kaOxGH5VbYkJNL9UCQPoCnolp5VnE4mKNJ+zYr6riAhpvkhuPpfkFY2t7deTRHlN+3IA49hQ00EDnuW3YdC12cGL8NByAZO+KHenSkkeviXgVb/BB1Ouh7o/P2XUkNWNyKA00XfYXJRVgG/DlJqLlAYB2A4BTPKis9Ui0NMFMdGoJiTOKwBmwr4fMIbWuEbVGEjOcWi8IZNCARjyTR/nsPwzI9ibNc3bDLYzLz12fvDonDg0rrOKLXO1w5/SE/Lr6ZSgXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OvTOFm2RS0P5DKQa+OSnvze/nSI3I8BajPrfxp3Hq84=; b=kDbo0B4ViziFIypKLh/QhZshwDuYIVMa4MqHHL5afV9eXOaKG7g5IvaT4VcFoiaSBypPkW2QLXkRoBqin0r9Bcy4k+sRqEnE+Nlh87bAklYMifmoW7Fi6aON8eCX3osRS8u6cnlOaHo1JC11rWYbrWEiN4WjovDSDTDL6lmq11qkB7nIe9QlUGpIIbDz5a9dF1myWiHaRXOiCY/iYgOTrcbDBQcdzkgmLyTu+QOEigzjBCboSAXJzw0WYDJplwfWaIMUiVS49sN4tvkrA/7/1Yu7TKu6jwt5Ym/Wu0li2FKiI7OMXzZApXOTJdeKQXDyyG2xdjS67tug1R8T24S6Rw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by TY1PPF6C31DB54F.apcprd06.prod.outlook.com (2603:1096:408::919) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.12; Wed, 22 Jul 2026 08:42:44 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0245.009; Wed, 22 Jul 2026 08:42:44 +0000 From: Pan Chuang To: Wim Van Sebroeck , Guenter Roeck , linux-watchdog@vger.kernel.org (open list:WATCHDOG DEVICE DRIVERS), linux-kernel@vger.kernel.org (open list) Cc: Pan Chuang Subject: [PATCH 5/9] watchdog: marvell_gti: Remove redundant dev_err_probe() Date: Wed, 22 Jul 2026 16:42:13 +0800 Message-Id: <20260722084218.79073-6-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260722084218.79073-1-panchuang@vivo.com> References: <20260722084218.79073-1-panchuang@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI3PR02CA0006.apcprd02.prod.outlook.com (2603:1096:4:295::13) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|TY1PPF6C31DB54F:EE_ X-MS-Office365-Filtering-Correlation-Id: 1c5643d1-602b-4694-a676-08dee7cd3325 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|23010399003|1800799024|376014|366016|18002099003|22082099003|38350700014|11063799006|6133799003|10067099003|56012099006; X-Microsoft-Antispam-Message-Info: vqtZqefLwh5TQwFJVhPbuIsVxv4pWeix/QpjqC0lIcpA3D35lz64xKCFG2wfLXagvyoizYCkoAiv7RQiTPpYjcTFRFmi1YqVQEUQNlY0kVlJMV5znnzvZ4TnMbigQvFus4f1FoLM/VKPpnH3aBjvDWnWwdWAuo69HpUnjO6k2t1QiM2WKDFmU1j6fijM5pKlICNtHrAoM040e1L7jt5BJE3lzR8RCG2OdTKB9YgVc0zwMGcAfnVGomlX3ksoFmbFCFz03k5/wUoiANFlhexXNhygokllBPJg3HuSSgtQgYECRNG3qVm8uQ9YuCNxu2YmYaURfXgLtB5IXi3TePTNHOCRjfvNBo4Ff6DyZaKH4SibT6K8vdmRyOoa1ZKSWg5sR3nc4UDVu1sSxjMXyKr773KjdiT110n3+d3y9PFiZBBFF8bYqWBCVRaFUla12j4gX6jX11T4CbUnmcH6kkafn6ge5PxV1itJW41EvObf4efY4/1a97Nccwq70TCb7OvOBt4uPYi62JHDzQBhE4qXlLh2bndtqiD1pXuFIOOR2ifAO4IFeeghNj4nJsfqA4PNoQiN//3E4RZ5MDEzAeiDJn/xtMlXm78q5Zx58zHMfn8XhZsNpuwPHrl1PWjKhjDX4uimnHIKQhyeUjnWzoj26sAdyPnHMz1/wG790l0CydyHlagCDKw3dabB6gjOv2o59yREQPWiG+Cm4T3bsy3AU5e2S6o+LFS2tBkr4OQU6sA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(23010399003)(1800799024)(376014)(366016)(18002099003)(22082099003)(38350700014)(11063799006)(6133799003)(10067099003)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lSbuHwkz/mf2Tc7TwUImxqp1Trb+qFtPtNg3RhjCBSwfsBOZOL2pNlaJLjkl?= =?us-ascii?Q?OF5ZjLfEyh7Ivam3z3NM83t/tSC/ka4bPZ6mQmBC5Jgs5zoZFTcl3D9Yv4Ze?= =?us-ascii?Q?E1w5UvCXPV9xuckQS8x6HeJdySfg8Zd3q1xX2yiYRmU+fFqjxfijWLKPzXni?= =?us-ascii?Q?DluDQUj58r82IKoXETnqjfxj9u7I5paUwDhULvICNdRnmONVOsY7LbV9WGG3?= =?us-ascii?Q?zhGIM5FeFQJoNEIP0BpN8arDjnWByPGXr8IlzdH7Ai7Z1RILRYEhQieLrURp?= =?us-ascii?Q?k6B/TfWGBkwiW5p1p7SjqlIM7Yrdh5e6WE3fpZ6OWHd67Uk9qhy/2szMdVQS?= =?us-ascii?Q?CJsSBZ89iv4WRCq5ML0Mbu1ioTW/g3LyRyDLKNgE/hZ4j5b+7fAb1ZAte6A3?= =?us-ascii?Q?0ETu7n4EyUYRqq6+XzjoHyKWNag4KrYAVIFDaa0qkFo3AoeVFPvPpnR42X7j?= =?us-ascii?Q?5ebiGReMRDvpzVrhGMUZ36E9RFAlUW20g20j9Hjg+Ximb3k+0RfnQU4efw+Q?= =?us-ascii?Q?pNJRwC5e2zwz+0ObnrJmGaXnUNT9rdh3ChTSNNB/Uaag5i9B4K3QUCoRNPWB?= =?us-ascii?Q?PPgYBn4OOCJQDqsRDVT04rDtplvmNKe/fzkV0pcLDIWbMfrrIWfq0Gb2KlSi?= =?us-ascii?Q?cJxa5gEvJKZIzvzHYBUyyvIyKDDCbZ8IxxXqVGvn5nkyHP5TJSS4uFX8XhMn?= =?us-ascii?Q?ySyPBIrZVVWzaL+HKElSqjujBWiCuHcFDNwkLibeeOdwMeSF2iGM7rJduRvW?= =?us-ascii?Q?6wYh5rBpNG5s/OdBkHyNNMqeMyG0NkQrAuFKpUoVyP4062tgVrqMy9Wn1XSd?= =?us-ascii?Q?YKTWmCVLiev5ZTrUFIO586ZkwgBktzaxHQsCqnYTlYD6CFYlbhOQftxYvLOz?= =?us-ascii?Q?jHlCbqjiljx0N1nh2HExv+ow5KvXjoOrKOsPB3zbRsd1CAlUiWuAHoiNGvvd?= =?us-ascii?Q?oVagVSIxfg14vEeb72GquE2ESgw9IjWg08cRx5jiin4vOiIQ9Lvv8N/rfOU7?= =?us-ascii?Q?9gBGUzUy6NHyT+qu4h03cY/Y6jy+E97HxAXca/HoQeaPOEg/K93JMKyAG98W?= =?us-ascii?Q?gSDBL5EyNRg/YZ4XJxE9ZwUctIatMGJIEg6c21Uki2Bvrd3EqESwBVEYKxCW?= =?us-ascii?Q?YjstR78J5cu1xH08kJP2N1vqOfmjvl/NxaHmVxknsjPkQoSvGxK3Npyhf0eM?= =?us-ascii?Q?tPE9kdgkPdyR/a0jfDa2BPqVrOIL6wZbfjR2KTf7P4mx4wuNBCFch855NJPY?= =?us-ascii?Q?tRoNwddVZoJLMn2NxIQ6RtJjqvhRki2W1bKxAfkvJKWL2q7u2JsqO2HkDD2X?= =?us-ascii?Q?IH42fr68w+sYYJGXhpmuIMF9tdApmwmtPpvr1YjpPsoAwyVngHqqTOsRylVP?= =?us-ascii?Q?7zGkCcs3B4mK0fRlMyptkHGPqAIFXdmZVixmvUASXvnMlPUcX3zluuzY+wou?= =?us-ascii?Q?BHCs/ETDq/UBj7vER4thAgiEjSxx5Xnmviiv/GmNtWaYnleqHOKkPfmB9Xs9?= =?us-ascii?Q?OaI86IEV073F41Bd4Uv8HWbAsJu3bJjdsKHaPI6YMYqJHWqDvu7wsjrq9gnK?= =?us-ascii?Q?wLYRTZgbN4HJ8vp00jz9kaK66G1ZWBQ1giSi4JEsJ2EXGCCxMc1Nr6d/44X3?= =?us-ascii?Q?9M+wQSgVW8XOcgSSdUwCpyKG330Z3QSvVZHpAzVAPL/lpR3v9KHs8hGT7GsZ?= =?us-ascii?Q?VabEYE2kLxN71kxr+4yl/Y1qFbdbpekisMf+1ey5G2JV2lRoU+xDkOm9yA6i?= =?us-ascii?Q?yB7wg8DMpQ=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1c5643d1-602b-4694-a676-08dee7cd3325 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2026 08:42:44.7606 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vgtx3McGp1BV+K/uKOBgdyk68ObolP/XoFSr0gOFuI0jdTBFWhrxZ1wKy0nKgT69Ymed3fLeHHETCNyOX1qgrg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY1PPF6C31DB54F Content-Type: text/plain; charset="utf-8" Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err_probe() call. Signed-off-by: Pan Chuang --- drivers/watchdog/marvell_gti_wdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/watchdog/marvell_gti_wdt.c b/drivers/watchdog/marvell_= gti_wdt.c index 298089d45ab8..31167034963c 100644 --- a/drivers/watchdog/marvell_gti_wdt.c +++ b/drivers/watchdog/marvell_gti_wdt.c @@ -321,7 +321,7 @@ static int gti_wdt_probe(struct platform_device *pdev) err =3D devm_request_irq(dev, irq, gti_wdt_interrupt, 0, pdev->name, &priv->wdev); if (err) - return dev_err_probe(dev, err, "Failed to register interrupt handler\n"); + return err; =20 dev_info(dev, "Watchdog enabled (timeout=3D%d sec)\n", wdog_dev->timeout); return 0; --=20 2.34.1 From nobody Fri Jul 24 23:31:01 2026 Received: from OS8PR02CU002.outbound.protection.outlook.com (mail-japanwestazon11012026.outbound.protection.outlook.com [40.107.75.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38E09480DF8; Wed, 22 Jul 2026 08:43:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.75.26 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784709785; cv=fail; b=ZsvQwbhY4jfKthKukjYRcDO8OY5FC5mZQfWK4KSNP5+WZZnkcKL/xBg884JtlkuCfPVue6m1+gkrSIFuYCU1PSN9mHER6YHfge4m8qW69vDIM0A2AbmIBN8+6Hp9BBMbMJ4gHfsOkNmdgqD5AWPN+yRow54lN0seHMrV7slUgVU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784709785; c=relaxed/simple; bh=rfKGRBwleJZTA5fIH2UIF2Y0YSkZQGmRXcpOWRDh2Rs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=bjD62x0okCTYUz0J6HEXF77gk/TQvjh1J6GMDHw3oDBLI9OKUxpVDvi+k37Vvc6ZljUdmvC4OoiuMGlhv5DSC95/EH1ne8cf2TyBVG1sqnECDnjR7oUu68sLwEHjNwbXHDs6Tvso1wLaEeP7m8JeVz9YIs1YvhLSfa0nMz1V8TY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=D/4Xcalc; arc=fail smtp.client-ip=40.107.75.26 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="D/4Xcalc" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KkYC7Po0y/lpMtet8ETWOmhU/4w1Qskl2N6whUPjp1cF/W4bUhpKCbow9iUcq4XUBGeGCH5Y17skyV0rKuCRr2/HcNhO0njyfc/AHA1mjPHmo6MEjJ0TVrwATEA/aoJD+caZGMGT7L+rSTgyGWMIWKE+iY3Pp04uBiRRjdAtj3IAq5/xC3MOE4U9sKE1g+6wsmLkSFd3fmznFTQRPuFzKgFQvH7trSZNvc79GdDyzV5BkbmXydvyELqKeA/0kzjd413GeXQoIGAoGwO5ZHujZpsFDYUyrpzw9b8h9+GN6fmyNPza0m9lvTZl0sVJpM/SNrBaReoOS8Im48JnDfubjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1lrfUmWGwKO85Y9VLwTVn6uIZkTzbhmzzS/da+nUt3U=; b=YHjnpSYSqybcdKKPBvFkij4Cga1tuMflVhCg52FtYQpe5ulTUT6SVFK4ZDwF1JzXZzi3AcPyAGFzM+ish9ZwVhmS+ktIGtjmnuLcy/gkVerYaZtZy9sE1/Hg3ryVS8GeXVcYG7qegXiWpF2F1HagoZ2ADNbqLyOV0rCbb7NPw/hoBAK+vniVFTW0BBPCth6bcd49RCQOXH7xciyjJwp2hkBJGcd+PIzK6IPPC31Oti70DAcZuroAeuUHIqh2VA4s67tRd3aA9TyI29fZQAJV3AM0HmRLlnRbRYtEfNFB36NHTl3Zdrqh+Htue8dMJ0+BG3NjkkJXsYyQWsCa9r+jFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1lrfUmWGwKO85Y9VLwTVn6uIZkTzbhmzzS/da+nUt3U=; b=D/4XcalcgpYRRCtjbmIFDGgyz8cc6cAcIPotTqGsWjOIxU6KssRe8tjyT9lpA8/mwbNHtJGj0q0GNIUQFPQjNwXqnouSUcVmIeG8wwqo3ykIxaZ0eRXay2bHhp9qOWdxVBrKRf4kDCLkO3J+PaCu2bH8FwcClqBFsmagoxo25nvx/nyqWbzZ7SHC0Mn45DJQtd/6G6hrfdOpSDYQnk3YSjida0ARHbcu4tOdh/FKEqQxn6AhBbu6hAZEPt+zEzbAzI5jyn/BHcJC2ZSjDCFk3R8Wkb4fNUkRB1xazLdNmcAA1NcnEpN++6YW7QSw6O4ow1OtcXV4kDVsfGCZ9oZDPA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by SEZPR06MB6037.apcprd06.prod.outlook.com (2603:1096:101:ee::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.10; Wed, 22 Jul 2026 08:42:46 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0245.009; Wed, 22 Jul 2026 08:42:46 +0000 From: Pan Chuang To: Wim Van Sebroeck , Guenter Roeck , linux-watchdog@vger.kernel.org (open list:WATCHDOG DEVICE DRIVERS), linux-kernel@vger.kernel.org (open list) Cc: Pan Chuang Subject: [PATCH 6/9] watchdog: orion: Remove redundant dev_err() Date: Wed, 22 Jul 2026 16:42:14 +0800 Message-Id: <20260722084218.79073-7-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260722084218.79073-1-panchuang@vivo.com> References: <20260722084218.79073-1-panchuang@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI3PR02CA0006.apcprd02.prod.outlook.com (2603:1096:4:295::13) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|SEZPR06MB6037:EE_ X-MS-Office365-Filtering-Correlation-Id: 7e54b361-203f-4f3c-ff8c-08dee7cd3427 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|52116014|366016|23010399003|1800799024|38350700014|22082099003|18002099003|6133799003|56012099006|11063799006|10067099003; X-Microsoft-Antispam-Message-Info: cEq/MFpVNUR9+ei/Z/dYFCeIx/zErN/0U9lVmpx9aLK52HgtZvO/jWlkwz9HhJJ41DJOl3Em/9G4QyDv2OC6azLm+VEmqbMZXm3QmZXa2E5GSr4VUyqWZcrFDg387TUJr7f0JWLhIibiCCneTP8uJIfhxhDCzy8fd+7KTX+WQTvaI5VK3KIV0ibcvyvIUJEKaDe/tVnO5T98Yu/RdZ4Ku/joTqH6RY17hl1ijfNYQ3glzznQaurFRsqtou5goSrtulmh9BL8nHyy31PAhBc0myxHZWNsgfis38zTnUL5Jk3Ck8V45o3sjMgumIPrkjRh9weVPA8zQWB/f0A+GFA5Uwttb/wjxnrxkdtWzVCkxYcEXt5suhpqdqQCEWWk0esOKnWi1/zGLxMXB/bvlfv+CjLG0IUEPG8fxWdps28keZvj0tD867VRgKcD05fOUHAgwPQBJpNoYrfmyH5GTT+QD4+HjfzkY/2cT6OLmqu0CbzWGQfZUvULS9NjvBB6wI68s68TnLEAdo6waQJs/f+gDugv0b4lsIwTOyGEiCcxcFAh+dPyE3iJ3HgAqSd+G3JfiMaQlCu8vYidMwmZCKRCSBN3mPx6bi/roSWgLXmf/rOVr/3YxH0H/twoJfiTfqLmZ8xxh55X35RwBMXfi+cvEo6SvbbhuAfdUQ4V6MmOEin2ynz66L9qTN2tIz+HvZvQZ5D/iQGAS2UfchhkP2z1A722g5x/pGlEQohDH+ztOzY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(52116014)(366016)(23010399003)(1800799024)(38350700014)(22082099003)(18002099003)(6133799003)(56012099006)(11063799006)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vFmPzIoUkB0MTa6tbdnNvJHOpx0RNw0NcY5oZqElBkgF760RX0Y9PWklO5Ly?= =?us-ascii?Q?Yjp26QI2XDwh3GvgL10CLT2Pb0pJ9E9uL1wgrGzD4VWpB0f9wZ/ydNNfSmnB?= =?us-ascii?Q?QiyqJjjoEVe6KBpt9z69egxTA6v0z4QLKl5rY1kTkjK9GdhFk9j85cSw/VE0?= =?us-ascii?Q?U9jTQGcs2q6NgSvFMx0R2QiBAdSgFVAERgpNU3n4opTqZVfrloU4rS357gF0?= =?us-ascii?Q?X0Hk/idyljLq1vhBjA7HUymTn5wRDIkfAtEfiqf0e3OtmGNWHwvc793AFElg?= =?us-ascii?Q?E8/hMbO78DdH+X61moqyv6rDHgAY+1WCPFCjPLzycYTxrfiYTR/jf1Pw86hM?= =?us-ascii?Q?jiQmjcEnZV2thdeAtPsM/Ft8O1lmet4P3PqYY5nmUFPjSfGoQfeOLj+nPzN/?= =?us-ascii?Q?YKR151ANERhJtXs23RMwhtkanz7Z0wmDpGGvvTbwxhvJeh51eIvFfmNeaYgg?= =?us-ascii?Q?NddwzRg+2TzSrnE/hNmZ4PUz8INoyFV58FBUSy38jRS4G+KQDIG8kAdnuZHx?= =?us-ascii?Q?g6bb3/sojFOFnpkBK7Sza6y4YmyC9UkpMfRL7P3rVt07hl9C7XEJjaeupqFm?= =?us-ascii?Q?6H5N3DvjK0WjxYAMoilI+tkukq6C21QGbDZN+QNP7kkNV0vfW/eOpKUQoUv3?= =?us-ascii?Q?2yNTjDVLT4PxBAK5JkfnHpSKx3ZrI3v2nEE4XO8idhNjPwREHmu3lIAn/ozb?= =?us-ascii?Q?co93z2DBhmIpUE33lmCRr+eDOTIganm1Q+N9QLdD4hOGTm17aXO/VASaeKaL?= =?us-ascii?Q?c2hGSebqaXfPxtERChV6RDLDvP8kSnp+2nD8sOpXbiaYqFmPMh8ZtlgOuRPC?= =?us-ascii?Q?KbVwU9pG/swjPofTKSnk3uYk/1Rk2GdyRckaCp6ivs3LHzaecTnD+MGec6gF?= =?us-ascii?Q?HL78cIuuY7kTX6K/FR4m5/X1irEBQRQ405tOF2Ak3/PwfJa8KjPYpFRT+IXj?= =?us-ascii?Q?Vnlh/M76CQzQzhoQSTrYlu0rwNxmSKXmPIqUwQE+eQawhhi79iPbKw0PoD8M?= =?us-ascii?Q?+dAmgQ+joOjEHs7DHUO/sBhF7sA+u3yiQcHKfliTAJ/j5WsjE/69VMehCC3c?= =?us-ascii?Q?/1Wfu6xbIkO1EFNSc2HHiE/e05ACPZntx8Qhc4CSuPjctS14fGVy1+nFU6nH?= =?us-ascii?Q?m8otbBUrDwm3sBU6CeRJRmEsBuZaHZYlWqDL3/OagEvb1S/0o7lFoMiJ5497?= =?us-ascii?Q?OWWxoBvsLWS2EUq0CN9ZXBbKEvAvSavedGzjXkdvBvz+ez+SvaDCQUVguJUM?= =?us-ascii?Q?R9caZAO9aL/KNkwiMZHSUu4tU54MHKfN6Oj8mu8Wy/lvuglLrco5SWm+QZRc?= =?us-ascii?Q?+V0Jyd2Zv6vjV5mGwGxj5+WJRZlsmDu07STMQ6QCqdCw0QjAMDdpY4Qg3IHj?= =?us-ascii?Q?xn/U7JrK4MsX+PPtyeWr3AkZbUHo0Idj05fL7jZxJwBKUkPHpMDf2CYQWSDN?= =?us-ascii?Q?NS1Wo6Avd3nzC1pz2ziXvMAZdNV4agCMTr58JjpX7AlgIJ+oSvWMuMENXxvT?= =?us-ascii?Q?KJu3FByr1Nofo+0wHXdjOGEOOdDlFskf/Uzj0N7CrFRUZRdXH8TJGuG9YO60?= =?us-ascii?Q?yoJE92F9pMPwNgtGHxfpi5RKiSLBHEqnKzt3HkYPhZdSxYH01Q1zpAPW274A?= =?us-ascii?Q?MKHRcnZX+nFPHPTekBr8bpTyU899jYli2ZG0yCqPgrRhZsc5hKb2YtXCwswP?= =?us-ascii?Q?rDRuJ98ghFpf5sZfcbrlfe6QPzUp31NBjgHD1UPMVzMSyl5vgH6mwJqQADQg?= =?us-ascii?Q?pflbJHBHmg=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7e54b361-203f-4f3c-ff8c-08dee7cd3427 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2026 08:42:46.4765 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JCbalWjZuqbZzQnb8OnTInp95dPi+lDw7m+ncifKowl1voiTUlE7Jjtu0bLpsYvSLwUY/RrsjiBQGk0fmODE5w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR06MB6037 Content-Type: text/plain; charset="utf-8" Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() calls. Signed-off-by: Pan Chuang --- drivers/watchdog/orion_wdt.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/watchdog/orion_wdt.c b/drivers/watchdog/orion_wdt.c index 0e145f762f6f..1802634cc7cd 100644 --- a/drivers/watchdog/orion_wdt.c +++ b/drivers/watchdog/orion_wdt.c @@ -613,10 +613,8 @@ static int orion_wdt_probe(struct platform_device *pde= v) */ ret =3D devm_request_irq(&pdev->dev, irq, orion_wdt_irq, 0, pdev->name, dev); - if (ret < 0) { - dev_err(&pdev->dev, "failed to request IRQ\n"); + if (ret < 0) goto disable_clk; - } } =20 /* Optional 2nd interrupt for pretimeout */ @@ -625,10 +623,8 @@ static int orion_wdt_probe(struct platform_device *pde= v) orion_wdt_info.options |=3D WDIOF_PRETIMEOUT; ret =3D devm_request_irq(&pdev->dev, irq, orion_wdt_pre_irq, 0, pdev->name, dev); - if (ret < 0) { - dev_err(&pdev->dev, "failed to request IRQ\n"); + if (ret < 0) goto disable_clk; - } } =20 =20 --=20 2.34.1 From nobody Fri Jul 24 23:31:01 2026 Received: from OS8PR02CU002.outbound.protection.outlook.com (mail-japanwestazon11012026.outbound.protection.outlook.com [40.107.75.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03D513932D9; Wed, 22 Jul 2026 08:42:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.75.26 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784709781; cv=fail; b=uYe9c0lrNoKSQ6+JARuU/gOhcCKw+IyELz2gVimY1BoDMGUKQczPxeNv3Fr3h8/Hqcz0Jz0HmBBGi8xuuaIHF6tBHlMkfnZBUnVTcqk/mwegDuHaGmgUOPdaQUXR8IHwLfjWOGhoIReeJ8OZefDt5J4vtBlK7IPgiegxSGCV0oA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784709781; c=relaxed/simple; bh=DUDlH+CUQwtb3g4l4VnjGSHwn10Ek4Jz4IU3yglKaF8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=dl1rn9yWGkscxrGAUZiTYD2vv2q2w1gDvhZlQrCPOHzVnHRN/fTTQJEexQ1B6cwJhQMDjYUadWhXXKKE8CNrY1WvHd5tH1D1G5osqLQRV5spnaTBrGEqwpgUAuOtPh/efAE5B99Wb/DQMlsqgRAsz/zjQu9JDos6eT+IOfZVMus= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=nMSjl1NZ; arc=fail smtp.client-ip=40.107.75.26 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="nMSjl1NZ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WYSqgh97UfjC6lzW29VCQCrqqzACpZTf2nYBOyf1X+hWtiCui2jQEfE5fOBlmq2EvxPigOlqpb+17ujeV3KBNLxvaZXG93ySaSl0MxPsx+wZI1jD/tNYArywQjnicQCn2MaajXLsvyUKa6ipSAkR+Y8GRcagSLhvoNw7fpjJ4YUtLkSEZFuU5TWaZQEDKwXCLgjy5nWjeQWvouzzdGZCkIp/ory0kflORWk8Q6Qd7npgitGyiLaozVI851Dmy7jAqjPZDJ7CLpLEcIlUYnNPn4BeMfmf/vR6guW3fvDSuvc9VOluqo/PMNTsV9/oKEnfW/ma7lOrwN2TAJ1EOYX4HA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uMMGSemNZTgnOS33a6vIHkfpchw7ehIhmPcfAZWLEb0=; b=DTUG9rfiQm6Jd66bh9JLc5/xmhgbzCxRG8WzgsD4ZBKKVlohY+cX6P5rwALl0rD7o3nzg1rskTJWfkp3iPcDwlPxMae6WO/JqNGpzcmQd65fHFJNaIJ993hwZIx8BVyP2UYkXWK4XrjMnOZ6b2atRyJI9iD+jkN8qO0IOt5oecB6gJ35p0HtZGqesKMn86vOOkELRKb3bqZBMmaQp7vZTI/N6u5oyre15Xo38ArMxyV7XM9Suu3XS/Yb7vbwGASVTf5j1NhKpg/0JG2eY4naPA3gBwwMfkyDr8JZy+KUwcelOkCVM0HGO2QSEfvWatakKLJPYzHrSb4kX0PNimfRPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uMMGSemNZTgnOS33a6vIHkfpchw7ehIhmPcfAZWLEb0=; b=nMSjl1NZ4m6kIEQ96PU0pvQfX9Omtkpfz4pmaxWjO8QdYRGMI1P+t/4ThxiN3s/4FP0g+rGqv2Nl5WOIWNWUCe1fvtorDgqbsmMx09fobblCroEsFQmOj2LA2OT2HSgJ1GLNPAKPEy3X8bUBEX4p1MtnIcdwWOH4kpp2LYGp8ZsSEA/BJ1SaMj34nXpdwIWiPB1N9Qh0PR8kLV6Tb6pV+t3z4hOHdUdOXt6QSB6iGj5oml3eaMB447NggnlUU17EdARQa06+d/OCtfF2PH9vN9jB177A942m9k33/G3559RHz11bP+4CSybQCBl4ANvh9uzDN+dxqVQMhJdjUEZysg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by SEZPR06MB6037.apcprd06.prod.outlook.com (2603:1096:101:ee::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.10; Wed, 22 Jul 2026 08:42:49 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0245.009; Wed, 22 Jul 2026 08:42:48 +0000 From: Pan Chuang To: Sander Vanheule , Wim Van Sebroeck , Guenter Roeck , linux-watchdog@vger.kernel.org (open list:REALTEK OTTO WATCHDOG), linux-kernel@vger.kernel.org (open list) Cc: Pan Chuang Subject: [PATCH 7/9] watchdog: realtek_otto: Remove redundant dev_err_probe() Date: Wed, 22 Jul 2026 16:42:15 +0800 Message-Id: <20260722084218.79073-8-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260722084218.79073-1-panchuang@vivo.com> References: <20260722084218.79073-1-panchuang@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI3PR02CA0006.apcprd02.prod.outlook.com (2603:1096:4:295::13) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|SEZPR06MB6037:EE_ X-MS-Office365-Filtering-Correlation-Id: 201b7426-6a19-4b0c-3cf1-08dee7cd353b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|52116014|366016|23010399003|1800799024|38350700014|22082099003|18002099003|6133799003|56012099006|11063799006|10067099003; X-Microsoft-Antispam-Message-Info: X0mFzrMpIGR0wjBAAUmGLKH1n8FmRhssB+w0+TpagXMsW7PBs6+SLba2LklIk31JI5IDg5F8X/LcpFl0Em7oPYdGulS0WhHJQCu0VaVFiAv2g8TJL3nfUh+Mz1k92fWY0sIRtIHL8kRYTgsEqhJmyyMYtLw/jUY/Ppfy5wi8Mjl9+K1XL16XmpKXXUZZ6buksUZNMaiaDtlZaqHZ2iCQDtVZ4xNL7bDuIe0Q3IlM4mBMEuvptvpcFPRnaP70WAfUL4CCmwUxE+zFt84xhrEuELVRqrw/EJcDZcer5tIu6iOa9rWmV9xloXgnsdFn0ryOp0sNq2tJLD2HhflaHAQc3dLFF1GHe7kvSipVbtOLdOVRUh/AHt4sQb+YucjGfKPJjGR2Xv27zj+lWS/Z+y2AuO1zv+XWtgdFeHzSRVJjDrpyhnC/L5x0waXjKEONJxI2wc7g0nqvqOklO/XECIXeIKJjexkMm7+ISB6MmrWtED49DbikF8izwRgfRiIZYsmXK/nMSXvEkCj8PA7qaIDyFEmOoQaMUlKgM+YUIEp46XoZNQAQ6HAHo7EZYaeQHV2M1ecFnfnlp8M3q0W7uSqLT2KdWD6qrHkQL5SE6PPEzqqzjN6/kAns0a2SbnLNFB8iItdyMwMEtV7uT/DMHn6S8s6/LgvnfRk2wbQsaAcghccrTFgYUS/ifBjEKWB6tDyBdl+rk7IDnd/wDyYrlYnOp04pB51WPMuDFkPrl67Ll1s= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(52116014)(366016)(23010399003)(1800799024)(38350700014)(22082099003)(18002099003)(6133799003)(56012099006)(11063799006)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2RuD7ZHY3m2ZXKV/f1Q10jP07yvbQCaU2E0+IQMURHtX5QMRexi2aDyCDt7g?= =?us-ascii?Q?lPGHulBjV6pS+GTk02m6W2Tf9rz6A3JDUgphUqXoiDwCyhV57SxGdCWclrqw?= =?us-ascii?Q?t40pHCo3moStFy8nnK6m4YNsVPoMskGhat/vBpCMd9CNaEv6MSHVgp9r2JeB?= =?us-ascii?Q?DnWJugtZU1fGkWsccCOVWFKQG28YkKU5eg4r2QIgcsMEDKTn8nD1VQEIScbF?= =?us-ascii?Q?UDP1imYk+wCZm3eOLdCyHwT4earF8ZZPy1JDS5bT6Rnk9z6hCYUrIs9WdjUQ?= =?us-ascii?Q?7MvDBNoirj6jkKHhROrplzujxXd/pSSUwLfXyU2CEXSjGdRULjQmUPJ0lQWm?= =?us-ascii?Q?pzC52nGaYMCvbUzywm0Y1RfYIT8V0CuRCkZ+E+NebfDeIOK/Fx4pDA+BJNZn?= =?us-ascii?Q?8oB0NyEddUvSzApHxoYj8sn8ONPPiqt3fowI7TvqHfc9Nb0jDE3iW1dvO1iS?= =?us-ascii?Q?SWxzZadClINbOucat+WWCVTNF7eBOSKwVJGNU/+9ZiIE+OyjlyTCzenRy01X?= =?us-ascii?Q?uuQIDn+D2Sy9JXTRIz2qJON4gYir31XTMkAYf7SeaSa3u41vq3urwqrbuT4u?= =?us-ascii?Q?m1XOYwxABwKKXlcEqJ0v24RpaxYtx8eEc/D8TrlBDC4GwzyNpGU03t0OIGxK?= =?us-ascii?Q?8DwZbnulk7LlPVg54Ftxl/VdtcUh080dZNnmGqG5ZtpoekqLYEH4wpuKMl5R?= =?us-ascii?Q?fkJNr8YR54ij2TqclZcg1QjWBIzrZs4+lI8FXRqOaPaEb8nqgcuJXsMZ+tvL?= =?us-ascii?Q?eoYfHtcC/Ro8J4KZSeamWkc92QZ3QEUoFMBomnDWVNzWQKCkOqu3nFzr7KVV?= =?us-ascii?Q?AAij36t7aRiB9yN6FJArP3lKBz6c+RPDtVsZnQC2lOM3DRmrUVgV9ZIP59Aw?= =?us-ascii?Q?y0nK+/K1xP+KS6MdO3CGrQP93CaeN4rPeQzYfYaDBBVxnrb6xS4qerYnCxbh?= =?us-ascii?Q?n2xFDmX90Yfu6KFkXvFTWIN34pTYWQnFfn6WNPe3WUcFslx6wHrP7eO2hCwx?= =?us-ascii?Q?8f6gT5c4FSLjIU+4mSeFKEcxGvV3OIHNfbqFOPcr4Wz4Sv8g2U2Gz4Le4yXg?= =?us-ascii?Q?DfIsGWQvH2MHj6xRpy3r0WtsQWf/NcHfC/v2uvcwtVA+XSxVNJxNPae8VTr6?= =?us-ascii?Q?iXR1MBrdWzry4Q6dDuGlq2wOJ4xW8RASQQMKFWw6mKgDMqUnnQtZRgYMV3yI?= =?us-ascii?Q?UYZR8kpk5LoLcRt2vmnYfIn0umXnQNePWSEd+R9hac9ERfcyG3RGeSu8vaAN?= =?us-ascii?Q?It0hnxoO6F8+7BwyqkBGzcVgiRgHCLxcXYJG/YvAdlAkT0U3x0SSPl3va6Ha?= =?us-ascii?Q?663agdmLf0pNmV0uu/PzJ6msqvZE028XX3f9QU2t4pHsbUHnU6OdGw7kuaGd?= =?us-ascii?Q?AKdTaUHhmBuV4O01Q/NL8gg2JM38dQF70rzHTjth9hRHz29UcqRD3E1FoXJ8?= =?us-ascii?Q?v3U0glJQ9FoOTZcgXT9tybDBgXSROQhAYcFLx1J4qC0jJ5zxiSHV6cD3Vbw8?= =?us-ascii?Q?L1OInY4trJpCNfGr690rcPAVosPk3lU2Z8xGGzEb248a3TG6p+v7bBuZtXDF?= =?us-ascii?Q?wbX0KBm6+Y0ohIPifp6iwmuGWtLS1DKwPIUWl5188WOP1FqRBpa5/Ysbhhy5?= =?us-ascii?Q?KhyEGaQ5XANvbtS5fy2RNJJjMqZsgY2eQ/4S1BQtpTguaub9Uhle7s8b3F5t?= =?us-ascii?Q?4qYuf/eS4xpPWqh8a1oRNxeTdV9RxcK3Em9//1jyrln6/w3VtQrQzGIXOkPl?= =?us-ascii?Q?III/EATvUQ=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 201b7426-6a19-4b0c-3cf1-08dee7cd353b X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2026 08:42:48.2702 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +YJ0dhcCaPtJy9+aeZkumCGvr2aOECINb2kCQ38IS4XsnSoTVQ/SOYP5Xz8APm7HMNuqhJqBWCPimvmGij5JDQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR06MB6037 Content-Type: text/plain; charset="utf-8" Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err_probe() call. Signed-off-by: Pan Chuang --- drivers/watchdog/realtek_otto_wdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/watchdog/realtek_otto_wdt.c b/drivers/watchdog/realtek= _otto_wdt.c index 9094f2189f55..a07bcf1de7c7 100644 --- a/drivers/watchdog/realtek_otto_wdt.c +++ b/drivers/watchdog/realtek_otto_wdt.c @@ -311,7 +311,7 @@ static int otto_wdt_probe(struct platform_device *pdev) ret =3D devm_request_irq(dev, ctrl->irq_phase1, otto_wdt_phase1_isr, 0, "realtek-otto-wdt", ctrl); if (ret) - return dev_err_probe(dev, ret, "Failed to get IRQ for phase1\n"); + return ret; =20 ret =3D otto_wdt_probe_reset_mode(ctrl); if (ret) --=20 2.34.1 From nobody Fri Jul 24 23:31:01 2026 Received: from OS8PR02CU002.outbound.protection.outlook.com (mail-japanwestazon11012026.outbound.protection.outlook.com [40.107.75.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBC0E481A86; Wed, 22 Jul 2026 08:43:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.75.26 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784709791; cv=fail; b=pwH5pN5sJQ5eXufxiul1Rn9N4LoDD4DIkkJt0vnL1ktU79SKepO9ycIBGlutMBoUz71beQ1czLWIEJKPfZSoJBKDXYT4JvkyUzadbIqndhYIUTHjlkU9LMg4ZuMH6ewn7iRAw0Bzm3+jq5EBSrIL8dD2KRCVpXMlE5rK7EAgaJw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784709791; c=relaxed/simple; bh=NosyOLreUzlhSfiuHsl/cxbxMLte3gDJXroT/JgjAVQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=sBeNz5+KPmPQm3nXdDPkQ/KtT3vyaW/ULxQihG/jA6R2KUHo3Flx0iKN01ugK8kCScvpts/ZmxsjMqmw3LeC0BokOop5pRfSnyyetVc9SwJTPEHBijUXovy/S7Zo8+GnYPnC9219L2iRsIgeiYfhw7Q8nvPkkaM9dNeWR/aLXuM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=D9YdTqPi; arc=fail smtp.client-ip=40.107.75.26 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="D9YdTqPi" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=d9A5imOs2ITNjAQDSIHNMIkdWv6Oa1J1RaCuFuaASwpyzA77nlFDjiynuRXjIleB7E7udNlQzPPNapZ8jKafSyr08FtbiC3dz3b1rfIAojr/4N0q2T9KAbcP5PEiMQowv/NDc7TGnetQ1K4XYeNlKqc8BGr073dq8Bf+HWTidVPaA+IbGrEtMaFfRwZDkhXYH+NjC6CApfUx7OdMcjyl9OKDIJi/2INO8GtxwujiyHrfsgC1+HZKiFSYzKv4jfRIxecU4t4h5UPA/jEn2cmFjEgbVqL5ighl/+DLRJqWl6QwGBFrKHLY5kDTBLizEhqJPO2aQbiBQHgVA7iMRyyZcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=75U+EZll1Gm+bSDexnWJkLRKTq1NK6ISsOqI25az8Fg=; b=G7R9JR9Q6l3c6Lzl28JlKhKoo2xyO+K3+wktVx3QeWaWKRr4KcKiWpZig/vszldLeJsW+OpyBpu6MItfZny0/szA4Rze0+OWXSxGH9eEbGJAOCUnfLQuKl4QLvzWmjWu4cETwlZpcJXlkq1G2Duk2D5WZi8/orq6hNE2wOplByf1aV+154l6qbkHrAAZuhOWWN4X6U9k8Mkb7q1crqg7UZusnTNSBhdcSD6DOzQZhBUgYqYJnnFs5fP7mXBgNpddSpcn4KLKL7/dOzHXh0UYo4Ppf1e5WpAWAHaaVXbv7TNBrY6NwGOVyrIRyU4dFLB8solcNPvTttVqm5EiVlogzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=75U+EZll1Gm+bSDexnWJkLRKTq1NK6ISsOqI25az8Fg=; b=D9YdTqPiLDehkVm2XzPwfmLiIhZMrit/6S+ArqVM15EwnE1ByzEl85xKhZPUcn+C8HgAwnc2AH1ZMpASzPlB3ydwh2HA5V3KRUZ2vX5GZ8ONLDASN/SEIpA/Z9brQagVD6jSqcAB1ugrFWVaAKYuFJA7/Iw8if9B0UK3nk006cE/i+w521iDHzjO6+2+Kht50HdV1FXnkzthUEYoLznaCeV14yfIFAhkECbCpWPt9Op3uH7QlBND+pk78ksu4LFkWUVdeSt3V3aw7J6yh6xvHFm8qHkhJj8eyZcpbtDELGk1XJWLtgyuy8AgXULdyhmyM+37FkSlUCus0pd/8kSHcQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by SEZPR06MB6037.apcprd06.prod.outlook.com (2603:1096:101:ee::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.10; Wed, 22 Jul 2026 08:42:50 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0245.009; Wed, 22 Jul 2026 08:42:50 +0000 From: Pan Chuang To: Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Wim Van Sebroeck , Guenter Roeck , linux-arm-kernel@lists.infradead.org (moderated list:ARM/Microchip (AT91) SoC support), linux-watchdog@vger.kernel.org (open list:WATCHDOG DEVICE DRIVERS), linux-kernel@vger.kernel.org (open list) Cc: Pan Chuang Subject: [PATCH 8/9] watchdog: sama5d4: Remove redundant dev_err() Date: Wed, 22 Jul 2026 16:42:16 +0800 Message-Id: <20260722084218.79073-9-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260722084218.79073-1-panchuang@vivo.com> References: <20260722084218.79073-1-panchuang@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI3PR02CA0006.apcprd02.prod.outlook.com (2603:1096:4:295::13) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|SEZPR06MB6037:EE_ X-MS-Office365-Filtering-Correlation-Id: e64a4e1c-ce0c-4992-cb9c-08dee7cd3689 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|52116014|366016|23010399003|1800799024|38350700014|22082099003|18002099003|6133799003|56012099006|11063799006|10067099003; X-Microsoft-Antispam-Message-Info: o69Cc2n+G5ttf1ZeXs1jvXQxJoclKxFT/EBf6Ix983wuBY5PyoeUgMxnvwkLRAuWn1ljd2Ay3wytq7bD4oZeYZ2rMgJOQ29PDlg+8T9t9522QIAsrhOJhEY9WMdHWciy4uw1ZtpGLrda+nRtcoeRta5+90t3mmsZ6+NyWqxfbDAhegtps0yJPG331nOH2+6yq7LsVOPFpc5T+5vHTGpvhgGZM30iFgI/eEhOv7xV0vL2K6GX7KRR9/uRSul24XizBIqZnUabEKFP/tp1A1HTv86UP2jN/4zLQFSSQdhLinRhqkEICiGSwakd29WAGaxch2bUoNgXkW6r2RB/iMrI5fm4t1TlHIzlTMXDX3C0b4jaa6KP5Nz2Z/xO0F75aa07lHljyenbJDr9cZDQ2/taGQjz5K1rbhmYCp4iejz9rgwNXcdUjEUWJnkMmBVvzWYHWtVwJktCG8vundbv+Y9z30sQhctSOOycvMyi4b7u8+11Zy0GZSSuia69A0C+WsB81P6c3uJg3jAcNU9i7jcoQtJLsWqRY3r7dAP9AVuDtvOM/iPJYh/dccgk1Gy1NDWVI/9RZzev8LboqPEHMygfNb047Yd/sxOPLfjSkKy6zLg1n0WBR3JznmwXkhsp68Nd6p2H82t+eM3Z11ctqnIclSe7SKCDQbYN/kvigVIQQvSaTnXo/1z1leZbBWjcitA8n0m6PLd70ut4XDsOCkBkP5n/7FkxaaajRJfQw/TB92o= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(52116014)(366016)(23010399003)(1800799024)(38350700014)(22082099003)(18002099003)(6133799003)(56012099006)(11063799006)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?udrUty9efItq3U5xy69B+/CdS/ZugK8Jd/pJobkUmTce+BT8tVCebVRij+wb?= =?us-ascii?Q?RcRZ7RiHY5WnrC333gQIiEJc7HtE4WqiXWRvKvyNZ3ajMe/M8vbDGw3Ve5mD?= =?us-ascii?Q?Hgono7Gle48YzezkooJ72w6ZfOvHKOeUUttcWDso6P7spwXjAhIzZeqTFKuL?= =?us-ascii?Q?0cn6Jh05ZEXFHGk9+xMWmFf5IQfKUsEZtOhG9r8KDB9J3kwfhmbB1buZTjla?= =?us-ascii?Q?NhkIjjglvsMnIRoziOZBMxwy5/LOC5n+6+6ai1x1C8s3SzBt5XKSqJ3LmzC7?= =?us-ascii?Q?5eBenVP3bchU4Hp9d4eIPJoU++XwwEJlAWp8l69+CGVutl0yA+SCPWfYXVc9?= =?us-ascii?Q?WozIVTlj88SZqW9wWXEy3sfdfh/U9RuuJXgFXonWCRTSB/UGpIE1ZP5QQyb0?= =?us-ascii?Q?XlO/iY55oxuZZL83bW3JM0qFCr1Jw747dhcpqpC4NYz/S1clxRVNzR2ww0P3?= =?us-ascii?Q?Z/6cYQ8s+t4y1hISyGLwQ6UCrYXDrPuwTlqUd82pNg6FEtqGQi45P0npFSRL?= =?us-ascii?Q?1V/s2FiH7w+HZC/9D8829p5N3OVk72RKcuxjQmqJC69vKm8g6OZIIfgKJ98E?= =?us-ascii?Q?4M4MyvP68J4t4gBaAst0rpgQEBeVMq2EiqkPT7haLarS5ZNA2upOH8V3VHDR?= =?us-ascii?Q?Xe9LKLRE2B/Yizx2iVqnG0QTW2ZmKXnBpESe2TA0nKbq1USFUYqawqBbaSht?= =?us-ascii?Q?hshn0ZnZZC4tg8sCeEe5xMKbTMyhLfWvRUaN5vZtEAR7e3hWAISNv0fSuhCy?= =?us-ascii?Q?ldfWqG9ROHf9AulDBkEVNviOkbC/NRBuGuqDMUf0cYH5qNqCT/j2UVb4zrtb?= =?us-ascii?Q?q3IYCRAS751DLfcDcutVGHYGW6YDHaE/8EvLG+uu2s4T83u2/4jS8qRScS+O?= =?us-ascii?Q?74ZHGnXApjGTZYUBkbca2s8IHr+c5puqltyhEoW3tcNQxrkeed92fsCy3JjH?= =?us-ascii?Q?bJrEq6nui/C1pYMwDefexCcqjcYYgOlKVpCbvpMNCakEQiJoZxLCBILlLfDI?= =?us-ascii?Q?9cGJPvh3VJ2VoAj5kPuSV9YrMrAa4jJSAzF1gNuCebWOB8zM9wesZl2Fw0/f?= =?us-ascii?Q?0hzPx/lQ5Y2on2SUMYCPeoMH+DLB2uJ31nXeBsdPw2OJvC+UEauO/eSc1ITM?= =?us-ascii?Q?r4IioHyv8hQRKS2PNIta3I4oKR35nv/tUUdhPa9/ZWWuIOJXRwqwlDBpENJi?= =?us-ascii?Q?2DmD4T57Ppk9Bz9Z+ppOzTffh1Kan0MTaUx15DQo3qm2AMg6LFcx3Mu0nCW2?= =?us-ascii?Q?CaDJqcPz9DdKtMeH06AknxKZ/zhI0thiQvSZP2iJN3c2lh7tqQKq18EmMezw?= =?us-ascii?Q?of4MS9vJ2AmiaV2QOhkVXvfQlkcd7L42xs0OMGAv5SpLFhRtGK4ANFkPSnH0?= =?us-ascii?Q?1DaJGD7LfDa/usbXHsGR5Aftd/ZV7AdtfH3OgtGRVSbmlotOYCRZEMsfkpUS?= =?us-ascii?Q?zPUVEI8HOIQelIZxhlsBUlKpKFVZkWnNaLWBqzH9m6Y8YG+O0HK2T3pJLJmk?= =?us-ascii?Q?dGS8onBoGMCbej/4uBSmf/TWsCIHG/+bGc8EaC8aBaN1p3Qh3JfbipW3e1QH?= =?us-ascii?Q?CDaleAQJOge4kl964pIq7hrKiMnulpEwwI+sX9m/Ez9P9tnp9/RiL19MEjLo?= =?us-ascii?Q?o7Gfo1bxhkISJxZpvQSxTayxqzdkQ4IyPef7cREcKKAr+jqYOHvsz+mWzsrB?= =?us-ascii?Q?9mMium+gKupXghnij/vYAKN06/hGs1NXo/ox86YooLxCWXOwASfxHvDjKLBq?= =?us-ascii?Q?sOfiSdjUXw=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: e64a4e1c-ce0c-4992-cb9c-08dee7cd3689 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2026 08:42:50.4555 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Fwki1v0yCNEYse2p6VaStt0+SxXhiHI5vHNgyMPenyVi4SbzsZZVRXDJTY9Gris/jA3iSpm3iJnQ0I7394D6EA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR06MB6037 Content-Type: text/plain; charset="utf-8" Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() call. Signed-off-by: Pan Chuang Acked-by: Alexandre Belloni --- drivers/watchdog/sama5d4_wdt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/watchdog/sama5d4_wdt.c b/drivers/watchdog/sama5d4_wdt.c index 704b786cc2ec..ecdd9aeab79c 100644 --- a/drivers/watchdog/sama5d4_wdt.c +++ b/drivers/watchdog/sama5d4_wdt.c @@ -291,10 +291,8 @@ static int sama5d4_wdt_probe(struct platform_device *p= dev) ret =3D devm_request_irq(dev, irq, sama5d4_wdt_irq_handler, IRQF_SHARED | IRQF_IRQPOLL | IRQF_NO_SUSPEND, pdev->name, pdev); - if (ret) { - dev_err(dev, "cannot register interrupt handler\n"); + if (ret) return ret; - } } =20 watchdog_init_timeout(wdd, wdt_timeout, dev); --=20 2.34.1 From nobody Fri Jul 24 23:31:01 2026 Received: from OS8PR02CU002.outbound.protection.outlook.com (mail-japanwestazon11012026.outbound.protection.outlook.com [40.107.75.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E14E636F8FE; Wed, 22 Jul 2026 08:43:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.75.26 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784709798; cv=fail; b=YotXx2DB1qn9h76RUfdXST4gF1yJv4NKx93HLV5uXpGFGLT9SifbCJN1RrvaEsYaHUoqU6HGuPwtVd+dePflLAiOqHi1qYoLZp2qkbmIRuiaQj/6x0mTVoyLQxtJspcgyqoLe4sZNaz5DOETh75vBooycsbnEu1Pd65CYX/4OvY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784709798; c=relaxed/simple; bh=MItCxsTdBhBsAsQeTqGv0WiNlIEVa3B77eoIT+eEwxM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=lZ2ZiPVic2LBv470b/6m0HrV+R7yw32taZPLcv0vmdps9agORzeIT66PC4qEOCc+AAVg3fmbyBKlm4Br/nphV4dsS+Gk61Y3BPxSw8hdYmMalW0Y3AnIMn4peU8Bw73Tu3ufKswgcKGj38Q11SSuC3VZMnz90jA7u/YmXFtYiB4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=Qr7aeMqq; arc=fail smtp.client-ip=40.107.75.26 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="Qr7aeMqq" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CxXTQhrpOfTwW51Zn36ZdUC8ONOg6LYxYFu8VbC8pTdteHN0ZZUCVzUDieoEAGu2uDZz0uw6ZEnGx/pXtIe22p/E8Kp4Xib9yZ9pNfInAoX1WlHs/QNmtbfgcN2g4C29DQy+6qg+z6UjJlijqSq/xnNOJ0FCk48ntxsKXAEbcuUyWbyQ8nqNjEemCjpccIL4RxcIDNr8cF66ZGxqhUJwtivyma2kClAJbr1htR/KwTKFP58d5g9gBmnyk/XX0KVdf0qHsJHT2o+HPI1s4m/AmX0JLv1NOOYb3K98HPGisE8eX5gTCiRiUmYY4vy86dKdj0YO+1EE8kPlLZkscP5KrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OXogmcNwFIPmGl0bit4zeQzrpZ/9HThoKwORjjWnx5g=; b=eWARoWNST8DNefMhsTEEDIIgG7eMyYK2Vo06CJzfc7GlKNjbp2ODCv8Hm+hJ8lY7EN9V3KcZNIICtylfhy7n1bMZxOe2vb/D/iZTJRC/uaY+pAf53e/gsjkoGuDgv4FUlbdiCaVtzLF3KJJXkWVeTIJk3IllmziqX0uNU6qjFUG6/15EGdxaBKuros9FhQCiX+aCzGxcYqN7nKyoyLDYMMJy9W21FzbSWvc75THMPjHunBtZ/iQMMAToPrEvpPla4VaG+lzQM286cgeQA4u4c8o1L6tqei11zmPvnuIz7OWUQURm/05qsHlb9srPDEhQklUohlXXX9h0hmviybWHRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OXogmcNwFIPmGl0bit4zeQzrpZ/9HThoKwORjjWnx5g=; b=Qr7aeMqqGCV55QrIcKVQ2RGVzf5/F4Q+x+gRO6oZ6FuNs9hV/y0RKLR2qrzRSHqJP/e4/WfoclIyZDIU0WfYMpReK6nABC9Oz4GZX0WN1maBRG2K4OXvYX/sbAQ3Rvmp9XtAqZUoZ9ZCK8iNHiq+QHBrQrKFh3qmZq/WFZdwZxw2kHAMN9QGGbJl5H4EgJhAZrF/sMocdNsjrrXclOZ7kS9V5KY8PspC6Gkm+H1gFKZbDjL1kqYDXI73dv16FI4AjIZtoenIF8EULbuugYbQgaRAZf4qZM626/FwWPZd8tvtEquskYbQDpSxRFnTI4LPm+OXVUhntgRijWmHPUFrIA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by SEZPR06MB6037.apcprd06.prod.outlook.com (2603:1096:101:ee::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.10; Wed, 22 Jul 2026 08:42:52 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0245.009; Wed, 22 Jul 2026 08:42:52 +0000 From: Pan Chuang To: Wim Van Sebroeck , Guenter Roeck , Orson Zhai , Baolin Wang , Chunyan Zhang , linux-watchdog@vger.kernel.org (open list:WATCHDOG DEVICE DRIVERS), linux-kernel@vger.kernel.org (open list) Cc: Pan Chuang Subject: [PATCH 9/9] watchdog: sprd: Remove redundant dev_err() Date: Wed, 22 Jul 2026 16:42:17 +0800 Message-Id: <20260722084218.79073-10-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260722084218.79073-1-panchuang@vivo.com> References: <20260722084218.79073-1-panchuang@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI3PR02CA0006.apcprd02.prod.outlook.com (2603:1096:4:295::13) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|SEZPR06MB6037:EE_ X-MS-Office365-Filtering-Correlation-Id: 57695353-5b4e-4d43-2af8-08dee7cd37be X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|52116014|366016|23010399003|1800799024|38350700014|22082099003|18002099003|6133799003|56012099006|11063799006|10067099003; X-Microsoft-Antispam-Message-Info: BCLQgFhLeIQoE1IeZQ+3GZSMfOy513u2g/d5Ktun9EfW7TeMmd+pDJgwAyxQ5s4RsOw04Rf5/rkQIgBiLjlDGRxscvt43OpkSLnR3YoN0jOEAiZ5/dv/jhcdBiftDh9aRsKhfxC4aHhwjz+d5QfMOgzpXAscqSVDnLKKaVyL3wFfqOYhwIVkbpHxfD+gUHxvv9JllSXWUp+ZNXiffG0G/M9cXcFPj5zoBUIQsy6ZZlVEJ7Qp/CVi8Fu7ymVphsrekCU1wxOz4Cai0STsiOUvK0wggt2IPuwgt5y9WwwiZVXvyf9IXW0puEkRLA6xnUI8tqjEnC533SyLDrEjO6gX2fHeJ/3VhnaVddq8P9bnIp9d/CFyrp+Wf+SeB3D6j/dDGK9JWn4/n6i6FZiOwXOTl1Ke9yo8IVC5EDRx/mh/SFunguu8e2RgIdBkLpEDymRW7yMQc6bQirKVvreyHJC+p0Bf33gwJ52CK6LeSNdAQQzy6L4TtkExi/6k7MCFmiEg2tigyCMwEHxCBb+ugfKf7JWG7prIbveuqn3BIi881UZP8j00wZD6mrxdTYOSR6CgV71Uqs2zfippNZsOUkcN99CSAAfV0O/Zraf6uCAmX0e6e3vTfzs+QYd75WtGkkM6CoDdCrnjVmA2K7tK1seY/a8n+YbPAaHSBBDIGqj1ko5rYUaRFjUyok3vG0hEF4112MaDF+KppcXnt4SXJnv5i8RYyHZWUlSi+13PoaIvkVA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(52116014)(366016)(23010399003)(1800799024)(38350700014)(22082099003)(18002099003)(6133799003)(56012099006)(11063799006)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?K4Eb0Z3W1yMCBaRrIblf2evwW+PPoSQp2IsqU0N3kQ/0FTEJBgJq85XQvjuV?= =?us-ascii?Q?PHV1Qo4xasTgJ1IG8xOpUyYEARKB0rk7rgfMfFK3W90KCHa0gEyYRJIGqjcB?= =?us-ascii?Q?JN2nSnU98poYX031EjJxEdj8BPySl2zwWRNZWocm4VkdpECrCPBRBYk3Do4r?= =?us-ascii?Q?uJgW7vHhGwF484fm1QurCKnZpIkycgicDKjo2PIWkGjq+s6xVG51wtpizJ34?= =?us-ascii?Q?99Z7yUu39WBPOO1R+DBITOgBDvzieFcFb/e0uMKFzt8GA5qLJHKfz+8cjrhi?= =?us-ascii?Q?JOB7w8A9ZGaCo29bTKKbB4KgTXl0uDidRwZiTBnGxvj7uAJPBcnEwsOqgHJE?= =?us-ascii?Q?0iLk5PUQ9n3vjzS5mY4VnhVYf8i3I+aGKcERmyrWnZ30D9jaG3sQFVV9Uey/?= =?us-ascii?Q?sdGV2B9gZqXzh2tKLXJ4Ncs4M0J2VjB9hvIu4hlHw61l7c3DAAId6NtXIqIc?= =?us-ascii?Q?XGRyJnuUGj2501qbdwi1Z5Qd0pKPkG51pWCHklnnwQ/QZlc0tsx9jFgJVOcy?= =?us-ascii?Q?4CFkvpIvyWP5NadssV5+a57Fjh+8zB7Lw8+JR0mbWAJli4g/JV5Wf1Hm1EeC?= =?us-ascii?Q?5VZZs/QnqoqNKmAK9o0WUM0vRyp9dKRqq29bQBmpjGr9aYjwHSpjBjZWalIW?= =?us-ascii?Q?A6v5GhjUpRZxSiB9FTFKHtAYvM3fNw8dOj3LxRZFATb1z1KvYY69BxOTF0rY?= =?us-ascii?Q?fYiEz+nzOxun7uMSK42IafJiscV6/QfwykE5sla1cet8ID7zH0ElPImtB91H?= =?us-ascii?Q?hEAJTMEVelTfqR65kvMrTtcS6aLQ2ild3qxxlKum0GCu4JVqeGiZixOKKMgl?= =?us-ascii?Q?MGTB8Rdlki008c6+FDsHEL59oZc/07tV28/+3QiEgWva8xvgYTMps20fr2xa?= =?us-ascii?Q?7Vi9ZcIXupJI9MRFqXPtf6vkjyQs2lS/U4aH4qmqTkscE40FsrEZBFDB9XVE?= =?us-ascii?Q?34mDvBuTQrOm3KVDzakqTo69mim1iyDVuabFHXqCGPxsrEsBGuAq4v0kaY/6?= =?us-ascii?Q?wsm2MPkgQEWtVBKPZOjeCGeI7avcpO7QuK1xjcOujcYLTuYpG2MBSBJl/ZX4?= =?us-ascii?Q?SdLOKd3XnctAsv1/CZoIuhcJ08dhheM+7dABIrtnvEZ+gv0E3LF/ZBNSoiUa?= =?us-ascii?Q?rcKXBVpTWlzwBCP4dkU0Y8SPu1qjcgW3JpDq9VKdOzqTAxs7uaweObSnTUh+?= =?us-ascii?Q?Y8pPKTziecyYbCGUiX1r1JLm3JGfQoijIsLlyNOlCHWG4AcvVjFUfb4J63M6?= =?us-ascii?Q?mmJv5cBQH4SAFuXT3lHzWpGQaGduIRFiAWagAblLRY0EMY2Twxn0XqCfN+hD?= =?us-ascii?Q?hYYglxf6k+ew/p00HvXV5wCCIioobKmkWwhTo/L3haf9gmQlNSAGYqnvSH4P?= =?us-ascii?Q?Pi0/6M4/hf7bqzl2WFFKkCSoXIlfwCcmXt8y87iRL+4cwlRkJR0jrpjOKAHW?= =?us-ascii?Q?JZpqHy7bahMSbQW+OvJg6g4jzPX+UAPo7yAa23sOapcP0Wjyqmpi8M5QVU3n?= =?us-ascii?Q?UG1Rp3UCp6KL3QF6L4vf2Jo4RAPbD35AdRBzjYlsn2I8oWZNUPnbro2tmRXz?= =?us-ascii?Q?uSC9O0FSW/mPViQu/jNIlHT+a7l9noMPTPSyP/ji9T0ojB4lDsldzvZ5rlst?= =?us-ascii?Q?4PGAwF7bYAESDMHcJSf63OcwWpetui4/c7rm53EX69H7RV0nPYFt9qgG755N?= =?us-ascii?Q?1FQ+ttLl/5u+gTZMiuEPg8OV4BXgDUMGf/rFarjf/SQ5WDf2+/7gZ+PSvevr?= =?us-ascii?Q?7Pv7prRADA=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 57695353-5b4e-4d43-2af8-08dee7cd37be X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2026 08:42:52.4761 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Kwd5qaoWUU+d79xa3kfGtwjy83L+MACucvzo1rB94TUO2+okOLTnYiNk7fU+UiH1EaHCuQmuJVvmNlnezqWFOQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR06MB6037 Content-Type: text/plain; charset="utf-8" Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() call. Signed-off-by: Pan Chuang --- drivers/watchdog/sprd_wdt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/watchdog/sprd_wdt.c b/drivers/watchdog/sprd_wdt.c index aacf04616fef..616b4d7f21d7 100644 --- a/drivers/watchdog/sprd_wdt.c +++ b/drivers/watchdog/sprd_wdt.c @@ -293,10 +293,8 @@ static int sprd_wdt_probe(struct platform_device *pdev) =20 ret =3D devm_request_irq(dev, wdt->irq, sprd_wdt_isr, IRQF_NO_SUSPEND, "sprd-wdt", (void *)wdt); - if (ret) { - dev_err(dev, "failed to register irq\n"); + if (ret) return ret; - } =20 wdt->wdd.info =3D &sprd_wdt_info; wdt->wdd.ops =3D &sprd_wdt_ops; --=20 2.34.1