Hi,

This series fixes a number of issues found while reviewing the opt4001
driver. All of them date back to the initial submission of the driver
in commit 9a9608418292 ("iio: light: Add support for TI OPT4001 light
sensor").

Patch 1 fixes the power down path, which read the device ID register
instead of the control register in a read-modify-write, corrupting the
CTRL configuration on the way to power down.

Patch 2 fixes an incompatible pointer type passed as the remainder
argument to div_u64_rem(). No functional impact.

Patch 3 makes opt4001_write_raw() reject integration time writes with
a non-zero integer (seconds) part, which were previously accepted
silently based on the microseconds part alone.

Patch 4 fixes reversed GENMASK() arguments in the (currently unused)
fault count mask definition and adds the _MASK suffix for consistency.

Changes in v3:
- Patch 4: replaced tabs by spaces as suggested by Andy

Changes in v2:
- Add Fixes: tags to all patches
- Patch 1: use regmap_clear_bits() directly in the opt4001_chip_off_action
  and drop opt4001_power_down() (Jonathan)
- Patch 2: document that there is no functional impact (Jonathan)
- Patch 3: add blank line after the early return (Jonathan)
- Patch 4: fix whitespace alignment of the new define

Regards,
Nikhil

Nikhil Gautam (4):
  iio: light: opt4001: Fix power down clearing bits of the wrong
    register
  iio: light: opt4001: Fix incompatible pointer type passed to
    div_u64_rem()
  iio: light: opt4001: Reject integration times with a non-zero seconds
    part
  iio: light: opt4001: Fix reversed GENMASK() arguments in fault count
    mask

 drivers/iio/light/opt4001.c | 37 +++++++++++--------------------------
 1 file changed, 11 insertions(+), 26 deletions(-)

-- 
2.39.5

On Tue, Jul 14, 2026 at 05:01:30PM +0530, Nikhil Gautam wrote:
> Hi,
> 
> This series fixes a number of issues found while reviewing the opt4001
> driver. All of them date back to the initial submission of the driver
> in commit 9a9608418292 ("iio: light: Add support for TI OPT4001 light
> sensor").
> 
> Patch 1 fixes the power down path, which read the device ID register
> instead of the control register in a read-modify-write, corrupting the
> CTRL configuration on the way to power down.
> 
> Patch 2 fixes an incompatible pointer type passed as the remainder
> argument to div_u64_rem(). No functional impact.
> 
> Patch 3 makes opt4001_write_raw() reject integration time writes with
> a non-zero integer (seconds) part, which were previously accepted
> silently based on the microseconds part alone.
> 
> Patch 4 fixes reversed GENMASK() arguments in the (currently unused)
> fault count mask definition and adds the _MASK suffix for consistency.

LGTM now, FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>

-- 
With Best Regards,
Andy Shevchenko

On Tue, 14 Jul 2026 15:44:33 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Tue, Jul 14, 2026 at 05:01:30PM +0530, Nikhil Gautam wrote:
> > Hi,
> > 
> > This series fixes a number of issues found while reviewing the opt4001
> > driver. All of them date back to the initial submission of the driver
> > in commit 9a9608418292 ("iio: light: Add support for TI OPT4001 light
> > sensor").
> > 
> > Patch 1 fixes the power down path, which read the device ID register
> > instead of the control register in a read-modify-write, corrupting the
> > CTRL configuration on the way to power down.
> > 
> > Patch 2 fixes an incompatible pointer type passed as the remainder
> > argument to div_u64_rem(). No functional impact.
> > 
> > Patch 3 makes opt4001_write_raw() reject integration time writes with
> > a non-zero integer (seconds) part, which were previously accepted
> > silently based on the microseconds part alone.
> > 
> > Patch 4 fixes reversed GENMASK() arguments in the (currently unused)
> > fault count mask definition and adds the _MASK suffix for consistency.  
> 
> LGTM now, FWIW,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> 

Nice. Applied to the fixes-togreg branch of iio.git. I marked them all
for stable

Thanks

Jonathan