From nobody Sat Jul 25 19:28:28 2026 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5782F351C25 for ; Tue, 14 Jul 2026 11:31:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784028708; cv=none; b=YYwQ0BDe2Slsj5he7+p3qkp9FglnjLco6SYFpwcBgCPQUZtJi5/fFFmvbdJeQHyr8XSqhme3b9C3B62oUa/ynM0mBfStE0w+DnSYz21WVRPLBdIO9RCMAZ3crr46BhQLu7YiTsXXzB6RaGfIKEqal4jFHnB168sBx34xAM8hsts= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784028708; c=relaxed/simple; bh=xxgwCeT3dSPUCMHW5OXfv9VTnN/cr+L941sj/wmgWQk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Obl5ul80egvnt2i+T3ekk6DR5CEyX5UxBev2+jdXJ/lp5IanLo1XNl9FzdWBI7/MIWR24fHYtKnEGIIzEKNFN91UTXkPx+dsVxu/8yxXYU66VrzH7FHdXq3lGnuuP/5hb6AYEwlbutLIN+/O+olcWmyrQjuKZx1Jh2KJ5Dn8+7A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=m4TK0FZX; arc=none smtp.client-ip=209.85.215.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m4TK0FZX" Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-ca7c1176317so3025513a12.1 for ; Tue, 14 Jul 2026 04:31:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784028707; x=1784633507; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=UQkjz4SLBwT2GueIM4+tWAz99xBrKedDThFl6sdTxH8=; b=m4TK0FZXFw/7luCgZ+72YHNV/0IX92yLgt0D4aQovBZZVQf5Gor/pMZNr5DW15eez2 dmeE6NS4xytwHIuPdsAcTdVgeN/sKb3jMLiItFY8qRrDcm7HmpED80kgf+a13/ongl0v 70kt6Ya5Bm+9DpIBFezGuJKqNcvn/NeYgtxPv5ODkm3QWyDTtb/QR+t7mZCveAFdS11a ZCr50+PL1ODZEcftzF1ousR5MCcAcOMtGZXz2yzNtTb8i+fErwRn9tBS72kJo1BT1yYd bnzXzg7mQpJ6MfwkNFOtho0sy65KKuUPxRjKWMm2PrTR0D5Rl55f9EbRSz7TowevjM8C pzdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784028707; x=1784633507; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=UQkjz4SLBwT2GueIM4+tWAz99xBrKedDThFl6sdTxH8=; b=jdQHl3Zk7z36dACSEOQGyA/UZTA3CEvhUJMLmFugOajReNuM+f3qWBRW2XKDhVVAWu FMbkf9dp8AOry9oElDcRGkUKkWEMUyWRLeZQ5MUu0dwEWHAyZlJhxpb+VH0+88xnzWwd a1A5+zadzwP5GdDyMuYHvmZyyqNL6au70smy2Xi9lH3n5jdW5fVjuJ4jSYeIqzJLYzl7 JmzKuzs2o3woI+PafewqVPRmuq43eQZYytvkjXweZMX4Ro78xGSDPTxp6SG+RfXAU8XW m/je7pcCP2VWosZRN240IJilRKWH8j3Ve//BFbEcbnaNCRSkUIN2nEV3XsemJMsXcy9b rpTQ== X-Forwarded-Encrypted: i=1; AHgh+RqGSSL9AfsmiCbUNgPxTk7ZuM7kNuuAtF4U62cZpjHpdD/0BKVWncuOnoAT8aV+5DE5n1SHgrsM6CrTM0U=@vger.kernel.org X-Gm-Message-State: AOJu0YxaCz4W8wlIXhkH4gEd7i7EUT95JQjna2aNHwUghUYBBx7DB1KR clMEcp5+0aoWUkUfPyRuPBLJ0m/x1XoC3wtwQ7RKmRjmVPJeD20ZSb0= X-Gm-Gg: AfdE7ckrrMoMfyP/Cmpo3slj5sauj5EcyM9MvGDKPwa6ZaMigymMKMAZuzHnVtifb5B D2AtTAMjI+ER3KIsYrbX4EpVLVb6+Icik4saWws13DCOJ43ohhDoAN1L/dI3f2Z5qr30divyAyQ KCeUTFmx2igC2FTFkesYnAYVfHwm+nG4nFONtViqZcZLwCNpVrFRU58igCoHk2muBo2HJ2HHMzJ F+9wsK/9oB0hDuubbIJ2VgtaKzptc6w/Ev8Sl4x2bEBL4E2bDNO6qV1cuxUq9IiIFYNBpRwdHWV 0AVS7neu/sXXb4CII0qAKktRzMuVVigKdB0uGFewU/dgmK8BFHU43zrZQC6ZIwSQQg+tT/Xw5GK 3mSpXUWCMn+TKfB9fSDrYBoFjCQ46CI83Q+nohoxXEGQgSU6pWeT4doMm2G5AMjgEikWD2kfJtU XD+zmXDi7vmyrJTn1LSS2ugsSevviEEGNzmh/mCJ8MMf547LFnTAPr X-Received: by 2002:a05:6a20:7283:b0:3b4:6f7e:d0f9 with SMTP id adf61e73a8af0-3c1100308f2mr13749870637.3.1784028706648; Tue, 14 Jul 2026 04:31:46 -0700 (PDT) Received: from localhost.localdomain ([101.0.63.168]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-311747f72a6sm95357368eec.1.2026.07.14.04.31.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2026 04:31:46 -0700 (PDT) From: Nikhil Gautam To: Jonathan Cameron Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Stefan Windfeldt-Prytz , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Nikhil Gautam Subject: [PATCH v3 1/4] iio: light: opt4001: Fix power down clearing bits of the wrong register Date: Tue, 14 Jul 2026 17:01:31 +0530 Message-Id: <20260714113134.3445-2-nikhilgtr@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260714113134.3445-1-nikhilgtr@gmail.com> References: <20260714113134.3445-1-nikhilgtr@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" opt4001_power_down() intends to clear the operating mode bits in the CTRL register but reads OPT4001_DEVICE_ID instead of OPT4001_CTRL, so the value written back to CTRL contains device ID bits rather than the current configuration. Fix and simplify this by using regmap_clear_bits() on the CTRL register directly in the devm action, and drop opt4001_power_down() which has no other users. Suggested-by: Jonathan Cameron Fixes: 9a9608418292 ("iio: light: Add support for TI OPT4001 light sensor") Signed-off-by: Nikhil Gautam Reviewed-by: Andy Shevchenko --- drivers/iio/light/opt4001.c | 27 ++++----------------------- 1 file changed, 4 insertions(+), 23 deletions(-) diff --git a/drivers/iio/light/opt4001.c b/drivers/iio/light/opt4001.c index ba4eb82d9bc2..66563000d081 100644 --- a/drivers/iio/light/opt4001.c +++ b/drivers/iio/light/opt4001.c @@ -222,33 +222,14 @@ static int opt4001_set_conf(struct opt4001_chip *chip) return ret; } =20 -static int opt4001_power_down(struct opt4001_chip *chip) -{ - struct device *dev =3D &chip->client->dev; - int ret; - unsigned int reg; - - ret =3D regmap_read(chip->regmap, OPT4001_DEVICE_ID, ®); - if (ret) { - dev_err(dev, "Failed to read configuration\n"); - return ret; - } - - /* MODE_OFF is 0x0 so just set bits to 0 */ - reg &=3D ~OPT4001_CTRL_OPER_MODE_MASK; - - ret =3D regmap_write(chip->regmap, OPT4001_CTRL, reg); - if (ret) - dev_err(dev, "Failed to set configuration to power down\n"); - - return ret; -} - static void opt4001_chip_off_action(void *data) { struct opt4001_chip *chip =3D data; + int ret; =20 - opt4001_power_down(chip); + ret =3D regmap_clear_bits(chip->regmap, OPT4001_CTRL, OPT4001_CTRL_OPER_M= ODE_MASK); + if (ret) + dev_err(&chip->client->dev, "Failed to power down\n"); } =20 static const struct iio_chan_spec opt4001_channels[] =3D { --=20 2.39.5 From nobody Sat Jul 25 19:28:28 2026 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2C2E35C19F for ; Tue, 14 Jul 2026 11:31:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784028715; cv=none; b=Qi3anHH3IB54FEuin4ACNucGoN8/+qKwCJF0CcxPFI95OcYXxc5RCyr7qmpzgspiQu3Oq+2jrp7NaGPkdFjMlEpCIoFTLHOc14s3ibKPx8NoJMGu9Uczn2Gmt93icDC2WRui2AM+LDoxCJJi2RxQp5oW+NnqXWgc1aLxePc2u28= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784028715; c=relaxed/simple; bh=biO2VDvvuMrg2uvDOeIUh5S1pDVpoUHuMMBFpMiL5jU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=GLGd6jm53WMULWG5HH6ClRvH+gjLWmNqe925SSRw7ojO5R337DkNVZcyc46KW9lhVjgwBNJ+7k1X1l4P2GZhfhs/MZAXMQ2eWzOuluoVyS0gnf73Mo2GxBGAJQhrTL8i2yT+J0xCwMwhDXjMQLWEmY384oQraCes9XPcnTd7kQI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fltIsD98; arc=none smtp.client-ip=209.85.215.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fltIsD98" Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-c9fe3c9bd5fso689514a12.0 for ; Tue, 14 Jul 2026 04:31:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784028710; x=1784633510; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Y0H1G5WZdR9SN2z823rVvQJ9X5UKno+8iIWeLBusZtg=; b=fltIsD98C6WwW35+fnMCah7EQCrx1Xn/JkgE20wqUNZTSaAARsguva9Ro5U0bElYMn H3auFQS+1JtrnUB9MLco8PsHNiR+m6OQSbl8zK4inpXg+GT1mjgDw+VglG8p569so6s2 7UEnxlzbs5x6KIInaNSNG3W2RBqedIeXn+5us7wme12mSUGuqVIDPysy6+fgGXi0E1d8 xT59dm4/r6qmh/9oWHbjxFMPeJgkARTiY4bDDNdGb9kiwANgBLyfQoMzc0ZUsnViBw6F QOs4KE+IYPXnQKvhEWtFy5MPqGhYUspU0btETSdtnUs8c0zm1R4Y35zOFp2hVME3f9cC 94OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784028710; x=1784633510; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Y0H1G5WZdR9SN2z823rVvQJ9X5UKno+8iIWeLBusZtg=; b=Lw0ppUTfAnQ42dHA77BGMHZl5tYfJcCP8Lc+M1YLJMD22RgJcBatHzpkzDBswtuETV SL1EwLFEEPcRyj2dX0HaAF/wG8S8L9kjb/MA+9aSQUXFHS6GuPvh4+n5FDFKtbJFYkeJ Zdumn3Nuxx8uPYXom8Pu8+LyemQXjRxVEttqrlmtsdjemH4WBPOdVL/KV82PxfnvwBEX Db+Z416DtaSVArr7eZomS4ZXTuEx1NiCTkWwTQHhVZ0KUKMLeM+MmcdPQCx14KWbH7Hd 8MBQAXFatGJF1F6EgfvmGQOCnZWLzaQ0fxHu+IPKp8BYPpbFvMf/OVzJxxjsKbqc4LeG fFow== X-Forwarded-Encrypted: i=1; AHgh+RovZMiSSLR5enNSnypsuaCdL9Js9JZ6HjtLfbOPpnx35VgdsMuUWkTgcrqjiCjOqgd9EAwooMfKT3OuJts=@vger.kernel.org X-Gm-Message-State: AOJu0Ywco5aTa/F23GuPZzfawHrmOx+PJzKZaWLX7En31Z/vtAonWGHY AAUGKwIpyTwWfnINZYAsLEu52V/KCDiDYe0RQfJPPV0vc8ZGxTSZwtg= X-Gm-Gg: AfdE7clmguN1Fl9DwUPm3no1t1ve0VUkTG1lNMRBYQ9dMrjFkJt36CV90qvKivvCNr+ 73iEdFL3Luf6aSYbHpbtpJ0j/sJ60Rd32DdB/YGosxNI1ejsBZwmyXJITj/nUTIMZakVZs3J6HG T1x4VmcqAQTIIBdi/7n+l8AnYL+xG7VieJGlR+9XAwsfcheehNdMjsgJDbp5Kas7Q+0XcTPELq8 keB1VFchEbrj7oi68Vtv4c+o6qRiZiQC18iXLp198C1raT/rNmJ09yZX1uPJyB9+gD2vNp733ne 7be6rhaCIAS2Oq/O4IzMgjuVwqpfRTneJDVSSqyjgBV8A1EzwXekpXxhqqClOeRa/gBP8g143Su 9xdTWKvovB3+fP0PLxLGDr13CLYMBwx/Q4EIrqvxit1JAHOpt+5Ka0pLdNa1MHKO+8sOuThqeSY xx1De6/5LfSM1WqIBMeI42KK3/5Tiqt9/UfFEyUPwiH5UQs4P7/aYY X-Received: by 2002:a05:6300:2189:b0:3bf:8a0e:dd99 with SMTP id adf61e73a8af0-3c0f0990bcfmr19424002637.17.1784028710394; Tue, 14 Jul 2026 04:31:50 -0700 (PDT) Received: from localhost.localdomain ([101.0.63.168]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-311747f72a6sm95357368eec.1.2026.07.14.04.31.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2026 04:31:49 -0700 (PDT) From: Nikhil Gautam To: Jonathan Cameron Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Stefan Windfeldt-Prytz , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Nikhil Gautam Subject: [PATCH v3 2/4] iio: light: opt4001: Fix incompatible pointer type passed to div_u64_rem() Date: Tue, 14 Jul 2026 17:01:32 +0530 Message-Id: <20260714113134.3445-3-nikhilgtr@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260714113134.3445-1-nikhilgtr@gmail.com> References: <20260714113134.3445-1-nikhilgtr@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" div_u64_rem() takes a u32 * for the remainder but is passed val2, which is an int *. There is no functional impact as int and u32 have the same size and representation on all supported architectures and the remainder is always smaller than the divisor, so it fits in the positive range of int. Fix the type mismatch by using a local u32 for the remainder and assigning the result to *val2. Fixes: 9a9608418292 ("iio: light: Add support for TI OPT4001 light sensor") Signed-off-by: Nikhil Gautam Reviewed-by: Andy Shevchenko --- drivers/iio/light/opt4001.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/iio/light/opt4001.c b/drivers/iio/light/opt4001.c index 66563000d081..a0f174888384 100644 --- a/drivers/iio/light/opt4001.c +++ b/drivers/iio/light/opt4001.c @@ -173,6 +173,7 @@ static int opt4001_read_lux_value(struct iio_dev *indio= _dev, u8 crc; u8 calc_crc; u64 lux_raw; + u32 rem; int ret; =20 ret =3D regmap_read(chip->regmap, OPT4001_LIGHT1_MSB, &light1); @@ -199,8 +200,8 @@ static int opt4001_read_lux_value(struct iio_dev *indio= _dev, =20 lux_raw =3D lux_raw << exp; lux_raw =3D lux_raw * chip->chip_info->mul; - *val =3D div_u64_rem(lux_raw, chip->chip_info->div, val2); - *val2 =3D *val2 * 100; + *val =3D div_u64_rem(lux_raw, chip->chip_info->div, &rem); + *val2 =3D rem * 100; =20 return IIO_VAL_INT_PLUS_NANO; } --=20 2.39.5 From nobody Sat Jul 25 19:28:28 2026 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0703366052 for ; Tue, 14 Jul 2026 11:31:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784028716; cv=none; b=QVlLjFtaP4FEc1qz9hlRHvUkIWpidJ7fH42T0+ZBRoecKgdPbxtDQ6O0gJrXB1oaCtpJS08MtpzhxgU860aDsshgPtTGbMPHuYlktemGDFfPg2nbAHIVTN7DcYbisE/EI3/LfOfqeQOYTxzmBsYB0ygrcomQGjaePA3mQ7uvFO8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784028716; c=relaxed/simple; bh=KPEtP/l2rpCPUPVRlPtwP57praEDezWS+qamOeiLmy4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=qxpsLc6d+kDYnicaEr0D3OzCkU3NuxQGX6SLjhSHFJq+ix9yHGAST5XttqQJYqy6F1FgJGC+vrZKw4Ekxf2Oqy3FbFYXWzz9cf6YLFcY/d9eQCoJAh/9ReFN/IIMGjGOomao/GWoACGuxNtL51ztMIdc/l/N221rLhdaDGOgnwE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=f6GoyT10; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="f6GoyT10" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-3856d6fbcb3so782119a91.2 for ; Tue, 14 Jul 2026 04:31:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784028714; x=1784633514; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=jrKroNG+WUkTMMJq+n2qekfNMAfDT5ieJ4xOEkhDX/M=; b=f6GoyT10QqNY9kD0Umpap57LxORyLhUnpAaU7eMLcPyM9f0FMDVk6jznIumVchjUJ6 DTjJw0MkDmnhPYYXrqAy76f/ADk0SuOm0k0Nxsxa7Y91iSXzjNla/KUgOvu8GdN1KqX9 m5zcJtGhYCq+/zUGMdmEWawFYioUnRGxTCEdOJka6WxZ3ffg1FSB73hqcrdVltUng6vI 0nhsbGqOm2SSksoUx+XkQWG1Qp30pdjIbeNCEAxup6mOMZ+Gx0yELCiZtrpc/jara8dv AQBiXGCUdkuSL7Ai/tT3W0QofHs535cMf1xUnpMFX+NGQQyvHJK694L978vowo3TryS2 LMww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784028714; x=1784633514; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=jrKroNG+WUkTMMJq+n2qekfNMAfDT5ieJ4xOEkhDX/M=; b=dZwMesWainTUWo7YMs7Qrgo+zb4imzNDG3H/GiqEs22PbNeEmATlGZ6fbzi2GC/HJr SCkVfuETqMHQjqBX7irF7sXkFy9qqwzFJSzAssXU9mMhtPB8bPIwP17A+IW037INYS+K tZB0gnO97uw0yOobgcdALv6JA081arZ/FSYhHXSunzG71GFUg0rncbjSm4PioKAKDWLz X9D/ZxDAKKxMRpHtb/Jk0HuT91fJsRdrWqWuKt2bGFYcRH64f0pbj9ENKbwJ4i261UWV MJgdP+gB5zNsqB97FG6n0SRULPqWQu/tTHC0u65AbtV6Uk4DhSJm4x4BTE+f7/3+hND2 arGw== X-Forwarded-Encrypted: i=1; AHgh+Rrj47npUqmYCm2qh+YX8S0LwGP8BQqYl8a9Dfi6YmMza/X+o9OmjMOxWvX8buuI7eZVvy6sINvPJ3C4cs0=@vger.kernel.org X-Gm-Message-State: AOJu0YyTltcvXycf8tHAjO4zMzjZI3/MoFH/6eJrzwff54evzcMBKCEB 8sKtBLdg9BuuBiZNJbe2c9yPKP1X4d6gwFHAkM9nxHt47pDhkXFKFmo= X-Gm-Gg: AfdE7cn0C6n4Vsq4aYZ9lPA7aP2D2wBm6COtazefSAcPP0+3JT/h46Bh042iJrWm2qp 6x0l7mcDvVBv0nRgvlEolXBDz7rgT6r/xn3f1LgoxjfpiMeRrVNr9fqAmdLoBd/wUDM0m7RYOJT zfa0/MsqzdvhPTNBtd5Vq6QAnSRyVhDEasYovy8VcmnQkendGwgP0/Im+ad8HOgVJzj7Yzq6kia IyMIcgYKxpFadOn7Wxc9nRt7OMTfsDd2h2msSZJAJOP4SBjgAY0n7TazaNRG6Pt4XZQdeHJaRF0 vYdnhy7UJxPBxj2L79jAmrhuJ7lStlXI4kh58TyqtSTnn0G6oPpBtZu7uWLZJvDKyoXzPuIsaUE +6n0iXmcrQaWf++JFXYNG9rAl4FydPpkhjJTYfMrJdNFTfe9OUvzq31mo7xgzlye0ymTRkhIKWi QXMVy9wNBWXvVhJxQV+mpvzlkMuTmzfo8QT/CYjJ6sywxzsvI2FMCErhkgt33BsHo= X-Received: by 2002:a17:90a:d886:b0:366:10f1:3d91 with SMTP id 98e67ed59e1d1-38dc782c6b0mr11083125a91.1.1784028714130; Tue, 14 Jul 2026 04:31:54 -0700 (PDT) Received: from localhost.localdomain ([101.0.63.168]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-311747f72a6sm95357368eec.1.2026.07.14.04.31.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2026 04:31:53 -0700 (PDT) From: Nikhil Gautam To: Jonathan Cameron Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Stefan Windfeldt-Prytz , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Nikhil Gautam Subject: [PATCH v3 3/4] iio: light: opt4001: Reject integration times with a non-zero seconds part Date: Tue, 14 Jul 2026 17:01:33 +0530 Message-Id: <20260714113134.3445-4-nikhilgtr@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260714113134.3445-1-nikhilgtr@gmail.com> References: <20260714113134.3445-1-nikhilgtr@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" opt4001_write_raw() only looks at val2 when setting the integration time, so a write such as 1.000600 is silently accepted as 600 us. Return -EINVAL if val is non-zero. Fixes: 9a9608418292 ("iio: light: Add support for TI OPT4001 light sensor") Signed-off-by: Nikhil Gautam Reviewed-by: Andy Shevchenko --- drivers/iio/light/opt4001.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/iio/light/opt4001.c b/drivers/iio/light/opt4001.c index a0f174888384..bb4be6384e4c 100644 --- a/drivers/iio/light/opt4001.c +++ b/drivers/iio/light/opt4001.c @@ -269,6 +269,9 @@ static int opt4001_write_raw(struct iio_dev *indio_dev, =20 switch (mask) { case IIO_CHAN_INFO_INT_TIME: + if (val) + return -EINVAL; + int_time =3D opt4001_als_time_to_index(val2); if (int_time < 0) return int_time; --=20 2.39.5 From nobody Sat Jul 25 19:28:28 2026 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83F9235BDC7 for ; Tue, 14 Jul 2026 11:31:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784028719; cv=none; b=aGruK0BV3EcPaFpoFyHQDFXGLWFRzCuft2vc8hB/Un3YZeYzY6SUkS5ugUfzYxlGJetfNPDiGhsMVwGLkS7F5h6o6gCyhWeOEjIuFNXoBr/NmtxoIGY1k2IFzuWxvRQNt3fmPpXbre/pbRuPwKfDvDbn7j3koSf6wFhvqxmQnfI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784028719; c=relaxed/simple; bh=ztaah7FswqrBKYufRFLu9xEbQVZRkHu40mWNK3sBTbE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=K7ep9TRFnMCX1IMjOPD38x3GaUalQw0jK8XDZWJUgQqLmci6pVWsYK79JIFz8Rvs91Bw1rB8ZLVhoN5Ee0Jrh7avEe8nEeNfnQMBBe7qcgReNFExXmfGT5oofhCAV+Dx95NMoHCbSrbM+Lf3qe4xhvhM9cCXCpuDlbw11bqgKVM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QYdyPkWC; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QYdyPkWC" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-84a2dcec51cso2485027b3a.3 for ; Tue, 14 Jul 2026 04:31:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784028718; x=1784633518; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=QVTvsPo5yWPdElSCJe1QICilasV5G2rwHI+ghLjXid4=; b=QYdyPkWCfU+VkIUOvccwunwakrCONF2LwAWXiUaMSFOvySe+VZAZrYcNIigmaiPq5f +gPkiaE+kbqQezOJZEIR2lFJm5OOlrIjrYjNkG3HuU985zpVpA0aBCiOyIZbdVoAWlkt ZH6401kNEWuRdwRFL3TRocP7awRlB61R4TD0vFg0jxNLkImZPTggeHQt4j4BiuehHQ3i S7YPfWetgnkTRhKxNLRDZuqL9GlzoSuCfY4nysJa7jssjjmraqfofogLuVoG7nyAeYfz wdCpV/w2m+cI3LxrU3vvehiT8d2lXdBp/GjQlgVCXoPnMOild04KmeBnNjjJyswYkVwc 9C8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784028718; x=1784633518; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=QVTvsPo5yWPdElSCJe1QICilasV5G2rwHI+ghLjXid4=; b=UKfS5GSyN0+46g+m6fYLh58lrIaaw/9W6a6+ZA1M7w2Uv6dF0QQMh1YaB9DCQL9/zY l4CWawu22xWYPGkFugWMUxKf4brg+ko0RHDCC9xhUkCmajsG7acV0+gEs3DrK2kYa9fR Yndt14XitgXzwNcpIYW4qboy7UAdPCRhrfSOEJ7Z/GjrmVzHCIDfiV8dkhyhvi1ocHxU PbhnmOHKyDMucUqG8UCrDv958zNKEVXlhBZtZRIflkKlVM+RUfo8yQWckaAKrk1vQpGc VwktBZ4db2RTGYEwk1CZ+jeV1GuJv2F1fX8Uo0FXaBZdp1t+LsgFqH9TKRGMUD8QyI+k vwsQ== X-Forwarded-Encrypted: i=1; AHgh+RpUIuKLQVVG2el0fpfQCo5b1qqPIMx/EI3KctDbokAndeuI9BE1d1Zyq/xuVCzfQJeIux1HIj0f8XYdOoo=@vger.kernel.org X-Gm-Message-State: AOJu0YygsBJm2SHZphT7d8BEPRp/+FqSPk2w2Yk58QzJWnojG6GncU5J OVVlODEtD2p99THfgp2ti0s0cS81AOLnS9WM60vYJmrVW/4CiRHDx0c= X-Gm-Gg: AfdE7cl3brZyVicm7+0nSB/WTx/S3VqeMYGg4NI9qYaVP5y3OrTmF0Ewzk9DzYQ/BGW eYjlZoL8QkumOa/ly+4uzHa/Q3Liq0RHGhdwwn2iZG1AwyXY5+/9NRhCsU6b961q4xsgETHs7pA fXtX7vbIBH501J3fQ3VGOkyisEt9Qi/GAXlLgGBImvMZvTrIq7jlcPysrYGt+3TXZHdNjA48Mhn T0Brmh2mjdh/JUnuePQ0fscy2Ug/WNWiENgjZrEOtkWdGiCQJJdxJDQuK+x8q/qMu/Eh/ew6Yah c9J62haAjSqRYbWSuh456dGIDvOVQ329K9pH9sSoLExTel1vdvWbs5zANIhXQCYyCs2V52iQvc9 6at8tm7t5cyDSPKsMTcBAGsaakmJTU0sfmjgapa1Uc7oXQL+aQ15ioRwBuzBgmIRqvmu4ymuMGH XdIR1247JrCrw/coSC54ZLoBfjwGWX3+T0ijm5IBF7xbkrVYvWbcJv X-Received: by 2002:a05:6a21:7a8b:b0:3bf:9aa9:b2a4 with SMTP id adf61e73a8af0-3c357395a06mr2281496637.20.1784028717926; Tue, 14 Jul 2026 04:31:57 -0700 (PDT) Received: from localhost.localdomain ([101.0.63.168]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-311747f72a6sm95357368eec.1.2026.07.14.04.31.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2026 04:31:57 -0700 (PDT) From: Nikhil Gautam To: Jonathan Cameron Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Stefan Windfeldt-Prytz , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Nikhil Gautam Subject: [PATCH v3 4/4] iio: light: opt4001: Fix reversed GENMASK() arguments in fault count mask Date: Tue, 14 Jul 2026 17:01:34 +0530 Message-Id: <20260714113134.3445-5-nikhilgtr@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260714113134.3445-1-nikhilgtr@gmail.com> References: <20260714113134.3445-1-nikhilgtr@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" GENMASK(h, l) requires h >=3D l, but OPT4001_CTRL_FAULT_COUNT is defined as GENMASK(0, 1). The define is currently unused so there is no functional impact, but fix it before anyone builds on it, and add the _MASK suffix for consistency with the neighbouring definitions. Fixes: 9a9608418292 ("iio: light: Add support for TI OPT4001 light sensor") Signed-off-by: Nikhil Gautam Reviewed-by: Andy Shevchenko --- drivers/iio/light/opt4001.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/light/opt4001.c b/drivers/iio/light/opt4001.c index bb4be6384e4c..731eb8d7326a 100644 --- a/drivers/iio/light/opt4001.c +++ b/drivers/iio/light/opt4001.c @@ -39,7 +39,7 @@ #define OPT4001_CTRL_OPER_MODE_MASK GENMASK(5, 4) #define OPT4001_CTRL_LATCH_MASK GENMASK(3, 3) #define OPT4001_CTRL_INT_POL_MASK GENMASK(2, 2) -#define OPT4001_CTRL_FAULT_COUNT GENMASK(0, 1) +#define OPT4001_CTRL_FAULT_COUNT_MASK GENMASK(1, 0) =20 /* OPT4001 constants */ #define OPT4001_DEVICE_ID_VAL 0x121 --=20 2.39.5