vdec_probe() maps any devm_clk_get() failure to -EPROBE_DEFER. This is
incorrect because devm_clk_get() can fail with other error codes like
-ENOMEM or -ENOENT (clock not registered). Hardcoding -EPROBE_DEFER
masks these real errors, causing the driver core to retry probing
indefinitely instead of failing early.
Propagate the actual error value using PTR_ERR() instead.
Signed-off-by: Alfie Varghese <alfievarghese22@gmail.com>
---
drivers/staging/media/meson/vdec/vdec.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/media/meson/vdec/vdec.c b/drivers/staging/media/meson/vdec/vdec.c
index a039d925c0fe..fba1e7f88d81 100644
--- a/drivers/staging/media/meson/vdec/vdec.c
+++ b/drivers/staging/media/meson/vdec/vdec.c
@@ -1026,24 +1026,24 @@ static int vdec_probe(struct platform_device *pdev)
core->platform->revision == VDEC_REVISION_SM1) {
core->vdec_hevcf_clk = devm_clk_get(dev, "vdec_hevcf");
if (IS_ERR(core->vdec_hevcf_clk))
- return -EPROBE_DEFER;
+ return PTR_ERR(core->vdec_hevcf_clk);
}
core->dos_parser_clk = devm_clk_get(dev, "dos_parser");
if (IS_ERR(core->dos_parser_clk))
- return -EPROBE_DEFER;
+ return PTR_ERR(core->dos_parser_clk);
core->dos_clk = devm_clk_get(dev, "dos");
if (IS_ERR(core->dos_clk))
- return -EPROBE_DEFER;
+ return PTR_ERR(core->dos_clk);
core->vdec_1_clk = devm_clk_get(dev, "vdec_1");
if (IS_ERR(core->vdec_1_clk))
- return -EPROBE_DEFER;
+ return PTR_ERR(core->vdec_1_clk);
core->vdec_hevc_clk = devm_clk_get(dev, "vdec_hevc");
if (IS_ERR(core->vdec_hevc_clk))
- return -EPROBE_DEFER;
+ return PTR_ERR(core->vdec_hevc_clk);
irq = platform_get_irq_byname(pdev, "vdec");
if (irq < 0)