From nobody Sat Jul 25 20:48:39 2026 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 217B326F2B0 for ; Mon, 13 Jul 2026 17:16:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783963008; cv=none; b=J6Gm+l+zlT9H0Z+csFlIpk7FmpxnoaF/F8Ezjr8UAgU9d1vXb0/ewdtvQ8sFKtr4kMB+qEZ9QfXmpDLi4UDN2MwrrCCYCKJxVSpmaXvn0FDQkZLOcCH3dTUrrLQX1EE+iu22l5D3JJa9tEWysELN3KupX7Qf97EDGzcaYUxhxyQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783963008; c=relaxed/simple; bh=DtDlb4T/GlICkbzrC4fhGZYL7BcVSaw/4uXDAPCLN2w=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=YnKph5iWqRGN5yT7G7lKeMF8Ky3Kc/dwkx7KCsFV4WmAa5HYksgoE8lP5AUC9E95t4qTiRQB5vU72gH4af256jf3pa1ChHgzldAM+ngA6HscASW9pdjUUCSEetza16FlTlHCZ15HARO7YpdYbe4AcKzy3I9av58Lko6FTATtl8I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Lr2RXsZd; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Lr2RXsZd" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-381216921aaso3778620a91.1 for ; Mon, 13 Jul 2026 10:16:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783963006; x=1784567806; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=r8F7PDpBGQrWy7oTUa6pu42Pf+937GWEA5yn0veEyiU=; b=Lr2RXsZdvxSUVYKcfulvklbhUhu8npH2JQEUKC5yPf7ItCmPWvG3NXopB+af24s5a+ UapGKAJx77a0jjFjn+yJiK5keNGj8WSeZYV2tu+hZ5+dCLl3TqT3eYcRforF9l/2ThJZ Dtqe6XIVTNdgApjtcwfskrTA7fSqKXipwOeTxuYvdGKnbG64v0Jbs6UDDTQ4mfMLRHu8 Ar7wm9RZqi3nzFmbOxVlQ9iStLoifVn0ti9NtPYMW/If2NdNYy49wI+fN+tXTgj1unjb o4g1WcaX8Dbu5nbrdhX1qH+fS65O0licOdDXRvwaLd8xePSDKAvBrEc+uzCtOdsIwdRr fdlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783963006; x=1784567806; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=r8F7PDpBGQrWy7oTUa6pu42Pf+937GWEA5yn0veEyiU=; b=BUhKmsVqlGCSRFDIW1t0IlMNcmRmaKIV387fJSxIjn92PiGQZOujXxEu179F8nG2KL fVDw0vuvspjgGsztl1LvEVe3yeFJrMJBx9Otkj8vRkUIHC5Q8sISEhRhldxxECwAQTH3 GBr8+PJ1mmtet2BL4XczJd8e4T9n8uv989JVxMjLD+PKFU/CddPkuCkRQC4FxQdjifIi CaX/5NDUWv7JwhydgUj8/I2IcRje02wMpvwMS+yeiOmLO2cobIL4hehbyWaRtCpozd/u QNRxqSyJBfjsjux6nfzvbjiox+lII/34siRIZa7ivqiiQzgJT5mctMJgnd/fAu1829RP abBQ== X-Forwarded-Encrypted: i=1; AHgh+RqnxGRIDKz2x9/UDbv7B3x02yMJCsO3+JjaJi4FdwRXz6HKJjmrL1rcI4vfm/UV2XBormzAbJ3KMDpiJjM=@vger.kernel.org X-Gm-Message-State: AOJu0YxOFRxj5RQN1Ga00o0at7I/v3qRBsdqgme7jGUjn05e31dIkUbi VBQVD1eq/9500lMiDlcYWCiFimhXM/7ltDF6Wbqdt58vdFuJP346O+l6 X-Gm-Gg: AfdE7cmKih4UIN7ExHOFTiLiR9B8l86Cujo7pUBrY1JzwF+MnRpsD6W9HIF4qN7pL/8 wxuXCDJ3E2cItWSHmV3BnlML4Ijnsx5VcGuS+nvnUNjkXXZmfnzLhJtQ9wVUhcMZAY+2iyga5G+ E15XiGMagtiLEP6AoVnuU6urzfNKQYy/WZrtksdixi+kpfK9Ggsj/t/tXaHtDW+hqvpJBzb9h4u V0VWAsQhuUc3A0qkxPv3yPTs4/dP54TqMhuE613Z+3iE1rIV5h+HZ7vu6q91VIiRK0qtGArVn4K xGQ4gWf2Xf3AzsUk9iYjukViTJc1ShtWBW4OfBiqrTU3HDR3wdYRvWkk98yO6K7uJwwtPiaegLF JS+RSI5V7jJQ7bBXTnQ1vLJD+QeObOxHFevLb9XA++3w6c70OKgxDvF9KAaYTZ4/bnUQcHk85cq TV3kqypxWSm14vO5Ez8McgX3BOMQf/mvgSjrGAewqoFlWZP4gIZMuMzZQx/dyFNZrsqNc2yZYDh LCOHoc3EhHVdPTfi7MqJ0grcxs2Oh3SWcJ3j7CJxky1mQ0= X-Received: by 2002:a17:90b:58ce:b0:381:152b:d596 with SMTP id 98e67ed59e1d1-38dc74cff62mr9789745a91.11.1783963006364; Mon, 13 Jul 2026 10:16:46 -0700 (PDT) Received: from OMEN ([103.184.238.250]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-311a6115e61sm55281016eec.22.2026.07.13.10.16.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 10:16:45 -0700 (PDT) From: Alfie Varghese To: neil.armstrong@linaro.org, gregkh@linuxfoundation.org Cc: linux-media@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Alfie Varghese Subject: [PATCH] staging: media: meson: vdec: propagate devm_clk_get() errors Date: Mon, 13 Jul 2026 22:46:44 +0530 Message-ID: <20260713171644.691-1-alfievarghese22@gmail.com> X-Mailer: git-send-email 2.54.0.windows.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" vdec_probe() maps any devm_clk_get() failure to -EPROBE_DEFER. This is incorrect because devm_clk_get() can fail with other error codes like -ENOMEM or -ENOENT (clock not registered). Hardcoding -EPROBE_DEFER masks these real errors, causing the driver core to retry probing indefinitely instead of failing early. Propagate the actual error value using PTR_ERR() instead. Signed-off-by: Alfie Varghese --- drivers/staging/media/meson/vdec/vdec.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/media/meson/vdec/vdec.c b/drivers/staging/medi= a/meson/vdec/vdec.c index a039d925c0fe..fba1e7f88d81 100644 --- a/drivers/staging/media/meson/vdec/vdec.c +++ b/drivers/staging/media/meson/vdec/vdec.c @@ -1026,24 +1026,24 @@ static int vdec_probe(struct platform_device *pdev) core->platform->revision =3D=3D VDEC_REVISION_SM1) { core->vdec_hevcf_clk =3D devm_clk_get(dev, "vdec_hevcf"); if (IS_ERR(core->vdec_hevcf_clk)) - return -EPROBE_DEFER; + return PTR_ERR(core->vdec_hevcf_clk); } =20 core->dos_parser_clk =3D devm_clk_get(dev, "dos_parser"); if (IS_ERR(core->dos_parser_clk)) - return -EPROBE_DEFER; + return PTR_ERR(core->dos_parser_clk); =20 core->dos_clk =3D devm_clk_get(dev, "dos"); if (IS_ERR(core->dos_clk)) - return -EPROBE_DEFER; + return PTR_ERR(core->dos_clk); =20 core->vdec_1_clk =3D devm_clk_get(dev, "vdec_1"); if (IS_ERR(core->vdec_1_clk)) - return -EPROBE_DEFER; + return PTR_ERR(core->vdec_1_clk); =20 core->vdec_hevc_clk =3D devm_clk_get(dev, "vdec_hevc"); if (IS_ERR(core->vdec_hevc_clk)) - return -EPROBE_DEFER; + return PTR_ERR(core->vdec_hevc_clk); =20 irq =3D platform_get_irq_byname(pdev, "vdec"); if (irq < 0)