Qcom PCIe Root Ports advertise the Attention Button Present (ABP) bit in
the Slot Capabilities register, but the slots have no attention button.
This causes pciehp's pcie_enable_notification() to enable the Attention
Button Pressed interrupt instead of the Presence Detect Changed
interrupt, so presence detect changes are never reported and surprise
hot-plug detection does not work.
Patch 1 renames qcom_pcie_set_slot_nccs() to qcom_pcie_set_slot_cap() as
a preparatory, no-functional-change step, split out per Bjorn's review
comment. Patch 2 clears the ABP bit.
---
Changes in v2:
- Split into two patches (rename as prep patch, ABP clear as the fix)
- Added a blank line before the new comment block
- Kept Konrad's Reviewed-by/Tested-by only on the functional (ABP) patch
- Link to v1: https://lore.kernel.org/all/20260710-clear_abp_0710-v1-1-efd63ebdaa09@oss.qualcomm.com/
To: Manivannan Sadhasivam <mani@kernel.org>
To: Lorenzo Pieralisi <lpieralisi@kernel.org>
To: Krzysztof Wilczyński <kwilczynski@kernel.org>
To: Rob Herring <robh@kernel.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-arm-msm@vger.kernel.org
Cc: linux-pci@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Qiang Yu <qiang.yu@oss.qualcomm.com>
---
Qiang Yu (2):
PCI: qcom: Rename qcom_pcie_set_slot_nccs() to qcom_pcie_set_slot_cap()
PCI: qcom: Clear Attention Button Present in Slot Capabilities
drivers/pci/controller/dwc/pcie-qcom.c | 16 +++++++++++-----
1 file changed, 11 insertions(+), 5 deletions(-)
---
base-commit: 3edb3a038d423480efeb204dbc6ddc9a292f8ecb
change-id: 20260712-b4-clear_abp_0713-d424da4dad3c
Best regards,
--
Qiang Yu <qiang.yu@oss.qualcomm.com>