From nobody Sat Jul 25 21:59:35 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18B8439060F for ; Mon, 13 Jul 2026 07:43:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783928585; cv=none; b=e3eG2TQpXgT6Xxb0W/1u/8UsIImpx6nYhDChHGWd7Ui6DCj6QJ9+jfaQeJMDLnAK1SeSSe35G9+gpdHdCJ+4yvWPVOO18Ly6BgCha40M28q94NQNitlK66Qq6h/lR2yWgMAtgXIUUAMpscjyoFOAmm9SepIu+AGLxveQcG05Dhc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783928585; c=relaxed/simple; bh=KGHvR2+JEE8fe51pL4GYOFt+Id/vPIyh/xzYWv60Bh4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CmTeim5+Ik57SBtCxiMVfzojv5YXCpKZlLhsZJc/7L8fOE0q5PiPJiQXAsn0yl+YreBl5LoEVnvIFP+5x/bFiwyXLVBZxhn12/eG9dkfYWM1q3brRqf4UVYsz3gCEo4ivRdpNAt7AAYk1xo+wOrfesfRePmOT5ltLbIVcPn7s6U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=I1HExbe2; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FsNNPdVW; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="I1HExbe2"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FsNNPdVW" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66D6NhmK648375 for ; Mon, 13 Jul 2026 07:43:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= MbgEqLMqAoeF/SF20KCGOOd7+BYZvWxnSyKnE5SbO3k=; b=I1HExbe2oI6F4tjZ yA/YVR2bi71XOqGawPGg2yFEHsImC0o4amhihZehMxPrKiCihtConvCuOV4Vfx4+ udxB+fIS4J9ZQxIcMBluXf7Kr0sbvmENI/puBFi3PvGVjyzyuu6XlyENRQX6OjlP UH8VSqZxgakBC3GSitcA0PELwY/URTr8cMzdFdzRTppJR2kZWG5ytyt60744Y7tu Z7rvIeJOq6UGh//b+O3AtrLjEBG0zpXAiV6UuX3MSwdPlk6Sy4/8IfEcTMhmYZPB ibzAu0RcPfb06tNZ/PpQFjGVfDv21pW7NnXgLptBmM/KeBvA9CiktZAS7Q6VdE7v uD91Dg== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fbebr4wuh-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 13 Jul 2026 07:43:01 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-c89704da8c7so4506442a12.0 for ; Mon, 13 Jul 2026 00:43:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783928581; x=1784533381; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=MbgEqLMqAoeF/SF20KCGOOd7+BYZvWxnSyKnE5SbO3k=; b=FsNNPdVWTyqwLsDcp40QFeXiwlTlGiLvjJSXFvGD+sNW/S2aKqz4lGCPl1fOVGcbrV azb0Qx2Wx7MdDzJq5h6C0lokf0B1DZ/AxQFHzIDSqmCXaRmD8WLeRd6pTgVlOS7U6+/b O3sm8CQ6wUSMTbjMslJXScRjEUXu1/sg0CnPwnQX/9FKCwmdmnoxkol9UlyhHV6ddTwg jhUm8UnmZ0hvyKjyGYbDwo/EcDiG2M5UlEkBW1NY8iipaCViO+MHcBi9hzuvGV3T0oJs 5OKEwkSZCSHUA/CUKVM77u8qn1LmYUNqXCZIjAD30Ggl3m+e7Tc6Iz/DqZu4+6TCg16A Zjsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783928581; x=1784533381; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=MbgEqLMqAoeF/SF20KCGOOd7+BYZvWxnSyKnE5SbO3k=; b=S/tUseOcTESImS4cduz9whbB7F4JwqoeD10+UtSjriGptNl2ZY22BHRf9+tScaUdXz r8q6gWa5xYScJbcTBwjL9Fi2T0/d5ydtxpjxjuIVArGpuBLImpp3SIjzIjL+Ge0Eeo/t ydF2mNPrVgh85lGBMExOQPSQsPEDv7WP0h7DZeaVr6X0b4SkzWeapi+6MNWMGF/YN+Is kOUVuxg90qyrtU2Bfgi11AAO/JHI8NP6/ZkSCcWg6CA2yGlozWc7QDFEBbbwEN1d8OQK Ob4InClaPWim7qcq7T70jKI2vY33O/DI0IlBuzK6hA+Tn1Go6lN3AOrgIRWxvslVOzDw /L8A== X-Forwarded-Encrypted: i=1; AHgh+Rou+YW9rl1l9cWQbIUqu5/saGVXL+V6Bw94XdGNnqG5URt6Kbse3REjeWb1tsTw0Aqi+d8jomKX48Qyzwk=@vger.kernel.org X-Gm-Message-State: AOJu0YxLIFauOOhZBQbe6rGzNAYQorWUmu2FHeIX1UwWxbweAWM2/O0H /QqATlq+XpQTTfhB70PBR4fO3UdDZK4IZzw8Vn3CsvVXRukChqG5zV/nDpZR8xFEJgpkGLSEgvT teHS2fLs45P+oN+NP2LOYwi9VfcfUnLOnPoitnrDrieR2bbZ6nI+bpkikKWr7LA0jOBw= X-Gm-Gg: AfdE7clwtR6Micc1aD0fvWpMUiPZSLaJ1LjAf8TKccidDtGvKHAfKvtp1PQwPGsflgW pjOlurPuNnjRzXNUBzKItWMkJ4/78p/PA7FtfPRnF+IyNxQvi+xriXY87dijAgu3Qcua/vGbF/S vNDXXu9MqcIpZwdlA1m3tQW8iKv8ORN8w3R4Foi7HpurQCm8LaO09KueB4fGyowG/dGAhPv3IvL 8n5QLv2OcpXKF+vsi18etvplrofSjBtZwF7rMADgXmfnh8wxBEIjLgQ9SA1U4EmyxQPNncVrr30 ifJWdtUt9j0wf9DlwcMykgM9IdzThzv49aZbwpW+bMSyDXc/HzufeH44/jCraoWMKrwhpRisIkh fgu3pMi+0zu5sjNuWywltNWx/P5wx5u7dJfKBmEtcSOSFhtvFSqqjElbpSA== X-Received: by 2002:a05:6a21:6497:b0:3bf:64cd:c45e with SMTP id adf61e73a8af0-3c11076511dmr8953113637.4.1783928580669; Mon, 13 Jul 2026 00:43:00 -0700 (PDT) X-Received: by 2002:a05:6a21:6497:b0:3bf:64cd:c45e with SMTP id adf61e73a8af0-3c11076511dmr8953087637.4.1783928580257; Mon, 13 Jul 2026 00:43:00 -0700 (PDT) Received: from hu-qianyu-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b659d87a2sm61329797c88.13.2026.07.13.00.42.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 00:42:59 -0700 (PDT) From: Qiang Yu Date: Mon, 13 Jul 2026 00:42:50 -0700 Subject: [PATCH v2 1/2] PCI: qcom: Rename qcom_pcie_set_slot_nccs() to qcom_pcie_set_slot_cap() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260713-b4-clear_abp_0713-v2-1-4f0333a98d4e@oss.qualcomm.com> References: <20260713-b4-clear_abp_0713-v2-0-4f0333a98d4e@oss.qualcomm.com> In-Reply-To: <20260713-b4-clear_abp_0713-v2-0-4f0333a98d4e@oss.qualcomm.com> To: Manivannan Sadhasivam , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas Cc: linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Qiang Yu X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1783928578; l=2114; i=qiang.yu@oss.qualcomm.com; s=20250513; h=from:subject:message-id; bh=KGHvR2+JEE8fe51pL4GYOFt+Id/vPIyh/xzYWv60Bh4=; b=i5qguIzH2Ol9/nNf4c3t73N3AmgQyAC4822HCYx3Nt5goQl/HCe8AhbzBCfNgB2EDbEIJkFR3 +7NUGW9l5+pATXjiv9e1t39R0QJxvAbBfPtOnQQ+k+GF57u8/php4Mx X-Developer-Key: i=qiang.yu@oss.qualcomm.com; a=ed25519; pk=Rr94t+fykoieF1ngg/bXxEfr5KoQxeXPtYxM8fBQTAI= X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEzMDA3OSBTYWx0ZWRfX0JEhCY9dgota OdP/N66l1ivE/qQrCiyjLhATBRFs7QygGgvPPZvy6t609bzgo3ScAiu2IxcVyVVf3ivlmWnTBrC zV0G627qiE9SOoK/ZRQYBtAmonhKknw= X-Authority-Analysis: v=2.4 cv=OK8XGyaB c=1 sm=1 tr=0 ts=6a549705 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=UWWLHM8_V65xiIckHG4A:9 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-GUID: ZgRcO6l0UF8K8SwINdJZRg51LoU1Oxtc X-Proofpoint-ORIG-GUID: ZgRcO6l0UF8K8SwINdJZRg51LoU1Oxtc X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEzMDA3OSBTYWx0ZWRfX9Kl1+sGqJR5Y A9j9XAx4om4acw76xfmQ2m1Z5aRjUxiIUMmWtFb5UUeGcM44XV+rpOw+xxgW94e4PrlTS9JwksP eaSKdjDMKrI3qmxb8SfD7iMdhWBowzCwFtt8KHqtPtBFQo2wPCnxVjFCV9zqQ+H4yo5g3QXWZAp KfmPMwZ53HRSnq+grc5BKdbEcQ//Mb/y75N8pP20QDYPQP5j1a6qcaXDjwQ3AKyBawvw4XCG7+5 vQoMgdJnpwbBH7mg2IIiwNThgUx11KQ4eawvqnEm9k2Ytku5FDZuwoWrFQ0MpoAYiqmXSb2AWrZ +7T0Q+3Cppx9igBCNa84JjP+mt9AcxUrNhnS+Fw0r965PljoKAN//5DzHQFdZxzgI2QTamNj7hL C7kHSjbKxxlrrM+cNH2XBpm9tVppxLgs2eLSpyLCbArwaT+936cjH548jpgWsCRI7nyZHdcoRCp 6Upsx4wpUogtxHS+i1Q== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-13_02,2026-07-10_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 phishscore=0 spamscore=0 adultscore=0 clxscore=1015 impostorscore=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607130079 qcom_pcie_set_slot_nccs() currently only sets the NCCS field in the Slot Capabilities register. A following patch adds programming of another field in the same register, so rename the function to qcom_pcie_set_slot_cap() to reflect that it configures Slot Capabilities as a whole, not just NCCS. No functional change intended. Signed-off-by: Qiang Yu --- drivers/pci/controller/dwc/pcie-qcom.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controlle= r/dwc/pcie-qcom.c index b193c989b2b8..465c940109a7 100644 --- a/drivers/pci/controller/dwc/pcie-qcom.c +++ b/drivers/pci/controller/dwc/pcie-qcom.c @@ -358,7 +358,7 @@ static void qcom_pcie_clear_aspm_l0s(struct dw_pcie *pc= i) dw_pcie_dbi_ro_wr_dis(pci); } =20 -static void qcom_pcie_set_slot_nccs(struct dw_pcie *pci) +static void qcom_pcie_set_slot_cap(struct dw_pcie *pci) { u16 offset =3D dw_pcie_find_capability(pci, PCI_CAP_ID_EXP); u32 val; @@ -580,7 +580,7 @@ static int qcom_pcie_post_init_2_1_0(struct qcom_pcie *= pcie) writel(CFG_BRIDGE_SB_INIT, pci->dbi_base + AXI_MSTR_RESP_COMP_CTRL1); =20 - qcom_pcie_set_slot_nccs(pcie->pci); + qcom_pcie_set_slot_cap(pcie->pci); =20 return 0; } @@ -660,7 +660,7 @@ static int qcom_pcie_post_init_1_0_0(struct qcom_pcie *= pcie) writel(val, pcie->parf + PARF_AXI_MSTR_WR_ADDR_HALT); } =20 - qcom_pcie_set_slot_nccs(pcie->pci); + qcom_pcie_set_slot_cap(pcie->pci); =20 return 0; } @@ -759,7 +759,7 @@ static int qcom_pcie_post_init_2_3_2(struct qcom_pcie *= pcie) val |=3D EN; writel(val, pcie->parf + PARF_AXI_MSTR_WR_ADDR_HALT_V2); =20 - qcom_pcie_set_slot_nccs(pcie->pci); + qcom_pcie_set_slot_cap(pcie->pci); =20 return 0; } @@ -1078,7 +1078,7 @@ static int qcom_pcie_post_init_2_7_0(struct qcom_pcie= *pcie) writel(WR_NO_SNOOP_OVERRIDE_EN | RD_NO_SNOOP_OVERRIDE_EN, pcie->parf + PARF_NO_SNOOP_OVERRIDE); =20 - qcom_pcie_set_slot_nccs(pcie->pci); + qcom_pcie_set_slot_cap(pcie->pci); =20 return 0; } --=20 2.34.1 From nobody Sat Jul 25 21:59:35 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6DD13914E0 for ; Mon, 13 Jul 2026 07:43:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783928585; cv=none; b=tRaYoBJrDQXIBVcrs1krWjJfIwK1VbsBr8jebOdEeQFJQhQrMG/NkIIua+oGyO+uiySEu9SrM7yX2i/mAai7Ub+35jrPYEffDNrTLv4FERXvjnMPZBgc3G0hEKsTW+K1WkMieKsba+nQ/BKi9yVu5ySNgfZqmsMz4OIw5Z2NgDU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783928585; c=relaxed/simple; bh=MYmlLT8ThQGLNwyV/BC1KUqTtU7yI19YSWTO28NshSc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=e3+tv+1jWnyBfudKarKdzWr5WVxXZbjbLWkt8Tdk2Z+xynlE5J0s7u7nXaW2c9uahwlELrZmyKQF19Qbp4TYEOulS0Irqp//n8Gnyl88cVefTxjbNrN3Gtq9kvEaf5aiMWXPsY2BInq9eKTvZaAHRXB7GiF7ICB8bbz0kghMCz8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GKNpjax2; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Rs0cxEb0; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GKNpjax2"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Rs0cxEb0" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66D6O7AP473551 for ; Mon, 13 Jul 2026 07:43:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= aWJFgQziladGBTw3u8LccKLmksdh3iW/fQSBcWMufXg=; b=GKNpjax2+eMcCj6U zTU6e0ImgTSsAl4ulwMAGQQDKuf9m6bT/M+07Y9HPwtOOB+738DBrehrzI7N3XWI r1+fUGF9+e/aS8ROz6Gr1+kshQ3K3qPyTNnM3y+Mg1at7z3MlsV+bsp5P7wT+3PY xp4zmCPZdKvhfIGpSG6WehyqhZyHc7ntqlFRAXKoNyI3DrGOkTnH8cBncQrSGQ/2 u/Ub+DDAAVdh86x7/QZEiq59FVlviZDhttbNm8TMN1tNLrY93eyjuIlXfXifoBSG utp3oYW4RYWqq+JYgLj2apmWKTbcXdjX5vaVmlbwnX3Nud9esE/trjI4khmb3bNL OSTkQg== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fbee9n34y-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 13 Jul 2026 07:43:02 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-84a251c2e3eso1242056b3a.1 for ; Mon, 13 Jul 2026 00:43:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783928581; x=1784533381; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=aWJFgQziladGBTw3u8LccKLmksdh3iW/fQSBcWMufXg=; b=Rs0cxEb0sOPa64DtBo5r0lPjcEYsruma+aVbwuJd8Jx6VUEX1igMFWdiCQDEqcixMI gFJSV3dXqoDHbWKal79WfsUSw5QxlJK9mvid22VMqFFweim3i2i2z5fQ2/PwqYt1tCun 95Es3h/K3hCSklOiAES3wq4SqXa+RtKvCY9WVg0PT9ynTW81xCUo/eVid3l874KCD7E8 ZSaK2TkTxe4pZ+OpJURyqzo7HeZid7coHACZKxnSInsVC6IukaNDLMQz1Rjlvuop6g+V y5k6hPw2YJKLv8SdSu6QuoNslzNWJrnjQhR8PZhGTbCy1Menx3+XWZHKdnkpAL8pARo3 U3Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783928581; x=1784533381; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=aWJFgQziladGBTw3u8LccKLmksdh3iW/fQSBcWMufXg=; b=Ax7eY0P63Xqa/he6Uu4d3LsVb7CPC4BPbDmpQl5lZXPGzKjRPqU7MdDPJm7GcJXcld 0UIiUZB7yN9NsRtkMy+YkwWANTUvYumv4LsQnr2X7vf1DfazwpwAw+2aZBfFN6+pmf8i Wn3l/ZIUFSB05LN6ht1CNSIwgBwwcihC+cdPsshW+J6Le5xl5FUczKhlVjW40w3tIOnZ Tgh/z5j/VFk7CYBqIPnQu9BfOF+tReLHdqh10I3tFJQZX2OyA8B6RoODX1rnORxJPDfR vHVf+Dnc1NswmEnXDuHoDJmqp7R5QX15F3W1Ld2mjngYLNw9ejKG4gv2K0L2SQegMsy+ tN8A== X-Forwarded-Encrypted: i=1; AHgh+Ro/gfWcWL27n3CRgThUtGzM247dL4kIr6FRuaRVsjOjr7Zu1vnLgr1UP9z8R6DO2AkmLm2aN/28X8Hf2Hw=@vger.kernel.org X-Gm-Message-State: AOJu0YyTi2aKapbcJ3OjFVw1MTdwFGCPCD6wplqk7y7AANvCgHERZdPn feW2KeDgxzgqz2cuDLZYGMKvYedU4NNl07nvgcPfhNv2kQVnFOv/8cWYthk7yolApFHw+o7IzRO p1ocJsAnwEDVetSgIDbvuyvNNSrbPRBxfUOIXmD8eKLuyxLUSKzhY/vcUjqRCXIkGlvg= X-Gm-Gg: AfdE7ckYbsyD6sAM6rllHYlC1uyUjfPJl7dnQ61Y0BfGJ2uSZ5Yr2kNL5ODANDky1pJ 76PGBe8uqE3z0vd22N+sK1ffvUjj6pLGrp4jtG8aNvqWe1zR3npQY3s0gij17IKYWcqNVHSLdqH LzZJf9y9RP+5Sx6IiM96Qc/FT/kO55JSVmt67mD+2iB7Z7q3LCNES9vuGHbl9AXAafMukp6A5qx T08vQ79R41kafbULOdW8Zs/Js/idheGhMNKNo3oN79KRu6hy+HAb/OyuDI+MDODdPx5OR7R/j1z c47YjH4ork5SSMmqAjgJn2iX6t0MNHifh4n8NZm/u8IshjeFbXrIeIiaZr7g4Uz8c8R3Hl1bf1G 7kwABkOnE6mSCzRULqKibvQlyoQk/wLQVnjJe/hJNAV81+wA0yBbtpu+9Lg== X-Received: by 2002:a05:6a21:50c:b0:3c0:9acb:3fc with SMTP id adf61e73a8af0-3c112e077b1mr6962666637.33.1783928581573; Mon, 13 Jul 2026 00:43:01 -0700 (PDT) X-Received: by 2002:a05:6a21:50c:b0:3c0:9acb:3fc with SMTP id adf61e73a8af0-3c112e077b1mr6962653637.33.1783928581158; Mon, 13 Jul 2026 00:43:01 -0700 (PDT) Received: from hu-qianyu-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b659d87a2sm61329797c88.13.2026.07.13.00.43.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 00:43:00 -0700 (PDT) From: Qiang Yu Date: Mon, 13 Jul 2026 00:42:51 -0700 Subject: [PATCH v2 2/2] PCI: qcom: Clear Attention Button Present in Slot Capabilities Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260713-b4-clear_abp_0713-v2-2-4f0333a98d4e@oss.qualcomm.com> References: <20260713-b4-clear_abp_0713-v2-0-4f0333a98d4e@oss.qualcomm.com> In-Reply-To: <20260713-b4-clear_abp_0713-v2-0-4f0333a98d4e@oss.qualcomm.com> To: Manivannan Sadhasivam , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas Cc: linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Qiang Yu , Konrad Dybcio X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1783928578; l=1446; i=qiang.yu@oss.qualcomm.com; s=20250513; h=from:subject:message-id; bh=MYmlLT8ThQGLNwyV/BC1KUqTtU7yI19YSWTO28NshSc=; b=z3ZkILMCnLB7e6E16R7obZNqsIMcdw37AAYKgycR9RUPbAY4yKc9xY9dlF37aojRYiO6oErzQ E41YQhmcLrZCDT/SsTyc8qXzZZWVYYJPdJpQzQEalN5Wl2GkSyUubyO X-Developer-Key: i=qiang.yu@oss.qualcomm.com; a=ed25519; pk=Rr94t+fykoieF1ngg/bXxEfr5KoQxeXPtYxM8fBQTAI= X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEzMDA3OSBTYWx0ZWRfXwTQe6RMYvWwO fXIB4+fICC+ViH9RIHPGdaA+fX6LKcyYCPQsrkjkuhKohNeOz7kGD+Ye6Dti1boF2m77S8OL0bX OJfZLarXiOvxauJxaPu/5MRwGWLpVYY= X-Proofpoint-GUID: v4GiCFwBG6S8FXKTp2nEjVk9Q_x6e-mO X-Authority-Analysis: v=2.4 cv=a7UAM0SF c=1 sm=1 tr=0 ts=6a549706 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=OhjUHQ0J9wk2a2_2EIIA:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEzMDA3OSBTYWx0ZWRfX8M4eAvz6pRbf hXkmOJgCarH80Vog/CPiEn65JFJKGhNLX/4KULMTpyyvztHP15nSk73ApXNlTPVYjFPmlE3ErY8 ZdvVigqhXDoLt3aYFBYDCJHivPC+YfvwCATAE+2s/FMLBHKAjvv+6hcnTY7QLfJUZeOX16HzcFI qYW0oZwERWFyPX9dsaX95vOvYpbPxwAyVWSMnz/sXajHiZTPUrkornD7IKw4y5y5V2NPERYum5d 03zeh3qR2KxN2gpzqKl7TNq7BuoHdiTenYe2Vx6ut7PXodtlEV2DWXvMGppHjPnf1DSV13rab/P YiZf12qME3fjmsU0gvbBENEbpjAZOv7bpF2LhXFPtAIecL8BQ06u4H22uaHx0izF7KBU5e7FTAp X/QjBByG81uGG8VKaCGN9TqKJHRob1edD+qulNSzmE9M6j/gU1F5LWBVHAufaCcnuCUuW13UNSt spWQDW6pOptWzUu/vPg== X-Proofpoint-ORIG-GUID: v4GiCFwBG6S8FXKTp2nEjVk9Q_x6e-mO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-13_02,2026-07-10_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 phishscore=0 priorityscore=1501 malwarescore=0 adultscore=0 clxscore=1015 spamscore=0 suspectscore=0 lowpriorityscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607130079 Qcom PCIe Root Ports advertise the Attention Button Present (ABP) bit in the Slot Capabilities register, but the slots have no attention button. When ABP is set, pcie_enable_notification() in the pciehp driver enables the Attention Button Pressed interrupt (ABPE) and leaves the Presence Detect Changed interrupt (PDCE) disabled. As a result, presence detect changes are never reported and surprise hot-plug detection that relies on Presence Detect Changed events does not work. Reviewed-by: Konrad Dybcio Tested-by: Konrad Dybcio # X1E80100 CRD Signed-off-by: Qiang Yu --- drivers/pci/controller/dwc/pcie-qcom.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controlle= r/dwc/pcie-qcom.c index 465c940109a7..0a826ba63277 100644 --- a/drivers/pci/controller/dwc/pcie-qcom.c +++ b/drivers/pci/controller/dwc/pcie-qcom.c @@ -372,6 +372,12 @@ static void qcom_pcie_set_slot_cap(struct dw_pcie *pci) */ val =3D readl(pci->dbi_base + offset + PCI_EXP_SLTCAP); val |=3D PCI_EXP_SLTCAP_NCCS; + + /* + * Qcom PCIe Root Ports do not support Attention Button, so clear + * Attention Button Present in Slot Capabilities. + */ + val &=3D ~PCI_EXP_SLTCAP_ABP; writel(val, pci->dbi_base + offset + PCI_EXP_SLTCAP); =20 dw_pcie_dbi_ro_wr_dis(pci); --=20 2.34.1