Hello,

This patchset fixes memory leaks in the perf timechart code.
I've extended and verified the timechart test with ASAN.

Thanks,
Namhyung


Namhyung Kim (4):
  perf timechart: Release event samples at the end
  perf timechart: Fix memory leaks during record
  perf timechart: Fix memory leaks in draw_wakeups()
  perf test: Update perf timechart test

 tools/perf/builtin-timechart.c      | 93 ++++++++++++++++++++++++-----
 tools/perf/tests/shell/timechart.sh | 24 +++++---
 2 files changed, 94 insertions(+), 23 deletions(-)

-- 
2.54.0.1032.g2f8565e1d1-goog

On Fri, Jun 05, 2026 at 04:11:51PM -0700, Namhyung Kim wrote:
> Hello,
> 
> This patchset fixes memory leaks in the perf timechart code.
> I've extended and verified the timechart test with ASAN.
 
Hi Namhyung,

	You submitted a series for timechart before, so I had to go on
looking if this was a second version or a different series.

	I suggest you always have a version in the cover letter, i.e.:

[PATCH v1 0/4] perf timechart: Fix memory leaks

	To avoid this brief distraction :-)

Regards,

- Arnaldo

> Thanks,
> Namhyung
> 
> 
> Namhyung Kim (4):
>   perf timechart: Release event samples at the end
>   perf timechart: Fix memory leaks during record
>   perf timechart: Fix memory leaks in draw_wakeups()
>   perf test: Update perf timechart test
> 
>  tools/perf/builtin-timechart.c      | 93 ++++++++++++++++++++++++-----
>  tools/perf/tests/shell/timechart.sh | 24 +++++---
>  2 files changed, 94 insertions(+), 23 deletions(-)
> 
> -- 
> 2.54.0.1032.g2f8565e1d1-goog

On Fri, Jun 05, 2026 at 08:19:13PM -0300, Arnaldo Carvalho de Melo wrote:
> On Fri, Jun 05, 2026 at 04:11:51PM -0700, Namhyung Kim wrote:
> > Hello,
> > 
> > This patchset fixes memory leaks in the perf timechart code.
> > I've extended and verified the timechart test with ASAN.
>  
> Hi Namhyung,
> 
> 	You submitted a series for timechart before, so I had to go on
> looking if this was a second version or a different series.

Right, this is a different series.  I believe they are independent.

> 
> 	I suggest you always have a version in the cover letter, i.e.:
> 
> [PATCH v1 0/4] perf timechart: Fix memory leaks
> 
> 	To avoid this brief distraction :-)

Ok, I'll do that if that helps. :)

Thanks,
Namhyung

On Fri, Jun 05, 2026 at 04:28:13PM -0700, Namhyung Kim wrote:
> On Fri, Jun 05, 2026 at 08:19:13PM -0300, Arnaldo Carvalho de Melo wrote:
> > On Fri, Jun 05, 2026 at 04:11:51PM -0700, Namhyung Kim wrote:
> > > This patchset fixes memory leaks in the perf timechart code.
> > > I've extended and verified the timechart test with ASAN.

> > 	You submitted a series for timechart before, so I had to go on
> > looking if this was a second version or a different series.
 
> Right, this is a different series.  I believe they are independent.

Thanks for clarifying.
 
> > 	I suggest you always have a version in the cover letter, i.e.:

> > [PATCH v1 0/4] perf timechart: Fix memory leaks

> > 	To avoid this brief distraction :-)
 
> Ok, I'll do that if that helps. :)

It is a small detail, not having anything it may have been that the
submitter forgot to add something or that it is the first entry, having
v1 removes this ambiguity.

Thanks,

- Arnaldo